All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miaohe Lin <linmiaohe@huawei.com>
To: Michal Hocko <mhocko@suse.com>
Cc: <akpm@linux-foundation.org>, <hannes@cmpxchg.org>,
	<vbabka@suse.cz>, <axboe@kernel.dk>, <iamjoonsoo.kim@lge.com>,
	<alexs@kernel.org>, <apopple@nvidia.com>, <willy@infradead.org>,
	<minchan@kernel.org>, <david@redhat.com>, <shli@fb.com>,
	<hillf.zj@alibaba-inc.com>, <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5] mm/vmscan: fix misleading comment in isolate_lru_pages()
Date: Tue, 13 Jul 2021 20:50:38 +0800	[thread overview]
Message-ID: <4ecacfca-4aba-b2c2-bc61-56a7a5d0fb2b@huawei.com> (raw)
In-Reply-To: <YO1drWweAjSz8Oa+@dhcp22.suse.cz>

On 2021/7/13 17:32, Michal Hocko wrote:
> On Mon 12-07-21 19:16:47, Miaohe Lin wrote:
>> On 2021/7/12 15:28, Michal Hocko wrote:
>>> On Sat 10-07-21 18:03:29, Miaohe Lin wrote:
>>>> We couldn't know whether the page is being freed elsewhere until we failed
>>>> to increase the page count.
>>>
>>> This is moving a hard to understand comment from one place to another.
>>
>> If get_page_unless_zero failed, the page could have been freed elsewhere. I think
>> this looks straightforward but doesn't help a lot. Are you preferring to just
>> remove this comment ?
> 
> Yes the comment in its current form is not really helpful much. Does it
> deserve a single liner to drop it? Likely not on its own without more
> changes in that area.

Sure, I will drop this single patch. And I would send a new patch when I collect enough
misleading/obsolete comments to fix.

Thanks.

> 


      reply	other threads:[~2021-07-13 12:50 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-10 10:03 [PATCH 0/5] Cleanup and fixup for vmscan Miaohe Lin
2021-07-10 10:03 ` [PATCH 1/5] mm/vmscan: put the redirtied MADV_FREE pages back to anonymous LRU list Miaohe Lin
2021-07-10 23:22   ` Yu Zhao
2021-07-10 23:22     ` Yu Zhao
2021-07-12  7:11     ` Miaohe Lin
2021-07-13  7:25       ` Yu Zhao
2021-07-13  7:25         ` Yu Zhao
2021-07-13 13:16         ` Miaohe Lin
2021-07-12  7:22   ` Michal Hocko
2021-07-12 11:03     ` Miaohe Lin
2021-07-13  9:30       ` Michal Hocko
2021-07-13 13:13         ` Miaohe Lin
2021-07-13 13:34           ` Matthew Wilcox
2021-07-14 11:36             ` Miaohe Lin
2021-07-14 11:48               ` Matthew Wilcox
2021-07-14 19:43                 ` John Hubbard
2021-07-15 11:30                   ` Miaohe Lin
2021-07-16  0:01                     ` John Hubbard
2021-07-16  1:53                       ` Miaohe Lin
2021-07-10 10:03 ` [PATCH 2/5] mm/vmscan: remove misleading setting to sc->priority Miaohe Lin
2021-07-12  7:24   ` Michal Hocko
2021-07-12 11:10     ` Miaohe Lin
2021-07-10 10:03 ` [PATCH 3/5] mm/vmscan: remove unneeded return value of kswapd_run() Miaohe Lin
2021-07-12  7:25   ` Michal Hocko
2021-07-10 10:03 ` [PATCH 4/5] mm/vmscan: add 'else' to remove check_pending label Miaohe Lin
2021-07-12  7:26   ` Michal Hocko
2021-07-10 10:03 ` [PATCH 5/5] mm/vmscan: fix misleading comment in isolate_lru_pages() Miaohe Lin
2021-07-12  7:28   ` Michal Hocko
2021-07-12 11:16     ` Miaohe Lin
2021-07-13  9:32       ` Michal Hocko
2021-07-13 12:50         ` Miaohe Lin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ecacfca-4aba-b2c2-bc61-56a7a5d0fb2b@huawei.com \
    --to=linmiaohe@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexs@kernel.org \
    --cc=apopple@nvidia.com \
    --cc=axboe@kernel.dk \
    --cc=david@redhat.com \
    --cc=hannes@cmpxchg.org \
    --cc=hillf.zj@alibaba-inc.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=minchan@kernel.org \
    --cc=shli@fb.com \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.