[PATCH] dim/drm-misc: Add rule to not push patches with issues

[PATCH] dim/drm-misc: Add rule to not push patches with issues

[Daniel Vetter]

We kinda left this out, and I like the wording from the drm-intel
side, so add that. Motivated by a discussion with Christian.

Cc: Christian König <christian.koenig@amd.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 committer-drm-misc.rst | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/committer-drm-misc.rst b/committer-drm-misc.rst
index 9497a5d26a9d..110ca8b0525e 100644
--- a/committer-drm-misc.rst
+++ b/committer-drm-misc.rst
@@ -21,6 +21,9 @@ Merge Criteria
 
 Right now the only hard merge criteria are:
 
+* There must not be open issues or unresolved or conflicting feedback from
+  anyone. Clear them up first. Defer to maintainers as needed.
+
 * Patch is properly reviewed or at least Ack, i.e. don't just push your own
   stuff directly. This rule holds even more for bugfix patches - it would be
   embarrassing if the bugfix contains a small gotcha that review would have
-- 
2.32.0

Re: [PATCH] dim/drm-misc: Add rule to not push patches with issues

[Christian König]

Am 09.07.21 um 10:11 schrieb Daniel Vetter:
> We kinda left this out, and I like the wording from the drm-intel
> side, so add that. Motivated by a discussion with Christian.
>
> Cc: Christian König <christian.koenig@amd.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   committer-drm-misc.rst | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/committer-drm-misc.rst b/committer-drm-misc.rst
> index 9497a5d26a9d..110ca8b0525e 100644
> --- a/committer-drm-misc.rst
> +++ b/committer-drm-misc.rst
> @@ -21,6 +21,9 @@ Merge Criteria
>   
>   Right now the only hard merge criteria are:
>   
> +* There must not be open issues or unresolved or conflicting feedback from
> +  anyone. Clear them up first. Defer to maintainers as needed.
> +
>   * Patch is properly reviewed or at least Ack, i.e. don't just push your own
>     stuff directly. This rule holds even more for bugfix patches - it would be
>     embarrassing if the bugfix contains a small gotcha that review would have

Re: [PATCH] dim/drm-misc: Add rule to not push patches with issues

[Maxime Ripard]

On Fri, Jul 09, 2021 at 10:11:16AM +0200, Daniel Vetter wrote:
> We kinda left this out, and I like the wording from the drm-intel
> side, so add that. Motivated by a discussion with Christian.
> 
> Cc: Christian König <christian.koenig@amd.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

Acked-by: Maxime Ripard <maxime@cerno.tech>

Thanks!
Maxime

Re: [PATCH] dim/drm-misc: Add rule to not push patches with issues

[Thomas Zimmermann]

[-- Attachment #1.1: Type: text/plain, Size: 1499 bytes --]



Am 09.07.21 um 10:11 schrieb Daniel Vetter:
> We kinda left this out, and I like the wording from the drm-intel
> side, so add that. Motivated by a discussion with Christian.

I always thought this goes without saying.

> 
> Cc: Christian König <christian.koenig@amd.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>

> ---
>   committer-drm-misc.rst | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/committer-drm-misc.rst b/committer-drm-misc.rst
> index 9497a5d26a9d..110ca8b0525e 100644
> --- a/committer-drm-misc.rst
> +++ b/committer-drm-misc.rst
> @@ -21,6 +21,9 @@ Merge Criteria
>   
>   Right now the only hard merge criteria are:
>   
> +* There must not be open issues or unresolved or conflicting feedback from
> +  anyone. Clear them up first. Defer to maintainers as needed.
> +
>   * Patch is properly reviewed or at least Ack, i.e. don't just push your own
>     stuff directly. This rule holds even more for bugfix patches - it would be
>     embarrassing if the bugfix contains a small gotcha that review would have
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

Re: [PATCH] dim/drm-misc: Add rule to not push patches with issues

[Daniel Vetter]

On Fri, Jul 9, 2021 at 10:11 AM Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
>
> We kinda left this out, and I like the wording from the drm-intel
> side, so add that. Motivated by a discussion with Christian.
>
> Cc: Christian König <christian.koenig@amd.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

Pushed, thanks for all the r-b/acks.
-Daniel

> ---
>  committer-drm-misc.rst | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/committer-drm-misc.rst b/committer-drm-misc.rst
> index 9497a5d26a9d..110ca8b0525e 100644
> --- a/committer-drm-misc.rst
> +++ b/committer-drm-misc.rst
> @@ -21,6 +21,9 @@ Merge Criteria
>
>  Right now the only hard merge criteria are:
>
> +* There must not be open issues or unresolved or conflicting feedback from
> +  anyone. Clear them up first. Defer to maintainers as needed.
> +
>  * Patch is properly reviewed or at least Ack, i.e. don't just push your own
>    stuff directly. This rule holds even more for bugfix patches - it would be
>    embarrassing if the bugfix contains a small gotcha that review would have
> --
> 2.32.0
>


-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch