* [PATCH] scsi: fas216: Fix a build error
@ 2021-07-11 3:36 Bart Van Assche
2021-07-11 12:07 ` Hannes Reinecke
2021-07-13 1:41 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Bart Van Assche @ 2021-07-11 3:36 UTC (permalink / raw)
To: Martin K . Petersen
Cc: linux-scsi, Jaegeuk Kim, Bart Van Assche, Hannes Reinecke,
Russell King, James E.J. Bottomley, Douglas Gilbert
Use SAM_STAT_GOOD instead of GOOD since GOOD has been removed.
Cc: Hannes Reinecke <hare@suse.de>
Fixes: 3d45cefc8edd ("scsi: core: Drop obsolete Linux-specific SCSI status codes")
Fixes: df1303147649 ("scsi: fas216: Use get_status_byte() to avoid using Linux-specific status codes")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
drivers/scsi/arm/fas216.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/arm/fas216.c b/drivers/scsi/arm/fas216.c
index 30ed3d23635a..6baa9b36367d 100644
--- a/drivers/scsi/arm/fas216.c
+++ b/drivers/scsi/arm/fas216.c
@@ -2010,7 +2010,7 @@ static void fas216_rq_sns_done(FAS216_Info *info, struct scsi_cmnd *SCpnt,
"request sense complete, result=0x%04x%02x%02x",
result, SCpnt->SCp.Message, SCpnt->SCp.Status);
- if (result != DID_OK || SCpnt->SCp.Status != GOOD)
+ if (result != DID_OK || SCpnt->SCp.Status != SAM_STAT_GOOD)
/*
* Something went wrong. Make sure that we don't
* have valid data in the sense buffer that could
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: fas216: Fix a build error
2021-07-11 3:36 [PATCH] scsi: fas216: Fix a build error Bart Van Assche
@ 2021-07-11 12:07 ` Hannes Reinecke
2021-07-13 1:41 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Hannes Reinecke @ 2021-07-11 12:07 UTC (permalink / raw)
To: Bart Van Assche, Martin K . Petersen
Cc: linux-scsi, Jaegeuk Kim, Russell King, James E.J. Bottomley,
Douglas Gilbert
On 7/11/21 5:36 AM, Bart Van Assche wrote:
> Use SAM_STAT_GOOD instead of GOOD since GOOD has been removed.
>
> Cc: Hannes Reinecke <hare@suse.de>
> Fixes: 3d45cefc8edd ("scsi: core: Drop obsolete Linux-specific SCSI status codes")
> Fixes: df1303147649 ("scsi: fas216: Use get_status_byte() to avoid using Linux-specific status codes")
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> drivers/scsi/arm/fas216.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/arm/fas216.c b/drivers/scsi/arm/fas216.c
> index 30ed3d23635a..6baa9b36367d 100644
> --- a/drivers/scsi/arm/fas216.c
> +++ b/drivers/scsi/arm/fas216.c
> @@ -2010,7 +2010,7 @@ static void fas216_rq_sns_done(FAS216_Info *info, struct scsi_cmnd *SCpnt,
> "request sense complete, result=0x%04x%02x%02x",
> result, SCpnt->SCp.Message, SCpnt->SCp.Status);
>
> - if (result != DID_OK || SCpnt->SCp.Status != GOOD)
> + if (result != DID_OK || SCpnt->SCp.Status != SAM_STAT_GOOD)
> /*
> * Something went wrong. Make sure that we don't
> * have valid data in the sense buffer that could
>
Thanks for spotting this.
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: fas216: Fix a build error
2021-07-11 3:36 [PATCH] scsi: fas216: Fix a build error Bart Van Assche
2021-07-11 12:07 ` Hannes Reinecke
@ 2021-07-13 1:41 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2021-07-13 1:41 UTC (permalink / raw)
To: Bart Van Assche
Cc: Martin K . Petersen, linux-scsi, Jaegeuk Kim, Hannes Reinecke,
Russell King, James E.J. Bottomley, Douglas Gilbert
Bart,
> Use SAM_STAT_GOOD instead of GOOD since GOOD has been removed.
Applied to 5.14/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-13 1:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-11 3:36 [PATCH] scsi: fas216: Fix a build error Bart Van Assche
2021-07-11 12:07 ` Hannes Reinecke
2021-07-13 1:41 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.