From: Cristian Marussi <cristian.marussi@arm.com> To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org Cc: sudeep.holla@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, cristian.marussi@arm.com, igor.skalkin@opensynergy.com, peter.hilber@opensynergy.com, alex.bennee@linaro.org, jean-philippe@linaro.org, mikhail.golubev@opensynergy.com, anton.yakovlev@opensynergy.com, Vasyl.Vavrychuk@opensynergy.com, Andriy.Tryshnivskyy@opensynergy.com Subject: [PATCH v6 01/17] firmware: arm_scmi: Avoid padding in sensor message structure Date: Mon, 12 Jul 2021 15:18:17 +0100 [thread overview] Message-ID: <20210712141833.6628-2-cristian.marussi@arm.com> (raw) In-Reply-To: <20210712141833.6628-1-cristian.marussi@arm.com> Structure scmi_resp_sensor_reading_complete is meant to represent an SCMI asynchronous reading complete message: representing the readings field with a 64bit type forces padding and breaks reads in scmi_sensor_reading_get. Split it in two adjacent 32bit readings_low/high subfields to avoid padding or the need to make it packed. Fixes: e2083d3673916 ("firmware: arm_scmi: Add SCMI v3.0 sensors timestamped reads") Signed-off-by: Cristian Marussi <cristian.marussi@arm.com> --- drivers/firmware/arm_scmi/sensors.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/arm_scmi/sensors.c b/drivers/firmware/arm_scmi/sensors.c index 2c88aa221559..308471586381 100644 --- a/drivers/firmware/arm_scmi/sensors.c +++ b/drivers/firmware/arm_scmi/sensors.c @@ -166,7 +166,8 @@ struct scmi_msg_sensor_reading_get { struct scmi_resp_sensor_reading_complete { __le32 id; - __le64 readings; + __le32 readings_low; + __le32 readings_high; }; struct scmi_sensor_reading_resp { @@ -717,7 +718,8 @@ static int scmi_sensor_reading_get(const struct scmi_protocol_handle *ph, resp = t->rx.buf; if (le32_to_cpu(resp->id) == sensor_id) - *value = get_unaligned_le64(&resp->readings); + *value = + get_unaligned_le64(&resp->readings_low); else ret = -EPROTO; } -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Cristian Marussi <cristian.marussi@arm.com> To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org Cc: sudeep.holla@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, cristian.marussi@arm.com, igor.skalkin@opensynergy.com, peter.hilber@opensynergy.com, alex.bennee@linaro.org, jean-philippe@linaro.org, mikhail.golubev@opensynergy.com, anton.yakovlev@opensynergy.com, Vasyl.Vavrychuk@opensynergy.com, Andriy.Tryshnivskyy@opensynergy.com Subject: [PATCH v6 01/17] firmware: arm_scmi: Avoid padding in sensor message structure Date: Mon, 12 Jul 2021 15:18:17 +0100 [thread overview] Message-ID: <20210712141833.6628-2-cristian.marussi@arm.com> (raw) In-Reply-To: <20210712141833.6628-1-cristian.marussi@arm.com> Structure scmi_resp_sensor_reading_complete is meant to represent an SCMI asynchronous reading complete message: representing the readings field with a 64bit type forces padding and breaks reads in scmi_sensor_reading_get. Split it in two adjacent 32bit readings_low/high subfields to avoid padding or the need to make it packed. Fixes: e2083d3673916 ("firmware: arm_scmi: Add SCMI v3.0 sensors timestamped reads") Signed-off-by: Cristian Marussi <cristian.marussi@arm.com> --- drivers/firmware/arm_scmi/sensors.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/arm_scmi/sensors.c b/drivers/firmware/arm_scmi/sensors.c index 2c88aa221559..308471586381 100644 --- a/drivers/firmware/arm_scmi/sensors.c +++ b/drivers/firmware/arm_scmi/sensors.c @@ -166,7 +166,8 @@ struct scmi_msg_sensor_reading_get { struct scmi_resp_sensor_reading_complete { __le32 id; - __le64 readings; + __le32 readings_low; + __le32 readings_high; }; struct scmi_sensor_reading_resp { @@ -717,7 +718,8 @@ static int scmi_sensor_reading_get(const struct scmi_protocol_handle *ph, resp = t->rx.buf; if (le32_to_cpu(resp->id) == sensor_id) - *value = get_unaligned_le64(&resp->readings); + *value = + get_unaligned_le64(&resp->readings_low); else ret = -EPROTO; } -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-12 14:19 UTC|newest] Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-12 14:18 [PATCH v6 00/17] Introduce SCMI transport based on VirtIO Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi [this message] 2021-07-12 14:18 ` [PATCH v6 01/17] firmware: arm_scmi: Avoid padding in sensor message structure Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 02/17] firmware: arm_scmi: Fix max pending messages boundary check Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-14 16:46 ` Sudeep Holla 2021-07-14 16:46 ` Sudeep Holla 2021-07-12 14:18 ` [PATCH v6 03/17] firmware: arm_scmi: Add support for type handling in common functions Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 04/17] firmware: arm_scmi: Remove scmi_dump_header_dbg() helper Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 05/17] firmware: arm_scmi: Add transport optional init/exit support Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-28 11:40 ` Sudeep Holla 2021-07-28 11:40 ` Sudeep Holla 2021-07-28 12:28 ` Cristian Marussi 2021-07-28 12:28 ` Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 06/17] firmware: arm_scmi: Introduce monotonically increasing tokens Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-28 14:17 ` Sudeep Holla 2021-07-28 14:17 ` Sudeep Holla 2021-07-28 16:54 ` Cristian Marussi 2021-07-28 16:54 ` [virtio-dev] " Cristian Marussi 2021-07-28 16:54 ` Cristian Marussi 2021-08-02 10:24 ` Sudeep Holla 2021-08-02 10:24 ` Sudeep Holla 2021-08-03 12:52 ` Cristian Marussi 2021-08-03 12:52 ` [virtio-dev] " Cristian Marussi 2021-08-03 12:52 ` Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 07/17] firmware: arm_scmi: Handle concurrent and out-of-order messages Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-15 16:36 ` Peter Hilber 2021-07-15 16:36 ` [virtio-dev] " Peter Hilber 2021-07-15 16:36 ` Peter Hilber 2021-07-19 9:14 ` Cristian Marussi 2021-07-19 9:14 ` Cristian Marussi 2021-07-22 8:32 ` Peter Hilber 2021-07-22 8:32 ` [virtio-dev] " Peter Hilber 2021-07-22 8:32 ` Peter Hilber 2021-07-28 8:31 ` Cristian Marussi 2021-07-28 8:31 ` Cristian Marussi 2021-08-02 10:10 ` Sudeep Holla 2021-08-02 10:10 ` Sudeep Holla 2021-08-02 10:27 ` Cristian Marussi 2021-08-02 10:27 ` [virtio-dev] " Cristian Marussi 2021-08-02 10:27 ` Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 08/17] firmware: arm_scmi: Add priv parameter to scmi_rx_callback Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-28 14:26 ` Sudeep Holla 2021-07-28 14:26 ` Sudeep Holla 2021-07-28 17:25 ` Cristian Marussi 2021-07-28 17:25 ` [virtio-dev] " Cristian Marussi 2021-07-28 17:25 ` Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 09/17] firmware: arm_scmi: Make .clear_channel optional Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 10/17] firmware: arm_scmi: Make polling mode optional Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-15 16:36 ` Peter Hilber 2021-07-15 16:36 ` [virtio-dev] " Peter Hilber 2021-07-15 16:36 ` Peter Hilber 2021-07-19 9:15 ` Cristian Marussi 2021-07-19 9:15 ` Cristian Marussi 2021-07-28 14:34 ` Sudeep Holla 2021-07-28 14:34 ` Sudeep Holla 2021-07-28 17:41 ` Cristian Marussi 2021-07-28 17:41 ` [virtio-dev] " Cristian Marussi 2021-07-28 17:41 ` Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 11/17] firmware: arm_scmi: Make SCMI transports configurable Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-28 14:50 ` Sudeep Holla 2021-07-28 14:50 ` Sudeep Holla 2021-07-29 16:18 ` Cristian Marussi 2021-07-29 16:18 ` [virtio-dev] " Cristian Marussi 2021-07-29 16:18 ` Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 12/17] firmware: arm_scmi: Make shmem support optional for transports Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 13/17] firmware: arm_scmi: Add method to override max message number Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 14/17] firmware: arm_scmi: Add message passing abstractions for transports Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-15 16:36 ` Peter Hilber 2021-07-15 16:36 ` [virtio-dev] " Peter Hilber 2021-07-15 16:36 ` Peter Hilber 2021-07-19 9:16 ` Cristian Marussi 2021-07-19 9:16 ` Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 15/17] firmware: arm_scmi: Add optional link_supplier() transport op Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-28 15:36 ` Sudeep Holla 2021-07-28 15:36 ` Sudeep Holla 2021-07-29 16:19 ` Cristian Marussi 2021-07-29 16:19 ` [virtio-dev] " Cristian Marussi 2021-07-29 16:19 ` Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 16/17] dt-bindings: arm: Add virtio transport for SCMI Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-12 14:18 ` [PATCH v6 17/17] firmware: arm_scmi: Add virtio transport Cristian Marussi 2021-07-12 14:18 ` Cristian Marussi 2021-07-15 16:35 ` [PATCH v6 00/17] Introduce SCMI transport based on VirtIO Peter Hilber 2021-07-15 16:35 ` [virtio-dev] " Peter Hilber 2021-07-15 16:35 ` Peter Hilber 2021-07-19 11:36 ` Cristian Marussi 2021-07-19 11:36 ` Cristian Marussi 2021-07-22 8:30 ` Peter Hilber 2021-07-22 8:30 ` [virtio-dev] " Peter Hilber 2021-07-22 8:30 ` Peter Hilber 2021-08-11 9:31 ` Floris Westermann 2021-08-11 9:31 ` Floris Westermann 2021-08-11 15:26 ` Cristian Marussi 2021-08-11 15:26 ` [virtio-dev] " Cristian Marussi 2021-08-11 15:26 ` Cristian Marussi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210712141833.6628-2-cristian.marussi@arm.com \ --to=cristian.marussi@arm.com \ --cc=Andriy.Tryshnivskyy@opensynergy.com \ --cc=Jonathan.Cameron@Huawei.com \ --cc=Vasyl.Vavrychuk@opensynergy.com \ --cc=alex.bennee@linaro.org \ --cc=anton.yakovlev@opensynergy.com \ --cc=etienne.carriere@linaro.org \ --cc=f.fainelli@gmail.com \ --cc=igor.skalkin@opensynergy.com \ --cc=james.quinlan@broadcom.com \ --cc=jean-philippe@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mikhail.golubev@opensynergy.com \ --cc=peter.hilber@opensynergy.com \ --cc=souvik.chakravarty@arm.com \ --cc=sudeep.holla@arm.com \ --cc=vincent.guittot@linaro.org \ --cc=virtio-dev@lists.oasis-open.org \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.