All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH 1/2] drm/i915: Silence __iomem sparse warn
@ 2021-07-12 16:18 Ville Syrjala
  2021-07-12 16:18 ` [Intel-gfx] [PATCH 2/2] drm/i915: s/0/NULL/ Ville Syrjala
                   ` (5 more replies)
  0 siblings, 6 replies; 8+ messages in thread
From: Ville Syrjala @ 2021-07-12 16:18 UTC (permalink / raw)
  To: intel-gfx

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

We don't care about __iomem mismatch when dealing with error
pointers. Silence it with ERR_CAST().

drivers/gpu/drm/i915/display/intel_display.c:1896:21:    expected struct i915_vma *[assigned] vma
drivers/gpu/drm/i915/display/intel_display.c:1896:21:    got void [noderef] __iomem *[assigned] iomem
drivers/gpu/drm/i915/display/intel_display.c:1896:21: warning: incorrect type in assignment (different address spaces)

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 026c28c612f0..496b72f10b4e 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -1893,7 +1893,7 @@ static struct i915_vma *intel_dpt_pin(struct i915_address_space *vm)
 	iomem = i915_vma_pin_iomap(vma);
 	i915_vma_unpin(vma);
 	if (IS_ERR(iomem)) {
-		vma = iomem;
+		vma = ERR_CAST(iomem);
 		goto err;
 	}
 
-- 
2.31.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-07-12 21:27 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-12 16:18 [Intel-gfx] [PATCH 1/2] drm/i915: Silence __iomem sparse warn Ville Syrjala
2021-07-12 16:18 ` [Intel-gfx] [PATCH 2/2] drm/i915: s/0/NULL/ Ville Syrjala
2021-07-12 16:30   ` Matthew Auld
2021-07-12 16:29 ` [Intel-gfx] [PATCH 1/2] drm/i915: Silence __iomem sparse warn Matthew Auld
2021-07-12 17:11 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] " Patchwork
2021-07-12 17:11 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-07-12 17:37 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-07-12 21:27 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.