* [PATCH v2] tools/runqslower: use __state instead of state
@ 2021-07-07 5:12 SanjayKumar J
2021-07-12 17:41 ` kernel test robot
0 siblings, 1 reply; 6+ messages in thread
From: SanjayKumar J @ 2021-07-07 5:12 UTC (permalink / raw)
To: ast, daniel, andrii, kafai, songliubraving, yhs, john.fastabend, kpsingh
Cc: SanjayKumar J, netdev, bpf
Commit 2f064a59a11f: sched: Change task_struct::state
renamed task->state to task->__state in task_struct
Acked-by: Yonghong Song <yhs@fb.com>
Signed-off-by: SanjayKumar Jeyakumar <vjsanjay@gmail.com>
---
tools/bpf/runqslower/runqslower.bpf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/bpf/runqslower/runqslower.bpf.c b/tools/bpf/runqslower/runqslower.bpf.c
index 645530ca7e98..ab9353f2fd46 100644
--- a/tools/bpf/runqslower/runqslower.bpf.c
+++ b/tools/bpf/runqslower/runqslower.bpf.c
@@ -74,7 +74,7 @@ int handle__sched_switch(u64 *ctx)
u32 pid;
/* ivcsw: treat like an enqueue event and store timestamp */
- if (prev->state == TASK_RUNNING)
+ if (prev->__state == TASK_RUNNING)
trace_enqueue(prev);
pid = next->pid;
--
2.32.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] tools/runqslower: use __state instead of state
2021-07-07 5:12 [PATCH v2] tools/runqslower: use __state instead of state SanjayKumar J
@ 2021-07-12 17:41 ` kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-07-12 17:41 UTC (permalink / raw)
To: SanjayKumar J, ast, daniel, andrii, kafai, songliubraving, yhs,
john.fastabend, kpsingh
Cc: kbuild-all, SanjayKumar J, netdev
[-- Attachment #1: Type: text/plain, Size: 1877 bytes --]
Hi SanjayKumar,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on bpf-next/master]
[also build test ERROR on vhost/linux-next ipvs/master v5.14-rc1]
[cannot apply to bpf/master next-20210712]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/SanjayKumar-J/tools-runqslower-use-__state-instead-of-state/20210707-131703
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: x86_64-rhel-8.3-kselftests (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/0e86dc86c0f18512dc19ba3d0b001b3f06338a0d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review SanjayKumar-J/tools-runqslower-use-__state-instead-of-state/20210707-131703
git checkout 0e86dc86c0f18512dc19ba3d0b001b3f06338a0d
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash -C tools/testing/selftests/bpf install
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> runqslower.bpf.c:77:12: error: no member named '__state' in 'struct task_struct'; did you mean 'state'?
if (prev->__state == TASK_RUNNING)
^~~~~~~
state
/tools/vmlinux.h:1096:20: note: 'state' declared here
volatile long int state;
^
1 error generated.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41980 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] tools/runqslower: use __state instead of state
@ 2021-07-12 17:41 ` kernel test robot
0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2021-07-12 17:41 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1920 bytes --]
Hi SanjayKumar,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on bpf-next/master]
[also build test ERROR on vhost/linux-next ipvs/master v5.14-rc1]
[cannot apply to bpf/master next-20210712]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/SanjayKumar-J/tools-runqslower-use-__state-instead-of-state/20210707-131703
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: x86_64-rhel-8.3-kselftests (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/0e86dc86c0f18512dc19ba3d0b001b3f06338a0d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review SanjayKumar-J/tools-runqslower-use-__state-instead-of-state/20210707-131703
git checkout 0e86dc86c0f18512dc19ba3d0b001b3f06338a0d
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash -C tools/testing/selftests/bpf install
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> runqslower.bpf.c:77:12: error: no member named '__state' in 'struct task_struct'; did you mean 'state'?
if (prev->__state == TASK_RUNNING)
^~~~~~~
state
/tools/vmlinux.h:1096:20: note: 'state' declared here
volatile long int state;
^
1 error generated.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 41980 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] tools/runqslower: use __state instead of state
2021-07-12 17:41 ` kernel test robot
@ 2021-07-14 5:14 ` Sanjay Kumar J
-1 siblings, 0 replies; 6+ messages in thread
From: Sanjay Kumar J @ 2021-07-14 5:14 UTC (permalink / raw)
To: kernel test robot
Cc: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, Martin Lau,
Song Liu, Yonghong Song, john fastabend, KP Singh, kbuild-all,
Networking
On Mon, Jul 12, 2021 at 11:12 PM kernel test robot <lkp@intel.com> wrote:
>
> Hi SanjayKumar,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on bpf-next/master]
> [also build test ERROR on vhost/linux-next ipvs/master v5.14-rc1]
> [cannot apply to bpf/master next-20210712]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
v4 version of the patch is already accepted in bpf tree
commit-id:5616e895ecc56 and also in net tree ommit:5616e895ecc56
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/SanjayKumar-J/tools-runqslower-use-__state-instead-of-state/20210707-131703
> base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
> config: x86_64-rhel-8.3-kselftests (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> reproduce (this is a W=1 build):
> # https://github.com/0day-ci/linux/commit/0e86dc86c0f18512dc19ba3d0b001b3f06338a0d
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review SanjayKumar-J/tools-runqslower-use-__state-instead-of-state/20210707-131703
> git checkout 0e86dc86c0f18512dc19ba3d0b001b3f06338a0d
> # save the attached .config to linux build tree
> mkdir build_dir
> make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash -C tools/testing/selftests/bpf install
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> >> runqslower.bpf.c:77:12: error: no member named '__state' in 'struct task_struct'; did you mean 'state'?
> if (prev->__state == TASK_RUNNING)
> ^~~~~~~
> state
> /tools/vmlinux.h:1096:20: note: 'state' declared here
> volatile long int state;
> ^
> 1 error generated.
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] tools/runqslower: use __state instead of state
@ 2021-07-06 18:14 SanjayKumar J
0 siblings, 0 replies; 6+ messages in thread
From: SanjayKumar J @ 2021-07-06 18:14 UTC (permalink / raw)
To: ast, daniel, andrii, kafai, songliubraving, yhs, john.fastabend, kpsingh
Cc: SanjayKumar J, netdev, bpf
task->state is renamed to task->__state in task_struct
Signed-off-by: SanjayKumar J <vjsanjay@gmail.com>
---
tools/bpf/runqslower/runqslower.bpf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/bpf/runqslower/runqslower.bpf.c b/tools/bpf/runqslower/runqslower.bpf.c
index 645530ca7e98..ab9353f2fd46 100644
--- a/tools/bpf/runqslower/runqslower.bpf.c
+++ b/tools/bpf/runqslower/runqslower.bpf.c
@@ -74,7 +74,7 @@ int handle__sched_switch(u64 *ctx)
u32 pid;
/* ivcsw: treat like an enqueue event and store timestamp */
- if (prev->state == TASK_RUNNING)
+ if (prev->__state == TASK_RUNNING)
trace_enqueue(prev);
pid = next->pid;
--
2.32.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-07-14 5:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-07 5:12 [PATCH v2] tools/runqslower: use __state instead of state SanjayKumar J
2021-07-12 17:41 ` kernel test robot
2021-07-12 17:41 ` kernel test robot
2021-07-14 5:14 ` Sanjay Kumar J
2021-07-14 5:14 ` Sanjay Kumar J
-- strict thread matches above, loose matches on Subject: below --
2021-07-06 18:14 SanjayKumar J
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.