From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> To: Intel-gfx@lists.freedesktop.org Cc: Chris Wilson <chris@chris-wilson.co.uk>, Aravind Iddamsetty <aravind.iddamsetty@intel.com>, dri-devel@lists.freedesktop.org, Tvrtko Ursulin <tvrtko.ursulin@intel.com> Subject: [RFC 2/8] drm/i915: Make GEM contexts track DRM clients Date: Thu, 15 Jul 2021 10:18:14 +0100 [thread overview] Message-ID: <20210715091820.1613726-3-tvrtko.ursulin@linux.intel.com> (raw) In-Reply-To: <20210715091820.1613726-1-tvrtko.ursulin@linux.intel.com> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Make GEM contexts keep a reference to i915_drm_client for the whole of of their lifetime which will come handy in following patches. v2: Don't bother supporting selftests contexts from debugfs. (Chris) v3 (Lucas): Finish constructing ctx before adding it to the list v4 (Ram): Rebase. v5: Trivial rebase for proto ctx changes. v6: Rebase after clients no longer track name and pid. Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> # v5 Reviewed-by: Aravind Iddamsetty <aravind.iddamsetty@intel.com> # v5 Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 5 +++++ drivers/gpu/drm/i915/gem/i915_gem_context_types.h | 3 +++ 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c index 7d6f52d8a801..3bf409cf0214 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c @@ -988,6 +988,9 @@ void i915_gem_context_release(struct kref *ref) trace_i915_context_free(ctx); GEM_BUG_ON(!i915_gem_context_is_closed(ctx)); + if (ctx->client) + i915_drm_client_put(ctx->client); + mutex_destroy(&ctx->engines_mutex); mutex_destroy(&ctx->lut_mutex); @@ -1436,6 +1439,8 @@ static void gem_context_register(struct i915_gem_context *ctx, ctx->file_priv = fpriv; ctx->pid = get_task_pid(current, PIDTYPE_PID); + ctx->client = i915_drm_client_get(fpriv->client); + snprintf(ctx->name, sizeof(ctx->name), "%s[%d]", current->comm, pid_nr(ctx->pid)); diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context_types.h b/drivers/gpu/drm/i915/gem/i915_gem_context_types.h index 94c03a97cb77..e1bca913818e 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_context_types.h +++ b/drivers/gpu/drm/i915/gem/i915_gem_context_types.h @@ -277,6 +277,9 @@ struct i915_gem_context { /** @link: place with &drm_i915_private.context_list */ struct list_head link; + /** @client: struct i915_drm_client */ + struct i915_drm_client *client; + /** * @ref: reference count * -- 2.30.2
WARNING: multiple messages have this Message-ID (diff)
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> To: Intel-gfx@lists.freedesktop.org Cc: Chris Wilson <chris@chris-wilson.co.uk>, dri-devel@lists.freedesktop.org Subject: [Intel-gfx] [RFC 2/8] drm/i915: Make GEM contexts track DRM clients Date: Thu, 15 Jul 2021 10:18:14 +0100 [thread overview] Message-ID: <20210715091820.1613726-3-tvrtko.ursulin@linux.intel.com> (raw) In-Reply-To: <20210715091820.1613726-1-tvrtko.ursulin@linux.intel.com> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Make GEM contexts keep a reference to i915_drm_client for the whole of of their lifetime which will come handy in following patches. v2: Don't bother supporting selftests contexts from debugfs. (Chris) v3 (Lucas): Finish constructing ctx before adding it to the list v4 (Ram): Rebase. v5: Trivial rebase for proto ctx changes. v6: Rebase after clients no longer track name and pid. Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> # v5 Reviewed-by: Aravind Iddamsetty <aravind.iddamsetty@intel.com> # v5 Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 5 +++++ drivers/gpu/drm/i915/gem/i915_gem_context_types.h | 3 +++ 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c index 7d6f52d8a801..3bf409cf0214 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c @@ -988,6 +988,9 @@ void i915_gem_context_release(struct kref *ref) trace_i915_context_free(ctx); GEM_BUG_ON(!i915_gem_context_is_closed(ctx)); + if (ctx->client) + i915_drm_client_put(ctx->client); + mutex_destroy(&ctx->engines_mutex); mutex_destroy(&ctx->lut_mutex); @@ -1436,6 +1439,8 @@ static void gem_context_register(struct i915_gem_context *ctx, ctx->file_priv = fpriv; ctx->pid = get_task_pid(current, PIDTYPE_PID); + ctx->client = i915_drm_client_get(fpriv->client); + snprintf(ctx->name, sizeof(ctx->name), "%s[%d]", current->comm, pid_nr(ctx->pid)); diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context_types.h b/drivers/gpu/drm/i915/gem/i915_gem_context_types.h index 94c03a97cb77..e1bca913818e 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_context_types.h +++ b/drivers/gpu/drm/i915/gem/i915_gem_context_types.h @@ -277,6 +277,9 @@ struct i915_gem_context { /** @link: place with &drm_i915_private.context_list */ struct list_head link; + /** @client: struct i915_drm_client */ + struct i915_drm_client *client; + /** * @ref: reference count * -- 2.30.2 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-07-15 9:18 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-15 9:18 [RFC 0/8] Per client GPU stats Tvrtko Ursulin 2021-07-15 9:18 ` [Intel-gfx] " Tvrtko Ursulin 2021-07-15 9:18 ` [RFC 1/8] drm/i915: Explicitly track DRM clients Tvrtko Ursulin 2021-07-15 9:18 ` [Intel-gfx] " Tvrtko Ursulin 2021-07-15 9:18 ` Tvrtko Ursulin [this message] 2021-07-15 9:18 ` [Intel-gfx] [RFC 2/8] drm/i915: Make GEM contexts " Tvrtko Ursulin 2021-07-15 9:18 ` [RFC 3/8] drm/i915: Track runtime spent in closed and unreachable GEM contexts Tvrtko Ursulin 2021-07-15 9:18 ` [Intel-gfx] " Tvrtko Ursulin 2021-07-15 9:18 ` [RFC 4/8] drm/i915: Track all user contexts per client Tvrtko Ursulin 2021-07-15 9:18 ` [Intel-gfx] " Tvrtko Ursulin 2021-07-15 9:18 ` [RFC 5/8] drm/i915: Track context current active time Tvrtko Ursulin 2021-07-15 9:18 ` [Intel-gfx] " Tvrtko Ursulin 2021-07-15 9:18 ` [RFC 6/8] drm: Document fdinfo format specification Tvrtko Ursulin 2021-07-15 9:18 ` [Intel-gfx] " Tvrtko Ursulin 2021-07-23 16:43 ` Daniel Stone 2021-07-23 16:43 ` [Intel-gfx] " Daniel Stone 2021-07-23 16:47 ` Daniel Vetter 2021-07-23 16:47 ` [Intel-gfx] " Daniel Vetter 2021-07-23 17:45 ` Nieto, David M 2021-07-23 17:45 ` [Intel-gfx] " Nieto, David M 2021-07-26 9:01 ` Tvrtko Ursulin 2021-07-26 9:01 ` [Intel-gfx] " Tvrtko Ursulin 2021-07-26 8:57 ` Tvrtko Ursulin 2021-07-26 8:57 ` [Intel-gfx] " Tvrtko Ursulin 2021-07-15 9:18 ` [RFC 7/8] drm/i915: Expose client engine utilisation via fdinfo Tvrtko Ursulin 2021-07-15 9:18 ` [Intel-gfx] " Tvrtko Ursulin 2021-07-15 9:18 ` [RFC 8/8] drm/amdgpu: Convert to common fdinfo format Tvrtko Ursulin 2021-07-15 9:18 ` [Intel-gfx] " Tvrtko Ursulin 2021-07-23 13:56 ` Alex Deucher 2021-07-23 13:56 ` [Intel-gfx] " Alex Deucher 2021-07-16 17:58 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Per client GPU stats (rev2) Patchwork 2021-07-16 17:59 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2021-07-16 18:03 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork 2021-07-16 18:24 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-07-16 23:58 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2021-07-23 11:21 ` [Intel-gfx] [RFC 0/8] Per client GPU stats Tvrtko Ursulin 2021-07-23 11:21 ` Tvrtko Ursulin 2021-07-23 11:23 ` Christian König 2021-07-23 11:23 ` Christian König 2021-07-23 13:50 ` Tvrtko Ursulin 2021-07-23 13:50 ` Tvrtko Ursulin 2021-07-23 13:55 ` Alex Deucher 2021-07-23 13:55 ` Alex Deucher 2021-08-23 11:28 Tvrtko Ursulin 2021-08-23 11:28 ` [RFC 2/8] drm/i915: Make GEM contexts track DRM clients Tvrtko Ursulin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210715091820.1613726-3-tvrtko.ursulin@linux.intel.com \ --to=tvrtko.ursulin@linux.intel.com \ --cc=Intel-gfx@lists.freedesktop.org \ --cc=aravind.iddamsetty@intel.com \ --cc=chris@chris-wilson.co.uk \ --cc=dri-devel@lists.freedesktop.org \ --cc=tvrtko.ursulin@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.