* [PATCH v2] drivers: watchdog: wdt-uclass: Use IS_ENABLED for WATCHDOG_AUTOSTART
@ 2021-07-15 11:26 Teresa Remmet
2021-07-16 10:17 ` Stefan Roese
0 siblings, 1 reply; 2+ messages in thread
From: Teresa Remmet @ 2021-07-15 11:26 UTC (permalink / raw)
To: u-boot
Cc: Stefan Roese, Pali Rohár, Rasmus Villemoes, Tim Harvey, Simon Glass
There is no separate SPL/TPL config for WATCHDOG_AUTOSTART.
So use IS_ENABLED instead of CONFIG_IS_ENABLED to make watchdog
working in SPL again.
Fixes: 830d29ac3721 ("watchdog: Allow to use CONFIG_WDT without starting watchdog")
Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
Reviewed-by: Stefan Roese <sr@denx.de>
---
Changes in v2:
- Added Fixes tag
- Added Reviewed-by
drivers/watchdog/wdt-uclass.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/wdt-uclass.c b/drivers/watchdog/wdt-uclass.c
index a0c2429e5a43..17334dbda6c9 100644
--- a/drivers/watchdog/wdt-uclass.c
+++ b/drivers/watchdog/wdt-uclass.c
@@ -53,7 +53,7 @@ int initr_watchdog(void)
4 * reset_period) / 4;
}
- if (!CONFIG_IS_ENABLED(WATCHDOG_AUTOSTART)) {
+ if (!IS_ENABLED(CONFIG_WATCHDOG_AUTOSTART)) {
printf("WDT: Not starting\n");
return 0;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] drivers: watchdog: wdt-uclass: Use IS_ENABLED for WATCHDOG_AUTOSTART
2021-07-15 11:26 [PATCH v2] drivers: watchdog: wdt-uclass: Use IS_ENABLED for WATCHDOG_AUTOSTART Teresa Remmet
@ 2021-07-16 10:17 ` Stefan Roese
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Roese @ 2021-07-16 10:17 UTC (permalink / raw)
To: Teresa Remmet, u-boot
Cc: Pali Rohár, Rasmus Villemoes, Tim Harvey, Simon Glass
On 15.07.21 13:26, Teresa Remmet wrote:
> There is no separate SPL/TPL config for WATCHDOG_AUTOSTART.
> So use IS_ENABLED instead of CONFIG_IS_ENABLED to make watchdog
> working in SPL again.
>
> Fixes: 830d29ac3721 ("watchdog: Allow to use CONFIG_WDT without starting watchdog")
> Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
> Reviewed-by: Stefan Roese <sr@denx.de>
Applied to u-boot-marvell/master
Thanks,
Stefan
> ---
> Changes in v2:
> - Added Fixes tag
> - Added Reviewed-by
>
> drivers/watchdog/wdt-uclass.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/wdt-uclass.c b/drivers/watchdog/wdt-uclass.c
> index a0c2429e5a43..17334dbda6c9 100644
> --- a/drivers/watchdog/wdt-uclass.c
> +++ b/drivers/watchdog/wdt-uclass.c
> @@ -53,7 +53,7 @@ int initr_watchdog(void)
> 4 * reset_period) / 4;
> }
>
> - if (!CONFIG_IS_ENABLED(WATCHDOG_AUTOSTART)) {
> + if (!IS_ENABLED(CONFIG_WATCHDOG_AUTOSTART)) {
> printf("WDT: Not starting\n");
> return 0;
> }
>
Viele Grüße,
Stefan
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-16 10:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-15 11:26 [PATCH v2] drivers: watchdog: wdt-uclass: Use IS_ENABLED for WATCHDOG_AUTOSTART Teresa Remmet
2021-07-16 10:17 ` Stefan Roese
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.