* [PATCH] cgroup: remove cgroup_mount from comments
@ 2021-07-16 9:18 ` zhaoxiaoqiang007-Re5JQEeQqe8AvxtiuMwx3w
0 siblings, 0 replies; 5+ messages in thread
From: zhaoxiaoqiang007 @ 2021-07-16 9:18 UTC (permalink / raw)
To: tj, lizefan.x, hannes
Cc: viro, cgroups, trivial, linux-kernel, zhaoxiaoqiang11
From: zhaoxiaoqiang11 <zhaoxiaoqiang11@jd.com>
Git rid of the inappropriate comment
Since cgroup is fully switched to fs_context, function cgroup_mount
is removed and it's confused to mention in comments of cgroup_kill_sb.
Just wipe it out.
Signed-off-by: zhaoxiaoqiang11 <zhaoxiaoqiang11@jd.com>
---
kernel/cgroup/cgroup.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index 3a0161c21b6b..d0725c1a8db5 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -2169,7 +2169,6 @@ static void cgroup_kill_sb(struct super_block *sb)
/*
* If @root doesn't have any children, start killing it.
* This prevents new mounts by disabling percpu_ref_tryget_live().
- * cgroup_mount() may wait for @root's release.
*
* And don't kill the default root.
*/
--
2.27.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] cgroup: remove cgroup_mount from comments
@ 2021-07-16 9:18 ` zhaoxiaoqiang007-Re5JQEeQqe8AvxtiuMwx3w
0 siblings, 0 replies; 5+ messages in thread
From: zhaoxiaoqiang007-Re5JQEeQqe8AvxtiuMwx3w @ 2021-07-16 9:18 UTC (permalink / raw)
To: tj-DgEjT+Ai2ygdnm+yROfE0A, lizefan.x-EC8Uxl6Npydl57MIdRCFDg,
hannes-druUgvl0LCNAfugRpC6u6w
Cc: viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn,
cgroups-u79uwXL29TY76Z2rM5mHXA, trivial-DgEjT+Ai2ygdnm+yROfE0A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, zhaoxiaoqiang11
From: zhaoxiaoqiang11 <zhaoxiaoqiang11-zFXdYKnZPWw@public.gmane.org>
Git rid of the inappropriate comment
Since cgroup is fully switched to fs_context, function cgroup_mount
is removed and it's confused to mention in comments of cgroup_kill_sb.
Just wipe it out.
Signed-off-by: zhaoxiaoqiang11 <zhaoxiaoqiang11-zFXdYKnZPWw@public.gmane.org>
---
kernel/cgroup/cgroup.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index 3a0161c21b6b..d0725c1a8db5 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -2169,7 +2169,6 @@ static void cgroup_kill_sb(struct super_block *sb)
/*
* If @root doesn't have any children, start killing it.
* This prevents new mounts by disabling percpu_ref_tryget_live().
- * cgroup_mount() may wait for @root's release.
*
* And don't kill the default root.
*/
--
2.27.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] cgroup: remove cgroup_mount from comments
@ 2021-07-16 16:18 ` Tejun Heo
0 siblings, 0 replies; 5+ messages in thread
From: Tejun Heo @ 2021-07-16 16:18 UTC (permalink / raw)
To: zhaoxiaoqiang007
Cc: lizefan.x, hannes, viro, cgroups, trivial, linux-kernel, zhaoxiaoqiang11
On Fri, Jul 16, 2021 at 05:18:53PM +0800, zhaoxiaoqiang007@gmail.com wrote:
> From: zhaoxiaoqiang11 <zhaoxiaoqiang11@jd.com>
>
> Git rid of the inappropriate comment
>
> Since cgroup is fully switched to fs_context, function cgroup_mount
> is removed and it's confused to mention in comments of cgroup_kill_sb.
> Just wipe it out.
>
> Signed-off-by: zhaoxiaoqiang11 <zhaoxiaoqiang11@jd.com>
Applied to cgroup/for-5.15 w/ some description tweaks.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] cgroup: remove cgroup_mount from comments
@ 2021-07-16 16:18 ` Tejun Heo
0 siblings, 0 replies; 5+ messages in thread
From: Tejun Heo @ 2021-07-16 16:18 UTC (permalink / raw)
To: zhaoxiaoqiang007-Re5JQEeQqe8AvxtiuMwx3w
Cc: lizefan.x-EC8Uxl6Npydl57MIdRCFDg, hannes-druUgvl0LCNAfugRpC6u6w,
viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn,
cgroups-u79uwXL29TY76Z2rM5mHXA, trivial-DgEjT+Ai2ygdnm+yROfE0A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, zhaoxiaoqiang11
On Fri, Jul 16, 2021 at 05:18:53PM +0800, zhaoxiaoqiang007-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> From: zhaoxiaoqiang11 <zhaoxiaoqiang11-zFXdYKnZPWw@public.gmane.org>
>
> Git rid of the inappropriate comment
>
> Since cgroup is fully switched to fs_context, function cgroup_mount
> is removed and it's confused to mention in comments of cgroup_kill_sb.
> Just wipe it out.
>
> Signed-off-by: zhaoxiaoqiang11 <zhaoxiaoqiang11-zFXdYKnZPWw@public.gmane.org>
Applied to cgroup/for-5.15 w/ some description tweaks.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] cgroup: remove cgroup_mount from comments
@ 2021-07-16 4:10 赵小强
0 siblings, 0 replies; 5+ messages in thread
From: 赵小强 @ 2021-07-16 4:10 UTC (permalink / raw)
To: tj-DgEjT+Ai2ygdnm+yROfE0A
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA, trivial-DgEjT+Ai2ygdnm+yROfE0A,
lizefan.x-EC8Uxl6Npydl57MIdRCFDg, hannes-druUgvl0LCNAfugRpC6u6w,
viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn
Git rid of the inappropriate comment
Since cgroup is fully switched to fs_context, function cgroup_mount
is removed and it's confused to mention in comments of cgroup_kill_sb.
Just wipe it out.
Signed-off-by: zhaoxiaoqiang11 <zhaoxiaoqiang11@jd.com>
---
kernel/cgroup/cgroup.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index 3a0161c21b6b..d0725c1a8db5 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -2169,7 +2169,6 @@ static void cgroup_kill_sb(struct super_block *sb)
/*
* If @root doesn't have any children, start killing it.
* This prevents new mounts by disabling percpu_ref_tryget_live().
- * cgroup_mount() may wait for @root's release.
*
* And don't kill the default root.
*/
--
2.27.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-07-16 16:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-16 9:18 [PATCH] cgroup: remove cgroup_mount from comments zhaoxiaoqiang007
2021-07-16 9:18 ` zhaoxiaoqiang007-Re5JQEeQqe8AvxtiuMwx3w
2021-07-16 16:18 ` Tejun Heo
2021-07-16 16:18 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2021-07-16 4:10 赵小强
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.