All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-wired-lan] [PATCH v1 1/1] igc: Remove media type checking on the PHY initialization
@ 2021-07-18  9:42 Sasha Neftin
  2021-08-04 12:08 ` Fuxbrumer, Dvora
  0 siblings, 1 reply; 2+ messages in thread
From: Sasha Neftin @ 2021-07-18  9:42 UTC (permalink / raw)
  To: intel-wired-lan

i225 devices have only copper phy media type. There is no point in checking
phy media type during the phy initialization.
This patch comes to clean up these pointless checkings.

Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
---
 drivers/net/ethernet/intel/igc/igc_base.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/ethernet/intel/igc/igc_base.c b/drivers/net/ethernet/intel/igc/igc_base.c
index 93feed4f7f1c..260b7b17bbcc 100644
--- a/drivers/net/ethernet/intel/igc/igc_base.c
+++ b/drivers/net/ethernet/intel/igc/igc_base.c
@@ -158,11 +158,6 @@ static s32 igc_init_phy_params_base(struct igc_hw *hw)
 	struct igc_phy_info *phy = &hw->phy;
 	s32 ret_val = 0;
 
-	if (hw->phy.media_type != igc_media_type_copper) {
-		phy->type = igc_phy_none;
-		goto out;
-	}
-
 	phy->autoneg_mask	= AUTONEG_ADVERTISE_SPEED_DEFAULT_2500;
 	phy->reset_delay_us	= 100;
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Intel-wired-lan] [PATCH v1 1/1] igc: Remove media type checking on the PHY initialization
  2021-07-18  9:42 [Intel-wired-lan] [PATCH v1 1/1] igc: Remove media type checking on the PHY initialization Sasha Neftin
@ 2021-08-04 12:08 ` Fuxbrumer, Dvora
  0 siblings, 0 replies; 2+ messages in thread
From: Fuxbrumer, Dvora @ 2021-08-04 12:08 UTC (permalink / raw)
  To: intel-wired-lan

On 7/18/2021 12:42, Sasha Neftin wrote:
> i225 devices have only copper phy media type. There is no point in checking
> phy media type during the phy initialization.
> This patch comes to clean up these pointless checkings.
> 
> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
> ---
>   drivers/net/ethernet/intel/igc/igc_base.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
Tested-by: Dvora Fuxbrumer <dvorax.fuxbrumer@linux.intel.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-04 12:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-18  9:42 [Intel-wired-lan] [PATCH v1 1/1] igc: Remove media type checking on the PHY initialization Sasha Neftin
2021-08-04 12:08 ` Fuxbrumer, Dvora

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.