* [PATCH v1 0/2] Update NVMM support to recent changes
@ 2021-07-18 13:46 Reinoud Zandijk
2021-07-18 13:46 ` [PATCH v1 1/2] Only check CONFIG_NVMM when NEED_CPU_H is defined Reinoud Zandijk
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Reinoud Zandijk @ 2021-07-18 13:46 UTC (permalink / raw)
To: qemu-devel; +Cc: Reinoud Zandijk
This patchset fixes small NVMM accelerator compilation issues due to
changes made in the rest of Qemu since its import.
Signed-off-by: Reinoud Zandijk <Reinoud@NetBSD.org>
---
Reinoud Zandijk (2):
Only check CONFIG_NVMM when NEED_CPU_H is defined
Fix nvmm_ram_block_added() function arguments
include/sysemu/nvmm.h | 7 ++++---
target/i386/nvmm/nvmm-all.c | 5 +++--
2 files changed, 7 insertions(+), 5 deletions(-)
--
2.31.1
^ permalink raw reply [flat|nested] 12+ messages in thread* [PATCH v1 1/2] Only check CONFIG_NVMM when NEED_CPU_H is defined 2021-07-18 13:46 [PATCH v1 0/2] Update NVMM support to recent changes Reinoud Zandijk @ 2021-07-18 13:46 ` Reinoud Zandijk 2021-09-07 16:20 ` Philippe Mathieu-Daudé 2021-07-18 13:46 ` [PATCH v1 2/2] Fix nvmm_ram_block_added() function arguments Reinoud Zandijk 2021-08-29 16:04 ` applied? Re: [PATCH v1 0/2] Update NVMM support to recent changes, [PATCH v1 1/2] Only check CONFIG_NVMM when NEED_CPU_H is defined, " Reinoud Zandijk 2 siblings, 1 reply; 12+ messages in thread From: Reinoud Zandijk @ 2021-07-18 13:46 UTC (permalink / raw) To: qemu-devel; +Cc: Reinoud Zandijk Userland targers will otherwise use a poisoned CONFIG_NVMM Signed-off-by: Reinoud Zandijk <Reinoud@NetBSD.org> --- include/sysemu/nvmm.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/include/sysemu/nvmm.h b/include/sysemu/nvmm.h index 6d216599b0..833670fccb 100644 --- a/include/sysemu/nvmm.h +++ b/include/sysemu/nvmm.h @@ -10,8 +10,7 @@ #ifndef QEMU_NVMM_H #define QEMU_NVMM_H -#include "config-host.h" -#include "qemu-common.h" +#ifdef NEED_CPU_H #ifdef CONFIG_NVMM @@ -23,4 +22,6 @@ int nvmm_enabled(void); #endif /* CONFIG_NVMM */ -#endif /* CONFIG_NVMM */ +#endif /* NEED_CPU_H */ + +#endif /* QEMU_NVMM_H */ -- 2.31.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v1 1/2] Only check CONFIG_NVMM when NEED_CPU_H is defined 2021-07-18 13:46 ` [PATCH v1 1/2] Only check CONFIG_NVMM when NEED_CPU_H is defined Reinoud Zandijk @ 2021-09-07 16:20 ` Philippe Mathieu-Daudé 2021-09-08 9:46 ` Reinoud Zandijk 0 siblings, 1 reply; 12+ messages in thread From: Philippe Mathieu-Daudé @ 2021-09-07 16:20 UTC (permalink / raw) To: Reinoud Zandijk, qemu-devel; +Cc: Paolo Bonzini, Claudio Fontana On 7/18/21 3:46 PM, Reinoud Zandijk wrote: > Userland targers will otherwise use a poisoned CONFIG_NVMM Typo "targets", but do you mean bsd-user or linux-user? But what is the error you get here? cpu_report_tpr_access() is protected for !CONFIG_USER_ONLY, target/i386/nvmm/ is only build on system emulation. So when can this happen? Last candidate is "sysemu/hw_accel.h"; does it really need to include "sysemu/nvmm.h"? > Signed-off-by: Reinoud Zandijk <Reinoud@NetBSD.org> > --- > include/sysemu/nvmm.h | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/include/sysemu/nvmm.h b/include/sysemu/nvmm.h > index 6d216599b0..833670fccb 100644 > --- a/include/sysemu/nvmm.h > +++ b/include/sysemu/nvmm.h > @@ -10,8 +10,7 @@ > #ifndef QEMU_NVMM_H > #define QEMU_NVMM_H > > -#include "config-host.h" > -#include "qemu-common.h" > +#ifdef NEED_CPU_H > > #ifdef CONFIG_NVMM > > @@ -23,4 +22,6 @@ int nvmm_enabled(void); > > #endif /* CONFIG_NVMM */ > > -#endif /* CONFIG_NVMM */ > +#endif /* NEED_CPU_H */ > + > +#endif /* QEMU_NVMM_H */ > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v1 1/2] Only check CONFIG_NVMM when NEED_CPU_H is defined 2021-09-07 16:20 ` Philippe Mathieu-Daudé @ 2021-09-08 9:46 ` Reinoud Zandijk 2021-09-08 10:30 ` Philippe Mathieu-Daudé 0 siblings, 1 reply; 12+ messages in thread From: Reinoud Zandijk @ 2021-09-08 9:46 UTC (permalink / raw) To: Philippe Mathieu-Daudé Cc: Paolo Bonzini, Reinoud Zandijk, qemu-devel, Claudio Fontana On Tue, Sep 07, 2021 at 06:20:33PM +0200, Philippe Mathieu-Daudé wrote: > On 7/18/21 3:46 PM, Reinoud Zandijk wrote: > > Userland targers will otherwise use a poisoned CONFIG_NVMM > > Typo "targets", but do you mean bsd-user or linux-user? Since its on NetBSD, I guess its bsd-user :) > But what is the error you get here? > > cpu_report_tpr_access() is protected for !CONFIG_USER_ONLY, > target/i386/nvmm/ is only build on system emulation. > > So when can this happen? Last candidate is "sysemu/hw_accel.h"; > does it really need to include "sysemu/nvmm.h"? [5560/6718] Compiling C object libcommon.fa.p/hw_core_cpu-common.c.o FAILED: libcommon.fa.p/hw_core_cpu-common.c.o gcc -Ilibcommon.fa.p -I../slirp -I../slirp/src -I../dtc/libfdt -I../capstone/include/capstone -I. -Iqapi -Itrace -Iui -Iui/shader -I/usr/pkg/include -I/usr/pkg/include/glib-2.0 -I/usr/pkg/lib/glib-2.0/include -I/usr/pkg/include/gio-unix-2.0 -I/usr/X11R7/include -I/usr/pkg/include/spice-1 -I/usr/pkg/include/spice-server -I/usr/X11R7/include/pixman-1 -I/usr/pkg/include/libpng16 -I/usr/pkg/include/SDL2 -I/usr/pkg/include/ncursesw -I/usr/X11R7/include/libdrm -I/usr/include -I/usr/pkg/include/ncurses -I/usr/pkg/include/python3.8 -I/usr/include/krb5 -fdiagnostics-color=auto -pipe -Wall -Winvalid-pch -std=gnu11 -O2 -iquote . -iquote /tmp/pkgsrc-gorilla/emulators/qemu-walking/work/qemu-9ad4c7c9b63f89c308fd988d509bed1389953c8b -iquote /tmp/pkgsrc-gorilla/emulators/qemu-walking/work/qemu-9ad4c7c9b63f89c308fd988d509bed1389953c8b/include -iquote /tmp/pkgsrc-gorilla/emulators/qemu-walking/work/qemu-9ad4c7c9b63f89c308fd988d509bed1389953c8b/disas/libvixl -iquote /tmp/pkgsrc-gorilla/emulators/qemu-walking/work/qemu-9ad4c7c9b63f89c308fd988d509bed1389953c8b/tcg/i386 -pthread -U_FORTIFY_SOURCE -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wold-style-declaration -Wold-style-definition -Wtype-limits -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wempty-body -Wnested-externs -Wendif-labels -Wexpansion-to-defined -Wimplicit-fallthrough=2 -Wno-missing-include-dirs -Wno-shift-negative-value -Wno-psabi -fstack-protector-strong -O2 -D_FORTIFY_SOURCE=2 -D_XOPEN_SOURCE_EXTENDED=1 -fPIC -D_NETBSD_SOURCE -D_XOPEN_SOURCE=600 -DNCURSES_WIDECHAR -D_REENTRANT -D_THREAD_SAFE -Wno-undef -MD -MQ libcommon.fa.p/hw_core_cpu-common.c.o -MF libcommon.fa.p/hw_core_cpu-common.c.o.d -o libcommon.fa.p/hw_core_cpu-common.c.o -c ../hw/core/cpu-common.c In file included from /tmp/pkgsrc-gorilla/emulators/qemu-walking/work/qemu-9ad4c7c9b63f89c308fd988d509bed1389953c8b/include/sysemu/hw_accel.h:19:0, from ../hw/core/cpu-common.c:24: /tmp/pkgsrc-gorilla/emulators/qemu-walking/work/qemu-9ad4c7c9b63f89c308fd988d509bed1389953c8b/include/sysemu/nvmm.h:16:8: error: attempt to use poisoned "CONFIG_NVMM" #ifdef CONFIG_NVMM ^ [5589/6718] Compiling C object libcommon.fa.p/hw_net_e1000e_core.c.o ninja: build stopped: subcommand failed. With the patch it works fine. With regards, Reinoud > > Signed-off-by: Reinoud Zandijk <Reinoud@NetBSD.org> > > --- > > include/sysemu/nvmm.h | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/include/sysemu/nvmm.h b/include/sysemu/nvmm.h > > index 6d216599b0..833670fccb 100644 > > --- a/include/sysemu/nvmm.h > > +++ b/include/sysemu/nvmm.h > > @@ -10,8 +10,7 @@ > > #ifndef QEMU_NVMM_H > > #define QEMU_NVMM_H > > > > -#include "config-host.h" > > -#include "qemu-common.h" > > +#ifdef NEED_CPU_H > > > > #ifdef CONFIG_NVMM > > > > @@ -23,4 +22,6 @@ int nvmm_enabled(void); > > > > #endif /* CONFIG_NVMM */ > > > > -#endif /* CONFIG_NVMM */ > > +#endif /* NEED_CPU_H */ > > + > > +#endif /* QEMU_NVMM_H */ > > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v1 1/2] Only check CONFIG_NVMM when NEED_CPU_H is defined 2021-09-08 9:46 ` Reinoud Zandijk @ 2021-09-08 10:30 ` Philippe Mathieu-Daudé 0 siblings, 0 replies; 12+ messages in thread From: Philippe Mathieu-Daudé @ 2021-09-08 10:30 UTC (permalink / raw) To: Reinoud Zandijk, Thomas Huth; +Cc: Paolo Bonzini, qemu-devel, Claudio Fontana +Thomas On 9/8/21 11:46 AM, Reinoud Zandijk wrote: > On Tue, Sep 07, 2021 at 06:20:33PM +0200, Philippe Mathieu-Daudé wrote: >> On 7/18/21 3:46 PM, Reinoud Zandijk wrote: >>> Userland targers will otherwise use a poisoned CONFIG_NVMM >> >> Typo "targets", but do you mean bsd-user or linux-user? > > Since its on NetBSD, I guess its bsd-user :) > >> But what is the error you get here? >> >> cpu_report_tpr_access() is protected for !CONFIG_USER_ONLY, >> target/i386/nvmm/ is only build on system emulation. >> >> So when can this happen? Last candidate is "sysemu/hw_accel.h"; >> does it really need to include "sysemu/nvmm.h"? > > [5560/6718] Compiling C object libcommon.fa.p/hw_core_cpu-common.c.o > FAILED: libcommon.fa.p/hw_core_cpu-common.c.o > gcc -Ilibcommon.fa.p -I../slirp -I../slirp/src -I../dtc/libfdt > -I../capstone/include/capstone -I. -Iqapi -Itrace -Iui -Iui/shader > -I/usr/pkg/include -I/usr/pkg/include/glib-2.0 -I/usr/pkg/lib/glib-2.0/include > -I/usr/pkg/include/gio-unix-2.0 -I/usr/X11R7/include > -I/usr/pkg/include/spice-1 -I/usr/pkg/include/spice-server > -I/usr/X11R7/include/pixman-1 -I/usr/pkg/include/libpng16 > -I/usr/pkg/include/SDL2 -I/usr/pkg/include/ncursesw > -I/usr/X11R7/include/libdrm -I/usr/include -I/usr/pkg/include/ncurses > -I/usr/pkg/include/python3.8 -I/usr/include/krb5 -fdiagnostics-color=auto > -pipe -Wall -Winvalid-pch -std=gnu11 -O2 -iquote . -iquote > /tmp/pkgsrc-gorilla/emulators/qemu-walking/work/qemu-9ad4c7c9b63f89c308fd988d509bed1389953c8b > -iquote > /tmp/pkgsrc-gorilla/emulators/qemu-walking/work/qemu-9ad4c7c9b63f89c308fd988d509bed1389953c8b/include > -iquote > /tmp/pkgsrc-gorilla/emulators/qemu-walking/work/qemu-9ad4c7c9b63f89c308fd988d509bed1389953c8b/disas/libvixl > -iquote > /tmp/pkgsrc-gorilla/emulators/qemu-walking/work/qemu-9ad4c7c9b63f89c308fd988d509bed1389953c8b/tcg/i386 > -pthread -U_FORTIFY_SOURCE -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 > -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wundef > -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv > -Wold-style-declaration -Wold-style-definition -Wtype-limits -Wformat-security > -Wformat-y2k -Winit-self -Wignored-qualifiers -Wempty-body -Wnested-externs > -Wendif-labels -Wexpansion-to-defined -Wimplicit-fallthrough=2 > -Wno-missing-include-dirs -Wno-shift-negative-value -Wno-psabi > -fstack-protector-strong -O2 -D_FORTIFY_SOURCE=2 -D_XOPEN_SOURCE_EXTENDED=1 > -fPIC -D_NETBSD_SOURCE -D_XOPEN_SOURCE=600 -DNCURSES_WIDECHAR -D_REENTRANT > -D_THREAD_SAFE -Wno-undef -MD -MQ libcommon.fa.p/hw_core_cpu-common.c.o -MF > libcommon.fa.p/hw_core_cpu-common.c.o.d -o > libcommon.fa.p/hw_core_cpu-common.c.o -c ../hw/core/cpu-common.c > In file included from > /tmp/pkgsrc-gorilla/emulators/qemu-walking/work/qemu-9ad4c7c9b63f89c308fd988d509bed1389953c8b/include/sysemu/hw_accel.h:19:0, > from ../hw/core/cpu-common.c:24: > /tmp/pkgsrc-gorilla/emulators/qemu-walking/work/qemu-9ad4c7c9b63f89c308fd988d509bed1389953c8b/include/sysemu/nvmm.h:16:8: > error: attempt to use poisoned "CONFIG_NVMM" > #ifdef CONFIG_NVMM > ^ > [5589/6718] Compiling C object libcommon.fa.p/hw_net_e1000e_core.c.o > ninja: build stopped: subcommand failed. > > With the patch it works fine. > > With regards, > Reinoud > > >>> Signed-off-by: Reinoud Zandijk <Reinoud@NetBSD.org> >>> --- >>> include/sysemu/nvmm.h | 7 ++++--- >>> 1 file changed, 4 insertions(+), 3 deletions(-) >>> >>> diff --git a/include/sysemu/nvmm.h b/include/sysemu/nvmm.h >>> index 6d216599b0..833670fccb 100644 >>> --- a/include/sysemu/nvmm.h >>> +++ b/include/sysemu/nvmm.h >>> @@ -10,8 +10,7 @@ >>> #ifndef QEMU_NVMM_H >>> #define QEMU_NVMM_H >>> >>> -#include "config-host.h" >>> -#include "qemu-common.h" >>> +#ifdef NEED_CPU_H >>> >>> #ifdef CONFIG_NVMM >>> >>> @@ -23,4 +22,6 @@ int nvmm_enabled(void); >>> >>> #endif /* CONFIG_NVMM */ >>> >>> -#endif /* CONFIG_NVMM */ >>> +#endif /* NEED_CPU_H */ >>> + >>> +#endif /* QEMU_NVMM_H */ >>> > ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v1 2/2] Fix nvmm_ram_block_added() function arguments 2021-07-18 13:46 [PATCH v1 0/2] Update NVMM support to recent changes Reinoud Zandijk 2021-07-18 13:46 ` [PATCH v1 1/2] Only check CONFIG_NVMM when NEED_CPU_H is defined Reinoud Zandijk @ 2021-07-18 13:46 ` Reinoud Zandijk 2021-07-18 16:38 ` Peter Maydell 2021-08-29 16:04 ` applied? Re: [PATCH v1 0/2] Update NVMM support to recent changes, [PATCH v1 1/2] Only check CONFIG_NVMM when NEED_CPU_H is defined, " Reinoud Zandijk 2 siblings, 1 reply; 12+ messages in thread From: Reinoud Zandijk @ 2021-07-18 13:46 UTC (permalink / raw) To: qemu-devel; +Cc: Reinoud Zandijk A parameter max_size was added to the RAMBlockNotifier ram_block_added function. Use the max_size for pre allocation of hva space. Signed-off-by: Reinoud Zandijk <Reinoud@NetBSD.org> --- target/i386/nvmm/nvmm-all.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target/i386/nvmm/nvmm-all.c b/target/i386/nvmm/nvmm-all.c index dfa690d65d..fdcd37ed3e 100644 --- a/target/i386/nvmm/nvmm-all.c +++ b/target/i386/nvmm/nvmm-all.c @@ -1134,13 +1134,14 @@ static MemoryListener nvmm_memory_listener = { }; static void -nvmm_ram_block_added(RAMBlockNotifier *n, void *host, size_t size) +nvmm_ram_block_added(RAMBlockNotifier *n, void *host, size_t size, + size_t max_size) { struct nvmm_machine *mach = get_nvmm_mach(); uintptr_t hva = (uintptr_t)host; int ret; - ret = nvmm_hva_map(mach, hva, size); + ret = nvmm_hva_map(mach, hva, max_size); if (ret == -1) { error_report("NVMM: Failed to map HVA, HostVA:%p " -- 2.31.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v1 2/2] Fix nvmm_ram_block_added() function arguments 2021-07-18 13:46 ` [PATCH v1 2/2] Fix nvmm_ram_block_added() function arguments Reinoud Zandijk @ 2021-07-18 16:38 ` Peter Maydell 2021-07-19 14:54 ` Reinoud Zandijk 0 siblings, 1 reply; 12+ messages in thread From: Peter Maydell @ 2021-07-18 16:38 UTC (permalink / raw) To: Reinoud Zandijk; +Cc: QEMU Developers On Sun, 18 Jul 2021 at 14:54, Reinoud Zandijk <reinoud@netbsd.org> wrote: > > A parameter max_size was added to the RAMBlockNotifier > ram_block_added function. Use the max_size for pre allocation > of hva space. > > Signed-off-by: Reinoud Zandijk <Reinoud@NetBSD.org> > --- > target/i386/nvmm/nvmm-all.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/target/i386/nvmm/nvmm-all.c b/target/i386/nvmm/nvmm-all.c > index dfa690d65d..fdcd37ed3e 100644 > --- a/target/i386/nvmm/nvmm-all.c > +++ b/target/i386/nvmm/nvmm-all.c > @@ -1134,13 +1134,14 @@ static MemoryListener nvmm_memory_listener = { > }; > > static void > -nvmm_ram_block_added(RAMBlockNotifier *n, void *host, size_t size) > +nvmm_ram_block_added(RAMBlockNotifier *n, void *host, size_t size, > + size_t max_size) > { > struct nvmm_machine *mach = get_nvmm_mach(); > uintptr_t hva = (uintptr_t)host; > int ret; > > - ret = nvmm_hva_map(mach, hva, size); > + ret = nvmm_hva_map(mach, hva, max_size); > > if (ret == -1) { > error_report("NVMM: Failed to map HVA, HostVA:%p " This suggests that this code isn't being covered by our CI. Is there something we can do to get it tested? -- PMM ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v1 2/2] Fix nvmm_ram_block_added() function arguments 2021-07-18 16:38 ` Peter Maydell @ 2021-07-19 14:54 ` Reinoud Zandijk 0 siblings, 0 replies; 12+ messages in thread From: Reinoud Zandijk @ 2021-07-19 14:54 UTC (permalink / raw) To: Peter Maydell; +Cc: Reinoud Zandijk, QEMU Developers Hi, On Sun, Jul 18, 2021 at 05:38:58PM +0100, Peter Maydell wrote: > On Sun, 18 Jul 2021 at 14:54, Reinoud Zandijk <reinoud@netbsd.org> wrote: > > A parameter max_size was added to the RAMBlockNotifier > > ram_block_added function. Use the max_size for pre allocation > > of hva space. > > > > Signed-off-by: Reinoud Zandijk <Reinoud@NetBSD.org> > > --- > > target/i386/nvmm/nvmm-all.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/target/i386/nvmm/nvmm-all.c b/target/i386/nvmm/nvmm-all.c > > index dfa690d65d..fdcd37ed3e 100644 > > --- a/target/i386/nvmm/nvmm-all.c > > +++ b/target/i386/nvmm/nvmm-all.c > > @@ -1134,13 +1134,14 @@ static MemoryListener nvmm_memory_listener = { > > }; > > > > static void > > -nvmm_ram_block_added(RAMBlockNotifier *n, void *host, size_t size) > > +nvmm_ram_block_added(RAMBlockNotifier *n, void *host, size_t size, > > + size_t max_size) > > { > > struct nvmm_machine *mach = get_nvmm_mach(); > > uintptr_t hva = (uintptr_t)host; > > int ret; > > > > - ret = nvmm_hva_map(mach, hva, size); > > + ret = nvmm_hva_map(mach, hva, max_size); > > > > if (ret == -1) { > > error_report("NVMM: Failed to map HVA, HostVA:%p " > > This suggests that this code isn't being covered by our CI. Is > there something we can do to get it tested? NVMM acceleration is currently NetBSD host only so can only be tested on NetBSD hosts. Unless Qemu is smart enough to allow a guest NetBSD to run NetBSD to test NVMM in a nested Qemu I don't think its possible to otherwise automatically test on Linux. Is there a README or documentation on how to modify and run the tests? With regard, Reinoud ^ permalink raw reply [flat|nested] 12+ messages in thread
* applied? Re: [PATCH v1 0/2] Update NVMM support to recent changes, [PATCH v1 1/2] Only check CONFIG_NVMM when NEED_CPU_H is defined, [PATCH v1 2/2] Fix nvmm_ram_block_added() function arguments 2021-07-18 13:46 [PATCH v1 0/2] Update NVMM support to recent changes Reinoud Zandijk 2021-07-18 13:46 ` [PATCH v1 1/2] Only check CONFIG_NVMM when NEED_CPU_H is defined Reinoud Zandijk 2021-07-18 13:46 ` [PATCH v1 2/2] Fix nvmm_ram_block_added() function arguments Reinoud Zandijk @ 2021-08-29 16:04 ` Reinoud Zandijk 2021-08-29 16:39 ` Peter Maydell 2 siblings, 1 reply; 12+ messages in thread From: Reinoud Zandijk @ 2021-08-29 16:04 UTC (permalink / raw) To: qemu-devel Hi :) Have these patches been applied? How can I easily check it without manually checking if they are there in a git pullup? Am I notified normally when patches are applied? With regards, Reinoud On Sun, Jul 18, 2021 at 03:46:48PM +0200, Reinoud Zandijk wrote: > This patchset fixes small NVMM accelerator compilation issues due to > changes made in the rest of Qemu since its import. > > Signed-off-by: Reinoud Zandijk <Reinoud@NetBSD.org> > --- > > Reinoud Zandijk (2): > Only check CONFIG_NVMM when NEED_CPU_H is defined > Fix nvmm_ram_block_added() function arguments > > include/sysemu/nvmm.h | 7 ++++--- > target/i386/nvmm/nvmm-all.c | 5 +++-- > 2 files changed, 7 insertions(+), 5 deletions(-) > > -- > 2.31.1 On Sun, Jul 18, 2021 at 03:46:49PM +0200, Reinoud Zandijk wrote: > Userland targers will otherwise use a poisoned CONFIG_NVMM > > Signed-off-by: Reinoud Zandijk <Reinoud@NetBSD.org> > --- > include/sysemu/nvmm.h | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/include/sysemu/nvmm.h b/include/sysemu/nvmm.h > index 6d216599b0..833670fccb 100644 > --- a/include/sysemu/nvmm.h > +++ b/include/sysemu/nvmm.h > @@ -10,8 +10,7 @@ > #ifndef QEMU_NVMM_H > #define QEMU_NVMM_H > > -#include "config-host.h" > -#include "qemu-common.h" > +#ifdef NEED_CPU_H > > #ifdef CONFIG_NVMM > > @@ -23,4 +22,6 @@ int nvmm_enabled(void); > > #endif /* CONFIG_NVMM */ > > -#endif /* CONFIG_NVMM */ > +#endif /* NEED_CPU_H */ > + > +#endif /* QEMU_NVMM_H */ > -- > 2.31.1 On Sun, Jul 18, 2021 at 03:46:50PM +0200, Reinoud Zandijk wrote: > A parameter max_size was added to the RAMBlockNotifier > ram_block_added function. Use the max_size for pre allocation > of hva space. > > Signed-off-by: Reinoud Zandijk <Reinoud@NetBSD.org> > --- > target/i386/nvmm/nvmm-all.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/target/i386/nvmm/nvmm-all.c b/target/i386/nvmm/nvmm-all.c > index dfa690d65d..fdcd37ed3e 100644 > --- a/target/i386/nvmm/nvmm-all.c > +++ b/target/i386/nvmm/nvmm-all.c > @@ -1134,13 +1134,14 @@ static MemoryListener nvmm_memory_listener = { > }; > > static void > -nvmm_ram_block_added(RAMBlockNotifier *n, void *host, size_t size) > +nvmm_ram_block_added(RAMBlockNotifier *n, void *host, size_t size, > + size_t max_size) > { > struct nvmm_machine *mach = get_nvmm_mach(); > uintptr_t hva = (uintptr_t)host; > int ret; > > - ret = nvmm_hva_map(mach, hva, size); > + ret = nvmm_hva_map(mach, hva, max_size); > > if (ret == -1) { > error_report("NVMM: Failed to map HVA, HostVA:%p " > -- > 2.31.1 ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: applied? Re: [PATCH v1 0/2] Update NVMM support to recent changes, [PATCH v1 1/2] Only check CONFIG_NVMM when NEED_CPU_H is defined, [PATCH v1 2/2] Fix nvmm_ram_block_added() function arguments 2021-08-29 16:04 ` applied? Re: [PATCH v1 0/2] Update NVMM support to recent changes, [PATCH v1 1/2] Only check CONFIG_NVMM when NEED_CPU_H is defined, " Reinoud Zandijk @ 2021-08-29 16:39 ` Peter Maydell 2021-09-07 16:02 ` Reinoud Zandijk 0 siblings, 1 reply; 12+ messages in thread From: Peter Maydell @ 2021-08-29 16:39 UTC (permalink / raw) To: Reinoud Zandijk; +Cc: Paolo Bonzini, QEMU Developers On Sun, 29 Aug 2021 at 17:06, Reinoud Zandijk <reinoud@13thmonkey.org> wrote: > > Hi :) > > Have these patches been applied? How can I easily check it without manually > checking if they are there in a git pullup? Am I notified normally when > patches are applied? Generally when a submaintainer picks up a patchset they'll send an email reply to the patch cover letter to say they've done so. At that point it should get into upstream git eventually. Until that happens it's the initial submitter's responsibility to 'ping' the patch after a few weeks if nobody's replied to it or reviewed it. Ccing Paolo who seems to have taken the initial nvmm patches through his tree. thanks -- PMM ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: applied? Re: [PATCH v1 0/2] Update NVMM support to recent changes, [PATCH v1 1/2] Only check CONFIG_NVMM when NEED_CPU_H is defined, [PATCH v1 2/2] Fix nvmm_ram_block_added() function arguments 2021-08-29 16:39 ` Peter Maydell @ 2021-09-07 16:02 ` Reinoud Zandijk 2021-09-10 16:21 ` Paolo Bonzini 0 siblings, 1 reply; 12+ messages in thread From: Reinoud Zandijk @ 2021-09-07 16:02 UTC (permalink / raw) To: Peter Maydell; +Cc: Paolo Bonzini, QEMU Developers ping? On Sun, Aug 29, 2021 at 05:39:07PM +0100, Peter Maydell wrote: > On Sun, 29 Aug 2021 at 17:06, Reinoud Zandijk <reinoud@13thmonkey.org> wrote: > > > > Hi :) > > > > Have these patches been applied? How can I easily check it without manually > > checking if they are there in a git pullup? Am I notified normally when > > patches are applied? > > Generally when a submaintainer picks up a patchset they'll send > an email reply to the patch cover letter to say they've done so. > At that point it should get into upstream git eventually. > Until that happens it's the initial submitter's responsibility to > 'ping' the patch after a few weeks if nobody's replied to it > or reviewed it. > > Ccing Paolo who seems to have taken the initial nvmm patches > through his tree. > > thanks > -- PMM ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: applied? Re: [PATCH v1 0/2] Update NVMM support to recent changes, [PATCH v1 1/2] Only check CONFIG_NVMM when NEED_CPU_H is defined, [PATCH v1 2/2] Fix nvmm_ram_block_added() function arguments 2021-09-07 16:02 ` Reinoud Zandijk @ 2021-09-10 16:21 ` Paolo Bonzini 0 siblings, 0 replies; 12+ messages in thread From: Paolo Bonzini @ 2021-09-10 16:21 UTC (permalink / raw) To: Reinoud Zandijk, Peter Maydell; +Cc: QEMU Developers On 07/09/21 18:02, Reinoud Zandijk wrote: > ping? Queued, thanks. Paolo > On Sun, Aug 29, 2021 at 05:39:07PM +0100, Peter Maydell wrote: >> On Sun, 29 Aug 2021 at 17:06, Reinoud Zandijk <reinoud@13thmonkey.org> wrote: >>> >>> Hi :) >>> >>> Have these patches been applied? How can I easily check it without manually >>> checking if they are there in a git pullup? Am I notified normally when >>> patches are applied? >> >> Generally when a submaintainer picks up a patchset they'll send >> an email reply to the patch cover letter to say they've done so. >> At that point it should get into upstream git eventually. >> Until that happens it's the initial submitter's responsibility to >> 'ping' the patch after a few weeks if nobody's replied to it >> or reviewed it. >> >> Ccing Paolo who seems to have taken the initial nvmm patches >> through his tree. >> >> thanks >> -- PMM > ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2021-09-10 16:28 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-07-18 13:46 [PATCH v1 0/2] Update NVMM support to recent changes Reinoud Zandijk 2021-07-18 13:46 ` [PATCH v1 1/2] Only check CONFIG_NVMM when NEED_CPU_H is defined Reinoud Zandijk 2021-09-07 16:20 ` Philippe Mathieu-Daudé 2021-09-08 9:46 ` Reinoud Zandijk 2021-09-08 10:30 ` Philippe Mathieu-Daudé 2021-07-18 13:46 ` [PATCH v1 2/2] Fix nvmm_ram_block_added() function arguments Reinoud Zandijk 2021-07-18 16:38 ` Peter Maydell 2021-07-19 14:54 ` Reinoud Zandijk 2021-08-29 16:04 ` applied? Re: [PATCH v1 0/2] Update NVMM support to recent changes, [PATCH v1 1/2] Only check CONFIG_NVMM when NEED_CPU_H is defined, " Reinoud Zandijk 2021-08-29 16:39 ` Peter Maydell 2021-09-07 16:02 ` Reinoud Zandijk 2021-09-10 16:21 ` Paolo Bonzini
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.