* [allisonhenderson-xfs_work:delayed_attrs_v21_extended 39/62] fs/xfs/xfs_attr_item.c:292:1: sparse: sparse: symbol 'xfs_trans_attr_finish_update' was not declared. Should it be static?
@ 2021-07-19 3:44 ` kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-07-19 3:44 UTC (permalink / raw)
To: Allison Henderson; +Cc: kbuild-all, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2867 bytes --]
tree: https://github.com/allisonhenderson/xfs_work.git delayed_attrs_v21_extended
head: 1a71ced599b41e7ee9f0ea02427b76c30f71f7dd
commit: ba1114fc490c84643980a816cfc54ae8f5da1dd3 [39/62] xfs: Implement attr logging and replay
config: x86_64-randconfig-s021-20210718 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://github.com/allisonhenderson/xfs_work/commit/ba1114fc490c84643980a816cfc54ae8f5da1dd3
git remote add allisonhenderson-xfs_work https://github.com/allisonhenderson/xfs_work.git
git fetch --no-tags allisonhenderson-xfs_work delayed_attrs_v21_extended
git checkout ba1114fc490c84643980a816cfc54ae8f5da1dd3
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> fs/xfs/xfs_attr_item.c:292:1: sparse: sparse: symbol 'xfs_trans_attr_finish_update' was not declared. Should it be static?
>> fs/xfs/xfs_attr_item.c:496:27: sparse: sparse: symbol 'xfs_trans_get_attrd' was not declared. Should it be static?
>> fs/xfs/xfs_attr_item.c:608:30: sparse: sparse: Using plain integer as NULL pointer
fs/xfs/xfs_attr_item.c: note: in included file:
fs/xfs/xfs_log.h:34:21: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __be32 [usertype] oh_len @@ got int len @@
fs/xfs/xfs_log.h:34:21: sparse: expected restricted __be32 [usertype] oh_len
fs/xfs/xfs_log.h:34:21: sparse: got int len
fs/xfs/xfs_log.h:34:21: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __be32 [usertype] oh_len @@ got int len @@
fs/xfs/xfs_log.h:34:21: sparse: expected restricted __be32 [usertype] oh_len
fs/xfs/xfs_log.h:34:21: sparse: got int len
fs/xfs/xfs_log.h:34:21: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __be32 [usertype] oh_len @@ got int len @@
fs/xfs/xfs_log.h:34:21: sparse: expected restricted __be32 [usertype] oh_len
fs/xfs/xfs_log.h:34:21: sparse: got int len
fs/xfs/xfs_log.h:34:21: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __be32 [usertype] oh_len @@ got int len @@
fs/xfs/xfs_log.h:34:21: sparse: expected restricted __be32 [usertype] oh_len
fs/xfs/xfs_log.h:34:21: sparse: got int len
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 44160 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* [allisonhenderson-xfs_work:delayed_attrs_v21_extended 39/62] fs/xfs/xfs_attr_item.c:292:1: sparse: sparse: symbol 'xfs_trans_attr_finish_update' was not declared. Should it be static?
@ 2021-07-19 3:44 ` kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-07-19 3:44 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2911 bytes --]
tree: https://github.com/allisonhenderson/xfs_work.git delayed_attrs_v21_extended
head: 1a71ced599b41e7ee9f0ea02427b76c30f71f7dd
commit: ba1114fc490c84643980a816cfc54ae8f5da1dd3 [39/62] xfs: Implement attr logging and replay
config: x86_64-randconfig-s021-20210718 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://github.com/allisonhenderson/xfs_work/commit/ba1114fc490c84643980a816cfc54ae8f5da1dd3
git remote add allisonhenderson-xfs_work https://github.com/allisonhenderson/xfs_work.git
git fetch --no-tags allisonhenderson-xfs_work delayed_attrs_v21_extended
git checkout ba1114fc490c84643980a816cfc54ae8f5da1dd3
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> fs/xfs/xfs_attr_item.c:292:1: sparse: sparse: symbol 'xfs_trans_attr_finish_update' was not declared. Should it be static?
>> fs/xfs/xfs_attr_item.c:496:27: sparse: sparse: symbol 'xfs_trans_get_attrd' was not declared. Should it be static?
>> fs/xfs/xfs_attr_item.c:608:30: sparse: sparse: Using plain integer as NULL pointer
fs/xfs/xfs_attr_item.c: note: in included file:
fs/xfs/xfs_log.h:34:21: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __be32 [usertype] oh_len @@ got int len @@
fs/xfs/xfs_log.h:34:21: sparse: expected restricted __be32 [usertype] oh_len
fs/xfs/xfs_log.h:34:21: sparse: got int len
fs/xfs/xfs_log.h:34:21: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __be32 [usertype] oh_len @@ got int len @@
fs/xfs/xfs_log.h:34:21: sparse: expected restricted __be32 [usertype] oh_len
fs/xfs/xfs_log.h:34:21: sparse: got int len
fs/xfs/xfs_log.h:34:21: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __be32 [usertype] oh_len @@ got int len @@
fs/xfs/xfs_log.h:34:21: sparse: expected restricted __be32 [usertype] oh_len
fs/xfs/xfs_log.h:34:21: sparse: got int len
fs/xfs/xfs_log.h:34:21: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __be32 [usertype] oh_len @@ got int len @@
fs/xfs/xfs_log.h:34:21: sparse: expected restricted __be32 [usertype] oh_len
fs/xfs/xfs_log.h:34:21: sparse: got int len
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 44160 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* [RFC PATCH allisonhenderson-xfs_work] xfs: xfs_trans_attr_finish_update can be static
2021-07-19 3:44 ` kernel test robot
@ 2021-07-19 3:44 ` kernel test robot
-1 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-07-19 3:44 UTC (permalink / raw)
To: Allison Henderson; +Cc: kbuild-all, linux-kernel
fs/xfs/xfs_attr_item.c:292:1: warning: symbol 'xfs_trans_attr_finish_update' was not declared. Should it be static?
fs/xfs/xfs_attr_item.c:496:27: warning: symbol 'xfs_trans_get_attrd' was not declared. Should it be static?
Fixes: ba1114fc490c ("xfs: Implement attr logging and replay")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
xfs_attr_item.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/xfs/xfs_attr_item.c b/fs/xfs/xfs_attr_item.c
index eda6ae3a39880..7d77de9e12781 100644
--- a/fs/xfs/xfs_attr_item.c
+++ b/fs/xfs/xfs_attr_item.c
@@ -288,7 +288,7 @@ xfs_attrd_item_release(
* transaction is marked dirty regardless of whether the operation succeeds or
* fails to support the ATTRI/ATTRD lifecycle rules.
*/
-int
+static int
xfs_trans_attr_finish_update(
struct xfs_delattr_context *dac,
struct xfs_attrd_log_item *attrdp,
@@ -493,7 +493,7 @@ xfs_attri_item_match(
/*
* This routine is called to allocate an "attr free done" log item.
*/
-struct xfs_attrd_log_item *
+static struct xfs_attrd_log_item *
xfs_trans_get_attrd(struct xfs_trans *tp,
struct xfs_attri_log_item *attrip)
{
^ permalink raw reply related [flat|nested] 4+ messages in thread* [RFC PATCH allisonhenderson-xfs_work] xfs: xfs_trans_attr_finish_update can be static
@ 2021-07-19 3:44 ` kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-07-19 3:44 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1233 bytes --]
fs/xfs/xfs_attr_item.c:292:1: warning: symbol 'xfs_trans_attr_finish_update' was not declared. Should it be static?
fs/xfs/xfs_attr_item.c:496:27: warning: symbol 'xfs_trans_get_attrd' was not declared. Should it be static?
Fixes: ba1114fc490c ("xfs: Implement attr logging and replay")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
xfs_attr_item.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/xfs/xfs_attr_item.c b/fs/xfs/xfs_attr_item.c
index eda6ae3a39880..7d77de9e12781 100644
--- a/fs/xfs/xfs_attr_item.c
+++ b/fs/xfs/xfs_attr_item.c
@@ -288,7 +288,7 @@ xfs_attrd_item_release(
* transaction is marked dirty regardless of whether the operation succeeds or
* fails to support the ATTRI/ATTRD lifecycle rules.
*/
-int
+static int
xfs_trans_attr_finish_update(
struct xfs_delattr_context *dac,
struct xfs_attrd_log_item *attrdp,
@@ -493,7 +493,7 @@ xfs_attri_item_match(
/*
* This routine is called to allocate an "attr free done" log item.
*/
-struct xfs_attrd_log_item *
+static struct xfs_attrd_log_item *
xfs_trans_get_attrd(struct xfs_trans *tp,
struct xfs_attri_log_item *attrip)
{
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-19 3:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-19 3:44 [allisonhenderson-xfs_work:delayed_attrs_v21_extended 39/62] fs/xfs/xfs_attr_item.c:292:1: sparse: sparse: symbol 'xfs_trans_attr_finish_update' was not declared. Should it be static? kernel test robot
2021-07-19 3:44 ` kernel test robot
2021-07-19 3:44 ` [RFC PATCH allisonhenderson-xfs_work] xfs: xfs_trans_attr_finish_update can be static kernel test robot
2021-07-19 3:44 ` kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.