* [LTP] [PATCH v3, 2/2] cgroup/cgroup_regression_test: Fix umount failure
@ 2021-07-16 14:02 Leo Liang
2021-07-19 5:24 ` xuyang2018.jy
2021-07-19 6:48 ` Petr Vorel
0 siblings, 2 replies; 6+ messages in thread
From: Leo Liang @ 2021-07-16 14:02 UTC (permalink / raw)
To: ltp
The test sequence
mount -t cgroup -o <controllers> <path>
mkdir <path>/<dir>
rmdir <path>/<dir>
umount <path>
mount -t cgroup -o <controllers> <path>
would easily fail at the last mount with -EBUSY on certain platform.
The reason is that this test sequence would have the chance of
missing a release code path when doing rmdir and umount.
Adding a little delay between "rmdir" and "umount" could fix the problem,
so use tst_umount API instead of umount in "rmdir, umount" sequence.
Fixes: #839
Signed-off-by: Leo Yu-Chi Liang <ycliang@andestech.com>
---
.../controllers/cgroup/cgroup_regression_test.sh | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh b/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
index 1f7f3820e..056166f11 100755
--- a/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
+++ b/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
@@ -145,7 +145,7 @@ test2()
fi
rmdir cgroup/0 cgroup/1
- umount cgroup/
+ tst_umount cgroup/
}
#---------------------------------------------------------------------------
@@ -193,7 +193,7 @@ test3()
wait $pid2 2>/dev/null
rmdir $cpu_subsys_path/0 2> /dev/null
- umount cgroup/ 2> /dev/null
+ tst_umount cgroup/ 2> /dev/null
check_kernel_bug
}
@@ -222,7 +222,7 @@ test4()
mount -t cgroup -o none,name=foo cgroup cgroup/
mkdir cgroup/0
rmdir cgroup/0
- umount cgroup/
+ tst_umount cgroup/
if dmesg | grep -q "MAX_LOCKDEP_SUBCLASSES too low"; then
tst_res TFAIL "lockdep BUG was found"
@@ -254,7 +254,7 @@ test5()
mount -t cgroup none cgroup 2> /dev/null
mkdir cgroup/0
rmdir cgroup/0
- umount cgroup/ 2> /dev/null
+ tst_umount cgroup/ 2> /dev/null
check_kernel_bug
}
@@ -290,7 +290,7 @@ test6()
mount -t cgroup -o ns xxx cgroup/ > /dev/null 2>&1
rmdir cgroup/[1-9]* > /dev/null 2>&1
- umount cgroup/
+ tst_umount cgroup/
check_kernel_bug
}
--
2.17.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [LTP] [PATCH v3, 2/2] cgroup/cgroup_regression_test: Fix umount failure
2021-07-16 14:02 [LTP] [PATCH v3, 2/2] cgroup/cgroup_regression_test: Fix umount failure Leo Liang
@ 2021-07-19 5:24 ` xuyang2018.jy
2021-07-19 5:59 ` Petr Vorel
2021-07-19 8:20 ` Leo Liang
2021-07-19 6:48 ` Petr Vorel
1 sibling, 2 replies; 6+ messages in thread
From: xuyang2018.jy @ 2021-07-19 5:24 UTC (permalink / raw)
To: ltp
Hi Leo
> The test sequence
> mount -t cgroup -o<controllers> <path>
> mkdir<path>/<dir>
> rmdir<path>/<dir>
> umount<path>
> mount -t cgroup -o<controllers> <path>
> would easily fail at the last mount with -EBUSY on certain platform.
>
> The reason is that this test sequence would have the chance of
> missing a release code path when doing rmdir and umount.
>
> Adding a little delay between "rmdir" and "umount" could fix the problem,
> so use tst_umount API instead of umount in "rmdir, umount" sequence.
>
> Fixes: #839
>
> Signed-off-by: Leo Yu-Chi Liang<ycliang@andestech.com>
> ---
> .../controllers/cgroup/cgroup_regression_test.sh | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh b/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
> index 1f7f3820e..056166f11 100755
> --- a/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
> +++ b/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
> @@ -145,7 +145,7 @@ test2()
> fi
>
> rmdir cgroup/0 cgroup/1
> - umount cgroup/
With adding a comment like
# Avoid possible EBUSY error
so when other converts this case into new api, they will keep to use
tst_umount.
Reviewed-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> + tst_umount cgroup/
> }
>
> #---------------------------------------------------------------------------
> @@ -193,7 +193,7 @@ test3()
> wait $pid2 2>/dev/null
>
> rmdir $cpu_subsys_path/0 2> /dev/null
> - umount cgroup/ 2> /dev/null
> + tst_umount cgroup/ 2> /dev/null
> check_kernel_bug
> }
>
> @@ -222,7 +222,7 @@ test4()
> mount -t cgroup -o none,name=foo cgroup cgroup/
> mkdir cgroup/0
> rmdir cgroup/0
> - umount cgroup/
> + tst_umount cgroup/
here as well
>
> if dmesg | grep -q "MAX_LOCKDEP_SUBCLASSES too low"; then
> tst_res TFAIL "lockdep BUG was found"
> @@ -254,7 +254,7 @@ test5()
> mount -t cgroup none cgroup 2> /dev/null
> mkdir cgroup/0
> rmdir cgroup/0
> - umount cgroup/ 2> /dev/null
> + tst_umount cgroup/ 2> /dev/null
> check_kernel_bug
> }
>
> @@ -290,7 +290,7 @@ test6()
>
> mount -t cgroup -o ns xxx cgroup/> /dev/null 2>&1
> rmdir cgroup/[1-9]*> /dev/null 2>&1
> - umount cgroup/
> + tst_umount cgroup/
here as well
> check_kernel_bug
> }
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [LTP] [PATCH v3, 2/2] cgroup/cgroup_regression_test: Fix umount failure
2021-07-19 5:24 ` xuyang2018.jy
@ 2021-07-19 5:59 ` Petr Vorel
2021-07-19 8:20 ` Leo Liang
1 sibling, 0 replies; 6+ messages in thread
From: Petr Vorel @ 2021-07-19 5:59 UTC (permalink / raw)
To: ltp
> Hi Leo
> > The test sequence
> > mount -t cgroup -o<controllers> <path>
> > mkdir<path>/<dir>
> > rmdir<path>/<dir>
> > umount<path>
> > mount -t cgroup -o<controllers> <path>
> > would easily fail at the last mount with -EBUSY on certain platform.
> > The reason is that this test sequence would have the chance of
> > missing a release code path when doing rmdir and umount.
> > Adding a little delay between "rmdir" and "umount" could fix the problem,
> > so use tst_umount API instead of umount in "rmdir, umount" sequence.
> > Fixes: #839
> > Signed-off-by: Leo Yu-Chi Liang<ycliang@andestech.com>
> > ---
> > .../controllers/cgroup/cgroup_regression_test.sh | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> > diff --git a/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh b/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
> > index 1f7f3820e..056166f11 100755
> > --- a/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
> > +++ b/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
> > @@ -145,7 +145,7 @@ test2()
> > fi
> > rmdir cgroup/0 cgroup/1
> > - umount cgroup/
> With adding a comment like
> # Avoid possible EBUSY error
> so when other converts this case into new api, they will keep to use
> tst_umount.
+1
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
> Reviewed-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> > + tst_umount cgroup/
> > }
> > #---------------------------------------------------------------------------
> > @@ -193,7 +193,7 @@ test3()
> > wait $pid2 2>/dev/null
> > rmdir $cpu_subsys_path/0 2> /dev/null
> > - umount cgroup/ 2> /dev/null
> > + tst_umount cgroup/ 2> /dev/null
> > check_kernel_bug
> > }
> > @@ -222,7 +222,7 @@ test4()
> > mount -t cgroup -o none,name=foo cgroup cgroup/
> > mkdir cgroup/0
> > rmdir cgroup/0
> > - umount cgroup/
> > + tst_umount cgroup/
> here as well
> > if dmesg | grep -q "MAX_LOCKDEP_SUBCLASSES too low"; then
> > tst_res TFAIL "lockdep BUG was found"
> > @@ -254,7 +254,7 @@ test5()
> > mount -t cgroup none cgroup 2> /dev/null
> > mkdir cgroup/0
> > rmdir cgroup/0
> > - umount cgroup/ 2> /dev/null
> > + tst_umount cgroup/ 2> /dev/null
> > check_kernel_bug
> > }
> > @@ -290,7 +290,7 @@ test6()
> > mount -t cgroup -o ns xxx cgroup/> /dev/null 2>&1
> > rmdir cgroup/[1-9]*> /dev/null 2>&1
> > - umount cgroup/
> > + tst_umount cgroup/
> here as well
> > check_kernel_bug
> > }
^ permalink raw reply [flat|nested] 6+ messages in thread
* [LTP] [PATCH v3, 2/2] cgroup/cgroup_regression_test: Fix umount failure
2021-07-19 5:24 ` xuyang2018.jy
2021-07-19 5:59 ` Petr Vorel
@ 2021-07-19 8:20 ` Leo Liang
1 sibling, 0 replies; 6+ messages in thread
From: Leo Liang @ 2021-07-19 8:20 UTC (permalink / raw)
To: ltp
Hi Yang,
On Mon, Jul 19, 2021 at 01:24:12PM +0800, xuyang2018.jy@fujitsu.com wrote:
> Hi Leo
> > The test sequence
> > mount -t cgroup -o<controllers> <path>
> > mkdir<path>/<dir>
> > rmdir<path>/<dir>
> > umount<path>
> > mount -t cgroup -o<controllers> <path>
> > would easily fail at the last mount with -EBUSY on certain platform.
> >
> > The reason is that this test sequence would have the chance of
> > missing a release code path when doing rmdir and umount.
> >
> > Adding a little delay between "rmdir" and "umount" could fix the problem,
> > so use tst_umount API instead of umount in "rmdir, umount" sequence.
> >
> > Fixes: #839
> >
> > Signed-off-by: Leo Yu-Chi Liang<ycliang@andestech.com>
> > ---
> > .../controllers/cgroup/cgroup_regression_test.sh | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh b/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
> > index 1f7f3820e..056166f11 100755
> > --- a/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
> > +++ b/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
> > @@ -145,7 +145,7 @@ test2()
> > fi
> >
> > rmdir cgroup/0 cgroup/1
> > - umount cgroup/
> With adding a comment like
> # Avoid possible EBUSY error
>
> so when other converts this case into new api, they will keep to use
> tst_umount.
>
No problem! Will do in the next version!
Thanks!
Best regards,
Leo
> Reviewed-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> > + tst_umount cgroup/
> > }
> >
> > #---------------------------------------------------------------------------
> > @@ -193,7 +193,7 @@ test3()
> > wait $pid2 2>/dev/null
> >
> > rmdir $cpu_subsys_path/0 2> /dev/null
> > - umount cgroup/ 2> /dev/null
> > + tst_umount cgroup/ 2> /dev/null
> > check_kernel_bug
> > }
> >
> > @@ -222,7 +222,7 @@ test4()
> > mount -t cgroup -o none,name=foo cgroup cgroup/
> > mkdir cgroup/0
> > rmdir cgroup/0
> > - umount cgroup/
> > + tst_umount cgroup/
> here as well
> >
> > if dmesg | grep -q "MAX_LOCKDEP_SUBCLASSES too low"; then
> > tst_res TFAIL "lockdep BUG was found"
> > @@ -254,7 +254,7 @@ test5()
> > mount -t cgroup none cgroup 2> /dev/null
> > mkdir cgroup/0
> > rmdir cgroup/0
> > - umount cgroup/ 2> /dev/null
> > + tst_umount cgroup/ 2> /dev/null
> > check_kernel_bug
> > }
> >
> > @@ -290,7 +290,7 @@ test6()
> >
> > mount -t cgroup -o ns xxx cgroup/> /dev/null 2>&1
> > rmdir cgroup/[1-9]*> /dev/null 2>&1
> > - umount cgroup/
> > + tst_umount cgroup/
> here as well
> > check_kernel_bug
> > }
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* [LTP] [PATCH v3, 2/2] cgroup/cgroup_regression_test: Fix umount failure
2021-07-16 14:02 [LTP] [PATCH v3, 2/2] cgroup/cgroup_regression_test: Fix umount failure Leo Liang
2021-07-19 5:24 ` xuyang2018.jy
@ 2021-07-19 6:48 ` Petr Vorel
2021-07-19 8:35 ` Leo Liang
1 sibling, 1 reply; 6+ messages in thread
From: Petr Vorel @ 2021-07-19 6:48 UTC (permalink / raw)
To: ltp
> The test sequence
> mount -t cgroup -o <controllers> <path>
> mkdir <path>/<dir>
> rmdir <path>/<dir>
> umount <path>
> mount -t cgroup -o <controllers> <path>
> would easily fail at the last mount with -EBUSY on certain platform.
> The reason is that this test sequence would have the chance of
> missing a release code path when doing rmdir and umount.
> Adding a little delay between "rmdir" and "umount" could fix the problem,
> so use tst_umount API instead of umount in "rmdir, umount" sequence.
> Fixes: #839
> Signed-off-by: Leo Yu-Chi Liang <ycliang@andestech.com>
> ---
> .../controllers/cgroup/cgroup_regression_test.sh | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
> diff --git a/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh b/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
> index 1f7f3820e..056166f11 100755
> --- a/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
> +++ b/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
> @@ -145,7 +145,7 @@ test2()
> fi
> rmdir cgroup/0 cgroup/1
> - umount cgroup/
> + tst_umount cgroup/
As I note in previous patch, with suggested change to tst_umount() to always add
trailing "/" it'd be enough just "tst_umount cgroup".
I'm not sure what is better: automatic handling or having to explicitly add
trailing "/".
Kind regards,
Petr
> }
> #---------------------------------------------------------------------------
> @@ -193,7 +193,7 @@ test3()
> wait $pid2 2>/dev/null
> rmdir $cpu_subsys_path/0 2> /dev/null
> - umount cgroup/ 2> /dev/null
> + tst_umount cgroup/ 2> /dev/null
> check_kernel_bug
> }
> @@ -222,7 +222,7 @@ test4()
> mount -t cgroup -o none,name=foo cgroup cgroup/
> mkdir cgroup/0
> rmdir cgroup/0
> - umount cgroup/
> + tst_umount cgroup/
> if dmesg | grep -q "MAX_LOCKDEP_SUBCLASSES too low"; then
> tst_res TFAIL "lockdep BUG was found"
> @@ -254,7 +254,7 @@ test5()
> mount -t cgroup none cgroup 2> /dev/null
> mkdir cgroup/0
> rmdir cgroup/0
> - umount cgroup/ 2> /dev/null
> + tst_umount cgroup/ 2> /dev/null
> check_kernel_bug
> }
> @@ -290,7 +290,7 @@ test6()
> mount -t cgroup -o ns xxx cgroup/ > /dev/null 2>&1
> rmdir cgroup/[1-9]* > /dev/null 2>&1
> - umount cgroup/
> + tst_umount cgroup/
> check_kernel_bug
> }
^ permalink raw reply [flat|nested] 6+ messages in thread
* [LTP] [PATCH v3, 2/2] cgroup/cgroup_regression_test: Fix umount failure
2021-07-19 6:48 ` Petr Vorel
@ 2021-07-19 8:35 ` Leo Liang
0 siblings, 0 replies; 6+ messages in thread
From: Leo Liang @ 2021-07-19 8:35 UTC (permalink / raw)
To: ltp
Hi Petr,
On Mon, Jul 19, 2021 at 02:48:10PM +0800, Petr Vorel wrote:
> > The test sequence
> > mount -t cgroup -o <controllers> <path>
> > mkdir <path>/<dir>
> > rmdir <path>/<dir>
> > umount <path>
> > mount -t cgroup -o <controllers> <path>
> > would easily fail at the last mount with -EBUSY on certain platform.
>
> > The reason is that this test sequence would have the chance of
> > missing a release code path when doing rmdir and umount.
>
> > Adding a little delay between "rmdir" and "umount" could fix the problem,
> > so use tst_umount API instead of umount in "rmdir, umount" sequence.
>
> > Fixes: #839
>
> > Signed-off-by: Leo Yu-Chi Liang <ycliang@andestech.com>
> > ---
> > .../controllers/cgroup/cgroup_regression_test.sh | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
>
> > diff --git a/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh b/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
> > index 1f7f3820e..056166f11 100755
> > --- a/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
> > +++ b/testcases/kernel/controllers/cgroup/cgroup_regression_test.sh
> > @@ -145,7 +145,7 @@ test2()
> > fi
>
> > rmdir cgroup/0 cgroup/1
> > - umount cgroup/
> > + tst_umount cgroup/
> As I note in previous patch, with suggested change to tst_umount() to always add
> trailing "/" it'd be enough just "tst_umount cgroup".
>
I think your method is better that we don't alter the argument passed into tst_umount.
Let users decide the argument and honor the choice.
I will send a v4 patch later and still keep the trailing slash.
Thanks!
Best regards,
Leo
> I'm not sure what is better: automatic handling or having to explicitly add
> trailing "/".
>
> Kind regards,
> Petr
>
> > }
>
> > #---------------------------------------------------------------------------
> > @@ -193,7 +193,7 @@ test3()
> > wait $pid2 2>/dev/null
>
> > rmdir $cpu_subsys_path/0 2> /dev/null
> > - umount cgroup/ 2> /dev/null
> > + tst_umount cgroup/ 2> /dev/null
> > check_kernel_bug
> > }
>
> > @@ -222,7 +222,7 @@ test4()
> > mount -t cgroup -o none,name=foo cgroup cgroup/
> > mkdir cgroup/0
> > rmdir cgroup/0
> > - umount cgroup/
> > + tst_umount cgroup/
>
> > if dmesg | grep -q "MAX_LOCKDEP_SUBCLASSES too low"; then
> > tst_res TFAIL "lockdep BUG was found"
> > @@ -254,7 +254,7 @@ test5()
> > mount -t cgroup none cgroup 2> /dev/null
> > mkdir cgroup/0
> > rmdir cgroup/0
> > - umount cgroup/ 2> /dev/null
> > + tst_umount cgroup/ 2> /dev/null
> > check_kernel_bug
> > }
>
> > @@ -290,7 +290,7 @@ test6()
>
> > mount -t cgroup -o ns xxx cgroup/ > /dev/null 2>&1
> > rmdir cgroup/[1-9]* > /dev/null 2>&1
> > - umount cgroup/
> > + tst_umount cgroup/
> > check_kernel_bug
> > }
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-07-19 8:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-16 14:02 [LTP] [PATCH v3, 2/2] cgroup/cgroup_regression_test: Fix umount failure Leo Liang
2021-07-19 5:24 ` xuyang2018.jy
2021-07-19 5:59 ` Petr Vorel
2021-07-19 8:20 ` Leo Liang
2021-07-19 6:48 ` Petr Vorel
2021-07-19 8:35 ` Leo Liang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.