* [PATCH] f2fs: fix wrong inflight page stats for directIO @ 2021-07-19 8:25 ` Chao Yu 0 siblings, 0 replies; 6+ messages in thread From: Chao Yu @ 2021-07-19 8:25 UTC (permalink / raw) To: jaegeuk; +Cc: linux-f2fs-devel, linux-kernel, Chao Yu, Chao Yu Previously, we use sbi->nr_pages[] to account direct IO, the count should be based on page granularity rather than bio granularity, fix it. Fixes: 02b16d0a34a1 ("f2fs: add to account direct IO") Signed-off-by: Chao Yu <chao@kernel.org> --- fs/f2fs/data.c | 10 ++++++---- fs/f2fs/f2fs.h | 13 +++++++++++++ 2 files changed, 19 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index e6f107de4c92..1198d6cb4811 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -3494,8 +3494,9 @@ static void f2fs_dio_end_io(struct bio *bio) { struct f2fs_private_dio *dio = bio->bi_private; - dec_page_count(F2FS_I_SB(dio->inode), - dio->write ? F2FS_DIO_WRITE : F2FS_DIO_READ); + dec_page_counts(F2FS_I_SB(dio->inode), + dio->write ? F2FS_DIO_WRITE : F2FS_DIO_READ, + dio->blkcnt); bio->bi_private = dio->orig_private; bio->bi_end_io = dio->orig_end_io; @@ -3519,13 +3520,14 @@ static void f2fs_dio_submit_bio(struct bio *bio, struct inode *inode, dio->inode = inode; dio->orig_end_io = bio->bi_end_io; dio->orig_private = bio->bi_private; + dio->blkcnt = blkcnt; dio->write = write; bio->bi_end_io = f2fs_dio_end_io; bio->bi_private = dio; - inc_page_count(F2FS_I_SB(inode), - write ? F2FS_DIO_WRITE : F2FS_DIO_READ); + inc_page_counts(F2FS_I_SB(inode), + write ? F2FS_DIO_WRITE : F2FS_DIO_READ, dio->blkcnt); submit_bio(bio); return; diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 867f2c5d9559..7369f8087f64 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -1759,6 +1759,7 @@ struct f2fs_private_dio { struct inode *inode; void *orig_private; bio_end_io_t *orig_end_io; + unsigned int blkcnt; bool write; }; @@ -2267,6 +2268,12 @@ static inline void inc_page_count(struct f2fs_sb_info *sbi, int count_type) set_sbi_flag(sbi, SBI_IS_DIRTY); } +static inline void inc_page_counts(struct f2fs_sb_info *sbi, int count_type, + unsigned int count) +{ + atomic_add(count, &sbi->nr_pages[count_type]); +} + static inline void inode_inc_dirty_pages(struct inode *inode) { atomic_inc(&F2FS_I(inode)->dirty_pages); @@ -2281,6 +2288,12 @@ static inline void dec_page_count(struct f2fs_sb_info *sbi, int count_type) atomic_dec(&sbi->nr_pages[count_type]); } +static inline void dec_page_counts(struct f2fs_sb_info *sbi, int count_type, + unsigned int count) +{ + atomic_sub(count, &sbi->nr_pages[count_type]); +} + static inline void inode_dec_dirty_pages(struct inode *inode) { if (!S_ISDIR(inode->i_mode) && !S_ISREG(inode->i_mode) && -- 2.22.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [f2fs-dev] [PATCH] f2fs: fix wrong inflight page stats for directIO @ 2021-07-19 8:25 ` Chao Yu 0 siblings, 0 replies; 6+ messages in thread From: Chao Yu @ 2021-07-19 8:25 UTC (permalink / raw) To: jaegeuk; +Cc: Chao Yu, linux-kernel, linux-f2fs-devel Previously, we use sbi->nr_pages[] to account direct IO, the count should be based on page granularity rather than bio granularity, fix it. Fixes: 02b16d0a34a1 ("f2fs: add to account direct IO") Signed-off-by: Chao Yu <chao@kernel.org> --- fs/f2fs/data.c | 10 ++++++---- fs/f2fs/f2fs.h | 13 +++++++++++++ 2 files changed, 19 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index e6f107de4c92..1198d6cb4811 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -3494,8 +3494,9 @@ static void f2fs_dio_end_io(struct bio *bio) { struct f2fs_private_dio *dio = bio->bi_private; - dec_page_count(F2FS_I_SB(dio->inode), - dio->write ? F2FS_DIO_WRITE : F2FS_DIO_READ); + dec_page_counts(F2FS_I_SB(dio->inode), + dio->write ? F2FS_DIO_WRITE : F2FS_DIO_READ, + dio->blkcnt); bio->bi_private = dio->orig_private; bio->bi_end_io = dio->orig_end_io; @@ -3519,13 +3520,14 @@ static void f2fs_dio_submit_bio(struct bio *bio, struct inode *inode, dio->inode = inode; dio->orig_end_io = bio->bi_end_io; dio->orig_private = bio->bi_private; + dio->blkcnt = blkcnt; dio->write = write; bio->bi_end_io = f2fs_dio_end_io; bio->bi_private = dio; - inc_page_count(F2FS_I_SB(inode), - write ? F2FS_DIO_WRITE : F2FS_DIO_READ); + inc_page_counts(F2FS_I_SB(inode), + write ? F2FS_DIO_WRITE : F2FS_DIO_READ, dio->blkcnt); submit_bio(bio); return; diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 867f2c5d9559..7369f8087f64 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -1759,6 +1759,7 @@ struct f2fs_private_dio { struct inode *inode; void *orig_private; bio_end_io_t *orig_end_io; + unsigned int blkcnt; bool write; }; @@ -2267,6 +2268,12 @@ static inline void inc_page_count(struct f2fs_sb_info *sbi, int count_type) set_sbi_flag(sbi, SBI_IS_DIRTY); } +static inline void inc_page_counts(struct f2fs_sb_info *sbi, int count_type, + unsigned int count) +{ + atomic_add(count, &sbi->nr_pages[count_type]); +} + static inline void inode_inc_dirty_pages(struct inode *inode) { atomic_inc(&F2FS_I(inode)->dirty_pages); @@ -2281,6 +2288,12 @@ static inline void dec_page_count(struct f2fs_sb_info *sbi, int count_type) atomic_dec(&sbi->nr_pages[count_type]); } +static inline void dec_page_counts(struct f2fs_sb_info *sbi, int count_type, + unsigned int count) +{ + atomic_sub(count, &sbi->nr_pages[count_type]); +} + static inline void inode_dec_dirty_pages(struct inode *inode) { if (!S_ISDIR(inode->i_mode) && !S_ISREG(inode->i_mode) && -- 2.22.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] f2fs: fix wrong inflight page stats for directIO 2021-07-19 8:25 ` [f2fs-dev] " Chao Yu @ 2021-07-19 10:36 ` kernel test robot -1 siblings, 0 replies; 6+ messages in thread From: kernel test robot @ 2021-07-19 10:36 UTC (permalink / raw) To: Chao Yu, Chao Yu, jaegeuk Cc: clang-built-linux, kbuild-all, linux-f2fs-devel, linux-kernel, Chao Yu, Chao Yu [-- Attachment #1: Type: text/plain, Size: 8960 bytes --] Hi Chao, I love your patch! Yet something to improve: [auto build test ERROR on f2fs/dev-test] [also build test ERROR on linux/master linus/master v5.14-rc2 next-20210716] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Chao-Yu/f2fs-fix-wrong-inflight-page-stats-for-directIO/20210719-170844 base: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test config: powerpc64-buildonly-randconfig-r004-20210719 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 5d5b08761f944d5b9822d582378333cc4b36a0a7) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install powerpc64 cross compiling tool for clang build # apt-get install binutils-powerpc64-linux-gnu # https://github.com/0day-ci/linux/commit/5fc42a72cb1e41b799ea659d710c091804fb648a git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Chao-Yu/f2fs-fix-wrong-inflight-page-stats-for-directIO/20210719-170844 git checkout 5fc42a72cb1e41b799ea659d710c091804fb648a # save the attached .config to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash fs/f2fs/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): In file included from arch/powerpc/include/asm/hardirq.h:6: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/powerpc/include/asm/io.h:619: arch/powerpc/include/asm/io-defs.h:45:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] DEF_PCI_AC_NORET(insw, (unsigned long p, void *b, unsigned long c), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET' __do_##name al; \ ^~~~~~~~~~~~~~ <scratch space>:40:1: note: expanded from here __do_insw ^ arch/powerpc/include/asm/io.h:557:56: note: expanded from macro '__do_insw' #define __do_insw(p, b, n) readsw((PCI_IO_ADDR)_IO_BASE+(p), (b), (n)) ~~~~~~~~~~~~~~~~~~~~~^ In file included from fs/f2fs/data.c:9: In file included from include/linux/f2fs_fs.h:11: In file included from include/linux/pagemap.h:11: In file included from include/linux/highmem.h:10: In file included from include/linux/hardirq.h:11: In file included from arch/powerpc/include/asm/hardirq.h:6: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/powerpc/include/asm/io.h:619: arch/powerpc/include/asm/io-defs.h:47:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] DEF_PCI_AC_NORET(insl, (unsigned long p, void *b, unsigned long c), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET' __do_##name al; \ ^~~~~~~~~~~~~~ <scratch space>:44:1: note: expanded from here __do_insl ^ arch/powerpc/include/asm/io.h:558:56: note: expanded from macro '__do_insl' #define __do_insl(p, b, n) readsl((PCI_IO_ADDR)_IO_BASE+(p), (b), (n)) ~~~~~~~~~~~~~~~~~~~~~^ In file included from fs/f2fs/data.c:9: In file included from include/linux/f2fs_fs.h:11: In file included from include/linux/pagemap.h:11: In file included from include/linux/highmem.h:10: In file included from include/linux/hardirq.h:11: In file included from arch/powerpc/include/asm/hardirq.h:6: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/powerpc/include/asm/io.h:619: arch/powerpc/include/asm/io-defs.h:49:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] DEF_PCI_AC_NORET(outsb, (unsigned long p, const void *b, unsigned long c), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET' __do_##name al; \ ^~~~~~~~~~~~~~ <scratch space>:48:1: note: expanded from here __do_outsb ^ arch/powerpc/include/asm/io.h:559:58: note: expanded from macro '__do_outsb' #define __do_outsb(p, b, n) writesb((PCI_IO_ADDR)_IO_BASE+(p),(b),(n)) ~~~~~~~~~~~~~~~~~~~~~^ In file included from fs/f2fs/data.c:9: In file included from include/linux/f2fs_fs.h:11: In file included from include/linux/pagemap.h:11: In file included from include/linux/highmem.h:10: In file included from include/linux/hardirq.h:11: In file included from arch/powerpc/include/asm/hardirq.h:6: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/powerpc/include/asm/io.h:619: arch/powerpc/include/asm/io-defs.h:51:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] DEF_PCI_AC_NORET(outsw, (unsigned long p, const void *b, unsigned long c), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET' __do_##name al; \ ^~~~~~~~~~~~~~ <scratch space>:52:1: note: expanded from here __do_outsw ^ arch/powerpc/include/asm/io.h:560:58: note: expanded from macro '__do_outsw' #define __do_outsw(p, b, n) writesw((PCI_IO_ADDR)_IO_BASE+(p),(b),(n)) ~~~~~~~~~~~~~~~~~~~~~^ In file included from fs/f2fs/data.c:9: In file included from include/linux/f2fs_fs.h:11: In file included from include/linux/pagemap.h:11: In file included from include/linux/highmem.h:10: In file included from include/linux/hardirq.h:11: In file included from arch/powerpc/include/asm/hardirq.h:6: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/powerpc/include/asm/io.h:619: arch/powerpc/include/asm/io-defs.h:53:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] DEF_PCI_AC_NORET(outsl, (unsigned long p, const void *b, unsigned long c), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET' __do_##name al; \ ^~~~~~~~~~~~~~ <scratch space>:56:1: note: expanded from here __do_outsl ^ arch/powerpc/include/asm/io.h:561:58: note: expanded from macro '__do_outsl' #define __do_outsl(p, b, n) writesl((PCI_IO_ADDR)_IO_BASE+(p),(b),(n)) ~~~~~~~~~~~~~~~~~~~~~^ >> fs/f2fs/data.c:3523:16: error: use of undeclared identifier 'blkcnt' dio->blkcnt = blkcnt; ^ 12 warnings and 1 error generated. vim +/blkcnt +3523 fs/f2fs/data.c 3508 3509 static void f2fs_dio_submit_bio(struct bio *bio, struct inode *inode, 3510 loff_t file_offset) 3511 { 3512 struct f2fs_private_dio *dio; 3513 bool write = (bio_op(bio) == REQ_OP_WRITE); 3514 3515 dio = f2fs_kzalloc(F2FS_I_SB(inode), 3516 sizeof(struct f2fs_private_dio), GFP_NOFS); 3517 if (!dio) 3518 goto out; 3519 3520 dio->inode = inode; 3521 dio->orig_end_io = bio->bi_end_io; 3522 dio->orig_private = bio->bi_private; > 3523 dio->blkcnt = blkcnt; 3524 dio->write = write; 3525 3526 bio->bi_end_io = f2fs_dio_end_io; 3527 bio->bi_private = dio; 3528 3529 inc_page_counts(F2FS_I_SB(inode), 3530 write ? F2FS_DIO_WRITE : F2FS_DIO_READ, dio->blkcnt); 3531 3532 submit_bio(bio); 3533 return; 3534 out: 3535 bio->bi_status = BLK_STS_IOERR; 3536 bio_endio(bio); 3537 } 3538 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 45323 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] f2fs: fix wrong inflight page stats for directIO @ 2021-07-19 10:36 ` kernel test robot 0 siblings, 0 replies; 6+ messages in thread From: kernel test robot @ 2021-07-19 10:36 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 9137 bytes --] Hi Chao, I love your patch! Yet something to improve: [auto build test ERROR on f2fs/dev-test] [also build test ERROR on linux/master linus/master v5.14-rc2 next-20210716] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Chao-Yu/f2fs-fix-wrong-inflight-page-stats-for-directIO/20210719-170844 base: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test config: powerpc64-buildonly-randconfig-r004-20210719 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 5d5b08761f944d5b9822d582378333cc4b36a0a7) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install powerpc64 cross compiling tool for clang build # apt-get install binutils-powerpc64-linux-gnu # https://github.com/0day-ci/linux/commit/5fc42a72cb1e41b799ea659d710c091804fb648a git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Chao-Yu/f2fs-fix-wrong-inflight-page-stats-for-directIO/20210719-170844 git checkout 5fc42a72cb1e41b799ea659d710c091804fb648a # save the attached .config to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash fs/f2fs/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): In file included from arch/powerpc/include/asm/hardirq.h:6: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/powerpc/include/asm/io.h:619: arch/powerpc/include/asm/io-defs.h:45:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] DEF_PCI_AC_NORET(insw, (unsigned long p, void *b, unsigned long c), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET' __do_##name al; \ ^~~~~~~~~~~~~~ <scratch space>:40:1: note: expanded from here __do_insw ^ arch/powerpc/include/asm/io.h:557:56: note: expanded from macro '__do_insw' #define __do_insw(p, b, n) readsw((PCI_IO_ADDR)_IO_BASE+(p), (b), (n)) ~~~~~~~~~~~~~~~~~~~~~^ In file included from fs/f2fs/data.c:9: In file included from include/linux/f2fs_fs.h:11: In file included from include/linux/pagemap.h:11: In file included from include/linux/highmem.h:10: In file included from include/linux/hardirq.h:11: In file included from arch/powerpc/include/asm/hardirq.h:6: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/powerpc/include/asm/io.h:619: arch/powerpc/include/asm/io-defs.h:47:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] DEF_PCI_AC_NORET(insl, (unsigned long p, void *b, unsigned long c), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET' __do_##name al; \ ^~~~~~~~~~~~~~ <scratch space>:44:1: note: expanded from here __do_insl ^ arch/powerpc/include/asm/io.h:558:56: note: expanded from macro '__do_insl' #define __do_insl(p, b, n) readsl((PCI_IO_ADDR)_IO_BASE+(p), (b), (n)) ~~~~~~~~~~~~~~~~~~~~~^ In file included from fs/f2fs/data.c:9: In file included from include/linux/f2fs_fs.h:11: In file included from include/linux/pagemap.h:11: In file included from include/linux/highmem.h:10: In file included from include/linux/hardirq.h:11: In file included from arch/powerpc/include/asm/hardirq.h:6: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/powerpc/include/asm/io.h:619: arch/powerpc/include/asm/io-defs.h:49:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] DEF_PCI_AC_NORET(outsb, (unsigned long p, const void *b, unsigned long c), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET' __do_##name al; \ ^~~~~~~~~~~~~~ <scratch space>:48:1: note: expanded from here __do_outsb ^ arch/powerpc/include/asm/io.h:559:58: note: expanded from macro '__do_outsb' #define __do_outsb(p, b, n) writesb((PCI_IO_ADDR)_IO_BASE+(p),(b),(n)) ~~~~~~~~~~~~~~~~~~~~~^ In file included from fs/f2fs/data.c:9: In file included from include/linux/f2fs_fs.h:11: In file included from include/linux/pagemap.h:11: In file included from include/linux/highmem.h:10: In file included from include/linux/hardirq.h:11: In file included from arch/powerpc/include/asm/hardirq.h:6: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/powerpc/include/asm/io.h:619: arch/powerpc/include/asm/io-defs.h:51:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] DEF_PCI_AC_NORET(outsw, (unsigned long p, const void *b, unsigned long c), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET' __do_##name al; \ ^~~~~~~~~~~~~~ <scratch space>:52:1: note: expanded from here __do_outsw ^ arch/powerpc/include/asm/io.h:560:58: note: expanded from macro '__do_outsw' #define __do_outsw(p, b, n) writesw((PCI_IO_ADDR)_IO_BASE+(p),(b),(n)) ~~~~~~~~~~~~~~~~~~~~~^ In file included from fs/f2fs/data.c:9: In file included from include/linux/f2fs_fs.h:11: In file included from include/linux/pagemap.h:11: In file included from include/linux/highmem.h:10: In file included from include/linux/hardirq.h:11: In file included from arch/powerpc/include/asm/hardirq.h:6: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/powerpc/include/asm/io.h:619: arch/powerpc/include/asm/io-defs.h:53:1: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] DEF_PCI_AC_NORET(outsl, (unsigned long p, const void *b, unsigned long c), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/include/asm/io.h:616:3: note: expanded from macro 'DEF_PCI_AC_NORET' __do_##name al; \ ^~~~~~~~~~~~~~ <scratch space>:56:1: note: expanded from here __do_outsl ^ arch/powerpc/include/asm/io.h:561:58: note: expanded from macro '__do_outsl' #define __do_outsl(p, b, n) writesl((PCI_IO_ADDR)_IO_BASE+(p),(b),(n)) ~~~~~~~~~~~~~~~~~~~~~^ >> fs/f2fs/data.c:3523:16: error: use of undeclared identifier 'blkcnt' dio->blkcnt = blkcnt; ^ 12 warnings and 1 error generated. vim +/blkcnt +3523 fs/f2fs/data.c 3508 3509 static void f2fs_dio_submit_bio(struct bio *bio, struct inode *inode, 3510 loff_t file_offset) 3511 { 3512 struct f2fs_private_dio *dio; 3513 bool write = (bio_op(bio) == REQ_OP_WRITE); 3514 3515 dio = f2fs_kzalloc(F2FS_I_SB(inode), 3516 sizeof(struct f2fs_private_dio), GFP_NOFS); 3517 if (!dio) 3518 goto out; 3519 3520 dio->inode = inode; 3521 dio->orig_end_io = bio->bi_end_io; 3522 dio->orig_private = bio->bi_private; > 3523 dio->blkcnt = blkcnt; 3524 dio->write = write; 3525 3526 bio->bi_end_io = f2fs_dio_end_io; 3527 bio->bi_private = dio; 3528 3529 inc_page_counts(F2FS_I_SB(inode), 3530 write ? F2FS_DIO_WRITE : F2FS_DIO_READ, dio->blkcnt); 3531 3532 submit_bio(bio); 3533 return; 3534 out: 3535 bio->bi_status = BLK_STS_IOERR; 3536 bio_endio(bio); 3537 } 3538 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 45323 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] f2fs: fix wrong inflight page stats for directIO 2021-07-19 8:25 ` [f2fs-dev] " Chao Yu @ 2021-07-19 10:39 ` kernel test robot -1 siblings, 0 replies; 6+ messages in thread From: kernel test robot @ 2021-07-19 10:39 UTC (permalink / raw) To: Chao Yu, Chao Yu, jaegeuk Cc: kbuild-all, linux-f2fs-devel, linux-kernel, Chao Yu, Chao Yu [-- Attachment #1: Type: text/plain, Size: 2913 bytes --] Hi Chao, I love your patch! Yet something to improve: [auto build test ERROR on f2fs/dev-test] [also build test ERROR on linux/master linus/master v5.14-rc2 next-20210716] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Chao-Yu/f2fs-fix-wrong-inflight-page-stats-for-directIO/20210719-170844 base: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test config: nios2-randconfig-r031-20210719 (attached as .config) compiler: nios2-linux-gcc (GCC) 10.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/5fc42a72cb1e41b799ea659d710c091804fb648a git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Chao-Yu/f2fs-fix-wrong-inflight-page-stats-for-directIO/20210719-170844 git checkout 5fc42a72cb1e41b799ea659d710c091804fb648a # save the attached .config to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=nios2 SHELL=/bin/bash fs/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): fs/f2fs/data.c: In function 'f2fs_dio_submit_bio': >> fs/f2fs/data.c:3523:16: error: 'blkcnt' undeclared (first use in this function); did you mean 'blkcg'? 3523 | dio->blkcnt = blkcnt; | ^~~~~~ | blkcg fs/f2fs/data.c:3523:16: note: each undeclared identifier is reported only once for each function it appears in vim +3523 fs/f2fs/data.c 3508 3509 static void f2fs_dio_submit_bio(struct bio *bio, struct inode *inode, 3510 loff_t file_offset) 3511 { 3512 struct f2fs_private_dio *dio; 3513 bool write = (bio_op(bio) == REQ_OP_WRITE); 3514 3515 dio = f2fs_kzalloc(F2FS_I_SB(inode), 3516 sizeof(struct f2fs_private_dio), GFP_NOFS); 3517 if (!dio) 3518 goto out; 3519 3520 dio->inode = inode; 3521 dio->orig_end_io = bio->bi_end_io; 3522 dio->orig_private = bio->bi_private; > 3523 dio->blkcnt = blkcnt; 3524 dio->write = write; 3525 3526 bio->bi_end_io = f2fs_dio_end_io; 3527 bio->bi_private = dio; 3528 3529 inc_page_counts(F2FS_I_SB(inode), 3530 write ? F2FS_DIO_WRITE : F2FS_DIO_READ, dio->blkcnt); 3531 3532 submit_bio(bio); 3533 return; 3534 out: 3535 bio->bi_status = BLK_STS_IOERR; 3536 bio_endio(bio); 3537 } 3538 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 28532 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] f2fs: fix wrong inflight page stats for directIO @ 2021-07-19 10:39 ` kernel test robot 0 siblings, 0 replies; 6+ messages in thread From: kernel test robot @ 2021-07-19 10:39 UTC (permalink / raw) To: kbuild-all [-- Attachment #1: Type: text/plain, Size: 2990 bytes --] Hi Chao, I love your patch! Yet something to improve: [auto build test ERROR on f2fs/dev-test] [also build test ERROR on linux/master linus/master v5.14-rc2 next-20210716] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Chao-Yu/f2fs-fix-wrong-inflight-page-stats-for-directIO/20210719-170844 base: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test config: nios2-randconfig-r031-20210719 (attached as .config) compiler: nios2-linux-gcc (GCC) 10.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/5fc42a72cb1e41b799ea659d710c091804fb648a git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Chao-Yu/f2fs-fix-wrong-inflight-page-stats-for-directIO/20210719-170844 git checkout 5fc42a72cb1e41b799ea659d710c091804fb648a # save the attached .config to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=nios2 SHELL=/bin/bash fs/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): fs/f2fs/data.c: In function 'f2fs_dio_submit_bio': >> fs/f2fs/data.c:3523:16: error: 'blkcnt' undeclared (first use in this function); did you mean 'blkcg'? 3523 | dio->blkcnt = blkcnt; | ^~~~~~ | blkcg fs/f2fs/data.c:3523:16: note: each undeclared identifier is reported only once for each function it appears in vim +3523 fs/f2fs/data.c 3508 3509 static void f2fs_dio_submit_bio(struct bio *bio, struct inode *inode, 3510 loff_t file_offset) 3511 { 3512 struct f2fs_private_dio *dio; 3513 bool write = (bio_op(bio) == REQ_OP_WRITE); 3514 3515 dio = f2fs_kzalloc(F2FS_I_SB(inode), 3516 sizeof(struct f2fs_private_dio), GFP_NOFS); 3517 if (!dio) 3518 goto out; 3519 3520 dio->inode = inode; 3521 dio->orig_end_io = bio->bi_end_io; 3522 dio->orig_private = bio->bi_private; > 3523 dio->blkcnt = blkcnt; 3524 dio->write = write; 3525 3526 bio->bi_end_io = f2fs_dio_end_io; 3527 bio->bi_private = dio; 3528 3529 inc_page_counts(F2FS_I_SB(inode), 3530 write ? F2FS_DIO_WRITE : F2FS_DIO_READ, dio->blkcnt); 3531 3532 submit_bio(bio); 3533 return; 3534 out: 3535 bio->bi_status = BLK_STS_IOERR; 3536 bio_endio(bio); 3537 } 3538 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 28532 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-07-19 10:39 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-07-19 8:25 [PATCH] f2fs: fix wrong inflight page stats for directIO Chao Yu 2021-07-19 8:25 ` [f2fs-dev] " Chao Yu 2021-07-19 10:36 ` kernel test robot 2021-07-19 10:36 ` kernel test robot 2021-07-19 10:39 ` kernel test robot 2021-07-19 10:39 ` kernel test robot
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.