* Re: [PATCH] tests/qtest/migration-test.c: use 127.0.0.1 instead of 0
2021-07-19 18:52 [PATCH] tests/qtest/migration-test.c: use 127.0.0.1 instead of 0 Dr. David Alan Gilbert (git)
@ 2021-07-19 19:43 ` Peter Xu
2021-07-19 22:16 ` Daniel P. Berrangé
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Peter Xu @ 2021-07-19 19:43 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git); +Cc: thuth, berrange, qemu-devel, quintela
On Mon, Jul 19, 2021 at 07:52:17PM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> OpenBSD doesn't like :0 as an address, switch to using 127.0.0.1
> in baddest; it's really testing the :0 port number that isn't allowed
> on anything.
>
> (The test doesn't currently run anyway because of the userfault
> problem that Peter noticed, but this gets us closer to being able to
> reenable it)
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Acked-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tests/qtest/migration-test.c: use 127.0.0.1 instead of 0
2021-07-19 18:52 [PATCH] tests/qtest/migration-test.c: use 127.0.0.1 instead of 0 Dr. David Alan Gilbert (git)
2021-07-19 19:43 ` Peter Xu
@ 2021-07-19 22:16 ` Daniel P. Berrangé
2021-07-20 8:04 ` Juan Quintela
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Daniel P. Berrangé @ 2021-07-19 22:16 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git); +Cc: thuth, qemu-devel, peterx, quintela
On Mon, Jul 19, 2021 at 07:52:17PM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> OpenBSD doesn't like :0 as an address, switch to using 127.0.0.1
> in baddest; it's really testing the :0 port number that isn't allowed
> on anything.
>
> (The test doesn't currently run anyway because of the userfault
> problem that Peter noticed, but this gets us closer to being able to
> reenable it)
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> tests/qtest/migration-test.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tests/qtest/migration-test.c: use 127.0.0.1 instead of 0
2021-07-19 18:52 [PATCH] tests/qtest/migration-test.c: use 127.0.0.1 instead of 0 Dr. David Alan Gilbert (git)
2021-07-19 19:43 ` Peter Xu
2021-07-19 22:16 ` Daniel P. Berrangé
@ 2021-07-20 8:04 ` Juan Quintela
2021-07-20 11:44 ` Philippe Mathieu-Daudé
2021-07-26 11:26 ` Dr. David Alan Gilbert
4 siblings, 0 replies; 6+ messages in thread
From: Juan Quintela @ 2021-07-20 8:04 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git); +Cc: thuth, berrange, qemu-devel, peterx
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> OpenBSD doesn't like :0 as an address, switch to using 127.0.0.1
> in baddest; it's really testing the :0 port number that isn't allowed
> on anything.
>
> (The test doesn't currently run anyway because of the userfault
> problem that Peter noticed, but this gets us closer to being able to
> reenable it)
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Why, o why networkinghas to be so difficult.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tests/qtest/migration-test.c: use 127.0.0.1 instead of 0
2021-07-19 18:52 [PATCH] tests/qtest/migration-test.c: use 127.0.0.1 instead of 0 Dr. David Alan Gilbert (git)
` (2 preceding siblings ...)
2021-07-20 8:04 ` Juan Quintela
@ 2021-07-20 11:44 ` Philippe Mathieu-Daudé
2021-07-26 11:26 ` Dr. David Alan Gilbert
4 siblings, 0 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-07-20 11:44 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git),
qemu-devel, thuth, peterx, berrange, quintela
On 7/19/21 8:52 PM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> OpenBSD doesn't like :0 as an address, switch to using 127.0.0.1
> in baddest; it's really testing the :0 port number that isn't allowed
> on anything.
>
> (The test doesn't currently run anyway because of the userfault
> problem that Peter noticed, but this gets us closer to being able to
> reenable it)
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> tests/qtest/migration-test.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tests/qtest/migration-test.c: use 127.0.0.1 instead of 0
2021-07-19 18:52 [PATCH] tests/qtest/migration-test.c: use 127.0.0.1 instead of 0 Dr. David Alan Gilbert (git)
` (3 preceding siblings ...)
2021-07-20 11:44 ` Philippe Mathieu-Daudé
@ 2021-07-26 11:26 ` Dr. David Alan Gilbert
4 siblings, 0 replies; 6+ messages in thread
From: Dr. David Alan Gilbert @ 2021-07-26 11:26 UTC (permalink / raw)
To: qemu-devel, thuth, peterx, berrange, quintela
* Dr. David Alan Gilbert (git) (dgilbert@redhat.com) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> OpenBSD doesn't like :0 as an address, switch to using 127.0.0.1
> in baddest; it's really testing the :0 port number that isn't allowed
> on anything.
>
> (The test doesn't currently run anyway because of the userfault
> problem that Peter noticed, but this gets us closer to being able to
> reenable it)
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Queued
> ---
> tests/qtest/migration-test.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
> index 328d6dbe97..1e8b7784ef 100644
> --- a/tests/qtest/migration-test.c
> +++ b/tests/qtest/migration-test.c
> @@ -787,10 +787,10 @@ static void test_baddest(void)
>
> args->hide_stderr = true;
>
> - if (test_migrate_start(&from, &to, "tcp:0:0", args)) {
> + if (test_migrate_start(&from, &to, "tcp:127.0.0.1:0", args)) {
> return;
> }
> - migrate_qmp(from, "tcp:0:0", "{}");
> + migrate_qmp(from, "tcp:127.0.0.1:0", "{}");
> wait_for_migration_fail(from, false);
> test_migrate_end(from, to, false);
> }
> --
> 2.31.1
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 6+ messages in thread