All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: hda: intel-dsp-cfg: add missing ElkhartLake PCI ID
@ 2021-07-19 23:17 Pierre-Louis Bossart
  2021-07-20  7:11 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Pierre-Louis Bossart @ 2021-07-19 23:17 UTC (permalink / raw)
  To: alsa-devel; +Cc: tiwai, broonie, Pierre-Louis Bossart

We missed the fact that ElkhartLake platforms have two different PCI
IDs. We only added one so the SOF driver is never selected by the
autodetection logic for the missing configuration.

BugLink: https://github.com/thesofproject/linux/issues/2990
Fixes: cc8f81c7e625 ('ALSA: hda: fix intel DSP config')
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/hda/intel-dsp-config.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sound/hda/intel-dsp-config.c b/sound/hda/intel-dsp-config.c
index d8be146793ee..c9d0ba353463 100644
--- a/sound/hda/intel-dsp-config.c
+++ b/sound/hda/intel-dsp-config.c
@@ -319,6 +319,10 @@ static const struct config_entry config_table[] = {
 		.flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC,
 		.device = 0x4b55,
 	},
+	{
+		.flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC,
+		.device = 0x4b58,
+	},
 #endif
 
 /* Alder Lake */
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ALSA: hda: intel-dsp-cfg: add missing ElkhartLake PCI ID
  2021-07-19 23:17 [PATCH] ALSA: hda: intel-dsp-cfg: add missing ElkhartLake PCI ID Pierre-Louis Bossart
@ 2021-07-20  7:11 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2021-07-20  7:11 UTC (permalink / raw)
  To: Pierre-Louis Bossart; +Cc: alsa-devel, broonie

On Tue, 20 Jul 2021 01:17:46 +0200,
Pierre-Louis Bossart wrote:
> 
> We missed the fact that ElkhartLake platforms have two different PCI
> IDs. We only added one so the SOF driver is never selected by the
> autodetection logic for the missing configuration.
> 
> BugLink: https://github.com/thesofproject/linux/issues/2990
> Fixes: cc8f81c7e625 ('ALSA: hda: fix intel DSP config')
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

Thanks, applied.


Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-20  7:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-19 23:17 [PATCH] ALSA: hda: intel-dsp-cfg: add missing ElkhartLake PCI ID Pierre-Louis Bossart
2021-07-20  7:11 ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.