drivers/net/ethernet/intel/ice/ice_ptp_hw.c:367 ice_ptp_port_cmd_e810() error: uninitialized symbol 'cmd_val'.

drivers/net/ethernet/intel/ice/ice_ptp_hw.c:367 ice_ptp_port_cmd_e810() error: uninitialized symbol 'cmd_val'.

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 4929 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Jacob Keller <jacob.e.keller@intel.com>
CC: Tony Nguyen <anthony.l.nguyen@intel.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   2734d6c1b1a089fb593ef6a23d4b70903526fe0c
commit: 06c16d89d2cbe284c2792caa7648c052c1b91042 ice: register 1588 PTP clock device object for E810 devices
date:   5 weeks ago
:::::: branch date: 22 hours ago
:::::: commit date: 5 weeks ago
config: i386-randconfig-m031-20210720 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/net/ethernet/intel/ice/ice_ptp_hw.c:367 ice_ptp_port_cmd_e810() error: uninitialized symbol 'cmd_val'.

vim +/cmd_val +367 drivers/net/ethernet/intel/ice/ice_ptp_hw.c

03cb4473be92a4 Jacob Keller 2021-06-09  326  
03cb4473be92a4 Jacob Keller 2021-06-09  327  /**
03cb4473be92a4 Jacob Keller 2021-06-09  328   * ice_ptp_port_cmd_e810 - Prepare all external PHYs for a timer command
03cb4473be92a4 Jacob Keller 2021-06-09  329   * @hw: pointer to HW struct
03cb4473be92a4 Jacob Keller 2021-06-09  330   * @cmd: Command to be sent to the port
03cb4473be92a4 Jacob Keller 2021-06-09  331   *
03cb4473be92a4 Jacob Keller 2021-06-09  332   * Prepare the external PHYs connected to this device for a timer sync
03cb4473be92a4 Jacob Keller 2021-06-09  333   * command.
03cb4473be92a4 Jacob Keller 2021-06-09  334   */
03cb4473be92a4 Jacob Keller 2021-06-09  335  static int ice_ptp_port_cmd_e810(struct ice_hw *hw, enum ice_ptp_tmr_cmd cmd)
03cb4473be92a4 Jacob Keller 2021-06-09  336  {
03cb4473be92a4 Jacob Keller 2021-06-09  337  	u32 cmd_val, val;
03cb4473be92a4 Jacob Keller 2021-06-09  338  	int status;
03cb4473be92a4 Jacob Keller 2021-06-09  339  
03cb4473be92a4 Jacob Keller 2021-06-09  340  	switch (cmd) {
03cb4473be92a4 Jacob Keller 2021-06-09  341  	case INIT_TIME:
03cb4473be92a4 Jacob Keller 2021-06-09  342  		cmd_val = GLTSYN_CMD_INIT_TIME;
03cb4473be92a4 Jacob Keller 2021-06-09  343  		break;
03cb4473be92a4 Jacob Keller 2021-06-09  344  	case INIT_INCVAL:
03cb4473be92a4 Jacob Keller 2021-06-09  345  		cmd_val = GLTSYN_CMD_INIT_INCVAL;
03cb4473be92a4 Jacob Keller 2021-06-09  346  		break;
03cb4473be92a4 Jacob Keller 2021-06-09  347  	case ADJ_TIME:
03cb4473be92a4 Jacob Keller 2021-06-09  348  		cmd_val = GLTSYN_CMD_ADJ_TIME;
03cb4473be92a4 Jacob Keller 2021-06-09  349  		break;
03cb4473be92a4 Jacob Keller 2021-06-09  350  	case READ_TIME:
03cb4473be92a4 Jacob Keller 2021-06-09  351  		cmd_val = GLTSYN_CMD_READ_TIME;
03cb4473be92a4 Jacob Keller 2021-06-09  352  		break;
03cb4473be92a4 Jacob Keller 2021-06-09  353  	case ADJ_TIME_AT_TIME:
03cb4473be92a4 Jacob Keller 2021-06-09  354  		cmd_val = GLTSYN_CMD_ADJ_INIT_TIME;
03cb4473be92a4 Jacob Keller 2021-06-09  355  		break;
03cb4473be92a4 Jacob Keller 2021-06-09  356  	}
03cb4473be92a4 Jacob Keller 2021-06-09  357  
03cb4473be92a4 Jacob Keller 2021-06-09  358  	/* Read, modify, write */
03cb4473be92a4 Jacob Keller 2021-06-09  359  	status = ice_read_phy_reg_e810(hw, ETH_GLTSYN_CMD, &val);
03cb4473be92a4 Jacob Keller 2021-06-09  360  	if (status) {
03cb4473be92a4 Jacob Keller 2021-06-09  361  		ice_debug(hw, ICE_DBG_PTP, "Failed to read GLTSYN_CMD, status %d\n", status);
03cb4473be92a4 Jacob Keller 2021-06-09  362  		return status;
03cb4473be92a4 Jacob Keller 2021-06-09  363  	}
03cb4473be92a4 Jacob Keller 2021-06-09  364  
03cb4473be92a4 Jacob Keller 2021-06-09  365  	/* Modify necessary bits only and perform write */
03cb4473be92a4 Jacob Keller 2021-06-09  366  	val &= ~TS_CMD_MASK_E810;
03cb4473be92a4 Jacob Keller 2021-06-09 @367  	val |= cmd_val;
03cb4473be92a4 Jacob Keller 2021-06-09  368  
03cb4473be92a4 Jacob Keller 2021-06-09  369  	status = ice_write_phy_reg_e810(hw, ETH_GLTSYN_CMD, val);
03cb4473be92a4 Jacob Keller 2021-06-09  370  	if (status) {
03cb4473be92a4 Jacob Keller 2021-06-09  371  		ice_debug(hw, ICE_DBG_PTP, "Failed to write back GLTSYN_CMD, status %d\n", status);
03cb4473be92a4 Jacob Keller 2021-06-09  372  		return status;
03cb4473be92a4 Jacob Keller 2021-06-09  373  	}
03cb4473be92a4 Jacob Keller 2021-06-09  374  
03cb4473be92a4 Jacob Keller 2021-06-09  375  	return 0;
03cb4473be92a4 Jacob Keller 2021-06-09  376  }
03cb4473be92a4 Jacob Keller 2021-06-09  377  

:::::: The code at line 367 was first introduced by commit
:::::: 03cb4473be92a4207a3d1df25186dafd1a5add4d ice: add low level PTP clock access functions

:::::: TO: Jacob Keller <jacob.e.keller@intel.com>
:::::: CC: Tony Nguyen <anthony.l.nguyen@intel.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38653 bytes --]