* drivers/net/wireless/intel/iwlwifi/mvm/fw.c:974 iwl_mvm_ppag_send_cmd() error: buffer overflow 'gain' 11 <= 21
@ 2021-07-20 1:48 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-07-20 1:48 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 5594 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Gil Adam <gil.adam@intel.com>
CC: Luca Coelho <luciano.coelho@intel.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 2734d6c1b1a089fb593ef6a23d4b70903526fe0c
commit: f2134f66f40e3f74104562a4eb6c607601dcfa83 iwlwifi: acpi: support ppag table command v2
date: 10 months ago
:::::: branch date: 29 hours ago
:::::: commit date: 10 months ago
config: x86_64-randconfig-m001-20210720 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/net/wireless/intel/iwlwifi/mvm/fw.c:974 iwl_mvm_ppag_send_cmd() error: buffer overflow 'gain' 11 <= 21
Old smatch warnings:
drivers/net/wireless/intel/iwlwifi/mvm/fw.c:1384 iwl_mvm_up() warn: missing error code 'ret'
vim +/gain +974 drivers/net/wireless/intel/iwlwifi/mvm/fw.c
6ce1e5c0c207d9 Gil Adam 2019-06-16 931
6ce1e5c0c207d9 Gil Adam 2019-06-16 932 int iwl_mvm_ppag_send_cmd(struct iwl_mvm *mvm)
6ce1e5c0c207d9 Gil Adam 2019-06-16 933 {
f2134f66f40e3f Gil Adam 2020-09-24 934 u8 cmd_ver;
f2134f66f40e3f Gil Adam 2020-09-24 935 int i, j, ret, num_sub_bands, cmd_size;
f2134f66f40e3f Gil Adam 2020-09-24 936 union iwl_ppag_table_cmd ppag_table;
f2134f66f40e3f Gil Adam 2020-09-24 937 s8 *gain;
6ce1e5c0c207d9 Gil Adam 2019-06-16 938
6ce1e5c0c207d9 Gil Adam 2019-06-16 939 if (!fw_has_capa(&mvm->fw->ucode_capa, IWL_UCODE_TLV_CAPA_SET_PPAG)) {
6ce1e5c0c207d9 Gil Adam 2019-06-16 940 IWL_DEBUG_RADIO(mvm,
6ce1e5c0c207d9 Gil Adam 2019-06-16 941 "PPAG capability not supported by FW, command not sent.\n");
6ce1e5c0c207d9 Gil Adam 2019-06-16 942 return 0;
6ce1e5c0c207d9 Gil Adam 2019-06-16 943 }
f2134f66f40e3f Gil Adam 2020-09-24 944 if (!mvm->fwrt.ppag_table.v1.enabled) {
f2134f66f40e3f Gil Adam 2020-09-24 945 IWL_DEBUG_RADIO(mvm, "PPAG not enabled, command not sent.\n");
f2134f66f40e3f Gil Adam 2020-09-24 946 return 0;
f2134f66f40e3f Gil Adam 2020-09-24 947 }
6ce1e5c0c207d9 Gil Adam 2019-06-16 948
f2134f66f40e3f Gil Adam 2020-09-24 949 cmd_ver = iwl_fw_lookup_cmd_ver(mvm->fw, PHY_OPS_GROUP,
f2134f66f40e3f Gil Adam 2020-09-24 950 PER_PLATFORM_ANT_GAIN_CMD);
f2134f66f40e3f Gil Adam 2020-09-24 951 if (cmd_ver == 1) {
f2134f66f40e3f Gil Adam 2020-09-24 952 num_sub_bands = IWL_NUM_SUB_BANDS;
f2134f66f40e3f Gil Adam 2020-09-24 953 gain = mvm->fwrt.ppag_table.v1.gain[0];
f2134f66f40e3f Gil Adam 2020-09-24 954 cmd_size = sizeof(ppag_table.v1);
f2134f66f40e3f Gil Adam 2020-09-24 955 if (mvm->fwrt.ppag_ver == 2) {
160bab43419ebc Gil Adam 2019-11-07 956 IWL_DEBUG_RADIO(mvm,
f2134f66f40e3f Gil Adam 2020-09-24 957 "PPAG table is v2 but FW supports v1, sending truncated table\n");
f2134f66f40e3f Gil Adam 2020-09-24 958 }
f2134f66f40e3f Gil Adam 2020-09-24 959 } else if (cmd_ver == 2) {
f2134f66f40e3f Gil Adam 2020-09-24 960 num_sub_bands = IWL_NUM_SUB_BANDS_V2;
f2134f66f40e3f Gil Adam 2020-09-24 961 gain = mvm->fwrt.ppag_table.v2.gain[0];
f2134f66f40e3f Gil Adam 2020-09-24 962 cmd_size = sizeof(ppag_table.v2);
f2134f66f40e3f Gil Adam 2020-09-24 963 if (mvm->fwrt.ppag_ver == 1) {
f2134f66f40e3f Gil Adam 2020-09-24 964 IWL_DEBUG_RADIO(mvm,
f2134f66f40e3f Gil Adam 2020-09-24 965 "PPAG table is v1 but FW supports v2, sending padded table\n");
f2134f66f40e3f Gil Adam 2020-09-24 966 }
f2134f66f40e3f Gil Adam 2020-09-24 967 } else {
f2134f66f40e3f Gil Adam 2020-09-24 968 IWL_DEBUG_RADIO(mvm, "Unsupported PPAG command version\n");
160bab43419ebc Gil Adam 2019-11-07 969 return 0;
160bab43419ebc Gil Adam 2019-11-07 970 }
160bab43419ebc Gil Adam 2019-11-07 971
f2134f66f40e3f Gil Adam 2020-09-24 972 for (i = 0; i < IWL_NUM_CHAIN_LIMITS; i++) {
f2134f66f40e3f Gil Adam 2020-09-24 973 for (j = 0; j < num_sub_bands; j++) {
6ce1e5c0c207d9 Gil Adam 2019-06-16 @974 IWL_DEBUG_RADIO(mvm,
6ce1e5c0c207d9 Gil Adam 2019-06-16 975 "PPAG table: chain[%d] band[%d]: gain = %d\n",
f2134f66f40e3f Gil Adam 2020-09-24 976 i, j, gain[i * num_sub_bands + j]);
6ce1e5c0c207d9 Gil Adam 2019-06-16 977 }
6ce1e5c0c207d9 Gil Adam 2019-06-16 978 }
f2134f66f40e3f Gil Adam 2020-09-24 979 IWL_DEBUG_RADIO(mvm, "Sending PER_PLATFORM_ANT_GAIN_CMD\n");
6ce1e5c0c207d9 Gil Adam 2019-06-16 980 ret = iwl_mvm_send_cmd_pdu(mvm, WIDE_ID(PHY_OPS_GROUP,
6ce1e5c0c207d9 Gil Adam 2019-06-16 981 PER_PLATFORM_ANT_GAIN_CMD),
f2134f66f40e3f Gil Adam 2020-09-24 982 0, cmd_size, &ppag_table);
6ce1e5c0c207d9 Gil Adam 2019-06-16 983 if (ret < 0)
6ce1e5c0c207d9 Gil Adam 2019-06-16 984 IWL_ERR(mvm, "failed to send PER_PLATFORM_ANT_GAIN_CMD (%d)\n",
6ce1e5c0c207d9 Gil Adam 2019-06-16 985 ret);
6ce1e5c0c207d9 Gil Adam 2019-06-16 986
6ce1e5c0c207d9 Gil Adam 2019-06-16 987 return ret;
6ce1e5c0c207d9 Gil Adam 2019-06-16 988 }
6ce1e5c0c207d9 Gil Adam 2019-06-16 989
:::::: The code@line 974 was first introduced by commit
:::::: 6ce1e5c0c207d9a0dbd0f451ed58f333c8e3594c iwlwifi: support per-platform antenna gain
:::::: TO: Gil Adam <gil.adam@intel.com>
:::::: CC: Luca Coelho <luciano.coelho@intel.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32843 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* drivers/net/wireless/intel/iwlwifi/mvm/fw.c:974 iwl_mvm_ppag_send_cmd() error: buffer overflow 'gain' 11 <= 21
@ 2021-02-08 1:55 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-02-08 1:55 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 5575 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Gil Adam <gil.adam@intel.com>
CC: Luca Coelho <luciano.coelho@intel.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 61556703b610a104de324e4f061dc6cf7b218b46
commit: f2134f66f40e3f74104562a4eb6c607601dcfa83 iwlwifi: acpi: support ppag table command v2
date: 4 months ago
:::::: branch date: 4 days ago
:::::: commit date: 4 months ago
config: x86_64-randconfig-m001-20210208 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/net/wireless/intel/iwlwifi/mvm/fw.c:974 iwl_mvm_ppag_send_cmd() error: buffer overflow 'gain' 11 <= 21
Old smatch warnings:
drivers/net/wireless/intel/iwlwifi/mvm/fw.c:1384 iwl_mvm_up() warn: missing error code 'ret'
vim +/gain +974 drivers/net/wireless/intel/iwlwifi/mvm/fw.c
6ce1e5c0c207d9 Gil Adam 2019-06-16 931
6ce1e5c0c207d9 Gil Adam 2019-06-16 932 int iwl_mvm_ppag_send_cmd(struct iwl_mvm *mvm)
6ce1e5c0c207d9 Gil Adam 2019-06-16 933 {
f2134f66f40e3f Gil Adam 2020-09-24 934 u8 cmd_ver;
f2134f66f40e3f Gil Adam 2020-09-24 935 int i, j, ret, num_sub_bands, cmd_size;
f2134f66f40e3f Gil Adam 2020-09-24 936 union iwl_ppag_table_cmd ppag_table;
f2134f66f40e3f Gil Adam 2020-09-24 937 s8 *gain;
6ce1e5c0c207d9 Gil Adam 2019-06-16 938
6ce1e5c0c207d9 Gil Adam 2019-06-16 939 if (!fw_has_capa(&mvm->fw->ucode_capa, IWL_UCODE_TLV_CAPA_SET_PPAG)) {
6ce1e5c0c207d9 Gil Adam 2019-06-16 940 IWL_DEBUG_RADIO(mvm,
6ce1e5c0c207d9 Gil Adam 2019-06-16 941 "PPAG capability not supported by FW, command not sent.\n");
6ce1e5c0c207d9 Gil Adam 2019-06-16 942 return 0;
6ce1e5c0c207d9 Gil Adam 2019-06-16 943 }
f2134f66f40e3f Gil Adam 2020-09-24 944 if (!mvm->fwrt.ppag_table.v1.enabled) {
f2134f66f40e3f Gil Adam 2020-09-24 945 IWL_DEBUG_RADIO(mvm, "PPAG not enabled, command not sent.\n");
f2134f66f40e3f Gil Adam 2020-09-24 946 return 0;
f2134f66f40e3f Gil Adam 2020-09-24 947 }
6ce1e5c0c207d9 Gil Adam 2019-06-16 948
f2134f66f40e3f Gil Adam 2020-09-24 949 cmd_ver = iwl_fw_lookup_cmd_ver(mvm->fw, PHY_OPS_GROUP,
f2134f66f40e3f Gil Adam 2020-09-24 950 PER_PLATFORM_ANT_GAIN_CMD);
f2134f66f40e3f Gil Adam 2020-09-24 951 if (cmd_ver == 1) {
f2134f66f40e3f Gil Adam 2020-09-24 952 num_sub_bands = IWL_NUM_SUB_BANDS;
f2134f66f40e3f Gil Adam 2020-09-24 953 gain = mvm->fwrt.ppag_table.v1.gain[0];
f2134f66f40e3f Gil Adam 2020-09-24 954 cmd_size = sizeof(ppag_table.v1);
f2134f66f40e3f Gil Adam 2020-09-24 955 if (mvm->fwrt.ppag_ver == 2) {
160bab43419ebc Gil Adam 2019-11-07 956 IWL_DEBUG_RADIO(mvm,
f2134f66f40e3f Gil Adam 2020-09-24 957 "PPAG table is v2 but FW supports v1, sending truncated table\n");
f2134f66f40e3f Gil Adam 2020-09-24 958 }
f2134f66f40e3f Gil Adam 2020-09-24 959 } else if (cmd_ver == 2) {
f2134f66f40e3f Gil Adam 2020-09-24 960 num_sub_bands = IWL_NUM_SUB_BANDS_V2;
f2134f66f40e3f Gil Adam 2020-09-24 961 gain = mvm->fwrt.ppag_table.v2.gain[0];
f2134f66f40e3f Gil Adam 2020-09-24 962 cmd_size = sizeof(ppag_table.v2);
f2134f66f40e3f Gil Adam 2020-09-24 963 if (mvm->fwrt.ppag_ver == 1) {
f2134f66f40e3f Gil Adam 2020-09-24 964 IWL_DEBUG_RADIO(mvm,
f2134f66f40e3f Gil Adam 2020-09-24 965 "PPAG table is v1 but FW supports v2, sending padded table\n");
f2134f66f40e3f Gil Adam 2020-09-24 966 }
f2134f66f40e3f Gil Adam 2020-09-24 967 } else {
f2134f66f40e3f Gil Adam 2020-09-24 968 IWL_DEBUG_RADIO(mvm, "Unsupported PPAG command version\n");
160bab43419ebc Gil Adam 2019-11-07 969 return 0;
160bab43419ebc Gil Adam 2019-11-07 970 }
160bab43419ebc Gil Adam 2019-11-07 971
f2134f66f40e3f Gil Adam 2020-09-24 972 for (i = 0; i < IWL_NUM_CHAIN_LIMITS; i++) {
f2134f66f40e3f Gil Adam 2020-09-24 973 for (j = 0; j < num_sub_bands; j++) {
6ce1e5c0c207d9 Gil Adam 2019-06-16 @974 IWL_DEBUG_RADIO(mvm,
6ce1e5c0c207d9 Gil Adam 2019-06-16 975 "PPAG table: chain[%d] band[%d]: gain = %d\n",
f2134f66f40e3f Gil Adam 2020-09-24 976 i, j, gain[i * num_sub_bands + j]);
6ce1e5c0c207d9 Gil Adam 2019-06-16 977 }
6ce1e5c0c207d9 Gil Adam 2019-06-16 978 }
f2134f66f40e3f Gil Adam 2020-09-24 979 IWL_DEBUG_RADIO(mvm, "Sending PER_PLATFORM_ANT_GAIN_CMD\n");
6ce1e5c0c207d9 Gil Adam 2019-06-16 980 ret = iwl_mvm_send_cmd_pdu(mvm, WIDE_ID(PHY_OPS_GROUP,
6ce1e5c0c207d9 Gil Adam 2019-06-16 981 PER_PLATFORM_ANT_GAIN_CMD),
f2134f66f40e3f Gil Adam 2020-09-24 982 0, cmd_size, &ppag_table);
6ce1e5c0c207d9 Gil Adam 2019-06-16 983 if (ret < 0)
6ce1e5c0c207d9 Gil Adam 2019-06-16 984 IWL_ERR(mvm, "failed to send PER_PLATFORM_ANT_GAIN_CMD (%d)\n",
6ce1e5c0c207d9 Gil Adam 2019-06-16 985 ret);
6ce1e5c0c207d9 Gil Adam 2019-06-16 986
6ce1e5c0c207d9 Gil Adam 2019-06-16 987 return ret;
6ce1e5c0c207d9 Gil Adam 2019-06-16 988 }
6ce1e5c0c207d9 Gil Adam 2019-06-16 989
:::::: The code@line 974 was first introduced by commit
:::::: 6ce1e5c0c207d9a0dbd0f451ed58f333c8e3594c iwlwifi: support per-platform antenna gain
:::::: TO: Gil Adam <gil.adam@intel.com>
:::::: CC: Luca Coelho <luciano.coelho@intel.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 39205 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-20 1:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-20 1:48 drivers/net/wireless/intel/iwlwifi/mvm/fw.c:974 iwl_mvm_ppag_send_cmd() error: buffer overflow 'gain' 11 <= 21 kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2021-02-08 1:55 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.