All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH][next] drm/i915/xelpd: Fix unsigned compared to less than zero error
@ 2021-07-20 15:57 ` Colin King
  0 siblings, 0 replies; 8+ messages in thread
From: Colin King @ 2021-07-20 15:57 UTC (permalink / raw)
  To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie,
	Daniel Vetter, Lucas De Marchi, Anusha Srivatsa, intel-gfx,
	dri-devel
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

The subtraction of fw->size - offset is operating on two unsigned
integers and the result is unsigned and hence the less than zero
comparison will always to be false. Fix this by casting fw->size
from a size_t to a ssize_t to ensure the result can be signed to
allow a less than zero result.

Addresses-Coverity: ("Unsigned compared against 0")
Fixes: 3d5928a168a9 ("drm/i915/xelpd: Pipe A DMC plugging")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/gpu/drm/i915/display/intel_dmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
index f8789d4543bf..dde1f243d375 100644
--- a/drivers/gpu/drm/i915/display/intel_dmc.c
+++ b/drivers/gpu/drm/i915/display/intel_dmc.c
@@ -645,7 +645,7 @@ static void parse_dmc_fw(struct drm_i915_private *dev_priv,
 			continue;
 
 		offset = readcount + dmc->dmc_info[id].dmc_offset * 4;
-		if (fw->size - offset < 0) {
+		if ((ssize_t)fw->size - offset < 0) {
 			drm_err(&dev_priv->drm, "Reading beyond the fw_size\n");
 			continue;
 		}
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-07-20 18:59 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-20 15:57 [PATCH][next] drm/i915/xelpd: Fix unsigned compared to less than zero error Colin King
2021-07-20 15:57 ` [Intel-gfx] " Colin King
2021-07-20 16:55 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
2021-07-20 17:19 ` [PATCH][next] " Lucas De Marchi
2021-07-20 17:19   ` [Intel-gfx] " Lucas De Marchi
2021-07-20 17:19   ` Lucas De Marchi
2021-07-20 17:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-07-20 18:59 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.