* [PATCH v4 00/12] Add Vangogh ACP ASoC driver
@ 2021-07-20 16:30 Vijendar Mukunda
0 siblings, 0 replies; 3+ messages in thread
From: Vijendar Mukunda @ 2021-07-20 16:30 UTC (permalink / raw)
To: broonie, alsa-devel
Cc: Alexander.Deucher, Sunil-kumar.Dommati, krisman, Vijendar Mukunda
This adds an ASoC driver for the ACP (Audio CoProcessor)
block on AMD Vangogh APU.
Changes since v3:
- Fixed typo errors
- Fixed platform devices unregister logic
- Updated acp resources count with macro value
- updated ACP5x_I2S_MODE macro value to avoid
unregistering platform devices for other ACP
audio configurations in driver remove callback
- Fixed error handling
- Fixed indentation issues in irq handler
- Add __maybe_unused for PM functions
Changes since v2:
- remove extra stuff from Make file
Changes since v1:
- add comment for acp_readl() & acp_writel() API's in
common header file.
- add amd: tag in commit message
- modify condition check in acp5x_power_on()
- removed acp_power_gating flag related code
- drop acp5x_audio_remove() API
- use single flag for handling irq status
- fixed indetation issue and used dev_err instead of pr_err
- drop acp5x_dai_remove() API
- use SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK
- use PM related Macros in ACP PCI driver
- use PM related Macros in ACP DMA driver
- remove extra line in Make file
Vijendar Mukunda (12):
ASoC: amd: add Vangogh ACP5x IP register header
ASoC: amd: add Vangogh ACP PCI driver
ASoc: amd: add acp5x init/de-init functions
ASoC: amd: create acp5x platform devices
ASoC: amd: add ACP5x PCM platform driver
ASoC: amd: irq handler changes for ACP5x PCM dma driver
ASoC: amd: add ACP5x pcm dma driver ops
ASoC: amd: add vangogh i2s controller driver
ASoC: amd: add vangogh i2s dai driver ops
ASoC: amd: add vangogh pci driver pm ops
ASoC: amd: add vangogh i2s dma driver pm ops
ASoC: amd: enable vangogh acp5x driver build
sound/soc/amd/Kconfig | 9 +
sound/soc/amd/Makefile | 1 +
sound/soc/amd/vangogh/Makefile | 9 +
sound/soc/amd/vangogh/acp5x-i2s.c | 427 ++++++++++++++++
sound/soc/amd/vangogh/acp5x-pcm-dma.c | 524 ++++++++++++++++++++
sound/soc/amd/vangogh/acp5x.h | 193 +++++++
sound/soc/amd/vangogh/pci-acp5x.c | 326 ++++++++++++
sound/soc/amd/vangogh/vg_chip_offset_byte.h | 337 +++++++++++++
8 files changed, 1826 insertions(+)
create mode 100644 sound/soc/amd/vangogh/Makefile
create mode 100644 sound/soc/amd/vangogh/acp5x-i2s.c
create mode 100644 sound/soc/amd/vangogh/acp5x-pcm-dma.c
create mode 100644 sound/soc/amd/vangogh/acp5x.h
create mode 100644 sound/soc/amd/vangogh/pci-acp5x.c
create mode 100644 sound/soc/amd/vangogh/vg_chip_offset_byte.h
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v4 00/12] Add Vangogh ACP ASoC driver
2021-07-20 16:37 Vijendar Mukunda
@ 2021-07-20 18:38 ` Pierre-Louis Bossart
0 siblings, 0 replies; 3+ messages in thread
From: Pierre-Louis Bossart @ 2021-07-20 18:38 UTC (permalink / raw)
To: Vijendar Mukunda, broonie, alsa-devel
Cc: Alexander.Deucher, Sunil-kumar.Dommati, krisman
On 7/20/21 11:37 AM, Vijendar Mukunda wrote:
> This adds an ASoC driver for the ACP (Audio CoProcessor)
> block on AMD Vangogh APU.
Thanks for the update. I added a couple of minor comments on the v4, this looks mostly good now so feel free to add my tag in the following version
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v4 00/12] Add Vangogh ACP ASoC driver
@ 2021-07-20 16:37 Vijendar Mukunda
2021-07-20 18:38 ` Pierre-Louis Bossart
0 siblings, 1 reply; 3+ messages in thread
From: Vijendar Mukunda @ 2021-07-20 16:37 UTC (permalink / raw)
To: broonie, alsa-devel
Cc: Alexander.Deucher, Sunil-kumar.Dommati, krisman, Vijendar Mukunda
This adds an ASoC driver for the ACP (Audio CoProcessor)
block on AMD Vangogh APU.
Changes since v3:
- Fixed typo errors
- Fixed platform devices unregister logic
- Updated acp resources count with macro value
- updated ACP5x_I2S_MODE macro value to avoid
unregistering platform devices for other ACP
audio configurations in driver remove callback
- Fixed error handling
- Fixed indentation issues in irq handler
- Add __maybe_unused for PM functions
Changes since v2:
- remove extra stuff from Make file
Changes since v1:
- add comment for acp_readl() & acp_writel() API's in
common header file.
- add amd: tag in commit message
- modify condition check in acp5x_power_on()
- removed acp_power_gating flag related code
- drop acp5x_audio_remove() API
- use single flag for handling irq status
- fixed indetation issue and used dev_err instead of pr_err
- drop acp5x_dai_remove() API
- use SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK
- use PM related Macros in ACP PCI driver
- use PM related Macros in ACP DMA driver
- remove extra line in Make file
Vijendar Mukunda (12):
ASoC: amd: add Vangogh ACP5x IP register header
ASoC: amd: add Vangogh ACP PCI driver
ASoc: amd: add acp5x init/de-init functions
ASoC: amd: create acp5x platform devices
ASoC: amd: add ACP5x PCM platform driver
ASoC: amd: irq handler changes for ACP5x PCM dma driver
ASoC: amd: add ACP5x pcm dma driver ops
ASoC: amd: add vangogh i2s controller driver
ASoC: amd: add vangogh i2s dai driver ops
ASoC: amd: add vangogh pci driver pm ops
ASoC: amd: add vangogh i2s dma driver pm ops
ASoC: amd: enable vangogh acp5x driver build
sound/soc/amd/Kconfig | 9 +
sound/soc/amd/Makefile | 1 +
sound/soc/amd/vangogh/Makefile | 9 +
sound/soc/amd/vangogh/acp5x-i2s.c | 427 ++++++++++++++++
sound/soc/amd/vangogh/acp5x-pcm-dma.c | 524 ++++++++++++++++++++
sound/soc/amd/vangogh/acp5x.h | 193 +++++++
sound/soc/amd/vangogh/pci-acp5x.c | 326 ++++++++++++
sound/soc/amd/vangogh/vg_chip_offset_byte.h | 337 +++++++++++++
8 files changed, 1826 insertions(+)
create mode 100644 sound/soc/amd/vangogh/Makefile
create mode 100644 sound/soc/amd/vangogh/acp5x-i2s.c
create mode 100644 sound/soc/amd/vangogh/acp5x-pcm-dma.c
create mode 100644 sound/soc/amd/vangogh/acp5x.h
create mode 100644 sound/soc/amd/vangogh/pci-acp5x.c
create mode 100644 sound/soc/amd/vangogh/vg_chip_offset_byte.h
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-20 18:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-20 16:30 [PATCH v4 00/12] Add Vangogh ACP ASoC driver Vijendar Mukunda
2021-07-20 16:37 Vijendar Mukunda
2021-07-20 18:38 ` Pierre-Louis Bossart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.