From: Lucas De Marchi <lucas.demarchi@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Tomas Winkler <tomas.winkler@intel.com>,
John Harrison <John.C.Harrison@Intel.com>,
dri-devel@lists.freedesktop.org,
Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: [PATCH 0/4] Nuke legacy hw_id
Date: Tue, 20 Jul 2021 16:20:10 -0700 [thread overview]
Message-ID: <20210720232014.3302645-1-lucas.demarchi@intel.com> (raw)
Motivated by my review in
https://patchwork.freedesktop.org/patch/443857/?series=92135&rev=5 I
went to look why we needed the additional hw_id fields. It turns out we
don't, but we kept adding new IDs to keep it consistent. Now that with
the extra media engines we would just leave than zero'ed, let's refactor
the code so we don't keep them around: they aren't used since
GRAPHICS_VER == 8.
I'd say last patch is a stretch due to the use of _PICK() and hardcoding
the map, but to me it seems to avoid making it more complex elsewhere.
Lucas De Marchi (4):
drm/i915/gt: fix platform prefix
drm/i915/gt: nuke unused legacy engine hw_id
drm/i915/gt: rename legacy engine->hw_id to engine->gen6_hw_id
drm/i915/gt: nuke gen6_hw_id
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 10 ----------
drivers/gpu/drm/i915/gt/intel_engine_types.h | 12 ------------
drivers/gpu/drm/i915/gt/intel_gt.c | 4 ++--
drivers/gpu/drm/i915/i915_reg.h | 4 +++-
4 files changed, 5 insertions(+), 25 deletions(-)
--
2.31.1
WARNING: multiple messages have this Message-ID (diff)
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Tomas Winkler <tomas.winkler@intel.com>, dri-devel@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 0/4] Nuke legacy hw_id
Date: Tue, 20 Jul 2021 16:20:10 -0700 [thread overview]
Message-ID: <20210720232014.3302645-1-lucas.demarchi@intel.com> (raw)
Motivated by my review in
https://patchwork.freedesktop.org/patch/443857/?series=92135&rev=5 I
went to look why we needed the additional hw_id fields. It turns out we
don't, but we kept adding new IDs to keep it consistent. Now that with
the extra media engines we would just leave than zero'ed, let's refactor
the code so we don't keep them around: they aren't used since
GRAPHICS_VER == 8.
I'd say last patch is a stretch due to the use of _PICK() and hardcoding
the map, but to me it seems to avoid making it more complex elsewhere.
Lucas De Marchi (4):
drm/i915/gt: fix platform prefix
drm/i915/gt: nuke unused legacy engine hw_id
drm/i915/gt: rename legacy engine->hw_id to engine->gen6_hw_id
drm/i915/gt: nuke gen6_hw_id
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 10 ----------
drivers/gpu/drm/i915/gt/intel_engine_types.h | 12 ------------
drivers/gpu/drm/i915/gt/intel_gt.c | 4 ++--
drivers/gpu/drm/i915/i915_reg.h | 4 +++-
4 files changed, 5 insertions(+), 25 deletions(-)
--
2.31.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2021-07-20 23:24 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 23:20 Lucas De Marchi [this message]
2021-07-20 23:20 ` [Intel-gfx] [PATCH 0/4] Nuke legacy hw_id Lucas De Marchi
2021-07-20 23:20 ` [PATCH 1/4] drm/i915/gt: fix platform prefix Lucas De Marchi
2021-07-20 23:20 ` [Intel-gfx] " Lucas De Marchi
2021-07-21 9:11 ` Tvrtko Ursulin
2021-07-21 9:11 ` Tvrtko Ursulin
2021-07-21 22:34 ` Matt Roper
2021-07-21 22:34 ` [Intel-gfx] " Matt Roper
2021-07-20 23:20 ` [PATCH 2/4] drm/i915/gt: nuke unused legacy engine hw_id Lucas De Marchi
2021-07-20 23:20 ` [Intel-gfx] " Lucas De Marchi
2021-07-21 9:18 ` Tvrtko Ursulin
2021-07-21 9:18 ` Tvrtko Ursulin
2021-07-21 22:47 ` Matt Roper
2021-07-21 22:47 ` [Intel-gfx] " Matt Roper
2021-07-21 23:17 ` Lucas De Marchi
2021-07-21 23:17 ` [Intel-gfx] " Lucas De Marchi
2021-07-20 23:20 ` [PATCH 3/4] drm/i915/gt: rename legacy engine->hw_id to engine->gen6_hw_id Lucas De Marchi
2021-07-20 23:20 ` [Intel-gfx] " Lucas De Marchi
2021-07-21 9:20 ` Tvrtko Ursulin
2021-07-21 9:20 ` Tvrtko Ursulin
2021-07-21 22:51 ` Matt Roper
2021-07-21 22:51 ` [Intel-gfx] " Matt Roper
2021-07-22 5:11 ` Lucas De Marchi
2021-07-22 5:11 ` Lucas De Marchi
2021-07-20 23:20 ` [PATCH 4/4] drm/i915/gt: nuke gen6_hw_id Lucas De Marchi
2021-07-20 23:20 ` [Intel-gfx] " Lucas De Marchi
2021-07-21 9:25 ` Tvrtko Ursulin
2021-07-21 9:25 ` Tvrtko Ursulin
2021-07-21 18:44 ` Lucas De Marchi
2021-07-21 18:44 ` Lucas De Marchi
2021-07-22 8:27 ` Tvrtko Ursulin
2021-07-22 8:27 ` Tvrtko Ursulin
2021-07-21 23:02 ` Matt Roper
2021-07-21 23:02 ` [Intel-gfx] " Matt Roper
2021-07-21 0:35 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for Nuke legacy hw_id Patchwork
2021-07-21 0:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-07-21 3:46 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210720232014.3302645-1-lucas.demarchi@intel.com \
--to=lucas.demarchi@intel.com \
--cc=John.C.Harrison@Intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tomas.winkler@intel.com \
--cc=tvrtko.ursulin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.