From: Nitesh Narayan Lal <nitesh@redhat.com> To: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-api@vger.kernel.org, linux-pci@vger.kernel.org, tglx@linutronix.de, jesse.brandeburg@intel.com, robin.murphy@arm.com, mtosatti@redhat.com, mingo@kernel.org, jbrandeb@kernel.org, frederic@kernel.org, juri.lelli@redhat.com, abelits@marvell.com, bhelgaas@google.com, rostedt@goodmis.org, peterz@infradead.org, davem@davemloft.net, akpm@linux-foundation.org, sfr@canb.auug.org.au, stephen@networkplumber.org, rppt@linux.vnet.ibm.com, chris.friesen@windriver.com, maz@kernel.org, nhorman@tuxdriver.com, pjwaskiewicz@gmail.com, sassmann@redhat.com, thenzl@redhat.com, kashyap.desai@broadcom.com, sumit.saxena@broadcom.com, shivasharan.srikanteshwara@broadcom.com, sathya.prakash@broadcom.com, sreekanth.reddy@broadcom.com, suganath-prabu.subramani@broadcom.com, james.smart@broadcom.com, dick.kennedy@broadcom.com, jkc@redhat.com, faisal.latif@intel.com, shiraz.saleem@intel.com, tariqt@nvidia.com, ahleihel@redhat.com, kheib@redhat.com, borisp@nvidia.com, saeedm@nvidia.com, benve@cisco.com, govind@gmx.com, jassisinghbrar@gmail.com, ajit.khaparde@broadcom.com, sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com, nilal@redhat.com, tatyana.e.nikolova@intel.com, mustafa.ismail@intel.com, ahs3@redhat.com, leonro@nvidia.com, chandrakanth.patil@broadcom.com, bjorn.andersson@linaro.org, chunkuang.hu@kernel.org, yongqiang.niu@mediatek.com, baolin.wang7@gmail.com, poros@redhat.com, minlei@redhat.com, emilne@redhat.com, jejb@linux.ibm.com, martin.petersen@oracle.com, _govind@gmx.com, kabel@kernel.org, viresh.kumar@linaro.org, Tushar.Khandelwal@arm.com, kuba@kernel.org Subject: [PATCH v5 07/14] enic: Use irq_update_affinity_hint Date: Tue, 20 Jul 2021 19:26:17 -0400 [thread overview] Message-ID: <20210720232624.1493424-8-nitesh@redhat.com> (raw) In-Reply-To: <20210720232624.1493424-1-nitesh@redhat.com> The driver uses irq_set_affinity_hint() to update the affinity_hint mask that is consumed by the userspace to distribute the interrupts. However, under the hood irq_set_affinity_hint() also applies the provided cpumask (if not NULL) as the affinity for the given interrupt which is an undocumented side effect. To remove this side effect irq_set_affinity_hint() has been marked as deprecated and new interfaces have been introduced. Hence, replace the irq_set_affinity_hint() with the new interface irq_update_affinity_hint() that only updates the affinity_hint pointer. Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com> --- drivers/net/ethernet/cisco/enic/enic_main.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c index d0a8f7106958..97eb5bd62855 100644 --- a/drivers/net/ethernet/cisco/enic/enic_main.c +++ b/drivers/net/ethernet/cisco/enic/enic_main.c @@ -150,10 +150,10 @@ static void enic_set_affinity_hint(struct enic *enic) !cpumask_available(enic->msix[i].affinity_mask) || cpumask_empty(enic->msix[i].affinity_mask)) continue; - err = irq_set_affinity_hint(enic->msix_entry[i].vector, - enic->msix[i].affinity_mask); + err = irq_update_affinity_hint(enic->msix_entry[i].vector, + enic->msix[i].affinity_mask); if (err) - netdev_warn(enic->netdev, "irq_set_affinity_hint failed, err %d\n", + netdev_warn(enic->netdev, "irq_update_affinity_hint failed, err %d\n", err); } @@ -173,7 +173,7 @@ static void enic_unset_affinity_hint(struct enic *enic) int i; for (i = 0; i < enic->intr_count; i++) - irq_set_affinity_hint(enic->msix_entry[i].vector, NULL); + irq_update_affinity_hint(enic->msix_entry[i].vector, NULL); } static int enic_udp_tunnel_set_port(struct net_device *netdev, -- 2.27.0
WARNING: multiple messages have this Message-ID (diff)
From: Nitesh Narayan Lal <nitesh@redhat.com> To: intel-wired-lan@osuosl.org Subject: [Intel-wired-lan] [PATCH v5 07/14] enic: Use irq_update_affinity_hint Date: Tue, 20 Jul 2021 19:26:17 -0400 [thread overview] Message-ID: <20210720232624.1493424-8-nitesh@redhat.com> (raw) In-Reply-To: <20210720232624.1493424-1-nitesh@redhat.com> The driver uses irq_set_affinity_hint() to update the affinity_hint mask that is consumed by the userspace to distribute the interrupts. However, under the hood irq_set_affinity_hint() also applies the provided cpumask (if not NULL) as the affinity for the given interrupt which is an undocumented side effect. To remove this side effect irq_set_affinity_hint() has been marked as deprecated and new interfaces have been introduced. Hence, replace the irq_set_affinity_hint() with the new interface irq_update_affinity_hint() that only updates the affinity_hint pointer. Signed-off-by: Nitesh Narayan Lal <nitesh@redhat.com> --- drivers/net/ethernet/cisco/enic/enic_main.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c index d0a8f7106958..97eb5bd62855 100644 --- a/drivers/net/ethernet/cisco/enic/enic_main.c +++ b/drivers/net/ethernet/cisco/enic/enic_main.c @@ -150,10 +150,10 @@ static void enic_set_affinity_hint(struct enic *enic) !cpumask_available(enic->msix[i].affinity_mask) || cpumask_empty(enic->msix[i].affinity_mask)) continue; - err = irq_set_affinity_hint(enic->msix_entry[i].vector, - enic->msix[i].affinity_mask); + err = irq_update_affinity_hint(enic->msix_entry[i].vector, + enic->msix[i].affinity_mask); if (err) - netdev_warn(enic->netdev, "irq_set_affinity_hint failed, err %d\n", + netdev_warn(enic->netdev, "irq_update_affinity_hint failed, err %d\n", err); } @@ -173,7 +173,7 @@ static void enic_unset_affinity_hint(struct enic *enic) int i; for (i = 0; i < enic->intr_count; i++) - irq_set_affinity_hint(enic->msix_entry[i].vector, NULL); + irq_update_affinity_hint(enic->msix_entry[i].vector, NULL); } static int enic_udp_tunnel_set_port(struct net_device *netdev, -- 2.27.0
next prev parent reply other threads:[~2021-07-20 23:38 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-20 23:26 [PATCH v5 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint() Nitesh Narayan Lal 2021-07-20 23:26 ` [Intel-wired-lan] " Nitesh Narayan Lal 2021-07-20 23:26 ` [PATCH v5 01/14] genirq: Provide new interfaces for affinity hints Nitesh Narayan Lal 2021-07-20 23:26 ` [Intel-wired-lan] " Nitesh Narayan Lal 2021-08-06 15:51 ` Ming Lei 2021-08-06 15:51 ` [Intel-wired-lan] " Ming Lei 2021-07-20 23:26 ` [PATCH v5 02/14] iavf: Use irq_update_affinity_hint Nitesh Narayan Lal 2021-07-20 23:26 ` [Intel-wired-lan] " Nitesh Narayan Lal 2021-07-20 23:26 ` [PATCH v5 03/14] i40e: " Nitesh Narayan Lal 2021-07-20 23:26 ` [Intel-wired-lan] " Nitesh Narayan Lal 2021-07-20 23:26 ` [PATCH v5 04/14] scsi: megaraid_sas: Use irq_set_affinity_and_hint Nitesh Narayan Lal 2021-07-20 23:26 ` [Intel-wired-lan] " Nitesh Narayan Lal 2021-08-06 11:31 ` Sumit Saxena 2021-08-06 11:31 ` [Intel-wired-lan] " Sumit Saxena 2021-07-20 23:26 ` [PATCH v5 05/14] scsi: mpt3sas: " Nitesh Narayan Lal 2021-07-20 23:26 ` [Intel-wired-lan] " Nitesh Narayan Lal 2021-08-06 8:54 ` Sreekanth Reddy 2021-08-06 8:54 ` [Intel-wired-lan] " Sreekanth Reddy 2021-07-20 23:26 ` [PATCH v5 06/14] RDMA/irdma: Use irq_update_affinity_hint Nitesh Narayan Lal 2021-07-20 23:26 ` [Intel-wired-lan] " Nitesh Narayan Lal 2021-07-22 18:25 ` Nikolova, Tatyana E 2021-07-22 18:25 ` [Intel-wired-lan] " Nikolova, Tatyana E 2021-07-20 23:26 ` Nitesh Narayan Lal [this message] 2021-07-20 23:26 ` [Intel-wired-lan] [PATCH v5 07/14] enic: " Nitesh Narayan Lal 2021-08-16 17:53 ` Christian Benvenuti (benve) 2021-08-16 17:53 ` [Intel-wired-lan] " Christian Benvenuti 2021-07-20 23:26 ` [PATCH v5 08/14] be2net: " Nitesh Narayan Lal 2021-07-20 23:26 ` [Intel-wired-lan] " Nitesh Narayan Lal 2021-07-20 23:26 ` [PATCH v5 09/14] ixgbe: " Nitesh Narayan Lal 2021-07-20 23:26 ` [Intel-wired-lan] " Nitesh Narayan Lal 2021-07-20 23:26 ` [PATCH v5 10/14] mailbox: " Nitesh Narayan Lal 2021-07-20 23:26 ` [Intel-wired-lan] " Nitesh Narayan Lal 2021-08-16 18:11 ` Jassi Brar 2021-08-16 18:11 ` [Intel-wired-lan] " Jassi Brar 2021-07-20 23:26 ` [PATCH v5 11/14] scsi: lpfc: Use irq_set_affinity Nitesh Narayan Lal 2021-07-20 23:26 ` [Intel-wired-lan] " Nitesh Narayan Lal 2021-07-23 17:15 ` James Smart 2021-07-23 17:15 ` [Intel-wired-lan] " James Smart 2021-07-20 23:26 ` [PATCH v5 12/14] hinic: Use irq_set_affinity_and_hint Nitesh Narayan Lal 2021-07-20 23:26 ` [Intel-wired-lan] " Nitesh Narayan Lal 2021-07-20 23:26 ` [PATCH v5 13/14] net/mlx5: " Nitesh Narayan Lal 2021-07-20 23:26 ` [Intel-wired-lan] " Nitesh Narayan Lal 2021-07-20 23:26 ` [PATCH v5 14/14] net/mlx4: Use irq_update_affinity_hint Nitesh Narayan Lal 2021-07-20 23:26 ` [Intel-wired-lan] " Nitesh Narayan Lal 2021-08-02 15:26 ` [PATCH v5 00/14] genirq: Cleanup the abuse of irq_set_affinity_hint() Nitesh Lal 2021-08-06 3:04 ` Martin K. Petersen 2021-08-06 14:56 ` Nitesh Lal 2021-08-16 15:50 ` Nitesh Lal 2021-08-30 15:38 ` Nitesh Lal 2021-08-30 15:40 ` Nitesh Lal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210720232624.1493424-8-nitesh@redhat.com \ --to=nitesh@redhat.com \ --cc=Tushar.Khandelwal@arm.com \ --cc=_govind@gmx.com \ --cc=abelits@marvell.com \ --cc=ahleihel@redhat.com \ --cc=ahs3@redhat.com \ --cc=ajit.khaparde@broadcom.com \ --cc=akpm@linux-foundation.org \ --cc=baolin.wang7@gmail.com \ --cc=benve@cisco.com \ --cc=bhelgaas@google.com \ --cc=bjorn.andersson@linaro.org \ --cc=borisp@nvidia.com \ --cc=chandrakanth.patil@broadcom.com \ --cc=chris.friesen@windriver.com \ --cc=chunkuang.hu@kernel.org \ --cc=davem@davemloft.net \ --cc=dick.kennedy@broadcom.com \ --cc=emilne@redhat.com \ --cc=faisal.latif@intel.com \ --cc=frederic@kernel.org \ --cc=govind@gmx.com \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=james.smart@broadcom.com \ --cc=jassisinghbrar@gmail.com \ --cc=jbrandeb@kernel.org \ --cc=jejb@linux.ibm.com \ --cc=jesse.brandeburg@intel.com \ --cc=jkc@redhat.com \ --cc=juri.lelli@redhat.com \ --cc=kabel@kernel.org \ --cc=kashyap.desai@broadcom.com \ --cc=kheib@redhat.com \ --cc=kuba@kernel.org \ --cc=leonro@nvidia.com \ --cc=linux-api@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=maz@kernel.org \ --cc=mingo@kernel.org \ --cc=minlei@redhat.com \ --cc=mtosatti@redhat.com \ --cc=mustafa.ismail@intel.com \ --cc=netdev@vger.kernel.org \ --cc=nhorman@tuxdriver.com \ --cc=nilal@redhat.com \ --cc=peterz@infradead.org \ --cc=pjwaskiewicz@gmail.com \ --cc=poros@redhat.com \ --cc=robin.murphy@arm.com \ --cc=rostedt@goodmis.org \ --cc=rppt@linux.vnet.ibm.com \ --cc=saeedm@nvidia.com \ --cc=sassmann@redhat.com \ --cc=sathya.prakash@broadcom.com \ --cc=sfr@canb.auug.org.au \ --cc=shiraz.saleem@intel.com \ --cc=shivasharan.srikanteshwara@broadcom.com \ --cc=somnath.kotur@broadcom.com \ --cc=sreekanth.reddy@broadcom.com \ --cc=sriharsha.basavapatna@broadcom.com \ --cc=stephen@networkplumber.org \ --cc=suganath-prabu.subramani@broadcom.com \ --cc=sumit.saxena@broadcom.com \ --cc=tariqt@nvidia.com \ --cc=tatyana.e.nikolova@intel.com \ --cc=tglx@linutronix.de \ --cc=thenzl@redhat.com \ --cc=viresh.kumar@linaro.org \ --cc=yongqiang.niu@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.