* [PATCH] video: fbdev: arcfb: remove redundant initialization of variable err
@ 2021-07-21 10:26 Colin King
2021-07-21 11:11 ` Sam Ravnborg
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2021-07-21 10:26 UTC (permalink / raw)
To: dri-devel, linux-fbdev; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable err is being initialized with a value that is never
read, the assignment is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/video/fbdev/arcfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/arcfb.c b/drivers/video/fbdev/arcfb.c
index 1447324ed0b6..45e64016db32 100644
--- a/drivers/video/fbdev/arcfb.c
+++ b/drivers/video/fbdev/arcfb.c
@@ -446,7 +446,7 @@ static ssize_t arcfb_write(struct fb_info *info, const char __user *buf,
/* modded from epson 1355 */
unsigned long p;
- int err=-EINVAL;
+ int err;
unsigned int fbmemlength,x,y,w,h, bitppos, startpos, endpos, bitcount;
struct arcfb_par *par;
unsigned int xres;
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video: fbdev: arcfb: remove redundant initialization of variable err
2021-07-21 10:26 [PATCH] video: fbdev: arcfb: remove redundant initialization of variable err Colin King
@ 2021-07-21 11:11 ` Sam Ravnborg
0 siblings, 0 replies; 2+ messages in thread
From: Sam Ravnborg @ 2021-07-21 11:11 UTC (permalink / raw)
To: Colin King; +Cc: linux-fbdev, kernel-janitors, linux-kernel, dri-devel
Hi Colin,
On Wed, Jul 21, 2021 at 11:26:08AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable err is being initialized with a value that is never
> read, the assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/video/fbdev/arcfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/arcfb.c b/drivers/video/fbdev/arcfb.c
> index 1447324ed0b6..45e64016db32 100644
> --- a/drivers/video/fbdev/arcfb.c
> +++ b/drivers/video/fbdev/arcfb.c
> @@ -446,7 +446,7 @@ static ssize_t arcfb_write(struct fb_info *info, const char __user *buf,
> /* modded from epson 1355 */
>
> unsigned long p;
> - int err=-EINVAL;
> + int err;
> unsigned int fbmemlength,x,y,w,h, bitppos, startpos, endpos, bitcount;
> struct arcfb_par *par;
> unsigned int xres;
thnaks, applied to drm-misc-next.
It will show up in -next within a week.
Sam
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-21 11:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-21 10:26 [PATCH] video: fbdev: arcfb: remove redundant initialization of variable err Colin King
2021-07-21 11:11 ` Sam Ravnborg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.