* [PATCH] phy: tegra: xusb: mark PM functions as __maybe_unused
@ 2021-07-21 15:25 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2021-07-21 15:25 UTC (permalink / raw)
To: JC Kuo, Kishon Vijay Abraham I, Vinod Koul, Thierry Reding,
Jonathan Hunter
Cc: Arnd Bergmann, Rikard Falkeborn, Marc Zyngier, Chunfeng Yun,
linux-phy, linux-tegra, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
When these are not referenced, gcc prints a harmless warning:
drivers/phy/tegra/xusb.c:1286:12: error: 'tegra_xusb_padctl_resume_noirq' defined but not used [-Werror=unused-function]
1286 | static int tegra_xusb_padctl_resume_noirq(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/phy/tegra/xusb.c:1276:12: error: 'tegra_xusb_padctl_suspend_noirq' defined but not used [-Werror=unused-function]
1276 | static int tegra_xusb_padctl_suspend_noirq(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Fixes: c545a9056712 ("phy: tegra: xusb: Add sleepwalk and suspend/resume")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/phy/tegra/xusb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
index 0aadac678191..963de5913e50 100644
--- a/drivers/phy/tegra/xusb.c
+++ b/drivers/phy/tegra/xusb.c
@@ -1273,7 +1273,7 @@ static int tegra_xusb_padctl_remove(struct platform_device *pdev)
return err;
}
-static int tegra_xusb_padctl_suspend_noirq(struct device *dev)
+static __maybe_unused int tegra_xusb_padctl_suspend_noirq(struct device *dev)
{
struct tegra_xusb_padctl *padctl = dev_get_drvdata(dev);
@@ -1283,7 +1283,7 @@ static int tegra_xusb_padctl_suspend_noirq(struct device *dev)
return 0;
}
-static int tegra_xusb_padctl_resume_noirq(struct device *dev)
+static __maybe_unused int tegra_xusb_padctl_resume_noirq(struct device *dev)
{
struct tegra_xusb_padctl *padctl = dev_get_drvdata(dev);
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] phy: tegra: xusb: mark PM functions as __maybe_unused
@ 2021-07-21 15:25 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2021-07-21 15:25 UTC (permalink / raw)
To: JC Kuo, Kishon Vijay Abraham I, Vinod Koul, Thierry Reding,
Jonathan Hunter
Cc: Arnd Bergmann, Rikard Falkeborn, Marc Zyngier, Chunfeng Yun,
linux-phy, linux-tegra, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
When these are not referenced, gcc prints a harmless warning:
drivers/phy/tegra/xusb.c:1286:12: error: 'tegra_xusb_padctl_resume_noirq' defined but not used [-Werror=unused-function]
1286 | static int tegra_xusb_padctl_resume_noirq(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/phy/tegra/xusb.c:1276:12: error: 'tegra_xusb_padctl_suspend_noirq' defined but not used [-Werror=unused-function]
1276 | static int tegra_xusb_padctl_suspend_noirq(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Fixes: c545a9056712 ("phy: tegra: xusb: Add sleepwalk and suspend/resume")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/phy/tegra/xusb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
index 0aadac678191..963de5913e50 100644
--- a/drivers/phy/tegra/xusb.c
+++ b/drivers/phy/tegra/xusb.c
@@ -1273,7 +1273,7 @@ static int tegra_xusb_padctl_remove(struct platform_device *pdev)
return err;
}
-static int tegra_xusb_padctl_suspend_noirq(struct device *dev)
+static __maybe_unused int tegra_xusb_padctl_suspend_noirq(struct device *dev)
{
struct tegra_xusb_padctl *padctl = dev_get_drvdata(dev);
@@ -1283,7 +1283,7 @@ static int tegra_xusb_padctl_suspend_noirq(struct device *dev)
return 0;
}
-static int tegra_xusb_padctl_resume_noirq(struct device *dev)
+static __maybe_unused int tegra_xusb_padctl_resume_noirq(struct device *dev)
{
struct tegra_xusb_padctl *padctl = dev_get_drvdata(dev);
--
2.29.2
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] phy: tegra: xusb: mark PM functions as __maybe_unused
2021-07-21 15:25 ` Arnd Bergmann
@ 2021-07-22 9:11 ` Vinod Koul
-1 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2021-07-22 9:11 UTC (permalink / raw)
To: Arnd Bergmann
Cc: JC Kuo, Kishon Vijay Abraham I, Thierry Reding, Jonathan Hunter,
Arnd Bergmann, Rikard Falkeborn, Marc Zyngier, Chunfeng Yun,
linux-phy, linux-tegra, linux-kernel
On 21-07-21, 17:25, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When these are not referenced, gcc prints a harmless warning:
>
> drivers/phy/tegra/xusb.c:1286:12: error: 'tegra_xusb_padctl_resume_noirq' defined but not used [-Werror=unused-function]
> 1286 | static int tegra_xusb_padctl_resume_noirq(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/phy/tegra/xusb.c:1276:12: error: 'tegra_xusb_padctl_suspend_noirq' defined but not used [-Werror=unused-function]
> 1276 | static int tegra_xusb_padctl_suspend_noirq(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] phy: tegra: xusb: mark PM functions as __maybe_unused
@ 2021-07-22 9:11 ` Vinod Koul
0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2021-07-22 9:11 UTC (permalink / raw)
To: Arnd Bergmann
Cc: JC Kuo, Kishon Vijay Abraham I, Thierry Reding, Jonathan Hunter,
Arnd Bergmann, Rikard Falkeborn, Marc Zyngier, Chunfeng Yun,
linux-phy, linux-tegra, linux-kernel
On 21-07-21, 17:25, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When these are not referenced, gcc prints a harmless warning:
>
> drivers/phy/tegra/xusb.c:1286:12: error: 'tegra_xusb_padctl_resume_noirq' defined but not used [-Werror=unused-function]
> 1286 | static int tegra_xusb_padctl_resume_noirq(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/phy/tegra/xusb.c:1276:12: error: 'tegra_xusb_padctl_suspend_noirq' defined but not used [-Werror=unused-function]
> 1276 | static int tegra_xusb_padctl_suspend_noirq(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
Applied, thanks
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-22 9:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-21 15:25 [PATCH] phy: tegra: xusb: mark PM functions as __maybe_unused Arnd Bergmann
2021-07-21 15:25 ` Arnd Bergmann
2021-07-22 9:11 ` Vinod Koul
2021-07-22 9:11 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.