* [PATCH] bluez:fix btmon tools “Allow slave” to "Master Or Slave" #431 [hci0] 99.922927
@ 2021-07-22 2:19 wangyouwan
2021-07-22 3:02 ` bluez.test.bot
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: wangyouwan @ 2021-07-22 2:19 UTC (permalink / raw)
To: linux-bluetooth; +Cc: wangyouwan
I want to explain it as “Master Or Slave”, because this is explained in the Core_v5.2
8.6.5 Role switch
There are several occasions when a role switch is used:
• A role switch is necessary in order to make a paging device a slave when
joining an existing piconet, since by definition the paging device is initially
master of a piconet involving the pager (master) and the paged (slave)
device.
• A role switch is necessary in order for a slave in an existing piconet to set up
a new piconet with itself as master and the original piconet master as slave.
If the original piconet had more than one slave, then this implies a double
role for the original piconet master; it becomes a slave
Signed-off-by: wangyouwan <wangyouwan@uniontech.com>
---
monitor/packet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/monitor/packet.c b/monitor/packet.c
index 52d22ab21..b73615509 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -4143,7 +4143,7 @@ static void create_conn_cmd(const void *data, uint8_t size)
str = "Stay master";
break;
case 0x01:
- str = "Allow slave";
+ str = "Master Or Slave";
break;
default:
str = "Reserved";
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: bluez:fix btmon tools “Allow slave” to "Master Or Slave" #431 [hci0] 99.922927
2021-07-22 2:19 [PATCH] bluez:fix btmon tools “Allow slave” to "Master Or Slave" #431 [hci0] 99.922927 wangyouwan
@ 2021-07-22 3:02 ` bluez.test.bot
2021-07-22 7:07 ` [PATCH] " Barry Byford
2021-07-22 14:47 ` Marcel Holtmann
2 siblings, 0 replies; 4+ messages in thread
From: bluez.test.bot @ 2021-07-22 3:02 UTC (permalink / raw)
To: linux-bluetooth, wangyouwan
[-- Attachment #1: Type: text/plain, Size: 3569 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=519397
---Test result---
Test Summary:
CheckPatch FAIL 0.26 seconds
GitLint FAIL 0.11 seconds
Prep - Setup ELL PASS 40.07 seconds
Build - Prep PASS 0.09 seconds
Build - Configure PASS 6.91 seconds
Build - Make PASS 173.73 seconds
Make Check PASS 8.95 seconds
Make Distcheck PASS 205.55 seconds
Build w/ext ELL - Configure PASS 7.04 seconds
Build w/ext ELL - Make PASS 163.65 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
bluez:fix btmon tools “Allow slave” to "Master Or Slave" #431 [hci0] 99.922927
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#11:
I want to explain it as “Master Or Slave”, because this is explained in the Core_v5.2
- total: 0 errors, 1 warnings, 8 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
"[PATCH] =?UTF-8?q?bluez:fix=20btmon=20tools=20=E2=80=9CAllow=20sl?=" has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: GitLint - FAIL
Desc: Run gitlint with rule in .gitlint
Output:
bluez:fix btmon tools “Allow slave” to "Master Or Slave" #431 [hci0] 99.922927
1: T1 Title exceeds max length (78>72): "bluez:fix btmon tools “Allow slave” to "Master Or Slave" #431 [hci0] 99.922927"
3: B1 Line exceeds max length (85>80): "I want to explain it as “Master Or Slave”, because this is explained in the Core_v5.2"
8: B1 Line exceeds max length (83>80): " joining an existing piconet, since by definition the paging device is initially"
11: B1 Line exceeds max length (86>80): " • A role switch is necessary in order for a slave in an existing piconet to set up"
12: B1 Line exceeds max length (81>80): " a new piconet with itself as master and the original piconet master as slave."
##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL
##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build
##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree
##############################
Test: Build - Make - PASS
Desc: Build the BlueZ source tree
##############################
Test: Make Check - PASS
Desc: Run 'make check'
##############################
Test: Make Distcheck - PASS
Desc: Run distcheck to check the distribution
##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration
##############################
Test: Build w/ext ELL - Make - PASS
Desc: Build BlueZ source with '--enable-external-ell' configuration
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bluez:fix btmon tools “Allow slave” to "Master Or Slave" #431 [hci0] 99.922927
2021-07-22 2:19 [PATCH] bluez:fix btmon tools “Allow slave” to "Master Or Slave" #431 [hci0] 99.922927 wangyouwan
2021-07-22 3:02 ` bluez.test.bot
@ 2021-07-22 7:07 ` Barry Byford
2021-07-22 14:47 ` Marcel Holtmann
2 siblings, 0 replies; 4+ messages in thread
From: Barry Byford @ 2021-07-22 7:07 UTC (permalink / raw)
To: wangyouwan; +Cc: Bluez mailing list
On Thu, 22 Jul 2021 at 03:23, wangyouwan <wangyouwan@uniontech.com> wrote:
>
> I want to explain it as “Master Or Slave”, because this is explained in the Core_v5.2
>
There is now Core V5.3 which has been updated to use inclusive
language as outlined by Archie in his post:
https://marc.info/?l=linux-bluetooth&m=162195325125419&w=2
I think the terms should be Central or Peripheral. Here is the same
extract from the spec in v5.3
8.6.5 Role switch
There are several occasions when a role switch is used:
• A role switch is necessary in order to make a paging device a Peripheral
when joining an existing piconet, since by definition the paging device is
initially Central of a piconet involving the pager (Central) and the paged
(Peripheral) device.
• A role switch is necessary in order for a Peripheral in an existing piconet to
set up a new piconet with itself as Central and the original piconet Central as
Peripheral. If the original piconet had more than one Peripheral, then this
implies a double role for the original piconet Central; it becomes a Peripheral
in the new piconet while still maintaining the original piconet as Central.
> 8.6.5 Role switch
> There are several occasions when a role switch is used:
> • A role switch is necessary in order to make a paging device a slave when
> joining an existing piconet, since by definition the paging device is initially
> master of a piconet involving the pager (master) and the paged (slave)
> device.
> • A role switch is necessary in order for a slave in an existing piconet to set up
> a new piconet with itself as master and the original piconet master as slave.
> If the original piconet had more than one slave, then this implies a double
> role for the original piconet master; it becomes a slave
>
> Signed-off-by: wangyouwan <wangyouwan@uniontech.com>
> ---
> monitor/packet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/monitor/packet.c b/monitor/packet.c
> index 52d22ab21..b73615509 100644
> --- a/monitor/packet.c
> +++ b/monitor/packet.c
> @@ -4143,7 +4143,7 @@ static void create_conn_cmd(const void *data, uint8_t size)
> str = "Stay master";
> break;
> case 0x01:
> - str = "Allow slave";
> + str = "Master Or Slave";
> break;
> default:
> str = "Reserved";
> --
> 2.20.1
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bluez:fix btmon tools “Allow slave” to "Master Or Slave" #431 [hci0] 99.922927
2021-07-22 2:19 [PATCH] bluez:fix btmon tools “Allow slave” to "Master Or Slave" #431 [hci0] 99.922927 wangyouwan
2021-07-22 3:02 ` bluez.test.bot
2021-07-22 7:07 ` [PATCH] " Barry Byford
@ 2021-07-22 14:47 ` Marcel Holtmann
2 siblings, 0 replies; 4+ messages in thread
From: Marcel Holtmann @ 2021-07-22 14:47 UTC (permalink / raw)
To: wangyouwan; +Cc: linux-bluetooth
Hi Wang,
> I want to explain it as “Master Or Slave”, because this is explained in the Core_v5.2
>
> 8.6.5 Role switch
> There are several occasions when a role switch is used:
> • A role switch is necessary in order to make a paging device a slave when
> joining an existing piconet, since by definition the paging device is initially
> master of a piconet involving the pager (master) and the paged (slave)
> device.
> • A role switch is necessary in order for a slave in an existing piconet to set up
> a new piconet with itself as master and the original piconet master as slave.
> If the original piconet had more than one slave, then this implies a double
> role for the original piconet master; it becomes a slave
>
> Signed-off-by: wangyouwan <wangyouwan@uniontech.com>
> ---
> monitor/packet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/monitor/packet.c b/monitor/packet.c
> index 52d22ab21..b73615509 100644
> --- a/monitor/packet.c
> +++ b/monitor/packet.c
> @@ -4143,7 +4143,7 @@ static void create_conn_cmd(const void *data, uint8_t size)
> str = "Stay master";
> break;
> case 0x01:
> - str = "Allow slave";
> + str = "Master Or Slave";
> break;
the text was verbatim from Bluetooth 4.x core spec. If that has changed in Core 5.3 spec, then we can use that one.
Regards
Marcel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-22 14:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-22 2:19 [PATCH] bluez:fix btmon tools “Allow slave” to "Master Or Slave" #431 [hci0] 99.922927 wangyouwan
2021-07-22 3:02 ` bluez.test.bot
2021-07-22 7:07 ` [PATCH] " Barry Byford
2021-07-22 14:47 ` Marcel Holtmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.