Nokia RX51 U-Boot USB support updates?

Nokia RX51 U-Boot USB support updates?

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 1966 bytes --]

Hey all,

So, the DM_USB migration deadline issue has been addressed by the series
here:
https://patchwork.ozlabs.org/project/uboot/list/?series=252793&state=*
which splits out host and gadget support from the CONFIG_USB symbol
itself.  The migration deadline was for host support, and as noted, N900
is gadget only.  That particular issue is resolved.

But investigating that issue lead me to figure out some other problems,
that I do need someone to say how will be addressed.  Now that the other
board removal series has been applied, and then with:
https://patchwork.ozlabs.org/project/uboot/patch/20210708014348.4010-1-trini@konsulko.com/
also applied (for which the maintainer is happy to take), this brings
N900 as the last and only user of the "old" musb driver (the "new" musb
driver is now almost 9 years old) and also the last and only user of the
usbtty driver.

I suspect that moving to the "new" MUSB driver, for gadget only, and
with that enabling DM_USB_GADGET should be a mechanical affair, so long
as you can fit within the space constraints of the platform.  I'm not
immediately sure how hard it will be to update usbtty.c to modern gadget
APIs.  If there are size problems, then, well, we need solutions
proposed (it's possible that some of the usb-uclass.c code is host-only
and needs moving, but that likely won't stop gadget from needing it for
gadget related information, to bring up a specific example).

It's also likely that the MUSB support needs a little further
clean-up for supporting building as gadget-only when there's some common
code under a host-only check.

What I would like is for someone to step forward and say they'll pick up
this work.  Is there an immediate deadline? No.  I don't think that
would be helpful.  I'm not going to dictate how long it takes for
someone to do the work, that's for the person doing the work to say how
long they think it'll take.

Thanks all!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: Nokia RX51 U-Boot USB support updates?

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 2112 bytes --]

On Tue, Jul 13, 2021 at 04:33:04PM -0400, Tom Rini wrote:

> Hey all,
> 
> So, the DM_USB migration deadline issue has been addressed by the series
> here:
> https://patchwork.ozlabs.org/project/uboot/list/?series=252793&state=*
> which splits out host and gadget support from the CONFIG_USB symbol
> itself.  The migration deadline was for host support, and as noted, N900
> is gadget only.  That particular issue is resolved.
> 
> But investigating that issue lead me to figure out some other problems,
> that I do need someone to say how will be addressed.  Now that the other
> board removal series has been applied, and then with:
> https://patchwork.ozlabs.org/project/uboot/patch/20210708014348.4010-1-trini@konsulko.com/
> also applied (for which the maintainer is happy to take), this brings
> N900 as the last and only user of the "old" musb driver (the "new" musb
> driver is now almost 9 years old) and also the last and only user of the
> usbtty driver.
> 
> I suspect that moving to the "new" MUSB driver, for gadget only, and
> with that enabling DM_USB_GADGET should be a mechanical affair, so long
> as you can fit within the space constraints of the platform.  I'm not
> immediately sure how hard it will be to update usbtty.c to modern gadget
> APIs.  If there are size problems, then, well, we need solutions
> proposed (it's possible that some of the usb-uclass.c code is host-only
> and needs moving, but that likely won't stop gadget from needing it for
> gadget related information, to bring up a specific example).
> 
> It's also likely that the MUSB support needs a little further
> clean-up for supporting building as gadget-only when there's some common
> code under a host-only check.
> 
> What I would like is for someone to step forward and say they'll pick up
> this work.  Is there an immediate deadline? No.  I don't think that
> would be helpful.  I'm not going to dictate how long it takes for
> someone to do the work, that's for the person doing the work to say how
> long they think it'll take.
> 
> Thanks all!

ping?

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: Nokia RX51 U-Boot USB support updates?

[Merlijn Wajer]

Hi Tom,

On 13/07/2021 22:33, Tom Rini wrote:
> Hey all,
> 
> So, the DM_USB migration deadline issue has been addressed by the series
> here:
> https://patchwork.ozlabs.org/project/uboot/list/?series=252793&state=*
> which splits out host and gadget support from the CONFIG_USB symbol
> itself.  The migration deadline was for host support, and as noted, N900
> is gadget only.  That particular issue is resolved.

Thanks a lot for doing that!

> But investigating that issue lead me to figure out some other problems,
> that I do need someone to say how will be addressed.  Now that the other
> board removal series has been applied, and then with:
> https://patchwork.ozlabs.org/project/uboot/patch/20210708014348.4010-1-trini@konsulko.com/
> also applied (for which the maintainer is happy to take), this brings
> N900 as the last and only user of the "old" musb driver (the "new" musb
> driver is now almost 9 years old) and also the last and only user of the
> usbtty driver.
> 
> I suspect that moving to the "new" MUSB driver, for gadget only, and
> with that enabling DM_USB_GADGET should be a mechanical affair, so long
> as you can fit within the space constraints of the platform.  I'm not
> immediately sure how hard it will be to update usbtty.c to modern gadget
> APIs.  If there are size problems, then, well, we need solutions
> proposed (it's possible that some of the usb-uclass.c code is host-only
> and needs moving, but that likely won't stop gadget from needing it for
> gadget related information, to bring up a specific example).
> 
> It's also likely that the MUSB support needs a little further
> clean-up for supporting building as gadget-only when there's some common
> code under a host-only check.
> 
> What I would like is for someone to step forward and say they'll pick up
> this work.  Is there an immediate deadline? No.  I don't think that
> would be helpful.  I'm not going to dictate how long it takes for
> someone to do the work, that's for the person doing the work to say how
> long they think it'll take.

I have a nokia serial device for the N900, which makes debugging
significantly easier. I have some experience with u-boot (not that much
with u-boot on omap though), but I imagine that Ivaylo and/or Pali can
help me if I run into problems. So I'll try to pick this up.

As for a time frame, I imagine I should be able to find some time for
this in the next couple of months.

Thanks,
Merlijn

Re: Nokia RX51 U-Boot USB support updates?

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 2692 bytes --]

On Sun, Jul 25, 2021 at 12:40:13PM +0200, Merlijn Wajer wrote:
> Hi Tom,
> 
> On 13/07/2021 22:33, Tom Rini wrote:
> > Hey all,
> > 
> > So, the DM_USB migration deadline issue has been addressed by the series
> > here:
> > https://patchwork.ozlabs.org/project/uboot/list/?series=252793&state=*
> > which splits out host and gadget support from the CONFIG_USB symbol
> > itself.  The migration deadline was for host support, and as noted, N900
> > is gadget only.  That particular issue is resolved.
> 
> Thanks a lot for doing that!
> 
> > But investigating that issue lead me to figure out some other problems,
> > that I do need someone to say how will be addressed.  Now that the other
> > board removal series has been applied, and then with:
> > https://patchwork.ozlabs.org/project/uboot/patch/20210708014348.4010-1-trini@konsulko.com/
> > also applied (for which the maintainer is happy to take), this brings
> > N900 as the last and only user of the "old" musb driver (the "new" musb
> > driver is now almost 9 years old) and also the last and only user of the
> > usbtty driver.
> > 
> > I suspect that moving to the "new" MUSB driver, for gadget only, and
> > with that enabling DM_USB_GADGET should be a mechanical affair, so long
> > as you can fit within the space constraints of the platform.  I'm not
> > immediately sure how hard it will be to update usbtty.c to modern gadget
> > APIs.  If there are size problems, then, well, we need solutions
> > proposed (it's possible that some of the usb-uclass.c code is host-only
> > and needs moving, but that likely won't stop gadget from needing it for
> > gadget related information, to bring up a specific example).
> > 
> > It's also likely that the MUSB support needs a little further
> > clean-up for supporting building as gadget-only when there's some common
> > code under a host-only check.
> > 
> > What I would like is for someone to step forward and say they'll pick up
> > this work.  Is there an immediate deadline? No.  I don't think that
> > would be helpful.  I'm not going to dictate how long it takes for
> > someone to do the work, that's for the person doing the work to say how
> > long they think it'll take.
> 
> I have a nokia serial device for the N900, which makes debugging
> significantly easier. I have some experience with u-boot (not that much
> with u-boot on omap though), but I imagine that Ivaylo and/or Pali can
> help me if I run into problems. So I'll try to pick this up.
> 
> As for a time frame, I imagine I should be able to find some time for
> this in the next couple of months.

A couple of months sounds great, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: Nokia RX51 U-Boot USB support updates?

[Merlijn Wajer]

Hi Tom, Pali,

On 25/07/2021 15:43, Tom Rini wrote:
> On Sun, Jul 25, 2021 at 12:40:13PM +0200, Merlijn Wajer wrote:
>> Hi Tom,
>>
>> On 13/07/2021 22:33, Tom Rini wrote:
>>> Hey all,
>>>
>>> So, the DM_USB migration deadline issue has been addressed by the series
>>> here:
>>> https://patchwork.ozlabs.org/project/uboot/list/?series=252793&state=*
>>> which splits out host and gadget support from the CONFIG_USB symbol
>>> itself.  The migration deadline was for host support, and as noted, N900
>>> is gadget only.  That particular issue is resolved.
>>
>> Thanks a lot for doing that!
>>
>>> But investigating that issue lead me to figure out some other problems,
>>> that I do need someone to say how will be addressed.  Now that the other
>>> board removal series has been applied, and then with:
>>> https://patchwork.ozlabs.org/project/uboot/patch/20210708014348.4010-1-trini@konsulko.com/
>>> also applied (for which the maintainer is happy to take), this brings
>>> N900 as the last and only user of the "old" musb driver (the "new" musb
>>> driver is now almost 9 years old) and also the last and only user of the
>>> usbtty driver.
>>>
>>> I suspect that moving to the "new" MUSB driver, for gadget only, and
>>> with that enabling DM_USB_GADGET should be a mechanical affair, so long
>>> as you can fit within the space constraints of the platform.  I'm not
>>> immediately sure how hard it will be to update usbtty.c to modern gadget
>>> APIs.  If there are size problems, then, well, we need solutions
>>> proposed (it's possible that some of the usb-uclass.c code is host-only
>>> and needs moving, but that likely won't stop gadget from needing it for
>>> gadget related information, to bring up a specific example).
>>>
>>> It's also likely that the MUSB support needs a little further
>>> clean-up for supporting building as gadget-only when there's some common
>>> code under a host-only check.
>>>
>>> What I would like is for someone to step forward and say they'll pick up
>>> this work.  Is there an immediate deadline? No.  I don't think that
>>> would be helpful.  I'm not going to dictate how long it takes for
>>> someone to do the work, that's for the person doing the work to say how
>>> long they think it'll take.
>>
>> I have a nokia serial device for the N900, which makes debugging
>> significantly easier. I have some experience with u-boot (not that much
>> with u-boot on omap though), but I imagine that Ivaylo and/or Pali can
>> help me if I run into problems. So I'll try to pick this up.
>>
>> As for a time frame, I imagine I should be able to find some time for
>> this in the next couple of months.
> 
> A couple of months sounds great, thanks!

It's been a bit longer than that, but I am starting with it today. It 
shouldn't take too long at this point. Sorry for the delay.

Regards,
Merlijn

Re: Nokia RX51 U-Boot USB support updates?

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 3195 bytes --]

On Sat, May 07, 2022 at 05:18:02PM +0200, Merlijn Wajer wrote:
> Hi Tom, Pali,
> 
> On 25/07/2021 15:43, Tom Rini wrote:
> > On Sun, Jul 25, 2021 at 12:40:13PM +0200, Merlijn Wajer wrote:
> > > Hi Tom,
> > > 
> > > On 13/07/2021 22:33, Tom Rini wrote:
> > > > Hey all,
> > > > 
> > > > So, the DM_USB migration deadline issue has been addressed by the series
> > > > here:
> > > > https://patchwork.ozlabs.org/project/uboot/list/?series=252793&state=*
> > > > which splits out host and gadget support from the CONFIG_USB symbol
> > > > itself.  The migration deadline was for host support, and as noted, N900
> > > > is gadget only.  That particular issue is resolved.
> > > 
> > > Thanks a lot for doing that!
> > > 
> > > > But investigating that issue lead me to figure out some other problems,
> > > > that I do need someone to say how will be addressed.  Now that the other
> > > > board removal series has been applied, and then with:
> > > > https://patchwork.ozlabs.org/project/uboot/patch/20210708014348.4010-1-trini@konsulko.com/
> > > > also applied (for which the maintainer is happy to take), this brings
> > > > N900 as the last and only user of the "old" musb driver (the "new" musb
> > > > driver is now almost 9 years old) and also the last and only user of the
> > > > usbtty driver.
> > > > 
> > > > I suspect that moving to the "new" MUSB driver, for gadget only, and
> > > > with that enabling DM_USB_GADGET should be a mechanical affair, so long
> > > > as you can fit within the space constraints of the platform.  I'm not
> > > > immediately sure how hard it will be to update usbtty.c to modern gadget
> > > > APIs.  If there are size problems, then, well, we need solutions
> > > > proposed (it's possible that some of the usb-uclass.c code is host-only
> > > > and needs moving, but that likely won't stop gadget from needing it for
> > > > gadget related information, to bring up a specific example).
> > > > 
> > > > It's also likely that the MUSB support needs a little further
> > > > clean-up for supporting building as gadget-only when there's some common
> > > > code under a host-only check.
> > > > 
> > > > What I would like is for someone to step forward and say they'll pick up
> > > > this work.  Is there an immediate deadline? No.  I don't think that
> > > > would be helpful.  I'm not going to dictate how long it takes for
> > > > someone to do the work, that's for the person doing the work to say how
> > > > long they think it'll take.
> > > 
> > > I have a nokia serial device for the N900, which makes debugging
> > > significantly easier. I have some experience with u-boot (not that much
> > > with u-boot on omap though), but I imagine that Ivaylo and/or Pali can
> > > help me if I run into problems. So I'll try to pick this up.
> > > 
> > > As for a time frame, I imagine I should be able to find some time for
> > > this in the next couple of months.
> > 
> > A couple of months sounds great, thanks!
> 
> It's been a bit longer than that, but I am starting with it today. It
> shouldn't take too long at this point. Sorry for the delay.

OK, thanks for the update.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: Nokia RX51 U-Boot USB support updates?

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 3408 bytes --]

On Sat, May 07, 2022 at 01:13:03PM -0400, Tom Rini wrote:
> On Sat, May 07, 2022 at 05:18:02PM +0200, Merlijn Wajer wrote:
> > Hi Tom, Pali,
> > 
> > On 25/07/2021 15:43, Tom Rini wrote:
> > > On Sun, Jul 25, 2021 at 12:40:13PM +0200, Merlijn Wajer wrote:
> > > > Hi Tom,
> > > > 
> > > > On 13/07/2021 22:33, Tom Rini wrote:
> > > > > Hey all,
> > > > > 
> > > > > So, the DM_USB migration deadline issue has been addressed by the series
> > > > > here:
> > > > > https://patchwork.ozlabs.org/project/uboot/list/?series=252793&state=*
> > > > > which splits out host and gadget support from the CONFIG_USB symbol
> > > > > itself.  The migration deadline was for host support, and as noted, N900
> > > > > is gadget only.  That particular issue is resolved.
> > > > 
> > > > Thanks a lot for doing that!
> > > > 
> > > > > But investigating that issue lead me to figure out some other problems,
> > > > > that I do need someone to say how will be addressed.  Now that the other
> > > > > board removal series has been applied, and then with:
> > > > > https://patchwork.ozlabs.org/project/uboot/patch/20210708014348.4010-1-trini@konsulko.com/
> > > > > also applied (for which the maintainer is happy to take), this brings
> > > > > N900 as the last and only user of the "old" musb driver (the "new" musb
> > > > > driver is now almost 9 years old) and also the last and only user of the
> > > > > usbtty driver.
> > > > > 
> > > > > I suspect that moving to the "new" MUSB driver, for gadget only, and
> > > > > with that enabling DM_USB_GADGET should be a mechanical affair, so long
> > > > > as you can fit within the space constraints of the platform.  I'm not
> > > > > immediately sure how hard it will be to update usbtty.c to modern gadget
> > > > > APIs.  If there are size problems, then, well, we need solutions
> > > > > proposed (it's possible that some of the usb-uclass.c code is host-only
> > > > > and needs moving, but that likely won't stop gadget from needing it for
> > > > > gadget related information, to bring up a specific example).
> > > > > 
> > > > > It's also likely that the MUSB support needs a little further
> > > > > clean-up for supporting building as gadget-only when there's some common
> > > > > code under a host-only check.
> > > > > 
> > > > > What I would like is for someone to step forward and say they'll pick up
> > > > > this work.  Is there an immediate deadline? No.  I don't think that
> > > > > would be helpful.  I'm not going to dictate how long it takes for
> > > > > someone to do the work, that's for the person doing the work to say how
> > > > > long they think it'll take.
> > > > 
> > > > I have a nokia serial device for the N900, which makes debugging
> > > > significantly easier. I have some experience with u-boot (not that much
> > > > with u-boot on omap though), but I imagine that Ivaylo and/or Pali can
> > > > help me if I run into problems. So I'll try to pick this up.
> > > > 
> > > > As for a time frame, I imagine I should be able to find some time for
> > > > this in the next couple of months.
> > > 
> > > A couple of months sounds great, thanks!
> > 
> > It's been a bit longer than that, but I am starting with it today. It
> > shouldn't take too long at this point. Sorry for the delay.
> 
> OK, thanks for the update.

Checking in on this, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]