All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH BlueZ] tools/mesh-cfgtest: include limits.h
@ 2021-07-22 20:49 Michael Nosthoff
  2021-07-22 21:38 ` [BlueZ] " bluez.test.bot
  0 siblings, 1 reply; 6+ messages in thread
From: Michael Nosthoff @ 2021-07-22 20:49 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Michael Nosthoff

mesh-cfgtest.c uses MAX_PATH so it should include limits.h.

fixes compilation error with musl-based toolchains.
---
 tools/mesh-cfgtest.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/mesh-cfgtest.c b/tools/mesh-cfgtest.c
index fa0474faa..116ab7f16 100644
--- a/tools/mesh-cfgtest.c
+++ b/tools/mesh-cfgtest.c
@@ -21,6 +21,7 @@
 #include <ftw.h>
 #include <getopt.h>
 #include <libgen.h>
+#include <limits.h>
 #include <signal.h>
 #include <stdio.h>
 #include <time.h>
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* RE: [BlueZ] tools/mesh-cfgtest: include limits.h
  2021-07-22 20:49 [PATCH BlueZ] tools/mesh-cfgtest: include limits.h Michael Nosthoff
@ 2021-07-22 21:38 ` bluez.test.bot
  0 siblings, 0 replies; 6+ messages in thread
From: bluez.test.bot @ 2021-07-22 21:38 UTC (permalink / raw)
  To: linux-bluetooth, bluez

[-- Attachment #1: Type: text/plain, Size: 1953 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=519969

---Test result---

Test Summary:
CheckPatch                    PASS      0.37 seconds
GitLint                       PASS      0.12 seconds
Prep - Setup ELL              PASS      49.13 seconds
Build - Prep                  PASS      0.14 seconds
Build - Configure             PASS      8.64 seconds
Build - Make                  PASS      216.88 seconds
Make Check                    PASS      9.25 seconds
Make Distcheck                PASS      254.97 seconds
Build w/ext ELL - Configure   PASS      8.52 seconds
Build w/ext ELL - Make        PASS      205.83 seconds

Details
##############################
Test: CheckPatch - PASS
Desc: Run checkpatch.pl script with rule in .checkpatch.conf

##############################
Test: GitLint - PASS
Desc: Run gitlint with rule in .gitlint

##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL

##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build

##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree

##############################
Test: Build - Make - PASS
Desc: Build the BlueZ source tree

##############################
Test: Make Check - PASS
Desc: Run 'make check'

##############################
Test: Make Distcheck - PASS
Desc: Run distcheck to check the distribution

##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration

##############################
Test: Build w/ext ELL - Make - PASS
Desc: Build BlueZ source with '--enable-external-ell' configuration



---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH BlueZ] tools/mesh-cfgtest: include  limits.h
  2022-02-16 11:57 ` Michael Nosthoff
  2022-02-16 12:35   ` Fabrice Fontaine
@ 2022-02-16 18:34   ` Gix, Brian
  1 sibling, 0 replies; 6+ messages in thread
From: Gix, Brian @ 2022-02-16 18:34 UTC (permalink / raw)
  To: bluez, fontaine.fabrice; +Cc: buildroot, linux-bluetooth, Stotland, Inga

The clean applying version of this patch has  been applied. This is *not* the one with the Notes attached which
broke length rules in the commit message.

On Wed, 2022-02-16 at 12:57 +0100, Michael Nosthoff wrote:
> Hi Fabrice,
> 
> On Tuesday, February 15, 2022 23:50 CET, Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> 
> > ---
> > I'm sending back this patch as for an unknown reason, the patch sent by
> > Michael in July 2021 is set as superseded in patchwork:
> > https://patchwork.kernel.org/project/bluetooth/patch/20210722204923.29735-1-bluez@heine.tech
> > 
> I had sent a v2 with an improved description. The buildbot didn't like the Commit Msg because of the too long
> urls to the buildroot autobuilders. Maybe that's why it was marked as "archived" on patchwork?
> 
> https://patchwork.kernel.org/project/bluetooth/patch/20210723081039.30396-1-bluez@heine.tech/
> 
> Regards,
> Michael
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH BlueZ] tools/mesh-cfgtest: include limits.h
  2022-02-16 11:57 ` Michael Nosthoff
@ 2022-02-16 12:35   ` Fabrice Fontaine
  2022-02-16 18:34   ` Gix, Brian
  1 sibling, 0 replies; 6+ messages in thread
From: Fabrice Fontaine @ 2022-02-16 12:35 UTC (permalink / raw)
  To: Michael Nosthoff; +Cc: linux-bluetooth, Michael Nosthoff

Hi Michael,

Le mer. 16 févr. 2022 à 12:57, Michael Nosthoff <bluez@heine.tech> a écrit :
>
> Hi Fabrice,
>
> On Tuesday, February 15, 2022 23:50 CET, Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > ---
> > I'm sending back this patch as for an unknown reason, the patch sent by
> > Michael in July 2021 is set as superseded in patchwork:
> > https://patchwork.kernel.org/project/bluetooth/patch/20210722204923.29735-1-bluez@heine.tech
> >
> I had sent a v2 with an improved description. The buildbot didn't like the Commit Msg because of the too long
> urls to the buildroot autobuilders. Maybe that's why it was marked as "archived" on patchwork?
>
> https://patchwork.kernel.org/project/bluetooth/patch/20210723081039.30396-1-bluez@heine.tech/

Thanks for pointing out v2, I missed it.
Would be great to merge one of the version of this patch so we can
drop it from buildroot.

>
> Regards,
> Michael
>
Best Regards,

Fabrice

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH BlueZ] tools/mesh-cfgtest: include  limits.h
  2022-02-15 22:50 [PATCH BlueZ] " Fabrice Fontaine
@ 2022-02-16 11:57 ` Michael Nosthoff
  2022-02-16 12:35   ` Fabrice Fontaine
  2022-02-16 18:34   ` Gix, Brian
  0 siblings, 2 replies; 6+ messages in thread
From: Michael Nosthoff @ 2022-02-16 11:57 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: linux-bluetooth, Michael Nosthoff, Michael Nosthoff

Hi Fabrice,

On Tuesday, February 15, 2022 23:50 CET, Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> ---
> I'm sending back this patch as for an unknown reason, the patch sent by
> Michael in July 2021 is set as superseded in patchwork:
> https://patchwork.kernel.org/project/bluetooth/patch/20210722204923.29735-1-bluez@heine.tech
>
I had sent a v2 with an improved description. The buildbot didn't like the Commit Msg because of the too long
urls to the buildroot autobuilders. Maybe that's why it was marked as "archived" on patchwork?

https://patchwork.kernel.org/project/bluetooth/patch/20210723081039.30396-1-bluez@heine.tech/

Regards,
Michael


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH BlueZ] tools/mesh-cfgtest: include limits.h
@ 2022-02-15 22:50 Fabrice Fontaine
  2022-02-16 11:57 ` Michael Nosthoff
  0 siblings, 1 reply; 6+ messages in thread
From: Fabrice Fontaine @ 2022-02-15 22:50 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Michael Nosthoff, Michael Nosthoff

From: Michael Nosthoff <bluez@heine.tech>

mesh-cfgtest.c uses PATH_MAX so it should include limits.h.

fixes compilation error when enabling mesh support with musl-based
toolchains observed in buildroot autobuilders.

http://autobuild.buildroot.net/results/20cc47f54de0b0d4bdf108c3715c590ae8ab476f/
http://autobuild.buildroot.net/results/003968b25906579dbcf5a95d1e43fec0ab504ef5/

Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
---
I'm sending back this patch as for an unknown reason, the patch sent by
Michael in July 2021 is set as superseded in patchwork:
https://patchwork.kernel.org/project/bluetooth/patch/20210722204923.29735-1-bluez@heine.tech

 tools/mesh-cfgtest.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/mesh-cfgtest.c b/tools/mesh-cfgtest.c
index fa0474faa..116ab7f16 100644
--- a/tools/mesh-cfgtest.c
+++ b/tools/mesh-cfgtest.c
@@ -21,6 +21,7 @@
 #include <ftw.h>
 #include <getopt.h>
 #include <libgen.h>
+#include <limits.h>
 #include <signal.h>
 #include <stdio.h>
 #include <time.h>
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-02-16 18:34 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-22 20:49 [PATCH BlueZ] tools/mesh-cfgtest: include limits.h Michael Nosthoff
2021-07-22 21:38 ` [BlueZ] " bluez.test.bot
2022-02-15 22:50 [PATCH BlueZ] " Fabrice Fontaine
2022-02-16 11:57 ` Michael Nosthoff
2022-02-16 12:35   ` Fabrice Fontaine
2022-02-16 18:34   ` Gix, Brian

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.