All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Christoph Hellwig <hch@lst.de>
Cc: David Airlie <airlied@linux.ie>,
	Tony Krowiak <akrowiak@linux.ibm.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Cornelia Huck <cohuck@redhat.com>,
	Jonathan Corbet <corbet@lwn.net>, Daniel Vetter <daniel@ffwll.ch>,
	Diana Craciun <diana.craciun@oss.nxp.com>,
	dri-devel@lists.freedesktop.org,
	Eric Auger <eric.auger@redhat.com>,
	Eric Farman <farman@linux.ibm.com>,
	Harald Freudenberger <freude@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	intel-gfx@lists.freedesktop.org,
	intel-gvt-dev@lists.freedesktop.org,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Jason Herne <jjherne@linux.ibm.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	kvm@vger.kernel.org, Kirti Wankhede <kwankhede@nvidia.com>,
	linux-doc@vger.kernel.org, linux-s390@vger.kernel.org,
	Matthew Rosato <mjrosato@linux.ibm.com>,
	Peter Oberparleiter <oberpar@linux.ibm.com>,
	Halil Pasic <pasic@linux.ibm.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Vineeth Vijayan <vneethv@linux.ibm.com>,
	Zhi Wang <zhi.a.wang@intel.com>,
	"Raj, Ashok" <ashok.raj@intel.com>,
	Leon Romanovsky <leonro@nvidia.com>,
	Max Gurtovoy <mgurtovoy@nvidia.com>,
	Yishai Hadas <yishaih@nvidia.com>,
	Zhenyu Wang <zhenyuw@linux.intel.com>
Subject: Re: [PATCH v2 10/14] vfio/pci: Reorganize VFIO_DEVICE_PCI_HOT_RESET to use the device set
Date: Fri, 23 Jul 2021 10:31:19 -0300	[thread overview]
Message-ID: <20210723133119.GW1117491@nvidia.com> (raw)
In-Reply-To: <20210723081208.GE2795@lst.de>

On Fri, Jul 23, 2021 at 10:12:08AM +0200, Christoph Hellwig wrote:
> On Tue, Jul 20, 2021 at 02:42:56PM -0300, Jason Gunthorpe wrote:
> > Like vfio_pci_try_bus_reset() this code wants to reset all of the devices
> > in the "reset group" which is the same membership as the device set.
> > 
> > Instead of trying to reconstruct the device set from the PCI list go
> > directly from the device set's device list to execute the reset.
> > 
> > The same basic structure as vfio_pci_try_bus_reset() is used. The
> > 'vfio_devices' struct is replaced with the device set linked list and we
> > simply sweep it multiple times under the lock.
> > 
> > This eliminates a memory allocation and get/put traffic and another
> > improperly locked test of pci_dev_driver().
> 
> Looks fine.  But oh gad is that locking scheme awful..

I hope that the address space patches Alex has been working on will
help this.

And as I wrote it I was wondering if we can swap the dev_set lock for
all these other locks and just delete the whole thing..

Thanks,
Jason

WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Christoph Hellwig <hch@lst.de>
Cc: kvm@vger.kernel.org, linux-doc@vger.kernel.org,
	David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org,
	Kirti Wankhede <kwankhede@nvidia.com>,
	Max Gurtovoy <mgurtovoy@nvidia.com>,
	Vineeth Vijayan <vneethv@linux.ibm.com>,
	Diana Craciun <diana.craciun@oss.nxp.com>,
	Leon Romanovsky <leonro@nvidia.com>,
	linux-s390@vger.kernel.org,
	Matthew Rosato <mjrosato@linux.ibm.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Halil Pasic <pasic@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	intel-gfx@lists.freedesktop.org, Zhi Wang <zhi.a.wang@intel.com>,
	Jason Herne <jjherne@linux.ibm.com>,
	Eric Farman <farman@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Eric Auger <eric.auger@redhat.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Harald Freudenberger <freude@linux.ibm.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	intel-gvt-dev@lists.freedesktop.org, "Raj,
	Ashok" <ashok.raj@intel.com>,
	Tony Krowiak <akrowiak@linux.ibm.com>,
	Yishai Hadas <yishaih@nvidia.com>,
	Cornelia Huck <cohuck@redhat.com>,
	Peter Oberparleiter <oberpar@linux.ibm.com>
Subject: Re: [PATCH v2 10/14] vfio/pci: Reorganize VFIO_DEVICE_PCI_HOT_RESET to use the device set
Date: Fri, 23 Jul 2021 10:31:19 -0300	[thread overview]
Message-ID: <20210723133119.GW1117491@nvidia.com> (raw)
In-Reply-To: <20210723081208.GE2795@lst.de>

On Fri, Jul 23, 2021 at 10:12:08AM +0200, Christoph Hellwig wrote:
> On Tue, Jul 20, 2021 at 02:42:56PM -0300, Jason Gunthorpe wrote:
> > Like vfio_pci_try_bus_reset() this code wants to reset all of the devices
> > in the "reset group" which is the same membership as the device set.
> > 
> > Instead of trying to reconstruct the device set from the PCI list go
> > directly from the device set's device list to execute the reset.
> > 
> > The same basic structure as vfio_pci_try_bus_reset() is used. The
> > 'vfio_devices' struct is replaced with the device set linked list and we
> > simply sweep it multiple times under the lock.
> > 
> > This eliminates a memory allocation and get/put traffic and another
> > improperly locked test of pci_dev_driver().
> 
> Looks fine.  But oh gad is that locking scheme awful..

I hope that the address space patches Alex has been working on will
help this.

And as I wrote it I was wondering if we can swap the dev_set lock for
all these other locks and just delete the whole thing..

Thanks,
Jason

WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Christoph Hellwig <hch@lst.de>
Cc: kvm@vger.kernel.org, linux-doc@vger.kernel.org,
	David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org,
	Kirti Wankhede <kwankhede@nvidia.com>,
	Max Gurtovoy <mgurtovoy@nvidia.com>,
	Vineeth Vijayan <vneethv@linux.ibm.com>,
	Diana Craciun <diana.craciun@oss.nxp.com>,
	Leon Romanovsky <leonro@nvidia.com>,
	linux-s390@vger.kernel.org,
	Matthew Rosato <mjrosato@linux.ibm.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Halil Pasic <pasic@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	intel-gfx@lists.freedesktop.org,
	Jason Herne <jjherne@linux.ibm.com>,
	Eric Farman <farman@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Eric Auger <eric.auger@redhat.com>,
	Harald Freudenberger <freude@linux.ibm.com>,
	intel-gvt-dev@lists.freedesktop.org, "Raj,
	Ashok" <ashok.raj@intel.com>,
	Tony Krowiak <akrowiak@linux.ibm.com>,
	Yishai Hadas <yishaih@nvidia.com>,
	Cornelia Huck <cohuck@redhat.com>,
	Peter Oberparleiter <oberpar@linux.ibm.com>
Subject: Re: [Intel-gfx] [PATCH v2 10/14] vfio/pci: Reorganize VFIO_DEVICE_PCI_HOT_RESET to use the device set
Date: Fri, 23 Jul 2021 10:31:19 -0300	[thread overview]
Message-ID: <20210723133119.GW1117491@nvidia.com> (raw)
In-Reply-To: <20210723081208.GE2795@lst.de>

On Fri, Jul 23, 2021 at 10:12:08AM +0200, Christoph Hellwig wrote:
> On Tue, Jul 20, 2021 at 02:42:56PM -0300, Jason Gunthorpe wrote:
> > Like vfio_pci_try_bus_reset() this code wants to reset all of the devices
> > in the "reset group" which is the same membership as the device set.
> > 
> > Instead of trying to reconstruct the device set from the PCI list go
> > directly from the device set's device list to execute the reset.
> > 
> > The same basic structure as vfio_pci_try_bus_reset() is used. The
> > 'vfio_devices' struct is replaced with the device set linked list and we
> > simply sweep it multiple times under the lock.
> > 
> > This eliminates a memory allocation and get/put traffic and another
> > improperly locked test of pci_dev_driver().
> 
> Looks fine.  But oh gad is that locking scheme awful..

I hope that the address space patches Alex has been working on will
help this.

And as I wrote it I was wondering if we can swap the dev_set lock for
all these other locks and just delete the whole thing..

Thanks,
Jason
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2021-07-23 13:31 UTC|newest]

Thread overview: 122+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-20 17:42 [PATCH v2 00/14] Provide core infrastructure for managing open/release Jason Gunthorpe
2021-07-20 17:42 ` [Intel-gfx] " Jason Gunthorpe
2021-07-20 17:42 ` Jason Gunthorpe
2021-07-20 17:42 ` [PATCH v2 01/14] vfio/samples: Remove module get/put Jason Gunthorpe
2021-07-20 17:42   ` [Intel-gfx] " Jason Gunthorpe
2021-07-20 17:42   ` Jason Gunthorpe
2021-07-23  7:18   ` Christoph Hellwig
2021-07-23  7:18     ` [Intel-gfx] " Christoph Hellwig
2021-07-20 17:42 ` [PATCH v2 02/14] vfio/mbochs: Fix missing error unwind in mbochs_probe() Jason Gunthorpe
2021-07-20 17:42   ` [Intel-gfx] " Jason Gunthorpe
2021-07-20 17:42   ` Jason Gunthorpe
2021-07-20 22:01   ` Alex Williamson
2021-07-20 22:01     ` [Intel-gfx] " Alex Williamson
2021-07-20 22:01     ` Alex Williamson
2021-07-20 22:49     ` Jason Gunthorpe
2021-07-20 22:49       ` [Intel-gfx] " Jason Gunthorpe
2021-07-20 22:49       ` Jason Gunthorpe
2021-07-20 22:54       ` Alex Williamson
2021-07-20 22:54         ` [Intel-gfx] " Alex Williamson
2021-07-20 22:54         ` Alex Williamson
2021-07-21  9:18       ` Cornelia Huck
2021-07-21  9:18         ` [Intel-gfx] " Cornelia Huck
2021-07-21  9:18         ` Cornelia Huck
2021-07-21  9:16   ` Cornelia Huck
2021-07-21  9:16     ` [Intel-gfx] " Cornelia Huck
2021-07-21  9:16     ` Cornelia Huck
2021-07-20 17:42 ` [PATCH v2 03/14] vfio: Introduce a vfio_uninit_group_dev() API call Jason Gunthorpe
2021-07-20 17:42   ` [Intel-gfx] " Jason Gunthorpe
2021-07-20 17:42   ` Jason Gunthorpe
2021-07-21 11:33   ` Cornelia Huck
2021-07-21 11:33     ` [Intel-gfx] " Cornelia Huck
2021-07-21 11:33     ` Cornelia Huck
2021-07-23  7:18   ` Christoph Hellwig
2021-07-23  7:18     ` [Intel-gfx] " Christoph Hellwig
2021-07-20 17:42 ` [PATCH v2 04/14] vfio: Provide better generic support for open/release vfio_device_ops Jason Gunthorpe
2021-07-20 17:42   ` [Intel-gfx] " Jason Gunthorpe
2021-07-20 17:42   ` Jason Gunthorpe
2021-07-22 14:42   ` Cornelia Huck
2021-07-22 14:42     ` [Intel-gfx] " Cornelia Huck
2021-07-22 14:42     ` Cornelia Huck
2021-07-23  7:39   ` Christoph Hellwig
2021-07-23  7:39     ` [Intel-gfx] " Christoph Hellwig
2021-07-23 14:38     ` Jason Gunthorpe
2021-07-23 14:38       ` [Intel-gfx] " Jason Gunthorpe
2021-07-23 14:38       ` Jason Gunthorpe
2021-07-20 17:42 ` [PATCH v2 05/14] vfio/samples: Delete useless open/close Jason Gunthorpe
2021-07-20 17:42   ` [Intel-gfx] " Jason Gunthorpe
2021-07-20 17:42   ` Jason Gunthorpe
2021-07-23  7:39   ` Christoph Hellwig
2021-07-23  7:39     ` [Intel-gfx] " Christoph Hellwig
2021-07-20 17:42 ` [PATCH v2 06/14] vfio/fsl: Move to the device set infrastructure Jason Gunthorpe
2021-07-20 17:42   ` [Intel-gfx] " Jason Gunthorpe
2021-07-20 17:42   ` Jason Gunthorpe
2021-07-23  7:44   ` Christoph Hellwig
2021-07-23  7:44     ` [Intel-gfx] " Christoph Hellwig
2021-07-23 12:22     ` Jason Gunthorpe
2021-07-23 12:22       ` [Intel-gfx] " Jason Gunthorpe
2021-07-23 12:22       ` Jason Gunthorpe
2021-07-23 12:29       ` Christoph Hellwig
2021-07-23 12:29         ` [Intel-gfx] " Christoph Hellwig
2021-07-23 13:11         ` Jason Gunthorpe
2021-07-23 13:11           ` [Intel-gfx] " Jason Gunthorpe
2021-07-23 13:11           ` Jason Gunthorpe
2021-07-20 17:42 ` [PATCH v2 07/14] vfio/platform: Use open_device() instead of open coding a refcnt scheme Jason Gunthorpe
2021-07-20 17:42   ` [Intel-gfx] " Jason Gunthorpe
2021-07-20 17:42   ` Jason Gunthorpe
2021-07-22 14:48   ` Cornelia Huck
2021-07-22 14:48     ` [Intel-gfx] " Cornelia Huck
2021-07-22 14:48     ` Cornelia Huck
2021-07-23  7:45   ` Christoph Hellwig
2021-07-23  7:45     ` [Intel-gfx] " Christoph Hellwig
2021-07-23 12:23     ` Jason Gunthorpe
2021-07-23 12:23       ` [Intel-gfx] " Jason Gunthorpe
2021-07-23 12:23       ` Jason Gunthorpe
2021-07-20 17:42 ` [PATCH v2 08/14] vfio/pci: Move to the device set infrastructure Jason Gunthorpe
2021-07-20 17:42   ` [Intel-gfx] " Jason Gunthorpe
2021-07-20 17:42   ` Jason Gunthorpe
2021-07-23  7:47   ` Christoph Hellwig
2021-07-23  7:47     ` [Intel-gfx] " Christoph Hellwig
2021-07-23 12:59     ` Jason Gunthorpe
2021-07-23 12:59       ` [Intel-gfx] " Jason Gunthorpe
2021-07-23 12:59       ` Jason Gunthorpe
2021-07-20 17:42 ` [PATCH v2 09/14] vfio/pci: Change vfio_pci_try_bus_reset() to use the dev_set Jason Gunthorpe
2021-07-20 17:42   ` [Intel-gfx] " Jason Gunthorpe
2021-07-20 17:42   ` Jason Gunthorpe
2021-07-23  8:05   ` Christoph Hellwig
2021-07-23  8:05     ` [Intel-gfx] " Christoph Hellwig
2021-07-23 13:30     ` Jason Gunthorpe
2021-07-23 13:30       ` [Intel-gfx] " Jason Gunthorpe
2021-07-23 13:30       ` Jason Gunthorpe
2021-07-20 17:42 ` [PATCH v2 10/14] vfio/pci: Reorganize VFIO_DEVICE_PCI_HOT_RESET to use the device set Jason Gunthorpe
2021-07-20 17:42   ` [Intel-gfx] " Jason Gunthorpe
2021-07-20 17:42   ` Jason Gunthorpe
2021-07-23  8:12   ` Christoph Hellwig
2021-07-23  8:12     ` [Intel-gfx] " Christoph Hellwig
2021-07-23 13:31     ` Jason Gunthorpe [this message]
2021-07-23 13:31       ` Jason Gunthorpe
2021-07-23 13:31       ` Jason Gunthorpe
2021-07-20 17:42 ` [PATCH v2 11/14] vfio/mbochs: Fix close when multiple device FDs are open Jason Gunthorpe
2021-07-20 17:42   ` [Intel-gfx] " Jason Gunthorpe
2021-07-20 17:42   ` Jason Gunthorpe
2021-07-23  8:13   ` Christoph Hellwig
2021-07-23  8:13     ` [Intel-gfx] " Christoph Hellwig
2021-07-20 17:42 ` [PATCH v2 12/14] vfio/ap,ccw: Fix open/close " Jason Gunthorpe
2021-07-20 17:42   ` [Intel-gfx] [PATCH v2 12/14] vfio/ap, ccw: " Jason Gunthorpe
2021-07-20 17:42   ` Jason Gunthorpe
2021-07-20 17:42 ` [PATCH v2 13/14] vfio/gvt: " Jason Gunthorpe
2021-07-20 17:42   ` [Intel-gfx] " Jason Gunthorpe
2021-07-20 17:42   ` Jason Gunthorpe
2021-07-23  8:14   ` Christoph Hellwig
2021-07-23  8:14     ` [Intel-gfx] " Christoph Hellwig
2021-07-20 17:43 ` [PATCH v2 14/14] vfio: Remove struct vfio_device_ops open/release Jason Gunthorpe
2021-07-20 17:43   ` [Intel-gfx] " Jason Gunthorpe
2021-07-20 17:43   ` Jason Gunthorpe
2021-07-23  8:14   ` Christoph Hellwig
2021-07-23  8:14     ` [Intel-gfx] " Christoph Hellwig
2021-07-20 17:55 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Provide core infrastructure for managing open/release (rev4) Patchwork
2021-07-20 17:59 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2021-07-20 18:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-07-20 19:53 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-07-20 22:22 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Provide core infrastructure for managing open/release (rev5) Patchwork
2021-07-23  9:41 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Provide core infrastructure for managing open/release (rev6) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210723133119.GW1117491@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=airlied@linux.ie \
    --cc=akrowiak@linux.ibm.com \
    --cc=alex.williamson@redhat.com \
    --cc=ashok.raj@intel.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=corbet@lwn.net \
    --cc=daniel@ffwll.ch \
    --cc=diana.craciun@oss.nxp.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric.auger@redhat.com \
    --cc=farman@linux.ibm.com \
    --cc=freude@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=hch@lst.de \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-gvt-dev@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=jjherne@linux.ibm.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=kwankhede@nvidia.com \
    --cc=leonro@nvidia.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=mgurtovoy@nvidia.com \
    --cc=mjrosato@linux.ibm.com \
    --cc=oberpar@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=vneethv@linux.ibm.com \
    --cc=yishaih@nvidia.com \
    --cc=zhenyuw@linux.intel.com \
    --cc=zhi.a.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.