From: kernel test robot <lkp@intel.com>
To: "Clément Léger" <clement.leger@bootlin.com>,
"Lee Jones" <lee.jones@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Brown" <broonie@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>
Cc: kbuild-all@lists.01.org,
"Clément Léger" <clement.leger@bootlin.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"Peng Fan" <peng.fan@nxp.com>
Subject: Re: [PATCH 2/3] syscon: add support for "syscon-smc" compatible
Date: Sat, 24 Jul 2021 15:00:19 +0800 [thread overview]
Message-ID: <202107241438.ZGxGgokJ-lkp@intel.com> (raw)
In-Reply-To: <20210723135239.388325-3-clement.leger@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 2804 bytes --]
Hi "Clément,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on regmap/for-next]
[also build test WARNING on robh/for-next v5.14-rc2 next-20210723]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Cl-ment-L-ger/add-SMC-based-regmap-driver-for-secure-syscon-access/20210723-215708
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git for-next
config: riscv-nommu_k210_defconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/5b8123662c54263f6fc86b6ef9e296739fe78353
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Cl-ment-L-ger/add-SMC-based-regmap-driver-for-secure-syscon-access/20210723-215708
git checkout 5b8123662c54263f6fc86b6ef9e296739fe78353
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/mfd/syscon.c: In function 'syscon_probe':
>> drivers/mfd/syscon.c:407:23: warning: variable 'syscon_config' set but not used [-Wunused-but-set-variable]
407 | struct regmap_config syscon_config = syscon_regmap_config;
| ^~~~~~~~~~~~~
vim +/syscon_config +407 drivers/mfd/syscon.c
401
402 static int syscon_probe(struct platform_device *pdev)
403 {
404 int ret;
405 struct device *dev = &pdev->dev;
406 struct syscon_platform_data *pdata = dev_get_platdata(dev);
> 407 struct regmap_config syscon_config = syscon_regmap_config;
408 struct syscon *syscon;
409 const struct syscon_driver_data *driver_data;
410
411 if (pdata)
412 syscon_config.name = pdata->label;
413
414 syscon = devm_kzalloc(dev, sizeof(*syscon), GFP_KERNEL);
415 if (!syscon)
416 return -ENOMEM;
417
418 driver_data = (const struct syscon_driver_data *)
419 platform_get_device_id(pdev)->driver_data;
420
421 ret = driver_data->probe_func(pdev, dev, syscon);
422 if (ret)
423 return ret;
424
425 platform_set_drvdata(pdev, syscon);
426
427 return 0;
428 }
429
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 8582 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 2/3] syscon: add support for "syscon-smc" compatible
Date: Sat, 24 Jul 2021 15:00:19 +0800 [thread overview]
Message-ID: <202107241438.ZGxGgokJ-lkp@intel.com> (raw)
In-Reply-To: <20210723135239.388325-3-clement.leger@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 2877 bytes --]
Hi "Clément,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on regmap/for-next]
[also build test WARNING on robh/for-next v5.14-rc2 next-20210723]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Cl-ment-L-ger/add-SMC-based-regmap-driver-for-secure-syscon-access/20210723-215708
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git for-next
config: riscv-nommu_k210_defconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/5b8123662c54263f6fc86b6ef9e296739fe78353
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Cl-ment-L-ger/add-SMC-based-regmap-driver-for-secure-syscon-access/20210723-215708
git checkout 5b8123662c54263f6fc86b6ef9e296739fe78353
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/mfd/syscon.c: In function 'syscon_probe':
>> drivers/mfd/syscon.c:407:23: warning: variable 'syscon_config' set but not used [-Wunused-but-set-variable]
407 | struct regmap_config syscon_config = syscon_regmap_config;
| ^~~~~~~~~~~~~
vim +/syscon_config +407 drivers/mfd/syscon.c
401
402 static int syscon_probe(struct platform_device *pdev)
403 {
404 int ret;
405 struct device *dev = &pdev->dev;
406 struct syscon_platform_data *pdata = dev_get_platdata(dev);
> 407 struct regmap_config syscon_config = syscon_regmap_config;
408 struct syscon *syscon;
409 const struct syscon_driver_data *driver_data;
410
411 if (pdata)
412 syscon_config.name = pdata->label;
413
414 syscon = devm_kzalloc(dev, sizeof(*syscon), GFP_KERNEL);
415 if (!syscon)
416 return -ENOMEM;
417
418 driver_data = (const struct syscon_driver_data *)
419 platform_get_device_id(pdev)->driver_data;
420
421 ret = driver_data->probe_func(pdev, dev, syscon);
422 if (ret)
423 return ret;
424
425 platform_set_drvdata(pdev, syscon);
426
427 return 0;
428 }
429
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 8582 bytes --]
next prev parent reply other threads:[~2021-07-24 7:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 13:52 [PATCH 0/3] add SMC based regmap driver for secure syscon access Clément Léger
2021-07-23 13:52 ` [PATCH 1/3] regmap: add regmap using ARM SMCCC Clément Léger
2021-07-23 14:43 ` Mark Brown
2021-07-23 15:53 ` Clément Léger
2021-07-23 16:37 ` Mark Brown
2021-07-23 13:52 ` [PATCH 2/3] syscon: add support for "syscon-smc" compatible Clément Léger
2021-07-23 15:27 ` Lee Jones
2021-07-23 15:56 ` Clément Léger
2021-07-23 16:07 ` Arnd Bergmann
2021-07-23 16:41 ` Mark Brown
2021-07-24 12:36 ` Peng Fan (OSS)
2021-07-24 7:00 ` kernel test robot [this message]
2021-07-24 7:00 ` kernel test robot
2021-07-23 13:52 ` [PATCH 3/3] dt-bindings: mfd: add "syscon-smc" YAML description Clément Léger
2021-07-29 21:19 ` Rob Herring
2021-07-30 7:21 ` Clément Léger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202107241438.ZGxGgokJ-lkp@intel.com \
--to=lkp@intel.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=clement.leger@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@lists.01.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.