All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/htop: fix sources location
@ 2021-07-24 20:48 Daniil Stas
  2021-07-24 21:03 ` Yann E. MORIN
  0 siblings, 1 reply; 4+ messages in thread
From: Daniil Stas @ 2021-07-24 20:48 UTC (permalink / raw)
  To: buildroot; +Cc: Daniil Stas

Change sources location from bintray to github since bintray doesn't
work anymore

Signed-off-by: Daniil Stas <daniil.stas@posteo.net>
---
Backport to: 2021.02.x, 2021.05.x
---
 package/htop/htop.hash | 2 +-
 package/htop/htop.mk   | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/htop/htop.hash b/package/htop/htop.hash
index 647feabb8e..e9eb5daf4d 100644
--- a/package/htop/htop.hash
+++ b/package/htop/htop.hash
@@ -1,3 +1,3 @@
 # Locally calculated
-sha256  19535f8f01ac08be2df880c93c9cedfc50fa92320d48e3ef92a30b6edc4d1917  htop-3.0.5.tar.gz
+sha256  4c2629bd50895bd24082ba2f81f8c972348aa2298cc6edc6a21a7fa18b73990c  htop-3.0.5.tar.gz
 sha256  c228cc14df980a23ea0c3c9ac957b904dd6a8514f6283db403de22e9179471be  COPYING
diff --git a/package/htop/htop.mk b/package/htop/htop.mk
index aa2ff24750..dd801b0dc0 100644
--- a/package/htop/htop.mk
+++ b/package/htop/htop.mk
@@ -5,8 +5,9 @@
 ################################################################################
 
 HTOP_VERSION = 3.0.5
-HTOP_SITE = https://dl.bintray.com/htop/source
+HTOP_SITE = $(call github,htop-dev,htop,$(HTOP_VERSION))
 HTOP_DEPENDENCIES = ncurses
+HTOP_AUTORECONF = YES
 # Prevent htop build system from searching the host paths
 HTOP_CONF_ENV = HTOP_NCURSES_CONFIG_SCRIPT=$(STAGING_DIR)/usr/bin/$(NCURSES_CONFIG_SCRIPTS)
 HTOP_LICENSE = GPL-2.0
-- 
2.32.0

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/htop: fix sources location
  2021-07-24 20:48 [Buildroot] [PATCH 1/1] package/htop: fix sources location Daniil Stas
@ 2021-07-24 21:03 ` Yann E. MORIN
  2021-07-25  4:01   ` Baruch Siach
  0 siblings, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2021-07-24 21:03 UTC (permalink / raw)
  To: Daniil Stas; +Cc: buildroot

Daniil, All,

On 2021-07-24 20:48 +0000, Daniil Stas spake thusly:
> Change sources location from bintray to github since bintray doesn't
> work anymore
> 
> Signed-off-by: Daniil Stas <daniil.stas@posteo.net>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
> Backport to: 2021.02.x, 2021.05.x
> ---
>  package/htop/htop.hash | 2 +-
>  package/htop/htop.mk   | 3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/package/htop/htop.hash b/package/htop/htop.hash
> index 647feabb8e..e9eb5daf4d 100644
> --- a/package/htop/htop.hash
> +++ b/package/htop/htop.hash
> @@ -1,3 +1,3 @@
>  # Locally calculated
> -sha256  19535f8f01ac08be2df880c93c9cedfc50fa92320d48e3ef92a30b6edc4d1917  htop-3.0.5.tar.gz
> +sha256  4c2629bd50895bd24082ba2f81f8c972348aa2298cc6edc6a21a7fa18b73990c  htop-3.0.5.tar.gz
>  sha256  c228cc14df980a23ea0c3c9ac957b904dd6a8514f6283db403de22e9179471be  COPYING
> diff --git a/package/htop/htop.mk b/package/htop/htop.mk
> index aa2ff24750..dd801b0dc0 100644
> --- a/package/htop/htop.mk
> +++ b/package/htop/htop.mk
> @@ -5,8 +5,9 @@
>  ################################################################################
>  
>  HTOP_VERSION = 3.0.5
> -HTOP_SITE = https://dl.bintray.com/htop/source
> +HTOP_SITE = $(call github,htop-dev,htop,$(HTOP_VERSION))
>  HTOP_DEPENDENCIES = ncurses
> +HTOP_AUTORECONF = YES
>  # Prevent htop build system from searching the host paths
>  HTOP_CONF_ENV = HTOP_NCURSES_CONFIG_SCRIPT=$(STAGING_DIR)/usr/bin/$(NCURSES_CONFIG_SCRIPTS)
>  HTOP_LICENSE = GPL-2.0
> -- 
> 2.32.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/htop: fix sources location
  2021-07-24 21:03 ` Yann E. MORIN
@ 2021-07-25  4:01   ` Baruch Siach
  2021-07-25  7:14     ` Yann E. MORIN
  0 siblings, 1 reply; 4+ messages in thread
From: Baruch Siach @ 2021-07-25  4:01 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: buildroot, Daniil Stas

Hi Yann, Daniil,

On Sun, Jul 25 2021, Yann E. MORIN wrote:

> Daniil, All,
>
> On 2021-07-24 20:48 +0000, Daniil Stas spake thusly:
>> Change sources location from bintray to github since bintray doesn't
>> work anymore
>> 
>> Signed-off-by: Daniil Stas <daniil.stas@posteo.net>
>
> Applied to master, thanks.

Wouldn't tar file hash change break the sources.buildroot.net cache?

baruch

>> ---
>> Backport to: 2021.02.x, 2021.05.x
>> ---
>>  package/htop/htop.hash | 2 +-
>>  package/htop/htop.mk   | 3 ++-
>>  2 files changed, 3 insertions(+), 2 deletions(-)
>> 
>> diff --git a/package/htop/htop.hash b/package/htop/htop.hash
>> index 647feabb8e..e9eb5daf4d 100644
>> --- a/package/htop/htop.hash
>> +++ b/package/htop/htop.hash
>> @@ -1,3 +1,3 @@
>>  # Locally calculated
>> -sha256  19535f8f01ac08be2df880c93c9cedfc50fa92320d48e3ef92a30b6edc4d1917  htop-3.0.5.tar.gz
>> +sha256  4c2629bd50895bd24082ba2f81f8c972348aa2298cc6edc6a21a7fa18b73990c  htop-3.0.5.tar.gz
>>  sha256  c228cc14df980a23ea0c3c9ac957b904dd6a8514f6283db403de22e9179471be  COPYING
>> diff --git a/package/htop/htop.mk b/package/htop/htop.mk
>> index aa2ff24750..dd801b0dc0 100644
>> --- a/package/htop/htop.mk
>> +++ b/package/htop/htop.mk
>> @@ -5,8 +5,9 @@
>>  ################################################################################
>>  
>>  HTOP_VERSION = 3.0.5
>> -HTOP_SITE = https://dl.bintray.com/htop/source
>> +HTOP_SITE = $(call github,htop-dev,htop,$(HTOP_VERSION))
>>  HTOP_DEPENDENCIES = ncurses
>> +HTOP_AUTORECONF = YES
>>  # Prevent htop build system from searching the host paths
>>  HTOP_CONF_ENV = HTOP_NCURSES_CONFIG_SCRIPT=$(STAGING_DIR)/usr/bin/$(NCURSES_CONFIG_SCRIPTS)
>>  HTOP_LICENSE = GPL-2.0


-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/htop: fix sources location
  2021-07-25  4:01   ` Baruch Siach
@ 2021-07-25  7:14     ` Yann E. MORIN
  0 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2021-07-25  7:14 UTC (permalink / raw)
  To: Baruch Siach; +Cc: buildroot, Daniil Stas

Baruch, All,

On 2021-07-25 07:01 +0300, Baruch Siach spake thusly:
> On Sun, Jul 25 2021, Yann E. MORIN wrote:
> > Daniil, All,
> > On 2021-07-24 20:48 +0000, Daniil Stas spake thusly:
> >> Change sources location from bintray to github since bintray doesn't
> >> work anymore
> > Applied to master, thanks.
> Wouldn't tar file hash change break the sources.buildroot.net cache?

Damn, you're absolutely right! I've revert the change now.

Daniil, could you redo your patch, but rather than use the tag, use the
sha1 of the corresponding commit, and explain why we do so in a comment
and in the commit log?

Thanks!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-07-25  7:14 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-24 20:48 [Buildroot] [PATCH 1/1] package/htop: fix sources location Daniil Stas
2021-07-24 21:03 ` Yann E. MORIN
2021-07-25  4:01   ` Baruch Siach
2021-07-25  7:14     ` Yann E. MORIN

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.