* [Buildroot] [PATCH 1/3] package/open62541: remove unneeded files
@ 2021-02-20 16:27 Scott Fan
2021-02-20 16:27 ` [Buildroot] [PATCH 2/3] package/open62541: fix library version definition Scott Fan
` (3 more replies)
0 siblings, 4 replies; 12+ messages in thread
From: Scott Fan @ 2021-02-20 16:27 UTC (permalink / raw)
To: buildroot
Signed-off-by: Scott Fan <fancp2007@gmail.com>
---
package/open62541/open62541.mk | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/package/open62541/open62541.mk b/package/open62541/open62541.mk
index 5a9f27562a..65742e83a1 100644
--- a/package/open62541/open62541.mk
+++ b/package/open62541/open62541.mk
@@ -54,4 +54,11 @@ else
OPEN62541_CONF_OPTS += -DUA_ENABLE_PUBSUB_INFORMATIONMODEL=OFF
endif
+# Remove unneeded files
+define OPEN62541_REMOVE_UNNEEDED_FILES
+ $(RM) -r $(TARGET_DIR)/usr/share/open62541
+endef
+
+OPEN62541_POST_INSTALL_TARGET_HOOKS += OPEN62541_REMOVE_UNNEEDED_FILES
+
$(eval $(cmake-package))
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [Buildroot] [PATCH 2/3] package/open62541: fix library version definition 2021-02-20 16:27 [Buildroot] [PATCH 1/3] package/open62541: remove unneeded files Scott Fan @ 2021-02-20 16:27 ` Scott Fan 2021-02-20 22:13 ` Yann E. MORIN 2021-02-20 16:27 ` [Buildroot] [PATCH 3/3] package/open62541: bump version to 1.2 Scott Fan ` (2 subsequent siblings) 3 siblings, 1 reply; 12+ messages in thread From: Scott Fan @ 2021-02-20 16:27 UTC (permalink / raw) To: buildroot Manually specified version must start with letter 'v', otherwise, the generated version macro will be zero in the <build_dir>/src_generated/open62541/config.h file: #define UA_OPEN62541_VER_MAJOR 0 #define UA_OPEN62541_VER_MINOR 0 #define UA_OPEN62541_VER_PATCH 0 Reference from the following link: https://open62541.org/doc/current/building.html Signed-off-by: Scott Fan <fancp2007@gmail.com> --- package/open62541/open62541.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/open62541/open62541.mk b/package/open62541/open62541.mk index 65742e83a1..3f75196817 100644 --- a/package/open62541/open62541.mk +++ b/package/open62541/open62541.mk @@ -19,7 +19,7 @@ OPEN62541_LICENSE_FILES = LICENSE OPEN62541_CONF_OPTS = \ -DCMAKE_BUILD_TYPE=Release \ -DGIT_EXECUTABLE=NO \ - -DOPEN62541_VERSION=$(OPEN62541_VERSION) \ + -DOPEN62541_VERSION=v$(OPEN62541_VERSION) \ -DUA_ENABLE_HARDENING=OFF ifeq ($(BR2_PACKAGE_OPEN62541_UA_NAMESPACE_ZERO_MINIMAL),y) -- 2.25.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 2/3] package/open62541: fix library version definition 2021-02-20 16:27 ` [Buildroot] [PATCH 2/3] package/open62541: fix library version definition Scott Fan @ 2021-02-20 22:13 ` Yann E. MORIN 0 siblings, 0 replies; 12+ messages in thread From: Yann E. MORIN @ 2021-02-20 22:13 UTC (permalink / raw) To: buildroot Scott, All, On 2021-02-21 00:27 +0800, Scott Fan spake thusly: > Manually specified version must start with letter 'v', > otherwise, the generated version macro will be zero > in the <build_dir>/src_generated/open62541/config.h file: > #define UA_OPEN62541_VER_MAJOR 0 > #define UA_OPEN62541_VER_MINOR 0 > #define UA_OPEN62541_VER_PATCH 0 > > Reference from the following link: > https://open62541.org/doc/current/building.html > > Signed-off-by: Scott Fan <fancp2007@gmail.com> Applied to master, thanks. Regards, Yann E. MORIN. > --- > package/open62541/open62541.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/open62541/open62541.mk b/package/open62541/open62541.mk > index 65742e83a1..3f75196817 100644 > --- a/package/open62541/open62541.mk > +++ b/package/open62541/open62541.mk > @@ -19,7 +19,7 @@ OPEN62541_LICENSE_FILES = LICENSE > OPEN62541_CONF_OPTS = \ > -DCMAKE_BUILD_TYPE=Release \ > -DGIT_EXECUTABLE=NO \ > - -DOPEN62541_VERSION=$(OPEN62541_VERSION) \ > + -DOPEN62541_VERSION=v$(OPEN62541_VERSION) \ > -DUA_ENABLE_HARDENING=OFF > > ifeq ($(BR2_PACKAGE_OPEN62541_UA_NAMESPACE_ZERO_MINIMAL),y) > -- > 2.25.1 > > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 3/3] package/open62541: bump version to 1.2 2021-02-20 16:27 [Buildroot] [PATCH 1/3] package/open62541: remove unneeded files Scott Fan 2021-02-20 16:27 ` [Buildroot] [PATCH 2/3] package/open62541: fix library version definition Scott Fan @ 2021-02-20 16:27 ` Scott Fan 2021-03-16 21:41 ` Thomas Petazzoni 2021-02-20 22:20 ` [Buildroot] [PATCH 1/3] package/open62541: remove unneeded files Yann E. MORIN 2021-02-22 5:39 ` [Buildroot] [PATCH] package/open62541: cleanup tools files after installation Scott Fan 3 siblings, 1 reply; 12+ messages in thread From: Scott Fan @ 2021-02-20 16:27 UTC (permalink / raw) To: buildroot Signed-off-by: Scott Fan <fancp2007@gmail.com> --- ...02-arch-posix-CMakeLists.txt-fix-build-without-threads.patch | 2 +- package/open62541/open62541.hash | 2 +- package/open62541/open62541.mk | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package/open62541/0002-arch-posix-CMakeLists.txt-fix-build-without-threads.patch b/package/open62541/0002-arch-posix-CMakeLists.txt-fix-build-without-threads.patch index 94ee76ad92..bdf3608041 100644 --- a/package/open62541/0002-arch-posix-CMakeLists.txt-fix-build-without-threads.patch +++ b/package/open62541/0002-arch-posix-CMakeLists.txt-fix-build-without-threads.patch @@ -29,7 +29,7 @@ index bb24757c..a53c9f2c 100644 ua_architecture_append_to_library(m) - #TODO - Error on first make run if pthread is included conditional? - ua_architecture_append_to_library(pthread) - if(UA_ENABLE_MULTITHREADING OR UA_BUILD_UNIT_TESTS) + if(UA_MULTITHREADING OR UA_BUILD_UNIT_TESTS) ua_architecture_append_to_library(pthread) endif() -- diff --git a/package/open62541/open62541.hash b/package/open62541/open62541.hash index 3da8c8f5fb..11414085c3 100644 --- a/package/open62541/open62541.hash +++ b/package/open62541/open62541.hash @@ -1,3 +1,3 @@ # Locally calculated -sha256 36273793e5247586fadaa73c0edad89be610100cbc839d1fb5f567f20c3cbc44 open62541-1.0-br1.tar.gz +sha256 38a8f9af14548ee9b04655eedb996f741032f7040ff9118bba853c0718d5e978 open62541-1.2-br1.tar.gz sha256 fab3dd6bdab226f1c08630b1dd917e11fcb4ec5e1e020e2c16f83a0a13863e85 LICENSE diff --git a/package/open62541/open62541.mk b/package/open62541/open62541.mk index 3f75196817..7e4058e29d 100644 --- a/package/open62541/open62541.mk +++ b/package/open62541/open62541.mk @@ -4,7 +4,7 @@ # ################################################################################ -OPEN62541_VERSION = 1.0 +OPEN62541_VERSION = 1.2 OPEN62541_DL_VERSION = v$(OPEN62541_VERSION) OPEN62541_SITE_METHOD = git OPEN62541_SITE = git://github.com/open62541/open62541.git -- 2.25.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 3/3] package/open62541: bump version to 1.2 2021-02-20 16:27 ` [Buildroot] [PATCH 3/3] package/open62541: bump version to 1.2 Scott Fan @ 2021-03-16 21:41 ` Thomas Petazzoni 2021-03-20 4:02 ` Scott Fan 0 siblings, 1 reply; 12+ messages in thread From: Thomas Petazzoni @ 2021-03-16 21:41 UTC (permalink / raw) To: buildroot On Sun, 21 Feb 2021 00:27:15 +0800 Scott Fan <fancp2007@gmail.com> wrote: > diff --git a/package/open62541/open62541.hash b/package/open62541/open62541.hash > index 3da8c8f5fb..11414085c3 100644 > --- a/package/open62541/open62541.hash > +++ b/package/open62541/open62541.hash > @@ -1,3 +1,3 @@ > # Locally calculated > -sha256 36273793e5247586fadaa73c0edad89be610100cbc839d1fb5f567f20c3cbc44 open62541-1.0-br1.tar.gz > +sha256 38a8f9af14548ee9b04655eedb996f741032f7040ff9118bba853c0718d5e978 open62541-1.2-br1.tar.gz > sha256 fab3dd6bdab226f1c08630b1dd917e11fcb4ec5e1e020e2c16f83a0a13863e85 LICENSE I am afraid this doesn't work here: >>> open62541 1.2 Downloading Reinitialized existing Git repository in /home/thomas/dl/open62541/git/.git/ Fetching all references remote: Enumerating objects: 633, done. remote: Counting objects: 100% (633/633), done. remote: Compressing objects: 100% (10/10), done. remote: Total 854 (delta 623), reused 633 (delta 623), pack-reused 221 Receiving objects: 100% (854/854), 398.44 KiB | 1.26 MiB/s, done. Resolving deltas: 100% (673/673), completed with 201 local objects. From git://github.com/open62541/open62541 33f1885b..f642222c 1.1 -> origin/1.1 def0642c..875d33a9 1.2 -> origin/1.2 * [new branch] fix_master_backport -> origin/fix_master_backport 563b150d..7bde5f2b master -> origin/master + 0f26511b...d0fc7ff1 pack/1.1 -> origin/pack/1.1 (forced update) * [new tag] v1.2 -> v1.2 Fetching submodule deps/ua-nodeset From https://github.com/OPCFoundation/UA-Nodeset 9c80cf6..9ba5c13 v1.04 -> origin/v1.04 * [new tag] UA-1.04.9-2021-01-21 -> UA-1.04.9-2021-01-21 * [new tag] Machinery-1.01.0-2021-02-25 -> Machinery-1.01.0-2021-02-25 Deregistering submodule "deps/mdnsd" Deregistering submodule "deps/ua-nodeset" Submodule path 'deps/mdnsd': checked out '3151afe5899dba5125dffa9f4cf3ae1fe2edc0f0' Submodule path 'deps/ua-nodeset': checked out '393b633468a5d1d062dd253e1488d1d8ba335b6f' ERROR: open62541-1.2-br1.tar.gz has wrong sha256 hash: ERROR: expected: 38a8f9af14548ee9b04655eedb996f741032f7040ff9118bba853c0718d5e978 ERROR: got : 928789032b67e92f0d546aedd521cf91cfb5ca3e12d714cbc01681d0afbda047 ERROR: Incomplete download, or man-in-the-middle (MITM) attack --2021-03-16 22:40:11-- http://sources.buildroot.net/open62541/open62541-1.2-br1.tar.gz Resolving sources.buildroot.net (sources.buildroot.net)... 104.26.0.37, 104.26.1.37, 172.67.72.56, ... Connecting to sources.buildroot.net (sources.buildroot.net)|104.26.0.37|:80... connected. HTTP request sent, awaiting response... 404 Not Found 2021-03-16 22:40:12 ERROR 404: Not Found. --2021-03-16 22:40:12-- http://sources.buildroot.net/open62541-1.2-br1.tar.gz Resolving sources.buildroot.net (sources.buildroot.net)... 172.67.72.56, 104.26.1.37, 104.26.0.37, ... Connecting to sources.buildroot.net (sources.buildroot.net)|172.67.72.56|:80... connected. HTTP request sent, awaiting response... 404 Not Found 2021-03-16 22:40:12 ERROR 404: Not Found. make: *** [package/pkg-generic.mk:148: /home/thomas/projets/buildroot/output/build/open62541-1.2/.stamp_downloaded] Error 1 Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 3/3] package/open62541: bump version to 1.2 2021-03-16 21:41 ` Thomas Petazzoni @ 2021-03-20 4:02 ` Scott Fan 2021-03-24 0:22 ` Scott Fan 0 siblings, 1 reply; 12+ messages in thread From: Scott Fan @ 2021-03-20 4:02 UTC (permalink / raw) To: buildroot Thanks, I'll check it out. Scott Fan On Wed, Mar 17, 2021 at 5:41 AM Thomas Petazzoni < thomas.petazzoni@bootlin.com> wrote: > On Sun, 21 Feb 2021 00:27:15 +0800 > Scott Fan <fancp2007@gmail.com> wrote: > > > > diff --git a/package/open62541/open62541.hash > b/package/open62541/open62541.hash > > index 3da8c8f5fb..11414085c3 100644 > > --- a/package/open62541/open62541.hash > > +++ b/package/open62541/open62541.hash > > @@ -1,3 +1,3 @@ > > # Locally calculated > > -sha256 > 36273793e5247586fadaa73c0edad89be610100cbc839d1fb5f567f20c3cbc44 > open62541-1.0-br1.tar.gz > > +sha256 > 38a8f9af14548ee9b04655eedb996f741032f7040ff9118bba853c0718d5e978 > open62541-1.2-br1.tar.gz > > sha256 > fab3dd6bdab226f1c08630b1dd917e11fcb4ec5e1e020e2c16f83a0a13863e85 LICENSE > > I am afraid this doesn't work here: > > >>> open62541 1.2 Downloading > Reinitialized existing Git repository in > /home/thomas/dl/open62541/git/.git/ > Fetching all references > remote: Enumerating objects: 633, done. > remote: Counting objects: 100% (633/633), done. > remote: Compressing objects: 100% (10/10), done. > remote: Total 854 (delta 623), reused 633 (delta 623), pack-reused 221 > Receiving objects: 100% (854/854), 398.44 KiB | 1.26 MiB/s, done. > Resolving deltas: 100% (673/673), completed with 201 local objects. > From git://github.com/open62541/open62541 > 33f1885b..f642222c 1.1 -> origin/1.1 > def0642c..875d33a9 1.2 -> origin/1.2 > * [new branch] fix_master_backport -> origin/fix_master_backport > 563b150d..7bde5f2b master -> origin/master > + 0f26511b...d0fc7ff1 pack/1.1 -> origin/pack/1.1 (forced > update) > * [new tag] v1.2 -> v1.2 > Fetching submodule deps/ua-nodeset > From https://github.com/OPCFoundation/UA-Nodeset > 9c80cf6..9ba5c13 v1.04 -> origin/v1.04 > * [new tag] UA-1.04.9-2021-01-21 -> UA-1.04.9-2021-01-21 > * [new tag] Machinery-1.01.0-2021-02-25 -> > Machinery-1.01.0-2021-02-25 > Deregistering submodule "deps/mdnsd" > Deregistering submodule "deps/ua-nodeset" > Submodule path 'deps/mdnsd': checked out > '3151afe5899dba5125dffa9f4cf3ae1fe2edc0f0' > Submodule path 'deps/ua-nodeset': checked out > '393b633468a5d1d062dd253e1488d1d8ba335b6f' > ERROR: open62541-1.2-br1.tar.gz has wrong sha256 hash: > ERROR: expected: > 38a8f9af14548ee9b04655eedb996f741032f7040ff9118bba853c0718d5e978 > ERROR: got : > 928789032b67e92f0d546aedd521cf91cfb5ca3e12d714cbc01681d0afbda047 > ERROR: Incomplete download, or man-in-the-middle (MITM) attack > --2021-03-16 22:40:11-- > http://sources.buildroot.net/open62541/open62541-1.2-br1.tar.gz > Resolving sources.buildroot.net (sources.buildroot.net)... 104.26.0.37, > 104.26.1.37, 172.67.72.56, ... > Connecting to sources.buildroot.net (sources.buildroot.net)|104.26.0.37|:80... > connected. > HTTP request sent, awaiting response... 404 Not Found > 2021-03-16 22:40:12 ERROR 404: Not Found. > > --2021-03-16 22:40:12-- > http://sources.buildroot.net/open62541-1.2-br1.tar.gz > Resolving sources.buildroot.net (sources.buildroot.net)... 172.67.72.56, > 104.26.1.37, 104.26.0.37, ... > Connecting to sources.buildroot.net (sources.buildroot.net)|172.67.72.56|:80... > connected. > HTTP request sent, awaiting response... 404 Not Found > 2021-03-16 22:40:12 ERROR 404: Not Found. > > make: *** [package/pkg-generic.mk:148: > /home/thomas/projets/buildroot/output/build/open62541-1.2/.stamp_downloaded] > Error 1 > > Thomas > -- > Thomas Petazzoni, co-owner and CEO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20210320/6009327d/attachment.html> ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 3/3] package/open62541: bump version to 1.2 2021-03-20 4:02 ` Scott Fan @ 2021-03-24 0:22 ` Scott Fan 0 siblings, 0 replies; 12+ messages in thread From: Scott Fan @ 2021-03-24 0:22 UTC (permalink / raw) To: buildroot Hi, Thomas Sorry for that I can't fix the open62541-1.2-br1.tar.gz file's sha256 hash, it's 38a8f9af14548ee9b04655eedb996f741032f7040ff9118bba853c0718d5e978 at Feb 21, In your reply, it's 928789032b67e92f0d546aedd521cf91cfb5ca3e12d714cbc01681d0afbda047 at Mar 17, But nowadays, it's 53119dbd12fae8d7e0a3173d42a9fde2ec9d6f17799000b67ce269a0597143a4 at Mar 24. I am afraid the checksum mechanism for git submodules downloading has some defect, but i can't locate it. Scott Fan On Sat, Mar 20, 2021 at 12:02 PM Scott Fan <fancp2007@gmail.com> wrote: > Thanks, I'll check it out. > > Scott Fan > > > On Wed, Mar 17, 2021 at 5:41 AM Thomas Petazzoni < > thomas.petazzoni at bootlin.com> wrote: > >> On Sun, 21 Feb 2021 00:27:15 +0800 >> Scott Fan <fancp2007@gmail.com> wrote: >> >> >> > diff --git a/package/open62541/open62541.hash >> b/package/open62541/open62541.hash >> > index 3da8c8f5fb..11414085c3 100644 >> > --- a/package/open62541/open62541.hash >> > +++ b/package/open62541/open62541.hash >> > @@ -1,3 +1,3 @@ >> > # Locally calculated >> > -sha256 >> 36273793e5247586fadaa73c0edad89be610100cbc839d1fb5f567f20c3cbc44 >> open62541-1.0-br1.tar.gz >> > +sha256 >> 38a8f9af14548ee9b04655eedb996f741032f7040ff9118bba853c0718d5e978 >> open62541-1.2-br1.tar.gz >> > sha256 >> fab3dd6bdab226f1c08630b1dd917e11fcb4ec5e1e020e2c16f83a0a13863e85 LICENSE >> >> I am afraid this doesn't work here: >> >> >>> open62541 1.2 Downloading >> Reinitialized existing Git repository in >> /home/thomas/dl/open62541/git/.git/ >> Fetching all references >> remote: Enumerating objects: 633, done. >> remote: Counting objects: 100% (633/633), done. >> remote: Compressing objects: 100% (10/10), done. >> remote: Total 854 (delta 623), reused 633 (delta 623), pack-reused 221 >> Receiving objects: 100% (854/854), 398.44 KiB | 1.26 MiB/s, done. >> Resolving deltas: 100% (673/673), completed with 201 local objects. >> From git://github.com/open62541/open62541 >> 33f1885b..f642222c 1.1 -> origin/1.1 >> def0642c..875d33a9 1.2 -> origin/1.2 >> * [new branch] fix_master_backport -> origin/fix_master_backport >> 563b150d..7bde5f2b master -> origin/master >> + 0f26511b...d0fc7ff1 pack/1.1 -> origin/pack/1.1 (forced >> update) >> * [new tag] v1.2 -> v1.2 >> Fetching submodule deps/ua-nodeset >> From https://github.com/OPCFoundation/UA-Nodeset >> 9c80cf6..9ba5c13 v1.04 -> origin/v1.04 >> * [new tag] UA-1.04.9-2021-01-21 -> UA-1.04.9-2021-01-21 >> * [new tag] Machinery-1.01.0-2021-02-25 -> >> Machinery-1.01.0-2021-02-25 >> Deregistering submodule "deps/mdnsd" >> Deregistering submodule "deps/ua-nodeset" >> Submodule path 'deps/mdnsd': checked out >> '3151afe5899dba5125dffa9f4cf3ae1fe2edc0f0' >> Submodule path 'deps/ua-nodeset': checked out >> '393b633468a5d1d062dd253e1488d1d8ba335b6f' >> ERROR: open62541-1.2-br1.tar.gz has wrong sha256 hash: >> ERROR: expected: >> 38a8f9af14548ee9b04655eedb996f741032f7040ff9118bba853c0718d5e978 >> ERROR: got : >> 928789032b67e92f0d546aedd521cf91cfb5ca3e12d714cbc01681d0afbda047 >> ERROR: Incomplete download, or man-in-the-middle (MITM) attack >> --2021-03-16 22:40:11-- >> http://sources.buildroot.net/open62541/open62541-1.2-br1.tar.gz >> Resolving sources.buildroot.net (sources.buildroot.net)... 104.26.0.37, >> 104.26.1.37, 172.67.72.56, ... >> Connecting to sources.buildroot.net (sources.buildroot.net)|104.26.0.37|:80... >> connected. >> HTTP request sent, awaiting response... 404 Not Found >> 2021-03-16 22:40:12 ERROR 404: Not Found. >> >> --2021-03-16 22:40:12-- >> http://sources.buildroot.net/open62541-1.2-br1.tar.gz >> Resolving sources.buildroot.net (sources.buildroot.net)... 172.67.72.56, >> 104.26.1.37, 104.26.0.37, ... >> Connecting to sources.buildroot.net (sources.buildroot.net)|172.67.72.56|:80... >> connected. >> HTTP request sent, awaiting response... 404 Not Found >> 2021-03-16 22:40:12 ERROR 404: Not Found. >> >> make: *** [package/pkg-generic.mk:148: >> /home/thomas/projets/buildroot/output/build/open62541-1.2/.stamp_downloaded] >> Error 1 >> >> Thomas >> -- >> Thomas Petazzoni, co-owner and CEO, Bootlin >> Embedded Linux and Kernel engineering >> https://bootlin.com >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20210324/4133d0f0/attachment.html> ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 1/3] package/open62541: remove unneeded files 2021-02-20 16:27 [Buildroot] [PATCH 1/3] package/open62541: remove unneeded files Scott Fan 2021-02-20 16:27 ` [Buildroot] [PATCH 2/3] package/open62541: fix library version definition Scott Fan 2021-02-20 16:27 ` [Buildroot] [PATCH 3/3] package/open62541: bump version to 1.2 Scott Fan @ 2021-02-20 22:20 ` Yann E. MORIN 2021-02-22 5:39 ` [Buildroot] [PATCH] package/open62541: cleanup tools files after installation Scott Fan 3 siblings, 0 replies; 12+ messages in thread From: Yann E. MORIN @ 2021-02-20 22:20 UTC (permalink / raw) To: buildroot Scott, All, On 2021-02-21 00:27 +0800, Scott Fan spake thusly: > Signed-off-by: Scott Fan <fancp2007@gmail.com> > --- > package/open62541/open62541.mk | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/package/open62541/open62541.mk b/package/open62541/open62541.mk > index 5a9f27562a..65742e83a1 100644 > --- a/package/open62541/open62541.mk > +++ b/package/open62541/open62541.mk > @@ -54,4 +54,11 @@ else > OPEN62541_CONF_OPTS += -DUA_ENABLE_PUBSUB_INFORMATIONMODEL=OFF > endif > > +# Remove unneeded files > +define OPEN62541_REMOVE_UNNEEDED_FILES > + $(RM) -r $(TARGET_DIR)/usr/share/open62541 Are you sure that we want to remove the whole dorectory? There are some tools in there that look like they might be useful. But hte whole directory is indeed 52MiB, with 51 for the 'ua-nodeset' alone (whatever that is), so maybe we do indeed need to do some cleanup. So, could you please respin this patch: - if really nothing is needed in that directory, then remove everything liek you did, but extend the commit log to explain why nothing in there is required, - if there are stuff that can be useful at runtime, then rework the hook to be a bit more selective in what it removes. Regards, Yann E. MORIN. > +endef > + > +OPEN62541_POST_INSTALL_TARGET_HOOKS += OPEN62541_REMOVE_UNNEEDED_FILES > + > $(eval $(cmake-package)) > -- > 2.25.1 > > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH] package/open62541: cleanup tools files after installation 2021-02-20 16:27 [Buildroot] [PATCH 1/3] package/open62541: remove unneeded files Scott Fan ` (2 preceding siblings ...) 2021-02-20 22:20 ` [Buildroot] [PATCH 1/3] package/open62541: remove unneeded files Yann E. MORIN @ 2021-02-22 5:39 ` Scott Fan 2021-03-16 22:16 ` Thomas Petazzoni 2021-07-25 21:58 ` Thomas Petazzoni 3 siblings, 2 replies; 12+ messages in thread From: Scott Fan @ 2021-02-22 5:39 UTC (permalink / raw) To: buildroot The open62541 tools directory is indeed 52 MiB, which built as a standalone package named 'libopen62541-1-tools' in launchpad. Nothing is required at runtime. See the official debian control file template: https://raw.githubusercontent.com/open62541/open62541/master/debian/control-template See https://launchpad.net/~open62541-team/+archive/ubuntu/ppa/+packages libopen62541-1 Open source implementation of OPC UA - shared library libopen62541-1-dev Open source implementation of OPC UA - development files libopen62541-1-tools Open source implementation of OPC UA - tools open62541-doc Open source implementation of OPC UA - documentation Signed-off-by: Scott Fan <fancp2007@gmail.com> --- Changes v1 -> v2: - extend the commit log to explain why nothing in there is required. --- package/open62541/open62541.mk | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/package/open62541/open62541.mk b/package/open62541/open62541.mk index 102e09a429..3f75196817 100644 --- a/package/open62541/open62541.mk +++ b/package/open62541/open62541.mk @@ -54,4 +54,11 @@ else OPEN62541_CONF_OPTS += -DUA_ENABLE_PUBSUB_INFORMATIONMODEL=OFF endif +# Remove unneeded files +define OPEN62541_REMOVE_UNNEEDED_FILES + $(RM) -r $(TARGET_DIR)/usr/share/open62541 +endef + +OPEN62541_POST_INSTALL_TARGET_HOOKS += OPEN62541_REMOVE_UNNEEDED_FILES + $(eval $(cmake-package)) -- 2.25.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH] package/open62541: cleanup tools files after installation 2021-02-22 5:39 ` [Buildroot] [PATCH] package/open62541: cleanup tools files after installation Scott Fan @ 2021-03-16 22:16 ` Thomas Petazzoni 2021-03-17 10:33 ` Yann Cardaillac 2021-07-25 21:58 ` Thomas Petazzoni 1 sibling, 1 reply; 12+ messages in thread From: Thomas Petazzoni @ 2021-03-16 22:16 UTC (permalink / raw) To: buildroot Hello, Thanks for the patch. Yann, since you contributed this package, could you give your opinion on this? It is quite important, as 52 MiB on the target is really huge. Thanks a lot, Thomas On Mon, 22 Feb 2021 13:39:52 +0800 Scott Fan <fancp2007@gmail.com> wrote: > The open62541 tools directory is indeed 52 MiB, which built as a standalone package > named 'libopen62541-1-tools' in launchpad. Nothing is required at runtime. > > See the official debian control file template: > https://raw.githubusercontent.com/open62541/open62541/master/debian/control-template > > See https://launchpad.net/~open62541-team/+archive/ubuntu/ppa/+packages > libopen62541-1 Open source implementation of OPC UA - shared library > libopen62541-1-dev Open source implementation of OPC UA - development files > libopen62541-1-tools Open source implementation of OPC UA - tools > open62541-doc Open source implementation of OPC UA - documentation > > Signed-off-by: Scott Fan <fancp2007@gmail.com> > > --- > Changes v1 -> v2: > - extend the commit log to explain why nothing in there is required. > --- > package/open62541/open62541.mk | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/package/open62541/open62541.mk b/package/open62541/open62541.mk > index 102e09a429..3f75196817 100644 > --- a/package/open62541/open62541.mk > +++ b/package/open62541/open62541.mk > @@ -54,4 +54,11 @@ else > OPEN62541_CONF_OPTS += -DUA_ENABLE_PUBSUB_INFORMATIONMODEL=OFF > endif > > +# Remove unneeded files > +define OPEN62541_REMOVE_UNNEEDED_FILES > + $(RM) -r $(TARGET_DIR)/usr/share/open62541 > +endef > + > +OPEN62541_POST_INSTALL_TARGET_HOOKS += OPEN62541_REMOVE_UNNEEDED_FILES > + > $(eval $(cmake-package)) -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH] package/open62541: cleanup tools files after installation 2021-03-16 22:16 ` Thomas Petazzoni @ 2021-03-17 10:33 ` Yann Cardaillac 0 siblings, 0 replies; 12+ messages in thread From: Yann Cardaillac @ 2021-03-17 10:33 UTC (permalink / raw) To: buildroot Hi Thomas, Scott, We didn't really used open6241 yet, so we did not really go further with the integration. However I've just built the package in buildroot mainline, here's the size of output/target/usr/share/open62541/ : $ du -h output/target/usr/share/open62541/ 20K output/target/usr/share/open62541/tools/certs 1,1M output/target/usr/share/open62541/tools/schema 2,4M output/target/usr/share/open62541/tools/ua-nodeset/MTConnect 988K output/target/usr/share/open62541/tools/ua-nodeset/TMC 228K output/target/usr/share/open62541/tools/ua-nodeset/ISA-95 3,1M output/target/usr/share/open62541/tools/ua-nodeset/FDI 1,2M output/target/usr/share/open62541/tools/ua-nodeset/GDS 3,3M output/target/usr/share/open62541/tools/ua-nodeset/ADI 24K output/target/usr/share/open62541/tools/ua-nodeset/CSPPlusForMachine 2,6M output/target/usr/share/open62541/tools/ua-nodeset/AnsiC 31M output/target/usr/share/open62541/tools/ua-nodeset/Schema 2,9M output/target/usr/share/open62541/tools/ua-nodeset/POWERLINK 192K output/target/usr/share/open62541/tools/ua-nodeset/Sercos 880K output/target/usr/share/open62541/tools/ua-nodeset/DotNet 276K output/target/usr/share/open62541/tools/ua-nodeset/PLCopen 1016K output/target/usr/share/open62541/tools/ua-nodeset/DI 824K output/target/usr/share/open62541/tools/ua-nodeset/MDIS 51M output/target/usr/share/open62541/tools/ua-nodeset 160K output/target/usr/share/open62541/tools/nodeset_compiler 52M output/target/usr/share/open62541/tools 52M output/target/usr/share/open62541/ To be honnest I don't really know what those are for, from my point of view the only people that can answer that question would be open62541 devs. In ua-nodeset we can find some .cs, .csv, .xml, .uanodes, .bsd, .xsd, .h, .wsdl, .c ... I would agree on the fact that most of them are probably useless, but I can't give you strong insight on this. I've added Julius Pfrommer that is one of the biggest contributor to open62541 in the hope that he could give us some advice. Best regards, Yann CARDAILLAC Ing?nieur d?veloppement logiciel SEPRO Robotique - 88 Rue Henry Bessemer - Zone Ajoncs Ouest - CS 10084 - 85003 La Roche sur Yon Cedex (France) [ http://www.sepro-group.com/fr | www.sepro-group.com ] | [ https://twitter.com/seprogroup | @SeproGroup ] ----- Mail original ----- De: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com> ?: "Scott Fan" <fancp2007@gmail.com>, "Yann Cardaillac" <ycardaillac@sepro-group.com> Cc: buildroot at buildroot.org Envoy?: Mardi 16 Mars 2021 23:16:40 Objet: Re: [Buildroot] [PATCH] package/open62541: cleanup tools files after installation Hello, Thanks for the patch. Yann, since you contributed this package, could you give your opinion on this? It is quite important, as 52 MiB on the target is really huge. Thanks a lot, Thomas On Mon, 22 Feb 2021 13:39:52 +0800 Scott Fan <fancp2007@gmail.com> wrote: > The open62541 tools directory is indeed 52 MiB, which built as a standalone package > named 'libopen62541-1-tools' in launchpad. Nothing is required at runtime. > > See the official debian control file template: > https://raw.githubusercontent.com/open62541/open62541/master/debian/control-template > > See https://launchpad.net/~open62541-team/+archive/ubuntu/ppa/+packages > libopen62541-1 Open source implementation of OPC UA - shared library > libopen62541-1-dev Open source implementation of OPC UA - development files > libopen62541-1-tools Open source implementation of OPC UA - tools > open62541-doc Open source implementation of OPC UA - documentation > > Signed-off-by: Scott Fan <fancp2007@gmail.com> > > --- > Changes v1 -> v2: > - extend the commit log to explain why nothing in there is required. > --- > package/open62541/open62541.mk | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/package/open62541/open62541.mk b/package/open62541/open62541.mk > index 102e09a429..3f75196817 100644 > --- a/package/open62541/open62541.mk > +++ b/package/open62541/open62541.mk > @@ -54,4 +54,11 @@ else > OPEN62541_CONF_OPTS += -DUA_ENABLE_PUBSUB_INFORMATIONMODEL=OFF > endif > > +# Remove unneeded files > +define OPEN62541_REMOVE_UNNEEDED_FILES > + $(RM) -r $(TARGET_DIR)/usr/share/open62541 > +endef > + > +OPEN62541_POST_INSTALL_TARGET_HOOKS += OPEN62541_REMOVE_UNNEEDED_FILES > + > $(eval $(cmake-package)) -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Buildroot] [PATCH] package/open62541: cleanup tools files after installation 2021-02-22 5:39 ` [Buildroot] [PATCH] package/open62541: cleanup tools files after installation Scott Fan 2021-03-16 22:16 ` Thomas Petazzoni @ 2021-07-25 21:58 ` Thomas Petazzoni 1 sibling, 0 replies; 12+ messages in thread From: Thomas Petazzoni @ 2021-07-25 21:58 UTC (permalink / raw) To: Scott Fan; +Cc: Yann CARDAILLAC, buildroot On Mon, 22 Feb 2021 13:39:52 +0800 Scott Fan <fancp2007@gmail.com> wrote: > The open62541 tools directory is indeed 52 MiB, which built as a standalone package > named 'libopen62541-1-tools' in launchpad. Nothing is required at runtime. > > See the official debian control file template: > https://raw.githubusercontent.com/open62541/open62541/master/debian/control-template > > See https://launchpad.net/~open62541-team/+archive/ubuntu/ppa/+packages > libopen62541-1 Open source implementation of OPC UA - shared library > libopen62541-1-dev Open source implementation of OPC UA - development files > libopen62541-1-tools Open source implementation of OPC UA - tools > open62541-doc Open source implementation of OPC UA - documentation > > Signed-off-by: Scott Fan <fancp2007@gmail.com> > > --- > Changes v1 -> v2: > - extend the commit log to explain why nothing in there is required. > --- > package/open62541/open62541.mk | 7 +++++++ > 1 file changed, 7 insertions(+) As there hasn't been a definitive feedback from Yann Cardaillac, I decided to simply apply your patch, as the justification based on the Ubuntu packaging made sense to me. Thanks! Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list buildroot@busybox.net http://lists.busybox.net/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2021-07-25 21:58 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-02-20 16:27 [Buildroot] [PATCH 1/3] package/open62541: remove unneeded files Scott Fan 2021-02-20 16:27 ` [Buildroot] [PATCH 2/3] package/open62541: fix library version definition Scott Fan 2021-02-20 22:13 ` Yann E. MORIN 2021-02-20 16:27 ` [Buildroot] [PATCH 3/3] package/open62541: bump version to 1.2 Scott Fan 2021-03-16 21:41 ` Thomas Petazzoni 2021-03-20 4:02 ` Scott Fan 2021-03-24 0:22 ` Scott Fan 2021-02-20 22:20 ` [Buildroot] [PATCH 1/3] package/open62541: remove unneeded files Yann E. MORIN 2021-02-22 5:39 ` [Buildroot] [PATCH] package/open62541: cleanup tools files after installation Scott Fan 2021-03-16 22:16 ` Thomas Petazzoni 2021-03-17 10:33 ` Yann Cardaillac 2021-07-25 21:58 ` Thomas Petazzoni
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.