All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] spi: nxp_fspi: Ensure width is respected in spi-mem operations
@ 2021-07-26 19:35 Michael Walle
  2021-07-26 19:46 ` Pratyush Yadav
  0 siblings, 1 reply; 2+ messages in thread
From: Michael Walle @ 2021-07-26 19:35 UTC (permalink / raw)
  To: u-boot; +Cc: Jagan Teki, Pratyush Yadav, Michael Walle

Import linux commit 007773e16a6f ("spi: nxp-fspi: Ensure width is
respected in spi-mem operations") to fix SPI access on boards which
don't have all SPI I/O lines connected to the flash.

Since commit 71025f013ccb ("mtd: spi-nor-core: Rework hwcaps selection")
u-boot figures out the capabilities by looking at spi_mem_supports_op().
The FlexSPI driver doesn't take the board layout into account. Fix that.

Fixes: 383fded70c4f ("spi: nxp_fspi: new driver for the FlexSPI controller")
Signed-off-by: Michael Walle <michael@walle.cc>
---
 drivers/spi/nxp_fspi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/nxp_fspi.c b/drivers/spi/nxp_fspi.c
index 6c5bad4c2c..bba7a330e0 100644
--- a/drivers/spi/nxp_fspi.c
+++ b/drivers/spi/nxp_fspi.c
@@ -428,7 +428,7 @@ static bool nxp_fspi_supports_op(struct spi_slave *slave,
 	    op->data.nbytes > f->devtype_data->txfifo)
 		return false;
 
-	return true;
+	return spi_mem_default_supports_op(slave, op);
 }
 
 /* Instead of busy looping invoke readl_poll_sleep_timeout functionality. */
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] spi: nxp_fspi: Ensure width is respected in spi-mem operations
  2021-07-26 19:35 [PATCH] spi: nxp_fspi: Ensure width is respected in spi-mem operations Michael Walle
@ 2021-07-26 19:46 ` Pratyush Yadav
  0 siblings, 0 replies; 2+ messages in thread
From: Pratyush Yadav @ 2021-07-26 19:46 UTC (permalink / raw)
  To: Michael Walle; +Cc: u-boot, Jagan Teki

On 26/07/21 09:35PM, Michael Walle wrote:
> Import linux commit 007773e16a6f ("spi: nxp-fspi: Ensure width is
> respected in spi-mem operations") to fix SPI access on boards which
> don't have all SPI I/O lines connected to the flash.
> 
> Since commit 71025f013ccb ("mtd: spi-nor-core: Rework hwcaps selection")
> u-boot figures out the capabilities by looking at spi_mem_supports_op().
> The FlexSPI driver doesn't take the board layout into account. Fix that.
> 
> Fixes: 383fded70c4f ("spi: nxp_fspi: new driver for the FlexSPI controller")
> Signed-off-by: Michael Walle <michael@walle.cc>

Reviewed-by: Pratyush Yadav <p.yadav@ti.com>

-- 
Regards,
Pratyush Yadav
Texas Instruments Inc.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-26 19:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-26 19:35 [PATCH] spi: nxp_fspi: Ensure width is respected in spi-mem operations Michael Walle
2021-07-26 19:46 ` Pratyush Yadav

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.