* [Buildroot] [PATCH v2 1/1] package/libtirpc: add missing !BR2_STATIC_LIBS dependency
@ 2021-07-25 21:34 James Hilliard
2021-07-25 21:45 ` Petr Vorel
2021-07-26 21:44 ` Thomas Petazzoni
0 siblings, 2 replies; 6+ messages in thread
From: James Hilliard @ 2021-07-25 21:34 UTC (permalink / raw)
To: buildroot; +Cc: James Hilliard, Thomas Petazzoni
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
Changes v1 -> v2:
- add comment requiring dynamic libraries
---
package/libtirpc/Config.in | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/package/libtirpc/Config.in b/package/libtirpc/Config.in
index 1899edefbf..31f1636ef5 100644
--- a/package/libtirpc/Config.in
+++ b/package/libtirpc/Config.in
@@ -10,6 +10,7 @@ config BR2_PACKAGE_LIBTIRPC
config BR2_PACKAGE_LIBTIRPC_GSS
bool "gss"
depends on BR2_USE_MMU # libkrb5
+ depends on !BR2_STATIC_LIBS # libkrb5
depends on BR2_PACKAGE_LIBTIRPC
select BR2_PACKAGE_LIBKRB5
help
@@ -17,3 +18,8 @@ config BR2_PACKAGE_LIBTIRPC_GSS
comment "libtirpc needs a toolchain w/ threads"
depends on !BR2_TOOLCHAIN_HAS_THREADS
+
+comment "libtirpc gss support needs a toolchain w/ dynamic library"
+ depends on BR2_USE_MMU
+ depends on BR2_STATIC_LIBS
+ depends on BR2_PACKAGE_LIBTIRPC
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH v2 1/1] package/libtirpc: add missing !BR2_STATIC_LIBS dependency
2021-07-25 21:34 [Buildroot] [PATCH v2 1/1] package/libtirpc: add missing !BR2_STATIC_LIBS dependency James Hilliard
@ 2021-07-25 21:45 ` Petr Vorel
2021-07-25 21:48 ` James Hilliard
2021-07-26 21:44 ` Thomas Petazzoni
1 sibling, 1 reply; 6+ messages in thread
From: Petr Vorel @ 2021-07-25 21:45 UTC (permalink / raw)
To: James Hilliard; +Cc: Thomas Petazzoni, buildroot
Hi James,
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> Changes v1 -> v2:
> - add comment requiring dynamic libraries
> ---
> package/libtirpc/Config.in | 6 ++++++
> 1 file changed, 6 insertions(+)
> diff --git a/package/libtirpc/Config.in b/package/libtirpc/Config.in
> index 1899edefbf..31f1636ef5 100644
> --- a/package/libtirpc/Config.in
> +++ b/package/libtirpc/Config.in
> @@ -10,6 +10,7 @@ config BR2_PACKAGE_LIBTIRPC
> config BR2_PACKAGE_LIBTIRPC_GSS
> bool "gss"
> depends on BR2_USE_MMU # libkrb5
> + depends on !BR2_STATIC_LIBS # libkrb5
> depends on BR2_PACKAGE_LIBTIRPC
> select BR2_PACKAGE_LIBKRB5
> help
> @@ -17,3 +18,8 @@ config BR2_PACKAGE_LIBTIRPC_GSS
> comment "libtirpc needs a toolchain w/ threads"
> depends on !BR2_TOOLCHAIN_HAS_THREADS
> +
> +comment "libtirpc gss support needs a toolchain w/ dynamic library"
> + depends on BR2_USE_MMU
> + depends on BR2_STATIC_LIBS
> + depends on BR2_PACKAGE_LIBTIRPC
Shouldn't the last item depend on BR2_PACKAGE_LIBTIRPC_GSS?
I'd also name it "libtirpc GSS support ..." (capitalize GSS)
Kind regards,
Petr
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH v2 1/1] package/libtirpc: add missing !BR2_STATIC_LIBS dependency
2021-07-25 21:45 ` Petr Vorel
@ 2021-07-25 21:48 ` James Hilliard
2021-07-25 21:57 ` Petr Vorel
0 siblings, 1 reply; 6+ messages in thread
From: James Hilliard @ 2021-07-25 21:48 UTC (permalink / raw)
To: Petr Vorel; +Cc: Thomas Petazzoni, buildroot
On Sun, Jul 25, 2021 at 3:45 PM Petr Vorel <petr.vorel@gmail.com> wrote:
>
> Hi James,
>
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > ---
> > Changes v1 -> v2:
> > - add comment requiring dynamic libraries
> > ---
> > package/libtirpc/Config.in | 6 ++++++
> > 1 file changed, 6 insertions(+)
>
> > diff --git a/package/libtirpc/Config.in b/package/libtirpc/Config.in
> > index 1899edefbf..31f1636ef5 100644
> > --- a/package/libtirpc/Config.in
> > +++ b/package/libtirpc/Config.in
> > @@ -10,6 +10,7 @@ config BR2_PACKAGE_LIBTIRPC
> > config BR2_PACKAGE_LIBTIRPC_GSS
> > bool "gss"
> > depends on BR2_USE_MMU # libkrb5
> > + depends on !BR2_STATIC_LIBS # libkrb5
> > depends on BR2_PACKAGE_LIBTIRPC
> > select BR2_PACKAGE_LIBKRB5
> > help
> > @@ -17,3 +18,8 @@ config BR2_PACKAGE_LIBTIRPC_GSS
>
> > comment "libtirpc needs a toolchain w/ threads"
> > depends on !BR2_TOOLCHAIN_HAS_THREADS
> > +
> > +comment "libtirpc gss support needs a toolchain w/ dynamic library"
> > + depends on BR2_USE_MMU
> > + depends on BR2_STATIC_LIBS
> > + depends on BR2_PACKAGE_LIBTIRPC
> Shouldn't the last item depend on BR2_PACKAGE_LIBTIRPC_GSS?
I don't think so, then it would never be shown AFAIU.
> I'd also name it "libtirpc GSS support ..." (capitalize GSS)
I kept it lowercase for consistency with:
config BR2_PACKAGE_LIBTIRPC_GSS
bool "gss"
Maybe we should change both?
>
> Kind regards,
> Petr
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH v2 1/1] package/libtirpc: add missing !BR2_STATIC_LIBS dependency
2021-07-25 21:48 ` James Hilliard
@ 2021-07-25 21:57 ` Petr Vorel
2021-07-25 21:59 ` Petr Vorel
0 siblings, 1 reply; 6+ messages in thread
From: Petr Vorel @ 2021-07-25 21:57 UTC (permalink / raw)
To: James Hilliard; +Cc: Thomas Petazzoni, buildroot
> On Sun, Jul 25, 2021 at 3:45 PM Petr Vorel <petr.vorel@gmail.com> wrote:
> > Hi James,
> > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > > ---
> > > Changes v1 -> v2:
> > > - add comment requiring dynamic libraries
> > > ---
> > > package/libtirpc/Config.in | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> > > diff --git a/package/libtirpc/Config.in b/package/libtirpc/Config.in
> > > index 1899edefbf..31f1636ef5 100644
> > > --- a/package/libtirpc/Config.in
> > > +++ b/package/libtirpc/Config.in
> > > @@ -10,6 +10,7 @@ config BR2_PACKAGE_LIBTIRPC
> > > config BR2_PACKAGE_LIBTIRPC_GSS
> > > bool "gss"
> > > depends on BR2_USE_MMU # libkrb5
> > > + depends on !BR2_STATIC_LIBS # libkrb5
> > > depends on BR2_PACKAGE_LIBTIRPC
> > > select BR2_PACKAGE_LIBKRB5
> > > help
> > > @@ -17,3 +18,8 @@ config BR2_PACKAGE_LIBTIRPC_GSS
> > > comment "libtirpc needs a toolchain w/ threads"
> > > depends on !BR2_TOOLCHAIN_HAS_THREADS
> > > +
> > > +comment "libtirpc gss support needs a toolchain w/ dynamic library"
> > > + depends on BR2_USE_MMU
> > > + depends on BR2_STATIC_LIBS
> > > + depends on BR2_PACKAGE_LIBTIRPC
> > Shouldn't the last item depend on BR2_PACKAGE_LIBTIRPC_GSS?
> I don't think so, then it would never be shown AFAIU.
Looking into package/apcupsd/Config.in shows 1) comment should be just below
config (problem also on previous patch) and 2) IMHO "depends on
BR2_PACKAGE_LIBTIRPC" should not be there at all. Or am I missing something?
> > I'd also name it "libtirpc GSS support ..." (capitalize GSS)
> I kept it lowercase for consistency with:
> config BR2_PACKAGE_LIBTIRPC_GSS
> bool "gss"
> Maybe we should change both?
Well, probably better to keep it lowercase.
I thought that first is identifier, other is abbreviation in the name,
but again, looking into package/apcupsd/Config.in shows I$m wrong.
Kind regards,
Petr
> > Kind regards,
> > Petr
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH v2 1/1] package/libtirpc: add missing !BR2_STATIC_LIBS dependency
2021-07-25 21:57 ` Petr Vorel
@ 2021-07-25 21:59 ` Petr Vorel
0 siblings, 0 replies; 6+ messages in thread
From: Petr Vorel @ 2021-07-25 21:59 UTC (permalink / raw)
To: James Hilliard, buildroot, Thomas Petazzoni
> > On Sun, Jul 25, 2021 at 3:45 PM Petr Vorel <petr.vorel@gmail.com> wrote:
> > > Hi James,
> > > > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > > > ---
> > > > Changes v1 -> v2:
> > > > - add comment requiring dynamic libraries
> > > > ---
> > > > package/libtirpc/Config.in | 6 ++++++
> > > > 1 file changed, 6 insertions(+)
> > > > diff --git a/package/libtirpc/Config.in b/package/libtirpc/Config.in
> > > > index 1899edefbf..31f1636ef5 100644
> > > > --- a/package/libtirpc/Config.in
> > > > +++ b/package/libtirpc/Config.in
> > > > @@ -10,6 +10,7 @@ config BR2_PACKAGE_LIBTIRPC
> > > > config BR2_PACKAGE_LIBTIRPC_GSS
> > > > bool "gss"
> > > > depends on BR2_USE_MMU # libkrb5
> > > > + depends on !BR2_STATIC_LIBS # libkrb5
> > > > depends on BR2_PACKAGE_LIBTIRPC
> > > > select BR2_PACKAGE_LIBKRB5
> > > > help
> > > > @@ -17,3 +18,8 @@ config BR2_PACKAGE_LIBTIRPC_GSS
> > > > comment "libtirpc needs a toolchain w/ threads"
> > > > depends on !BR2_TOOLCHAIN_HAS_THREADS
> > > > +
> > > > +comment "libtirpc gss support needs a toolchain w/ dynamic library"
> > > > + depends on BR2_USE_MMU
> > > > + depends on BR2_STATIC_LIBS
> > > > + depends on BR2_PACKAGE_LIBTIRPC
> > > Shouldn't the last item depend on BR2_PACKAGE_LIBTIRPC_GSS?
> > I don't think so, then it would never be shown AFAIU.
> Looking into package/apcupsd/Config.in shows 1) comment should be just below
> config (problem also on previous patch) and 2) IMHO "depends on
> BR2_PACKAGE_LIBTIRPC" should not be there at all. Or am I missing something?
Yes, I was missing something :). "depends on BR2_PACKAGE_LIBTIRPC" is correct.
It works, not sure if 1) is relevant, thus sorry for confusion.
Kind regards,
Petr
> > > I'd also name it "libtirpc GSS support ..." (capitalize GSS)
> > I kept it lowercase for consistency with:
> > config BR2_PACKAGE_LIBTIRPC_GSS
> > bool "gss"
> > Maybe we should change both?
> Well, probably better to keep it lowercase.
> I thought that first is identifier, other is abbreviation in the name,
> but again, looking into package/apcupsd/Config.in shows I$m wrong.
> Kind regards,
> Petr
> > > Kind regards,
> > > Petr
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH v2 1/1] package/libtirpc: add missing !BR2_STATIC_LIBS dependency
2021-07-25 21:34 [Buildroot] [PATCH v2 1/1] package/libtirpc: add missing !BR2_STATIC_LIBS dependency James Hilliard
2021-07-25 21:45 ` Petr Vorel
@ 2021-07-26 21:44 ` Thomas Petazzoni
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2021-07-26 21:44 UTC (permalink / raw)
To: James Hilliard; +Cc: buildroot
On Sun, 25 Jul 2021 15:34:22 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> Changes v1 -> v2:
> - add comment requiring dynamic libraries
> ---
> package/libtirpc/Config.in | 6 ++++++
> 1 file changed, 6 insertions(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-07-26 21:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-25 21:34 [Buildroot] [PATCH v2 1/1] package/libtirpc: add missing !BR2_STATIC_LIBS dependency James Hilliard
2021-07-25 21:45 ` Petr Vorel
2021-07-25 21:48 ` James Hilliard
2021-07-25 21:57 ` Petr Vorel
2021-07-25 21:59 ` Petr Vorel
2021-07-26 21:44 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.