* [PATCH] ARM: dts: at91: sama5d4_xplained: change the key code of the gpio key
@ 2021-07-27 9:13 ` nicolas.ferre
0 siblings, 0 replies; 4+ messages in thread
From: nicolas.ferre @ 2021-07-27 9:13 UTC (permalink / raw)
To: linux-kernel, linux-arm-kernel; +Cc: Alexandre Belloni, Ludovic Desroches
From: Ludovic Desroches <ludovic.desroches@microchip.com>
Having a button code and not a key code causes issues with libinput.
udev won't set ID_INPUT_KEY. If it is forced, then it causes a bug
within libinput.
Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
---
arch/arm/boot/dts/at91-sama5d4_xplained.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
index 541779af049f..d241c24f0d83 100644
--- a/arch/arm/boot/dts/at91-sama5d4_xplained.dts
+++ b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
@@ -7,6 +7,7 @@
*/
/dts-v1/;
#include "sama5d4.dtsi"
+#include <dt-bindings/input/input.h>
/ {
model = "Atmel SAMA5D4 Xplained";
@@ -250,7 +251,7 @@ gpio_keys {
pb_user1 {
label = "pb_user1";
gpios = <&pioE 8 GPIO_ACTIVE_HIGH>;
- linux,code = <0x100>;
+ linux,code = <KEY_PROG1>;
wakeup-source;
};
};
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: dts: at91: sama5d4_xplained: change the key code of the gpio key
@ 2021-07-27 9:13 ` nicolas.ferre
0 siblings, 0 replies; 4+ messages in thread
From: nicolas.ferre @ 2021-07-27 9:13 UTC (permalink / raw)
To: linux-kernel, linux-arm-kernel; +Cc: Alexandre Belloni, Ludovic Desroches
From: Ludovic Desroches <ludovic.desroches@microchip.com>
Having a button code and not a key code causes issues with libinput.
udev won't set ID_INPUT_KEY. If it is forced, then it causes a bug
within libinput.
Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
---
arch/arm/boot/dts/at91-sama5d4_xplained.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
index 541779af049f..d241c24f0d83 100644
--- a/arch/arm/boot/dts/at91-sama5d4_xplained.dts
+++ b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
@@ -7,6 +7,7 @@
*/
/dts-v1/;
#include "sama5d4.dtsi"
+#include <dt-bindings/input/input.h>
/ {
model = "Atmel SAMA5D4 Xplained";
@@ -250,7 +251,7 @@ gpio_keys {
pb_user1 {
label = "pb_user1";
gpios = <&pioE 8 GPIO_ACTIVE_HIGH>;
- linux,code = <0x100>;
+ linux,code = <KEY_PROG1>;
wakeup-source;
};
};
--
2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: at91: sama5d4_xplained: change the key code of the gpio key
2021-07-27 9:13 ` nicolas.ferre
@ 2021-07-27 9:56 ` Nicolas Ferre
-1 siblings, 0 replies; 4+ messages in thread
From: Nicolas Ferre @ 2021-07-27 9:56 UTC (permalink / raw)
To: linux-kernel, linux-arm-kernel; +Cc: Alexandre Belloni, Ludovic Desroches
On 27/07/2021 at 11:13, nicolas.ferre@microchip.com wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> From: Ludovic Desroches <ludovic.desroches@microchip.com>
>
> Having a button code and not a key code causes issues with libinput.
> udev won't set ID_INPUT_KEY. If it is forced, then it causes a bug
> within libinput.
>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
For the record: added to at91-dt for 5.15.
Regards,
Nicolas
> ---
> arch/arm/boot/dts/at91-sama5d4_xplained.dts | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> index 541779af049f..d241c24f0d83 100644
> --- a/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> @@ -7,6 +7,7 @@
> */
> /dts-v1/;
> #include "sama5d4.dtsi"
> +#include <dt-bindings/input/input.h>
>
> / {
> model = "Atmel SAMA5D4 Xplained";
> @@ -250,7 +251,7 @@ gpio_keys {
> pb_user1 {
> label = "pb_user1";
> gpios = <&pioE 8 GPIO_ACTIVE_HIGH>;
> - linux,code = <0x100>;
> + linux,code = <KEY_PROG1>;
> wakeup-source;
> };
> };
> --
> 2.32.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: at91: sama5d4_xplained: change the key code of the gpio key
@ 2021-07-27 9:56 ` Nicolas Ferre
0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Ferre @ 2021-07-27 9:56 UTC (permalink / raw)
To: linux-kernel, linux-arm-kernel; +Cc: Alexandre Belloni, Ludovic Desroches
On 27/07/2021 at 11:13, nicolas.ferre@microchip.com wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> From: Ludovic Desroches <ludovic.desroches@microchip.com>
>
> Having a button code and not a key code causes issues with libinput.
> udev won't set ID_INPUT_KEY. If it is forced, then it causes a bug
> within libinput.
>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
For the record: added to at91-dt for 5.15.
Regards,
Nicolas
> ---
> arch/arm/boot/dts/at91-sama5d4_xplained.dts | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> index 541779af049f..d241c24f0d83 100644
> --- a/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> @@ -7,6 +7,7 @@
> */
> /dts-v1/;
> #include "sama5d4.dtsi"
> +#include <dt-bindings/input/input.h>
>
> / {
> model = "Atmel SAMA5D4 Xplained";
> @@ -250,7 +251,7 @@ gpio_keys {
> pb_user1 {
> label = "pb_user1";
> gpios = <&pioE 8 GPIO_ACTIVE_HIGH>;
> - linux,code = <0x100>;
> + linux,code = <KEY_PROG1>;
> wakeup-source;
> };
> };
> --
> 2.32.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
Nicolas Ferre
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-27 9:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-27 9:13 [PATCH] ARM: dts: at91: sama5d4_xplained: change the key code of the gpio key nicolas.ferre
2021-07-27 9:13 ` nicolas.ferre
2021-07-27 9:56 ` Nicolas Ferre
2021-07-27 9:56 ` Nicolas Ferre
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.