* + mm-change-fault_in_pages_-to-have-an-unsigned-size-parameter.patch added to -mm tree
@ 2021-07-27 20:43 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2021-07-27 20:43 UTC (permalink / raw)
To: mm-commits, willy, william.kucharski, mchehab+huawei, jordy,
hughd, djwong, dhowells, gregkh
The patch titled
Subject: mm: change fault_in_pages_* to have an unsigned size parameter
has been added to the -mm tree. Its filename is
mm-change-fault_in_pages_-to-have-an-unsigned-size-parameter.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/mm-change-fault_in_pages_-to-have-an-unsigned-size-parameter.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/mm-change-fault_in_pages_-to-have-an-unsigned-size-parameter.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: mm: change fault_in_pages_* to have an unsigned size parameter
fault_in_pages_writeable() and fault_in_pages_readable() treat the size
parameter as unsigned, doing pointer math with the value, so make this
explicit and set it to be a size_t type which all callers currently treat
it as anyway.
This solves the issue where static checkers get nervous seeing pointer
arithmetic happening with a signed value.
Link: https://lkml.kernel.org/r/20210727111136.457638-1-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reported-by: Jordy Zomer <jordy@pwning.systems>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: David Howells <dhowells@redhat.com>
Cc: William Kucharski <william.kucharski@oracle.com>
Cc: "Darrick J. Wong" <djwong@kernel.org>
Cc: Hugh Dickins <hughd@google.com>
Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
include/linux/pagemap.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/include/linux/pagemap.h~mm-change-fault_in_pages_-to-have-an-unsigned-size-parameter
+++ a/include/linux/pagemap.h
@@ -786,7 +786,7 @@ extern void add_page_wait_queue(struct p
/*
* Fault everything in given userspace address range in.
*/
-static inline int fault_in_pages_writeable(char __user *uaddr, int size)
+static inline int fault_in_pages_writeable(char __user *uaddr, size_t size)
{
char __user *end = uaddr + size - 1;
@@ -813,7 +813,7 @@ static inline int fault_in_pages_writeab
return 0;
}
-static inline int fault_in_pages_readable(const char __user *uaddr, int size)
+static inline int fault_in_pages_readable(const char __user *uaddr, size_t size)
{
volatile char c;
const char __user *end = uaddr + size - 1;
_
Patches currently in -mm which might be from gregkh@linuxfoundation.org are
mm-change-fault_in_pages_-to-have-an-unsigned-size-parameter.patch
percpu-remove-export-of-pcpu_base_addr.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-07-27 20:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-27 20:43 + mm-change-fault_in_pages_-to-have-an-unsigned-size-parameter.patch added to -mm tree akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.