All of lore.kernel.org
 help / color / mirror / Atom feed
From: Atsushi Nemoto <atsushi.nemoto@sord.co.jp>
To: linux-rt-users@vger.kernel.org, John Kacur <jkacur@redhat.com>
Subject: [rteval PATCH] rteval: stressng.py: Fix argument passing to Popen
Date: Wed, 28 Jul 2021 20:19:27 +0900 (JST)	[thread overview]
Message-ID: <20210728.201927.2141210326291227293.atsushi.nemoto@sord.co.jp> (raw)

The self.args is a list of strings which may contains spaces.
Use shell style and pass self.args as a joined string.

Signed-off-by: Atsushi Nemoto <atsushi.nemoto@sord.co.jp>
---
 rteval/modules/loads/stressng.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rteval/modules/loads/stressng.py b/rteval/modules/loads/stressng.py
index 926de38..927bee5 100644
--- a/rteval/modules/loads/stressng.py
+++ b/rteval/modules/loads/stressng.py
@@ -84,7 +84,7 @@ class Stressng(CommandLineLoad):
 
         self._log(Log.DEBUG, "starting with %s" % " ".join(self.args))
         try:
-            self.process = subprocess.Popen(self.args,
+            self.process = subprocess.Popen(" ".join(self.args), shell=True,
                                             stdout=self.__out,
                                             stderr=self.__err,
                                             stdin=self.__in)
-- 
2.11.0

             reply	other threads:[~2021-07-28 11:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28 11:19 Atsushi Nemoto [this message]
2021-07-28 21:38 ` [rteval PATCH] rteval: stressng.py: Fix argument passing to Popen John Kacur
2021-07-29  0:23   ` Atsushi Nemoto
2021-07-29 23:10     ` John Kacur
2021-07-30  4:35       ` Atsushi Nemoto
2021-08-06  8:45         ` Atsushi Nemoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210728.201927.2141210326291227293.atsushi.nemoto@sord.co.jp \
    --to=atsushi.nemoto@sord.co.jp \
    --cc=jkacur@redhat.com \
    --cc=linux-rt-users@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.