All of lore.kernel.org
 help / color / mirror / Atom feed
From: Atsushi Nemoto <atsushi.nemoto@sord.co.jp>
To: jkacur@redhat.com
Cc: linux-rt-users@vger.kernel.org
Subject: Re: [rteval PATCH] rteval: stressng.py: Fix argument passing to Popen
Date: Thu, 29 Jul 2021 09:23:28 +0900 (JST)	[thread overview]
Message-ID: <20210729.092328.1410316616346703094.atsushi.nemoto@sord.co.jp> (raw)
In-Reply-To: <1643d3d2-250-5a9d-731f-fecf8f2f2b17@redhat.com>

On Wed, 28 Jul 2021 17:38:05 -0400 (EDT), John Kacur <jkacur@redhat.com> wrote:
>> -            self.process = subprocess.Popen(self.args,
>> +            self.process = subprocess.Popen(" ".join(self.args), shell=True,
>>                                              stdout=self.__out,
>>                                              stderr=self.__err,
>>                                              stdin=self.__in)
>> -- 
>> 2.11.0
>> 
> 
> I don't see the need to do this here and in fact there are some security 
> implications to using shell=True. Is there a reason you want to do this?

I want to pass multiple options using --stressng-arg.

And also, there are elements with spaces in self.args already:
"--timeout %s" and "--taskset %s".

---
Atsushi Nemoto

  reply	other threads:[~2021-07-29  0:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28 11:19 [rteval PATCH] rteval: stressng.py: Fix argument passing to Popen Atsushi Nemoto
2021-07-28 21:38 ` John Kacur
2021-07-29  0:23   ` Atsushi Nemoto [this message]
2021-07-29 23:10     ` John Kacur
2021-07-30  4:35       ` Atsushi Nemoto
2021-08-06  8:45         ` Atsushi Nemoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210729.092328.1410316616346703094.atsushi.nemoto@sord.co.jp \
    --to=atsushi.nemoto@sord.co.jp \
    --cc=jkacur@redhat.com \
    --cc=linux-rt-users@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.