All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] tools: perf: Report collisions in AUX records
       [not found] <20210723124456.3828769-1-suzuki.poulose@arm.com>
@ 2021-07-28  9:12   ` Suzuki K Poulose
  0 siblings, 0 replies; 8+ messages in thread
From: Suzuki K Poulose @ 2021-07-28  9:12 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: mike.leach, mathieu.poirier, coresight, Suzuki K Poulose,
	Leo Yan, James Clark, Arnaldo Carvalho de Melo, Mark Rutland,
	Jiri Olsa, linux-perf-users, Alexander Shishkin

Just like the other flags in the AUX records, report a summary
of the Collisions if there were any.

Cc: Mike Leach <mike.leach@linaro.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: James Clark <james.clark@arm.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: linux-perf-users@vger.kernel.org
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
 tools/perf/util/events_stats.h | 1 +
 tools/perf/util/session.c      | 9 +++++++++
 2 files changed, 10 insertions(+)

diff --git a/tools/perf/util/events_stats.h b/tools/perf/util/events_stats.h
index 3480bafd414b..1b0006092265 100644
--- a/tools/perf/util/events_stats.h
+++ b/tools/perf/util/events_stats.h
@@ -30,6 +30,7 @@ struct events_stats {
 	u64 total_lost_samples;
 	u64 total_aux_lost;
 	u64 total_aux_partial;
+	u64 total_aux_collision;
 	u64 total_invalid_chains;
 	u32 nr_events[PERF_RECORD_HEADER_MAX];
 	u32 nr_lost_warned;
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index 51f727402912..59b6c3fe0d01 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -1540,6 +1540,8 @@ static int machines__deliver_event(struct machines *machines,
 				evlist->stats.total_aux_lost += 1;
 			if (event->aux.flags & PERF_AUX_FLAG_PARTIAL)
 				evlist->stats.total_aux_partial += 1;
+			if (event->aux.flags & PERF_AUX_FLAG_COLLISION)
+				evlist->stats.total_aux_collision += 1;
 		}
 		return tool->aux(tool, event, sample, machine);
 	case PERF_RECORD_ITRACE_START:
@@ -1895,6 +1897,13 @@ static void perf_session__warn_about_errors(const struct perf_session *session)
 			    "");
 	}
 
+	if (session->tool->aux == perf_event__process_aux &&
+	    stats->total_aux_collision != 0) {
+		ui__warning("AUX data detected collision  %" PRIu64 " times out of %u!\n\n",
+			    stats->total_aux_collision,
+			    stats->nr_events[PERF_RECORD_AUX]);
+	}
+
 	if (stats->nr_unknown_events != 0) {
 		ui__warning("Found %u unknown events!\n\n"
 			    "Is this an older tool processing a perf.data "
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH] tools: perf: Report collisions in AUX records
@ 2021-07-28  9:12   ` Suzuki K Poulose
  0 siblings, 0 replies; 8+ messages in thread
From: Suzuki K Poulose @ 2021-07-28  9:12 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: mike.leach, mathieu.poirier, coresight, Suzuki K Poulose,
	Leo Yan, James Clark, Arnaldo Carvalho de Melo, Mark Rutland,
	Jiri Olsa, linux-perf-users, Alexander Shishkin

Just like the other flags in the AUX records, report a summary
of the Collisions if there were any.

Cc: Mike Leach <mike.leach@linaro.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: James Clark <james.clark@arm.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: linux-perf-users@vger.kernel.org
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
 tools/perf/util/events_stats.h | 1 +
 tools/perf/util/session.c      | 9 +++++++++
 2 files changed, 10 insertions(+)

diff --git a/tools/perf/util/events_stats.h b/tools/perf/util/events_stats.h
index 3480bafd414b..1b0006092265 100644
--- a/tools/perf/util/events_stats.h
+++ b/tools/perf/util/events_stats.h
@@ -30,6 +30,7 @@ struct events_stats {
 	u64 total_lost_samples;
 	u64 total_aux_lost;
 	u64 total_aux_partial;
+	u64 total_aux_collision;
 	u64 total_invalid_chains;
 	u32 nr_events[PERF_RECORD_HEADER_MAX];
 	u32 nr_lost_warned;
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index 51f727402912..59b6c3fe0d01 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -1540,6 +1540,8 @@ static int machines__deliver_event(struct machines *machines,
 				evlist->stats.total_aux_lost += 1;
 			if (event->aux.flags & PERF_AUX_FLAG_PARTIAL)
 				evlist->stats.total_aux_partial += 1;
+			if (event->aux.flags & PERF_AUX_FLAG_COLLISION)
+				evlist->stats.total_aux_collision += 1;
 		}
 		return tool->aux(tool, event, sample, machine);
 	case PERF_RECORD_ITRACE_START:
@@ -1895,6 +1897,13 @@ static void perf_session__warn_about_errors(const struct perf_session *session)
 			    "");
 	}
 
+	if (session->tool->aux == perf_event__process_aux &&
+	    stats->total_aux_collision != 0) {
+		ui__warning("AUX data detected collision  %" PRIu64 " times out of %u!\n\n",
+			    stats->total_aux_collision,
+			    stats->nr_events[PERF_RECORD_AUX]);
+	}
+
 	if (stats->nr_unknown_events != 0) {
 		ui__warning("Found %u unknown events!\n\n"
 			    "Is this an older tool processing a perf.data "
-- 
2.24.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] tools: perf: Report collisions in AUX records
  2021-07-28  9:12   ` Suzuki K Poulose
@ 2021-07-31  1:38     ` Leo Yan
  -1 siblings, 0 replies; 8+ messages in thread
From: Leo Yan @ 2021-07-31  1:38 UTC (permalink / raw)
  To: Suzuki K Poulose
  Cc: linux-arm-kernel, mike.leach, mathieu.poirier, coresight,
	James Clark, Arnaldo Carvalho de Melo, Mark Rutland, Jiri Olsa,
	linux-perf-users, Alexander Shishkin

On Wed, Jul 28, 2021 at 10:12:19AM +0100, Suzuki Kuruppassery Poulose wrote:
> Just like the other flags in the AUX records, report a summary
> of the Collisions if there were any.
> 
> Cc: Mike Leach <mike.leach@linaro.org>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: Leo Yan <leo.yan@linaro.org>
> Cc: James Clark <james.clark@arm.com>
> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: linux-perf-users@vger.kernel.org
> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>

The change looks good to me:

Reviewed-by: Leo Yan <leo.yan@linaro.org>

> ---
>  tools/perf/util/events_stats.h | 1 +
>  tools/perf/util/session.c      | 9 +++++++++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/tools/perf/util/events_stats.h b/tools/perf/util/events_stats.h
> index 3480bafd414b..1b0006092265 100644
> --- a/tools/perf/util/events_stats.h
> +++ b/tools/perf/util/events_stats.h
> @@ -30,6 +30,7 @@ struct events_stats {
>  	u64 total_lost_samples;
>  	u64 total_aux_lost;
>  	u64 total_aux_partial;
> +	u64 total_aux_collision;
>  	u64 total_invalid_chains;
>  	u32 nr_events[PERF_RECORD_HEADER_MAX];
>  	u32 nr_lost_warned;
> diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> index 51f727402912..59b6c3fe0d01 100644
> --- a/tools/perf/util/session.c
> +++ b/tools/perf/util/session.c
> @@ -1540,6 +1540,8 @@ static int machines__deliver_event(struct machines *machines,
>  				evlist->stats.total_aux_lost += 1;
>  			if (event->aux.flags & PERF_AUX_FLAG_PARTIAL)
>  				evlist->stats.total_aux_partial += 1;
> +			if (event->aux.flags & PERF_AUX_FLAG_COLLISION)
> +				evlist->stats.total_aux_collision += 1;
>  		}
>  		return tool->aux(tool, event, sample, machine);
>  	case PERF_RECORD_ITRACE_START:
> @@ -1895,6 +1897,13 @@ static void perf_session__warn_about_errors(const struct perf_session *session)
>  			    "");
>  	}
>  
> +	if (session->tool->aux == perf_event__process_aux &&
> +	    stats->total_aux_collision != 0) {
> +		ui__warning("AUX data detected collision  %" PRIu64 " times out of %u!\n\n",
> +			    stats->total_aux_collision,
> +			    stats->nr_events[PERF_RECORD_AUX]);
> +	}
> +
>  	if (stats->nr_unknown_events != 0) {
>  		ui__warning("Found %u unknown events!\n\n"
>  			    "Is this an older tool processing a perf.data "
> -- 
> 2.24.1
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] tools: perf: Report collisions in AUX records
@ 2021-07-31  1:38     ` Leo Yan
  0 siblings, 0 replies; 8+ messages in thread
From: Leo Yan @ 2021-07-31  1:38 UTC (permalink / raw)
  To: Suzuki K Poulose
  Cc: linux-arm-kernel, mike.leach, mathieu.poirier, coresight,
	James Clark, Arnaldo Carvalho de Melo, Mark Rutland, Jiri Olsa,
	linux-perf-users, Alexander Shishkin

On Wed, Jul 28, 2021 at 10:12:19AM +0100, Suzuki Kuruppassery Poulose wrote:
> Just like the other flags in the AUX records, report a summary
> of the Collisions if there were any.
> 
> Cc: Mike Leach <mike.leach@linaro.org>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: Leo Yan <leo.yan@linaro.org>
> Cc: James Clark <james.clark@arm.com>
> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: linux-perf-users@vger.kernel.org
> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>

The change looks good to me:

Reviewed-by: Leo Yan <leo.yan@linaro.org>

> ---
>  tools/perf/util/events_stats.h | 1 +
>  tools/perf/util/session.c      | 9 +++++++++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/tools/perf/util/events_stats.h b/tools/perf/util/events_stats.h
> index 3480bafd414b..1b0006092265 100644
> --- a/tools/perf/util/events_stats.h
> +++ b/tools/perf/util/events_stats.h
> @@ -30,6 +30,7 @@ struct events_stats {
>  	u64 total_lost_samples;
>  	u64 total_aux_lost;
>  	u64 total_aux_partial;
> +	u64 total_aux_collision;
>  	u64 total_invalid_chains;
>  	u32 nr_events[PERF_RECORD_HEADER_MAX];
>  	u32 nr_lost_warned;
> diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> index 51f727402912..59b6c3fe0d01 100644
> --- a/tools/perf/util/session.c
> +++ b/tools/perf/util/session.c
> @@ -1540,6 +1540,8 @@ static int machines__deliver_event(struct machines *machines,
>  				evlist->stats.total_aux_lost += 1;
>  			if (event->aux.flags & PERF_AUX_FLAG_PARTIAL)
>  				evlist->stats.total_aux_partial += 1;
> +			if (event->aux.flags & PERF_AUX_FLAG_COLLISION)
> +				evlist->stats.total_aux_collision += 1;
>  		}
>  		return tool->aux(tool, event, sample, machine);
>  	case PERF_RECORD_ITRACE_START:
> @@ -1895,6 +1897,13 @@ static void perf_session__warn_about_errors(const struct perf_session *session)
>  			    "");
>  	}
>  
> +	if (session->tool->aux == perf_event__process_aux &&
> +	    stats->total_aux_collision != 0) {
> +		ui__warning("AUX data detected collision  %" PRIu64 " times out of %u!\n\n",
> +			    stats->total_aux_collision,
> +			    stats->nr_events[PERF_RECORD_AUX]);
> +	}
> +
>  	if (stats->nr_unknown_events != 0) {
>  		ui__warning("Found %u unknown events!\n\n"
>  			    "Is this an older tool processing a perf.data "
> -- 
> 2.24.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] tools: perf: Report collisions in AUX records
  2021-07-31  1:38     ` Leo Yan
@ 2021-09-02 19:25       ` Mathieu Poirier
  -1 siblings, 0 replies; 8+ messages in thread
From: Mathieu Poirier @ 2021-09-02 19:25 UTC (permalink / raw)
  To: Leo Yan
  Cc: Suzuki K Poulose, linux-arm-kernel, mike.leach, coresight,
	James Clark, Arnaldo Carvalho de Melo, Mark Rutland, Jiri Olsa,
	linux-perf-users, Alexander Shishkin

On Sat, Jul 31, 2021 at 09:38:47AM +0800, Leo Yan wrote:
> On Wed, Jul 28, 2021 at 10:12:19AM +0100, Suzuki Kuruppassery Poulose wrote:
> > Just like the other flags in the AUX records, report a summary
> > of the Collisions if there were any.
> > 
> > Cc: Mike Leach <mike.leach@linaro.org>
> > Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> > Cc: Leo Yan <leo.yan@linaro.org>
> > Cc: James Clark <james.clark@arm.com>
> > Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> > Cc: Mark Rutland <mark.rutland@arm.com>
> > Cc: Jiri Olsa <jolsa@redhat.com>
> > Cc: linux-perf-users@vger.kernel.org
> > Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> > Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> 
> The change looks good to me:
> 
> Reviewed-by: Leo Yan <leo.yan@linaro.org>

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

> 
> > ---
> >  tools/perf/util/events_stats.h | 1 +
> >  tools/perf/util/session.c      | 9 +++++++++
> >  2 files changed, 10 insertions(+)
> > 
> > diff --git a/tools/perf/util/events_stats.h b/tools/perf/util/events_stats.h
> > index 3480bafd414b..1b0006092265 100644
> > --- a/tools/perf/util/events_stats.h
> > +++ b/tools/perf/util/events_stats.h
> > @@ -30,6 +30,7 @@ struct events_stats {
> >  	u64 total_lost_samples;
> >  	u64 total_aux_lost;
> >  	u64 total_aux_partial;
> > +	u64 total_aux_collision;
> >  	u64 total_invalid_chains;
> >  	u32 nr_events[PERF_RECORD_HEADER_MAX];
> >  	u32 nr_lost_warned;
> > diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> > index 51f727402912..59b6c3fe0d01 100644
> > --- a/tools/perf/util/session.c
> > +++ b/tools/perf/util/session.c
> > @@ -1540,6 +1540,8 @@ static int machines__deliver_event(struct machines *machines,
> >  				evlist->stats.total_aux_lost += 1;
> >  			if (event->aux.flags & PERF_AUX_FLAG_PARTIAL)
> >  				evlist->stats.total_aux_partial += 1;
> > +			if (event->aux.flags & PERF_AUX_FLAG_COLLISION)
> > +				evlist->stats.total_aux_collision += 1;
> >  		}
> >  		return tool->aux(tool, event, sample, machine);
> >  	case PERF_RECORD_ITRACE_START:
> > @@ -1895,6 +1897,13 @@ static void perf_session__warn_about_errors(const struct perf_session *session)
> >  			    "");
> >  	}
> >  
> > +	if (session->tool->aux == perf_event__process_aux &&
> > +	    stats->total_aux_collision != 0) {
> > +		ui__warning("AUX data detected collision  %" PRIu64 " times out of %u!\n\n",
> > +			    stats->total_aux_collision,
> > +			    stats->nr_events[PERF_RECORD_AUX]);
> > +	}
> > +
> >  	if (stats->nr_unknown_events != 0) {
> >  		ui__warning("Found %u unknown events!\n\n"
> >  			    "Is this an older tool processing a perf.data "
> > -- 
> > 2.24.1
> > 

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] tools: perf: Report collisions in AUX records
@ 2021-09-02 19:25       ` Mathieu Poirier
  0 siblings, 0 replies; 8+ messages in thread
From: Mathieu Poirier @ 2021-09-02 19:25 UTC (permalink / raw)
  To: Leo Yan
  Cc: Suzuki K Poulose, linux-arm-kernel, mike.leach, coresight,
	James Clark, Arnaldo Carvalho de Melo, Mark Rutland, Jiri Olsa,
	linux-perf-users, Alexander Shishkin

On Sat, Jul 31, 2021 at 09:38:47AM +0800, Leo Yan wrote:
> On Wed, Jul 28, 2021 at 10:12:19AM +0100, Suzuki Kuruppassery Poulose wrote:
> > Just like the other flags in the AUX records, report a summary
> > of the Collisions if there were any.
> > 
> > Cc: Mike Leach <mike.leach@linaro.org>
> > Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> > Cc: Leo Yan <leo.yan@linaro.org>
> > Cc: James Clark <james.clark@arm.com>
> > Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> > Cc: Mark Rutland <mark.rutland@arm.com>
> > Cc: Jiri Olsa <jolsa@redhat.com>
> > Cc: linux-perf-users@vger.kernel.org
> > Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> > Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> 
> The change looks good to me:
> 
> Reviewed-by: Leo Yan <leo.yan@linaro.org>

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

> 
> > ---
> >  tools/perf/util/events_stats.h | 1 +
> >  tools/perf/util/session.c      | 9 +++++++++
> >  2 files changed, 10 insertions(+)
> > 
> > diff --git a/tools/perf/util/events_stats.h b/tools/perf/util/events_stats.h
> > index 3480bafd414b..1b0006092265 100644
> > --- a/tools/perf/util/events_stats.h
> > +++ b/tools/perf/util/events_stats.h
> > @@ -30,6 +30,7 @@ struct events_stats {
> >  	u64 total_lost_samples;
> >  	u64 total_aux_lost;
> >  	u64 total_aux_partial;
> > +	u64 total_aux_collision;
> >  	u64 total_invalid_chains;
> >  	u32 nr_events[PERF_RECORD_HEADER_MAX];
> >  	u32 nr_lost_warned;
> > diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> > index 51f727402912..59b6c3fe0d01 100644
> > --- a/tools/perf/util/session.c
> > +++ b/tools/perf/util/session.c
> > @@ -1540,6 +1540,8 @@ static int machines__deliver_event(struct machines *machines,
> >  				evlist->stats.total_aux_lost += 1;
> >  			if (event->aux.flags & PERF_AUX_FLAG_PARTIAL)
> >  				evlist->stats.total_aux_partial += 1;
> > +			if (event->aux.flags & PERF_AUX_FLAG_COLLISION)
> > +				evlist->stats.total_aux_collision += 1;
> >  		}
> >  		return tool->aux(tool, event, sample, machine);
> >  	case PERF_RECORD_ITRACE_START:
> > @@ -1895,6 +1897,13 @@ static void perf_session__warn_about_errors(const struct perf_session *session)
> >  			    "");
> >  	}
> >  
> > +	if (session->tool->aux == perf_event__process_aux &&
> > +	    stats->total_aux_collision != 0) {
> > +		ui__warning("AUX data detected collision  %" PRIu64 " times out of %u!\n\n",
> > +			    stats->total_aux_collision,
> > +			    stats->nr_events[PERF_RECORD_AUX]);
> > +	}
> > +
> >  	if (stats->nr_unknown_events != 0) {
> >  		ui__warning("Found %u unknown events!\n\n"
> >  			    "Is this an older tool processing a perf.data "
> > -- 
> > 2.24.1
> > 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] tools: perf: Report collisions in AUX records
  2021-09-02 19:25       ` Mathieu Poirier
@ 2021-09-03 11:01         ` Arnaldo Carvalho de Melo
  -1 siblings, 0 replies; 8+ messages in thread
From: Arnaldo Carvalho de Melo @ 2021-09-03 11:01 UTC (permalink / raw)
  To: Mathieu Poirier
  Cc: Leo Yan, Suzuki K Poulose, linux-arm-kernel, mike.leach,
	coresight, James Clark, Mark Rutland, Jiri Olsa,
	linux-perf-users, Alexander Shishkin

Em Thu, Sep 02, 2021 at 01:25:20PM -0600, Mathieu Poirier escreveu:
> On Sat, Jul 31, 2021 at 09:38:47AM +0800, Leo Yan wrote:
> > On Wed, Jul 28, 2021 at 10:12:19AM +0100, Suzuki Kuruppassery Poulose wrote:
> > > Just like the other flags in the AUX records, report a summary
> > > of the Collisions if there were any.
> > > 
> > > Cc: Mike Leach <mike.leach@linaro.org>
> > > Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> > > Cc: Leo Yan <leo.yan@linaro.org>
> > > Cc: James Clark <james.clark@arm.com>
> > > Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> > > Cc: Mark Rutland <mark.rutland@arm.com>
> > > Cc: Jiri Olsa <jolsa@redhat.com>
> > > Cc: linux-perf-users@vger.kernel.org
> > > Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> > > Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> > 
> > The change looks good to me:
> > 
> > Reviewed-by: Leo Yan <leo.yan@linaro.org>
> 
> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

Thanks, applied.

- Arnaldo


^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] tools: perf: Report collisions in AUX records
@ 2021-09-03 11:01         ` Arnaldo Carvalho de Melo
  0 siblings, 0 replies; 8+ messages in thread
From: Arnaldo Carvalho de Melo @ 2021-09-03 11:01 UTC (permalink / raw)
  To: Mathieu Poirier
  Cc: Leo Yan, Suzuki K Poulose, linux-arm-kernel, mike.leach,
	coresight, James Clark, Mark Rutland, Jiri Olsa,
	linux-perf-users, Alexander Shishkin

Em Thu, Sep 02, 2021 at 01:25:20PM -0600, Mathieu Poirier escreveu:
> On Sat, Jul 31, 2021 at 09:38:47AM +0800, Leo Yan wrote:
> > On Wed, Jul 28, 2021 at 10:12:19AM +0100, Suzuki Kuruppassery Poulose wrote:
> > > Just like the other flags in the AUX records, report a summary
> > > of the Collisions if there were any.
> > > 
> > > Cc: Mike Leach <mike.leach@linaro.org>
> > > Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> > > Cc: Leo Yan <leo.yan@linaro.org>
> > > Cc: James Clark <james.clark@arm.com>
> > > Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> > > Cc: Mark Rutland <mark.rutland@arm.com>
> > > Cc: Jiri Olsa <jolsa@redhat.com>
> > > Cc: linux-perf-users@vger.kernel.org
> > > Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> > > Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> > 
> > The change looks good to me:
> > 
> > Reviewed-by: Leo Yan <leo.yan@linaro.org>
> 
> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

Thanks, applied.

- Arnaldo


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-09-03 11:04 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210723124456.3828769-1-suzuki.poulose@arm.com>
2021-07-28  9:12 ` [PATCH] tools: perf: Report collisions in AUX records Suzuki K Poulose
2021-07-28  9:12   ` Suzuki K Poulose
2021-07-31  1:38   ` Leo Yan
2021-07-31  1:38     ` Leo Yan
2021-09-02 19:25     ` Mathieu Poirier
2021-09-02 19:25       ` Mathieu Poirier
2021-09-03 11:01       ` Arnaldo Carvalho de Melo
2021-09-03 11:01         ` Arnaldo Carvalho de Melo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.