* [agd5f:drm-next 250/279] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:113:25: warning: suggest braces around empty body in an 'else' statement
@ 2021-07-28 2:30 ` kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-07-28 2:30 UTC (permalink / raw)
To: Wyatt Wood; +Cc: kbuild-all, linux-kernel, Alex Deucher, Koo Anthony
[-- Attachment #1: Type: text/plain, Size: 2876 bytes --]
tree: https://gitlab.freedesktop.org/agd5f/linux.git drm-next
head: 283bf4d8b36f0a453e9a6bf51cfe9d1c2a0daa91
commit: b30eda8d416c8b880b8bd0d422a798c526c549a6 [250/279] drm/amd/display: Add ETW log to dmub_psr_get_state
config: parisc-randconfig-r034-20210727 (attached as .config)
compiler: hppa-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add agd5f https://gitlab.freedesktop.org/agd5f/linux.git
git fetch --no-tags agd5f drm-next
git checkout b30eda8d416c8b880b8bd0d422a798c526c549a6
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=parisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c: In function 'dmub_psr_get_state':
>> drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:113:25: warning: suggest braces around empty body in an 'else' statement [-Wempty-body]
113 | *state, retry_count);
| ^
vim +/else +113 drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c
78
79 /*
80 * Get PSR state from firmware.
81 */
82 static void dmub_psr_get_state(struct dmub_psr *dmub, enum dc_psr_state *state, uint8_t panel_inst)
83 {
84 struct dmub_srv *srv = dmub->ctx->dmub_srv->dmub;
85 uint32_t raw_state = 0;
86 uint32_t retry_count = 0;
87 enum dmub_status status;
88
89 do {
90 // Send gpint command and wait for ack
91 status = dmub_srv_send_gpint_command(srv, DMUB_GPINT__GET_PSR_STATE, panel_inst, 30);
92
93 if (status == DMUB_STATUS_OK) {
94 // GPINT was executed, get response
95 dmub_srv_get_gpint_response(srv, &raw_state);
96 *state = convert_psr_state(raw_state);
97 } else
98 // Return invalid state when GPINT times out
99 *state = PSR_STATE_INVALID;
100
101 } while (++retry_count <= 1000 && *state == PSR_STATE_INVALID);
102
103 // Assert if max retry hit
104 if (retry_count >= 1000 && *state == PSR_STATE_INVALID) {
105 ASSERT(0);
106 DC_TRACE_LEVEL_MESSAGE(DAL_TRACE_LEVEL_ERROR,
107 WPP_BIT_FLAG_Firmware_PsrState,
108 "Unable to get PSR state from FW.");
109 } else
110 DC_TRACE_LEVEL_MESSAGE(DAL_TRACE_LEVEL_VERBOSE,
111 WPP_BIT_FLAG_Firmware_PsrState,
112 "Got PSR state from FW. PSR state: %d, Retry count: %d",
> 113 *state, retry_count);
114 }
115
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41606 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* [agd5f:drm-next 250/279] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:113:25: warning: suggest braces around empty body in an 'else' statement
@ 2021-07-28 2:30 ` kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-07-28 2:30 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2947 bytes --]
tree: https://gitlab.freedesktop.org/agd5f/linux.git drm-next
head: 283bf4d8b36f0a453e9a6bf51cfe9d1c2a0daa91
commit: b30eda8d416c8b880b8bd0d422a798c526c549a6 [250/279] drm/amd/display: Add ETW log to dmub_psr_get_state
config: parisc-randconfig-r034-20210727 (attached as .config)
compiler: hppa-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add agd5f https://gitlab.freedesktop.org/agd5f/linux.git
git fetch --no-tags agd5f drm-next
git checkout b30eda8d416c8b880b8bd0d422a798c526c549a6
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=parisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c: In function 'dmub_psr_get_state':
>> drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:113:25: warning: suggest braces around empty body in an 'else' statement [-Wempty-body]
113 | *state, retry_count);
| ^
vim +/else +113 drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c
78
79 /*
80 * Get PSR state from firmware.
81 */
82 static void dmub_psr_get_state(struct dmub_psr *dmub, enum dc_psr_state *state, uint8_t panel_inst)
83 {
84 struct dmub_srv *srv = dmub->ctx->dmub_srv->dmub;
85 uint32_t raw_state = 0;
86 uint32_t retry_count = 0;
87 enum dmub_status status;
88
89 do {
90 // Send gpint command and wait for ack
91 status = dmub_srv_send_gpint_command(srv, DMUB_GPINT__GET_PSR_STATE, panel_inst, 30);
92
93 if (status == DMUB_STATUS_OK) {
94 // GPINT was executed, get response
95 dmub_srv_get_gpint_response(srv, &raw_state);
96 *state = convert_psr_state(raw_state);
97 } else
98 // Return invalid state when GPINT times out
99 *state = PSR_STATE_INVALID;
100
101 } while (++retry_count <= 1000 && *state == PSR_STATE_INVALID);
102
103 // Assert if max retry hit
104 if (retry_count >= 1000 && *state == PSR_STATE_INVALID) {
105 ASSERT(0);
106 DC_TRACE_LEVEL_MESSAGE(DAL_TRACE_LEVEL_ERROR,
107 WPP_BIT_FLAG_Firmware_PsrState,
108 "Unable to get PSR state from FW.");
109 } else
110 DC_TRACE_LEVEL_MESSAGE(DAL_TRACE_LEVEL_VERBOSE,
111 WPP_BIT_FLAG_Firmware_PsrState,
112 "Got PSR state from FW. PSR state: %d, Retry count: %d",
> 113 *state, retry_count);
114 }
115
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 41606 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-28 2:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-28 2:30 [agd5f:drm-next 250/279] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_psr.c:113:25: warning: suggest braces around empty body in an 'else' statement kernel test robot
2021-07-28 2:30 ` kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.