All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Martin <Dave.Martin@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Shuah Khan <skhan@linuxfoundation.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v1 3/3] kselftest/arm64: Add tests for SVE vector configuration
Date: Wed, 28 Jul 2021 17:37:17 +0100	[thread overview]
Message-ID: <20210728163716.GG1724@arm.com> (raw)
In-Reply-To: <20210728162953.GF4670@sirena.org.uk>

On Wed, Jul 28, 2021 at 05:29:53PM +0100, Mark Brown wrote:
> On Wed, Jul 28, 2021 at 02:44:07PM +0100, Dave Martin wrote:
> 
> > This might be a bit clearer if the setup code was clearly separate from
> > the tests, but so long as the ordering requirements are clearly
> > documented that seems reasonably OK.
> 
> We can't really split the setup code out since the setup code would have
> to rely on one of the ABIs we're trying to test which is all fine and
> good until the tests actually help us catch something, we have to build
> up knowledge of the values as we go and hope that the cross checking we
> end up with helps us at least catch inconsistencies.

Ack.  The setup code could be defensive, but you would in effect be
doing some of the tests twice then.  Or the fact that the setup code
is "separate" from the tests might be a bit of an illusion.

Cheers
---Dave

WARNING: multiple messages have this Message-ID (diff)
From: Dave Martin <Dave.Martin@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Shuah Khan <skhan@linuxfoundation.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v1 3/3] kselftest/arm64: Add tests for SVE vector configuration
Date: Wed, 28 Jul 2021 17:37:17 +0100	[thread overview]
Message-ID: <20210728163716.GG1724@arm.com> (raw)
In-Reply-To: <20210728162953.GF4670@sirena.org.uk>

On Wed, Jul 28, 2021 at 05:29:53PM +0100, Mark Brown wrote:
> On Wed, Jul 28, 2021 at 02:44:07PM +0100, Dave Martin wrote:
> 
> > This might be a bit clearer if the setup code was clearly separate from
> > the tests, but so long as the ordering requirements are clearly
> > documented that seems reasonably OK.
> 
> We can't really split the setup code out since the setup code would have
> to rely on one of the ABIs we're trying to test which is all fine and
> good until the tests actually help us catch something, we have to build
> up knowledge of the values as we go and hope that the cross checking we
> end up with helps us at least catch inconsistencies.

Ack.  The setup code could be defensive, but you would in effect be
doing some of the tests twice then.  Or the fact that the setup code
is "separate" from the tests might be a bit of an illusion.

Cheers
---Dave

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-07-28 16:38 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-27 18:06 [PATCH v1 0/3] kselftest/arm64: Vector length configuration tests Mark Brown
2021-07-27 18:06 ` Mark Brown
2021-07-27 18:06 ` [PATCH v1 1/3] kselftest/arm64: Provide a helper binary and "library" for SVE RDVL Mark Brown
2021-07-27 18:06   ` Mark Brown
2021-07-28  9:41   ` Dave Martin
2021-07-28  9:41     ` Dave Martin
2021-07-28 10:20     ` Mark Brown
2021-07-28 10:20       ` Mark Brown
2021-07-28 10:45       ` Dave Martin
2021-07-28 10:45         ` Dave Martin
2021-07-27 18:06 ` [PATCH v1 2/3] kselftest/arm64: Validate vector lengths are set in sve-probe-vls Mark Brown
2021-07-27 18:06   ` Mark Brown
2021-07-28  9:41   ` Dave Martin
2021-07-28  9:41     ` Dave Martin
2021-07-28 11:07     ` Mark Brown
2021-07-28 11:07       ` Mark Brown
2021-07-28 11:35       ` Dave Martin
2021-07-28 11:35         ` Dave Martin
2021-07-27 18:06 ` [PATCH v1 3/3] kselftest/arm64: Add tests for SVE vector configuration Mark Brown
2021-07-27 18:06   ` Mark Brown
2021-07-28  9:41   ` Dave Martin
2021-07-28  9:41     ` Dave Martin
2021-07-28 12:59     ` Mark Brown
2021-07-28 12:59       ` Mark Brown
2021-07-28 13:44       ` Dave Martin
2021-07-28 13:44         ` Dave Martin
2021-07-28 16:29         ` Mark Brown
2021-07-28 16:29           ` Mark Brown
2021-07-28 16:37           ` Dave Martin [this message]
2021-07-28 16:37             ` Dave Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210728163716.GG1724@arm.com \
    --to=dave.martin@arm.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.