All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jisheng Zhang <jszhang3@mail.ustc.edu.cn>
To: Changbin Du <changbin.du@gmail.com>
Cc: Jisheng Zhang <Jisheng.Zhang@synaptics.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: stacktrace: fix dump_backtrace/walk_stackframe with NULL task
Date: Wed, 28 Jul 2021 21:39:34 +0800	[thread overview]
Message-ID: <20210728213934.5a0ee52e@xhacker> (raw)
In-Reply-To: <20210727221656.wq3ponbzhvftfxc5@mail.google.com>

On Wed, 28 Jul 2021 06:16:56 +0800
Changbin Du <changbin.du@gmail.com> wrote:

> On Mon, Jun 28, 2021 at 01:44:04PM +0800, Jisheng Zhang wrote:
> > On Sun, 27 Jun 2021 17:26:59 +0800
> > Changbin Du <changbin.du@gmail.com> wrote:
> > 
> >   
> > > 
> > > 
> > > Some places try to show backtrace with NULL task, and expect the task is
> > > 'current'. For example, dump_stack()->show_stack(NULL,...). So the
> > > stacktrace code should take care of this case.  
> > 
> > I fixed this issue one week ago:
> > 
> > http://lists.infradead.org/pipermail/linux-riscv/2021-June/007258.html  
> 
> I still see this issue on mainline. Is your fix merged? Thanks!

Nope, the fix is missed twice. Palmer has added the fix patch into
fix branch, I help it will be in next rc

Regards


WARNING: multiple messages have this Message-ID (diff)
From: Jisheng Zhang <jszhang3@mail.ustc.edu.cn>
To: Changbin Du <changbin.du@gmail.com>
Cc: Jisheng Zhang <Jisheng.Zhang@synaptics.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: stacktrace: fix dump_backtrace/walk_stackframe with NULL task
Date: Wed, 28 Jul 2021 21:39:34 +0800	[thread overview]
Message-ID: <20210728213934.5a0ee52e@xhacker> (raw)
In-Reply-To: <20210727221656.wq3ponbzhvftfxc5@mail.google.com>

On Wed, 28 Jul 2021 06:16:56 +0800
Changbin Du <changbin.du@gmail.com> wrote:

> On Mon, Jun 28, 2021 at 01:44:04PM +0800, Jisheng Zhang wrote:
> > On Sun, 27 Jun 2021 17:26:59 +0800
> > Changbin Du <changbin.du@gmail.com> wrote:
> > 
> >   
> > > 
> > > 
> > > Some places try to show backtrace with NULL task, and expect the task is
> > > 'current'. For example, dump_stack()->show_stack(NULL,...). So the
> > > stacktrace code should take care of this case.  
> > 
> > I fixed this issue one week ago:
> > 
> > http://lists.infradead.org/pipermail/linux-riscv/2021-June/007258.html  
> 
> I still see this issue on mainline. Is your fix merged? Thanks!

Nope, the fix is missed twice. Palmer has added the fix patch into
fix branch, I help it will be in next rc

Regards


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2021-07-28 13:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-27  9:26 [PATCH] riscv: stacktrace: fix dump_backtrace/walk_stackframe with NULL task Changbin Du
2021-06-27  9:26 ` Changbin Du
2021-06-28  5:44 ` Jisheng Zhang
2021-06-28  5:44   ` Jisheng Zhang
2021-06-28 23:20   ` Changbin Du
2021-06-28 23:20     ` Changbin Du
2021-07-27 22:16   ` Changbin Du
2021-07-27 22:16     ` Changbin Du
2021-07-28 13:39     ` Jisheng Zhang [this message]
2021-07-28 13:39       ` Jisheng Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210728213934.5a0ee52e@xhacker \
    --to=jszhang3@mail.ustc.edu.cn \
    --cc=Jisheng.Zhang@synaptics.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=changbin.du@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.