* [PATCH] selftests/net: remove min gso test in packet_snd
@ 2021-07-30 3:41 Dust Li
2021-08-02 9:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Dust Li @ 2021-07-30 3:41 UTC (permalink / raw)
To: Willem de Bruijn, Eric Dumazet; +Cc: Xuan Zhuo, netdev, Dust Li
This patch removed the 'raw gso min size - 1' test which
always fails now:
./in_netns.sh ./psock_snd -v -c -g -l "${mss}"
raw gso min size - 1 (expected to fail)
tx: 1524
rx: 1472
OK
After commit 7c6d2ecbda83 ("net: be more gentle about silly
gso requests coming from user"), we relaxed the min gso_size
check in virtio_net_hdr_to_skb().
So when a packet which is smaller then the gso_size,
GSO for this packet will not be set, the packet will be
send/recv successfully.
Signed-off-by: Dust Li <dust.li@linux.alibaba.com>
Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
---
tools/testing/selftests/net/psock_snd.sh | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tools/testing/selftests/net/psock_snd.sh b/tools/testing/selftests/net/psock_snd.sh
index 170be65e0816..1cbfeb5052ec 100755
--- a/tools/testing/selftests/net/psock_snd.sh
+++ b/tools/testing/selftests/net/psock_snd.sh
@@ -86,9 +86,6 @@ echo "raw truncate hlen - 1 (expected to fail: EINVAL)"
echo "raw gso min size"
./in_netns.sh ./psock_snd -v -c -g -l "${mss_exceeds}"
-echo "raw gso min size - 1 (expected to fail)"
-(! ./in_netns.sh ./psock_snd -v -c -g -l "${mss}")
-
echo "raw gso max size"
./in_netns.sh ./psock_snd -v -c -g -l "${max_mss}"
--
2.19.1.3.ge56e4f7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] selftests/net: remove min gso test in packet_snd
2021-07-30 3:41 [PATCH] selftests/net: remove min gso test in packet_snd Dust Li
@ 2021-08-02 9:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-08-02 9:40 UTC (permalink / raw)
To: Dust Li; +Cc: willemb, edumazet, xuanzhuo, netdev
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Fri, 30 Jul 2021 11:41:55 +0800 you wrote:
> This patch removed the 'raw gso min size - 1' test which
> always fails now:
> ./in_netns.sh ./psock_snd -v -c -g -l "${mss}"
> raw gso min size - 1 (expected to fail)
> tx: 1524
> rx: 1472
> OK
>
> [...]
Here is the summary with links:
- selftests/net: remove min gso test in packet_snd
https://git.kernel.org/netdev/net-next/c/cfba3fb68960
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-02 9:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-30 3:41 [PATCH] selftests/net: remove min gso test in packet_snd Dust Li
2021-08-02 9:40 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.