From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: John Ogness <john.ogness@linutronix.de>
Cc: chao.qin@intel.com, linux-kernel@vger.kernel.org,
linux-rt-users@vger.kernel.org, tglx@linutronix.de,
rostedt@goodmis.org, mgross@linux.intel.com, paul.mei@intel.com,
lili.li@intel.com
Subject: Re: [PREEMPT_RT][PATCH] printk: Enhance the condition check of msleep in pr_flush()
Date: Fri, 30 Jul 2021 16:01:43 +0200 [thread overview]
Message-ID: <20210730140143.53wls2g7xf2ktdgv@linutronix.de> (raw)
In-Reply-To: <87mtqiuzd4.fsf@jogness.linutronix.de>
On 2021-07-19 17:01:51 [+0206], John Ogness wrote:
> On 2021-07-19, chao.qin@intel.com wrote:
> > --- a/kernel/printk/printk.c
> > +++ b/kernel/printk/printk.c
> > @@ -3620,7 +3620,8 @@ bool pr_flush(int timeout_ms, bool reset_on_progress)
> > u64 diff;
> > u64 seq;
> >
> > - may_sleep = (preemptible() && !in_softirq());
> > + may_sleep = (preemptible() && !in_softirq()
> > + && (system_state >= SYSTEM_RUNNING));
I don't have more context but scheduling should work starting with
SYSTEM_SCHEDULING.
> >
> > seq = prb_next_seq(prb);
> >
> >
Sebastian
next prev parent reply other threads:[~2021-07-30 14:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 2:26 [PREEMPT_RT][PATCH] printk: Enhance the condition check of msleep in pr_flush() chao.qin
2021-07-19 14:55 ` John Ogness
2021-07-30 14:01 ` Sebastian Andrzej Siewior [this message]
2021-07-30 14:46 ` John Ogness
2021-08-02 6:08 ` Qin, Chao
2021-08-02 6:48 ` Sebastian Andrzej Siewior
2021-07-20 11:55 ` Joe Perches
2021-07-20 14:03 ` John Ogness
2021-07-21 1:42 ` Qin, Chao
2021-08-05 3:01 ` Qin, Chao
2021-08-05 12:21 ` John Ogness
2021-08-05 16:12 ` Steven Rostedt
2021-08-06 18:34 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210730140143.53wls2g7xf2ktdgv@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=chao.qin@intel.com \
--cc=john.ogness@linutronix.de \
--cc=lili.li@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=paul.mei@intel.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.