* [PATCH 2/2] qedr: Improve error logs for rdma_alloc_tid error return
2021-07-29 15:17 [PATCH 1/2] qed: Use accurate error num in qed_cxt_dynamic_ilt_alloc Prabhakar Kushwaha
@ 2021-07-29 15:17 ` Prabhakar Kushwaha
2021-07-30 14:33 ` [PATCH 1/2] qed: Use accurate error num in qed_cxt_dynamic_ilt_alloc Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Prabhakar Kushwaha @ 2021-07-29 15:17 UTC (permalink / raw)
To: linux-rdma, dledford, jgg, mkalderon
Cc: davem, kuba, smalin, aelior, pkushwaha, prabhakar.pkin, malin1024
Use -EINVAL return type to identify whether error is returned
because of "Out of MR resources" or any other error types.
Signed-off-by: Shai Malin <smalin@marvell.com>
Signed-off-by: Ariel Elior <aelior@marvell.com>
Signed-off-by: Prabhakar Kushwaha <pkushwaha@marvell.com>
---
drivers/infiniband/hw/qedr/verbs.c | 18 +++++++++++++++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/drivers/infiniband/hw/qedr/verbs.c b/drivers/infiniband/hw/qedr/verbs.c
index fdc47ef7d861..b72ef24db657 100644
--- a/drivers/infiniband/hw/qedr/verbs.c
+++ b/drivers/infiniband/hw/qedr/verbs.c
@@ -2996,7 +2996,11 @@ struct ib_mr *qedr_reg_user_mr(struct ib_pd *ibpd, u64 start, u64 len,
rc = dev->ops->rdma_alloc_tid(dev->rdma_ctx, &mr->hw_mr.itid);
if (rc) {
- DP_ERR(dev, "roce alloc tid returned an error %d\n", rc);
+ if (rc == -EINVAL)
+ DP_ERR(dev, "Out of MR resources\n");
+ else
+ DP_ERR(dev, "roce alloc tid returned error %d\n", rc);
+
goto err1;
}
@@ -3091,7 +3095,11 @@ static struct qedr_mr *__qedr_alloc_mr(struct ib_pd *ibpd,
rc = dev->ops->rdma_alloc_tid(dev->rdma_ctx, &mr->hw_mr.itid);
if (rc) {
- DP_ERR(dev, "roce alloc tid returned an error %d\n", rc);
+ if (rc == -EINVAL)
+ DP_ERR(dev, "Out of MR resources\n");
+ else
+ DP_ERR(dev, "roce alloc tid returned error %d\n", rc);
+
goto err0;
}
@@ -3221,7 +3229,11 @@ struct ib_mr *qedr_get_dma_mr(struct ib_pd *ibpd, int acc)
rc = dev->ops->rdma_alloc_tid(dev->rdma_ctx, &mr->hw_mr.itid);
if (rc) {
- DP_ERR(dev, "roce alloc tid returned an error %d\n", rc);
+ if (rc == -EINVAL)
+ DP_ERR(dev, "Out of MR resources\n");
+ else
+ DP_ERR(dev, "roce alloc tid returned error %d\n", rc);
+
goto err1;
}
--
2.24.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] qed: Use accurate error num in qed_cxt_dynamic_ilt_alloc
2021-07-29 15:17 [PATCH 1/2] qed: Use accurate error num in qed_cxt_dynamic_ilt_alloc Prabhakar Kushwaha
2021-07-29 15:17 ` [PATCH 2/2] qedr: Improve error logs for rdma_alloc_tid error return Prabhakar Kushwaha
@ 2021-07-30 14:33 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2021-07-30 14:33 UTC (permalink / raw)
To: Prabhakar Kushwaha
Cc: linux-rdma, dledford, mkalderon, davem, kuba, smalin, aelior,
prabhakar.pkin, malin1024
On Thu, Jul 29, 2021 at 06:17:31PM +0300, Prabhakar Kushwaha wrote:
> To have more accurate error return type use -EOPNOTSUPP instead
> of -EINVAL.
>
> Signed-off-by: Shai Malin <smalin@marvell.com>
> Signed-off-by: Ariel Elior <aelior@marvell.com>
> Signed-off-by: Prabhakar Kushwaha <pkushwaha@marvell.com>
> ---
> drivers/net/ethernet/qlogic/qed/qed_cxt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Both applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread