From: Leo Yan <leo.yan@linaro.org> To: James Clark <james.clark@arm.com> Cc: acme@kernel.org, mathieu.poirier@linaro.org, coresight@lists.linaro.org, al.grant@arm.com, suzuki.poulose@arm.com, anshuman.khandual@arm.com, mike.leach@linaro.org, John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH 1/6] perf cs-etm: Refactor initialisation of decoder params. Date: Sat, 31 Jul 2021 13:48:22 +0800 [thread overview] Message-ID: <20210731054822.GA7437@leoy-ThinkPad-X240s> (raw) In-Reply-To: <20210721090706.21523-2-james.clark@arm.com> On Wed, Jul 21, 2021 at 10:07:00AM +0100, James Clark wrote: > The initialisation of the decoder params is duplicated between > creation of the packet printer and packet decoder. Put them both > into one function so that future changes only need to be made in one > place. > > Signed-off-by: James Clark <james.clark@arm.com> It's good to wait for Mathieu's review, I reviewed this patch and it's good for me: Reviewed-by: Leo Yan <leo.yan@linaro.org> > --- > .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 99 +++++-------------- > 1 file changed, 25 insertions(+), 74 deletions(-) > > diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > index ed1f0326f859..30889a9d0165 100644 > --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > @@ -227,55 +227,6 @@ cs_etm_decoder__init_raw_frame_logging( > } > #endif > > -static int cs_etm_decoder__create_packet_printer(struct cs_etm_decoder *decoder, > - const char *decoder_name, > - void *trace_config) > -{ > - u8 csid; > - > - if (ocsd_dt_create_decoder(decoder->dcd_tree, decoder_name, > - OCSD_CREATE_FLG_PACKET_PROC, > - trace_config, &csid)) > - return -1; > - > - if (ocsd_dt_set_pkt_protocol_printer(decoder->dcd_tree, csid, 0)) > - return -1; > - > - return 0; > -} > - > -static int > -cs_etm_decoder__create_etm_packet_printer(struct cs_etm_trace_params *t_params, > - struct cs_etm_decoder *decoder) > -{ > - const char *decoder_name; > - ocsd_etmv3_cfg config_etmv3; > - ocsd_etmv4_cfg trace_config_etmv4; > - void *trace_config; > - > - switch (t_params->protocol) { > - case CS_ETM_PROTO_ETMV3: > - case CS_ETM_PROTO_PTM: > - cs_etm_decoder__gen_etmv3_config(t_params, &config_etmv3); > - decoder_name = (t_params->protocol == CS_ETM_PROTO_ETMV3) ? > - OCSD_BUILTIN_DCD_ETMV3 : > - OCSD_BUILTIN_DCD_PTM; > - trace_config = &config_etmv3; > - break; > - case CS_ETM_PROTO_ETMV4i: > - cs_etm_decoder__gen_etmv4_config(t_params, &trace_config_etmv4); > - decoder_name = OCSD_BUILTIN_DCD_ETMV4I; > - trace_config = &trace_config_etmv4; > - break; > - default: > - return -1; > - } > - > - return cs_etm_decoder__create_packet_printer(decoder, > - decoder_name, > - trace_config); > -} > - > static ocsd_datapath_resp_t > cs_etm_decoder__do_soft_timestamp(struct cs_etm_queue *etmq, > struct cs_etm_packet_queue *packet_queue, > @@ -629,9 +580,10 @@ static ocsd_datapath_resp_t cs_etm_decoder__gen_trace_elem_printer( > return resp; > } > > -static int cs_etm_decoder__create_etm_packet_decoder( > - struct cs_etm_trace_params *t_params, > - struct cs_etm_decoder *decoder) > +static int > +cs_etm_decoder__create_etm_decoder(struct cs_etm_decoder_params *d_params, > + struct cs_etm_trace_params *t_params, > + struct cs_etm_decoder *decoder) > { > const char *decoder_name; > ocsd_etmv3_cfg config_etmv3; > @@ -657,31 +609,30 @@ static int cs_etm_decoder__create_etm_packet_decoder( > return -1; > } > > - if (ocsd_dt_create_decoder(decoder->dcd_tree, > - decoder_name, > - OCSD_CREATE_FLG_FULL_DECODER, > - trace_config, &csid)) > - return -1; > + if (d_params->operation == CS_ETM_OPERATION_DECODE) { > + if (ocsd_dt_create_decoder(decoder->dcd_tree, > + decoder_name, > + OCSD_CREATE_FLG_FULL_DECODER, > + trace_config, &csid)) > + return -1; > > - if (ocsd_dt_set_gen_elem_outfn(decoder->dcd_tree, > - cs_etm_decoder__gen_trace_elem_printer, > - decoder)) > - return -1; > + if (ocsd_dt_set_gen_elem_outfn(decoder->dcd_tree, > + cs_etm_decoder__gen_trace_elem_printer, > + decoder)) > + return -1; > > - return 0; > -} > + return 0; > + } else if (d_params->operation == CS_ETM_OPERATION_PRINT) { > + if (ocsd_dt_create_decoder(decoder->dcd_tree, decoder_name, > + OCSD_CREATE_FLG_PACKET_PROC, > + trace_config, &csid)) > + return -1; > > -static int > -cs_etm_decoder__create_etm_decoder(struct cs_etm_decoder_params *d_params, > - struct cs_etm_trace_params *t_params, > - struct cs_etm_decoder *decoder) > -{ > - if (d_params->operation == CS_ETM_OPERATION_PRINT) > - return cs_etm_decoder__create_etm_packet_printer(t_params, > - decoder); > - else if (d_params->operation == CS_ETM_OPERATION_DECODE) > - return cs_etm_decoder__create_etm_packet_decoder(t_params, > - decoder); > + if (ocsd_dt_set_pkt_protocol_printer(decoder->dcd_tree, csid, 0)) > + return -1; > + > + return 0; > + } > > return -1; > } > -- > 2.28.0 >
WARNING: multiple messages have this Message-ID (diff)
From: Leo Yan <leo.yan@linaro.org> To: James Clark <james.clark@arm.com> Cc: acme@kernel.org, mathieu.poirier@linaro.org, coresight@lists.linaro.org, al.grant@arm.com, suzuki.poulose@arm.com, anshuman.khandual@arm.com, mike.leach@linaro.org, John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH 1/6] perf cs-etm: Refactor initialisation of decoder params. Date: Sat, 31 Jul 2021 13:48:22 +0800 [thread overview] Message-ID: <20210731054822.GA7437@leoy-ThinkPad-X240s> (raw) In-Reply-To: <20210721090706.21523-2-james.clark@arm.com> On Wed, Jul 21, 2021 at 10:07:00AM +0100, James Clark wrote: > The initialisation of the decoder params is duplicated between > creation of the packet printer and packet decoder. Put them both > into one function so that future changes only need to be made in one > place. > > Signed-off-by: James Clark <james.clark@arm.com> It's good to wait for Mathieu's review, I reviewed this patch and it's good for me: Reviewed-by: Leo Yan <leo.yan@linaro.org> > --- > .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 99 +++++-------------- > 1 file changed, 25 insertions(+), 74 deletions(-) > > diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > index ed1f0326f859..30889a9d0165 100644 > --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > @@ -227,55 +227,6 @@ cs_etm_decoder__init_raw_frame_logging( > } > #endif > > -static int cs_etm_decoder__create_packet_printer(struct cs_etm_decoder *decoder, > - const char *decoder_name, > - void *trace_config) > -{ > - u8 csid; > - > - if (ocsd_dt_create_decoder(decoder->dcd_tree, decoder_name, > - OCSD_CREATE_FLG_PACKET_PROC, > - trace_config, &csid)) > - return -1; > - > - if (ocsd_dt_set_pkt_protocol_printer(decoder->dcd_tree, csid, 0)) > - return -1; > - > - return 0; > -} > - > -static int > -cs_etm_decoder__create_etm_packet_printer(struct cs_etm_trace_params *t_params, > - struct cs_etm_decoder *decoder) > -{ > - const char *decoder_name; > - ocsd_etmv3_cfg config_etmv3; > - ocsd_etmv4_cfg trace_config_etmv4; > - void *trace_config; > - > - switch (t_params->protocol) { > - case CS_ETM_PROTO_ETMV3: > - case CS_ETM_PROTO_PTM: > - cs_etm_decoder__gen_etmv3_config(t_params, &config_etmv3); > - decoder_name = (t_params->protocol == CS_ETM_PROTO_ETMV3) ? > - OCSD_BUILTIN_DCD_ETMV3 : > - OCSD_BUILTIN_DCD_PTM; > - trace_config = &config_etmv3; > - break; > - case CS_ETM_PROTO_ETMV4i: > - cs_etm_decoder__gen_etmv4_config(t_params, &trace_config_etmv4); > - decoder_name = OCSD_BUILTIN_DCD_ETMV4I; > - trace_config = &trace_config_etmv4; > - break; > - default: > - return -1; > - } > - > - return cs_etm_decoder__create_packet_printer(decoder, > - decoder_name, > - trace_config); > -} > - > static ocsd_datapath_resp_t > cs_etm_decoder__do_soft_timestamp(struct cs_etm_queue *etmq, > struct cs_etm_packet_queue *packet_queue, > @@ -629,9 +580,10 @@ static ocsd_datapath_resp_t cs_etm_decoder__gen_trace_elem_printer( > return resp; > } > > -static int cs_etm_decoder__create_etm_packet_decoder( > - struct cs_etm_trace_params *t_params, > - struct cs_etm_decoder *decoder) > +static int > +cs_etm_decoder__create_etm_decoder(struct cs_etm_decoder_params *d_params, > + struct cs_etm_trace_params *t_params, > + struct cs_etm_decoder *decoder) > { > const char *decoder_name; > ocsd_etmv3_cfg config_etmv3; > @@ -657,31 +609,30 @@ static int cs_etm_decoder__create_etm_packet_decoder( > return -1; > } > > - if (ocsd_dt_create_decoder(decoder->dcd_tree, > - decoder_name, > - OCSD_CREATE_FLG_FULL_DECODER, > - trace_config, &csid)) > - return -1; > + if (d_params->operation == CS_ETM_OPERATION_DECODE) { > + if (ocsd_dt_create_decoder(decoder->dcd_tree, > + decoder_name, > + OCSD_CREATE_FLG_FULL_DECODER, > + trace_config, &csid)) > + return -1; > > - if (ocsd_dt_set_gen_elem_outfn(decoder->dcd_tree, > - cs_etm_decoder__gen_trace_elem_printer, > - decoder)) > - return -1; > + if (ocsd_dt_set_gen_elem_outfn(decoder->dcd_tree, > + cs_etm_decoder__gen_trace_elem_printer, > + decoder)) > + return -1; > > - return 0; > -} > + return 0; > + } else if (d_params->operation == CS_ETM_OPERATION_PRINT) { > + if (ocsd_dt_create_decoder(decoder->dcd_tree, decoder_name, > + OCSD_CREATE_FLG_PACKET_PROC, > + trace_config, &csid)) > + return -1; > > -static int > -cs_etm_decoder__create_etm_decoder(struct cs_etm_decoder_params *d_params, > - struct cs_etm_trace_params *t_params, > - struct cs_etm_decoder *decoder) > -{ > - if (d_params->operation == CS_ETM_OPERATION_PRINT) > - return cs_etm_decoder__create_etm_packet_printer(t_params, > - decoder); > - else if (d_params->operation == CS_ETM_OPERATION_DECODE) > - return cs_etm_decoder__create_etm_packet_decoder(t_params, > - decoder); > + if (ocsd_dt_set_pkt_protocol_printer(decoder->dcd_tree, csid, 0)) > + return -1; > + > + return 0; > + } > > return -1; > } > -- > 2.28.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-31 5:48 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-21 9:06 [PATCH 0/6] Support ETE decoding James Clark 2021-07-21 9:06 ` James Clark 2021-07-21 9:07 ` [PATCH 1/6] perf cs-etm: Refactor initialisation of decoder params James Clark 2021-07-21 9:07 ` James Clark 2021-07-31 5:48 ` Leo Yan [this message] 2021-07-31 5:48 ` Leo Yan 2021-07-21 9:07 ` [PATCH 2/6] perf cs-etm: Initialise architecture based on TRCIDR1 James Clark 2021-07-21 9:07 ` James Clark 2021-07-22 11:10 ` Mike Leach 2021-07-22 11:10 ` Mike Leach 2021-07-31 6:03 ` Leo Yan 2021-07-31 6:03 ` Leo Yan 2021-08-02 14:04 ` Mike Leach 2021-08-02 14:04 ` Mike Leach 2021-08-02 15:03 ` Leo Yan 2021-08-02 15:03 ` Leo Yan 2021-08-02 15:43 ` Mike Leach 2021-08-02 15:43 ` Mike Leach 2021-07-21 9:07 ` [PATCH 3/6] perf cs-etm: Save TRCDEVARCH register James Clark 2021-07-21 9:07 ` James Clark 2021-07-21 9:48 ` Mike Leach 2021-07-21 9:48 ` Mike Leach 2021-07-23 12:09 ` James Clark 2021-07-23 12:09 ` James Clark 2021-07-31 6:37 ` Leo Yan 2021-07-31 6:37 ` Leo Yan 2021-08-03 12:33 ` James Clark 2021-08-03 12:33 ` James Clark 2021-08-03 12:34 ` James Clark 2021-08-03 12:34 ` James Clark 2021-08-05 9:40 ` Leo Yan 2021-08-05 9:40 ` Leo Yan 2021-08-03 12:36 ` James Clark 2021-08-03 12:36 ` James Clark 2021-07-31 7:43 ` Leo Yan 2021-07-31 7:43 ` Leo Yan 2021-08-02 11:21 ` Mike Leach 2021-08-02 11:21 ` Mike Leach 2021-08-02 12:05 ` Leo Yan 2021-08-02 12:05 ` Leo Yan 2021-08-02 12:48 ` Mike Leach 2021-08-02 12:48 ` Mike Leach 2021-08-03 12:29 ` James Clark 2021-08-03 12:29 ` James Clark 2021-07-21 9:07 ` [PATCH 4/6] perf cs-etm: Update OpenCSD decoder for ETE James Clark 2021-07-21 9:07 ` James Clark 2021-07-31 6:50 ` Leo Yan 2021-07-31 6:50 ` Leo Yan 2021-07-21 9:07 ` [PATCH 5/6] perf cs-etm: Create ETE decoder James Clark 2021-07-21 9:07 ` James Clark 2021-07-31 7:23 ` Leo Yan 2021-07-31 7:23 ` Leo Yan 2021-08-03 13:09 ` James Clark 2021-08-03 13:09 ` James Clark 2021-08-05 10:59 ` Leo Yan 2021-08-05 10:59 ` Leo Yan 2021-07-21 9:07 ` [PATCH 6/6] perf cs-etm: Print the decoder name James Clark 2021-07-21 9:07 ` James Clark 2021-07-31 7:30 ` Leo Yan 2021-07-31 7:30 ` Leo Yan 2021-08-06 9:43 ` James Clark 2021-08-06 9:43 ` James Clark 2021-08-06 11:52 ` Leo Yan 2021-08-06 11:52 ` Leo Yan 2021-07-21 14:59 ` [PATCH 0/6] Support ETE decoding Mathieu Poirier 2021-07-21 14:59 ` Mathieu Poirier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210731054822.GA7437@leoy-ThinkPad-X240s \ --to=leo.yan@linaro.org \ --cc=acme@kernel.org \ --cc=al.grant@arm.com \ --cc=alexander.shishkin@linux.intel.com \ --cc=anshuman.khandual@arm.com \ --cc=coresight@lists.linaro.org \ --cc=james.clark@arm.com \ --cc=john.garry@huawei.com \ --cc=jolsa@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-perf-users@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mathieu.poirier@linaro.org \ --cc=mike.leach@linaro.org \ --cc=namhyung@kernel.org \ --cc=suzuki.poulose@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.