* [meta-virtualization][PATCH] xen-image-minimal: fix aarch64 build for non-qemuboot-enabled machines
@ 2021-08-02 1:26 Christopher Clark
2021-08-02 3:48 ` Bruce Ashfield
2021-08-02 19:51 ` Bruce Ashfield
0 siblings, 2 replies; 4+ messages in thread
From: Christopher Clark @ 2021-08-02 1:26 UTC (permalink / raw)
To: meta-virtualization; +Cc: bruce.ashfield, cardoe, jdmason, christopher.clark
The qemuboot device tree generation task in qemuboot-xen-dtb.bbclass
requires the QB_SYSTEM_NAME variable to be set to identify the Qemu
binary to use. Skip the task if it is not set.
Reported-by: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Christopher Clark <christopher.clark@starlab.io>
---
classes/qemuboot-xen-dtb.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/classes/qemuboot-xen-dtb.bbclass b/classes/qemuboot-xen-dtb.bbclass
index 08f9b02..2d37e91 100644
--- a/classes/qemuboot-xen-dtb.bbclass
+++ b/classes/qemuboot-xen-dtb.bbclass
@@ -176,7 +176,7 @@ do_write_xen_qemuboot_dtb() {
# Not all architectures qemuboot with a device tree binary, so check
# to see if one is needed. This allows this bbclass file to be used
# in the same image recipe for multiple architectures.
- if [ -n "${QB_DTB}" ] ; then
+ if [ -n "${QB_DTB}" ] && [ -n "${QB_SYSTEM_NAME}" ] ; then
generate_xen_qemuboot_dtb
fi
}
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [meta-virtualization][PATCH] xen-image-minimal: fix aarch64 build for non-qemuboot-enabled machines
2021-08-02 1:26 [meta-virtualization][PATCH] xen-image-minimal: fix aarch64 build for non-qemuboot-enabled machines Christopher Clark
@ 2021-08-02 3:48 ` Bruce Ashfield
2021-08-02 13:55 ` Jon Mason
2021-08-02 19:51 ` Bruce Ashfield
1 sibling, 1 reply; 4+ messages in thread
From: Bruce Ashfield @ 2021-08-02 3:48 UTC (permalink / raw)
To: Christopher Clark; +Cc: meta-virtualization, cardoe, jdmason, christopher.clark
Looks good to me.
I'll wait to hear from Jon that it fixes his problem before merging.
Cheers,
Bruce
In message: [meta-virtualization][PATCH] xen-image-minimal: fix aarch64 build for non-qemuboot-enabled machines
on 01/08/2021 Christopher Clark wrote:
> The qemuboot device tree generation task in qemuboot-xen-dtb.bbclass
> requires the QB_SYSTEM_NAME variable to be set to identify the Qemu
> binary to use. Skip the task if it is not set.
>
> Reported-by: Jon Mason <jdmason@kudzu.us>
> Signed-off-by: Christopher Clark <christopher.clark@starlab.io>
> ---
> classes/qemuboot-xen-dtb.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/classes/qemuboot-xen-dtb.bbclass b/classes/qemuboot-xen-dtb.bbclass
> index 08f9b02..2d37e91 100644
> --- a/classes/qemuboot-xen-dtb.bbclass
> +++ b/classes/qemuboot-xen-dtb.bbclass
> @@ -176,7 +176,7 @@ do_write_xen_qemuboot_dtb() {
> # Not all architectures qemuboot with a device tree binary, so check
> # to see if one is needed. This allows this bbclass file to be used
> # in the same image recipe for multiple architectures.
> - if [ -n "${QB_DTB}" ] ; then
> + if [ -n "${QB_DTB}" ] && [ -n "${QB_SYSTEM_NAME}" ] ; then
> generate_xen_qemuboot_dtb
> fi
> }
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [meta-virtualization][PATCH] xen-image-minimal: fix aarch64 build for non-qemuboot-enabled machines
2021-08-02 3:48 ` Bruce Ashfield
@ 2021-08-02 13:55 ` Jon Mason
0 siblings, 0 replies; 4+ messages in thread
From: Jon Mason @ 2021-08-02 13:55 UTC (permalink / raw)
To: Bruce Ashfield
Cc: Christopher Clark, meta-virtualization, cardoe, Christopher Clark
On Sun, Aug 1, 2021 at 11:49 PM Bruce Ashfield <bruce.ashfield@gmail.com> wrote:
>
> Looks good to me.
>
> I'll wait to hear from Jon that it fixes his problem before merging.
Fix confirmed. Feel free to add
Reported-and-tested-by: Jon Mason <jdmason@kudzu.us>
:)
>
> Cheers,
>
> Bruce
>
> In message: [meta-virtualization][PATCH] xen-image-minimal: fix aarch64 build for non-qemuboot-enabled machines
> on 01/08/2021 Christopher Clark wrote:
> > The qemuboot device tree generation task in qemuboot-xen-dtb.bbclass
> > requires the QB_SYSTEM_NAME variable to be set to identify the Qemu
> > binary to use. Skip the task if it is not set.
> >
> > Reported-by: Jon Mason <jdmason@kudzu.us>
> > Signed-off-by: Christopher Clark <christopher.clark@starlab.io>
> > ---
> > classes/qemuboot-xen-dtb.bbclass | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/classes/qemuboot-xen-dtb.bbclass b/classes/qemuboot-xen-dtb.bbclass
> > index 08f9b02..2d37e91 100644
> > --- a/classes/qemuboot-xen-dtb.bbclass
> > +++ b/classes/qemuboot-xen-dtb.bbclass
> > @@ -176,7 +176,7 @@ do_write_xen_qemuboot_dtb() {
> > # Not all architectures qemuboot with a device tree binary, so check
> > # to see if one is needed. This allows this bbclass file to be used
> > # in the same image recipe for multiple architectures.
> > - if [ -n "${QB_DTB}" ] ; then
> > + if [ -n "${QB_DTB}" ] && [ -n "${QB_SYSTEM_NAME}" ] ; then
> > generate_xen_qemuboot_dtb
> > fi
> > }
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [meta-virtualization][PATCH] xen-image-minimal: fix aarch64 build for non-qemuboot-enabled machines
2021-08-02 1:26 [meta-virtualization][PATCH] xen-image-minimal: fix aarch64 build for non-qemuboot-enabled machines Christopher Clark
2021-08-02 3:48 ` Bruce Ashfield
@ 2021-08-02 19:51 ` Bruce Ashfield
1 sibling, 0 replies; 4+ messages in thread
From: Bruce Ashfield @ 2021-08-02 19:51 UTC (permalink / raw)
To: Christopher Clark; +Cc: meta-virtualization, cardoe, jdmason, christopher.clark
merged.
Bruce
In message: [meta-virtualization][PATCH] xen-image-minimal: fix aarch64 build for non-qemuboot-enabled machines
on 01/08/2021 Christopher Clark wrote:
> The qemuboot device tree generation task in qemuboot-xen-dtb.bbclass
> requires the QB_SYSTEM_NAME variable to be set to identify the Qemu
> binary to use. Skip the task if it is not set.
>
> Reported-by: Jon Mason <jdmason@kudzu.us>
> Signed-off-by: Christopher Clark <christopher.clark@starlab.io>
> ---
> classes/qemuboot-xen-dtb.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/classes/qemuboot-xen-dtb.bbclass b/classes/qemuboot-xen-dtb.bbclass
> index 08f9b02..2d37e91 100644
> --- a/classes/qemuboot-xen-dtb.bbclass
> +++ b/classes/qemuboot-xen-dtb.bbclass
> @@ -176,7 +176,7 @@ do_write_xen_qemuboot_dtb() {
> # Not all architectures qemuboot with a device tree binary, so check
> # to see if one is needed. This allows this bbclass file to be used
> # in the same image recipe for multiple architectures.
> - if [ -n "${QB_DTB}" ] ; then
> + if [ -n "${QB_DTB}" ] && [ -n "${QB_SYSTEM_NAME}" ] ; then
> generate_xen_qemuboot_dtb
> fi
> }
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-02 19:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-02 1:26 [meta-virtualization][PATCH] xen-image-minimal: fix aarch64 build for non-qemuboot-enabled machines Christopher Clark
2021-08-02 3:48 ` Bruce Ashfield
2021-08-02 13:55 ` Jon Mason
2021-08-02 19:51 ` Bruce Ashfield
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.