All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Shawn Guo <shawnguo@kernel.org>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"David Airlie" <airlied@linux.ie>,
	"Olof Johansson" <olof@lixom.net>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	soc@kernel.org, "Thierry Reding" <thierry.reding@gmail.com>,
	"Sam Ravnborg" <sam@ravnborg.org>, "Søren Andersen" <san@skov.dk>,
	"Juergen Borleis" <jbe@pengutronix.de>,
	"Ulrich Ölmann" <u.oelmann@pengutronix.de>,
	"Michael Grzeschik" <m.grzeschik@pengutronix.de>,
	"Marco Felsch" <m.felsch@pengutronix.de>,
	"Lucas Stach" <l.stach@pengutronix.de>,
	devicetree@vger.kernel.org, "Fabio Estevam" <festevam@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 4/4] ARM: dts: add SKOV imx6q and imx6dl based boards
Date: Mon, 2 Aug 2021 11:21:00 +0200	[thread overview]
Message-ID: <20210802092100.ctkncu6g4ka4rvtt@pengutronix.de> (raw)
In-Reply-To: <20210726012043.GC5901@dragon>

[...]
> > +	reg_vcc_mmc_io: regulator-vcc-mmc-io {
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&pinctrl_vcc_mmc_io>;
> > +		compatible = "regulator-gpio";
> > +		vin-supply = <&reg_5v0>;
> > +		regulator-name = "mmc_io_supply";
> > +		regulator-type = "voltage";
> > +		regulator-min-microvolt = <1800000>;
> > +		regulator-max-microvolt = <3300000>;
> > +		gpios = <&gpio7 13 GPIO_ACTIVE_HIGH>;
> 
> enable-active-high?

right, thx!

> > +		states = <1800000 0x1>, <3300000 0x0>;
> 
> Hmm, I do not see this 'states' in fixed-regulator.yaml.

It is in gpio-regulator.yaml

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

WARNING: multiple messages have this Message-ID (diff)
From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Shawn Guo <shawnguo@kernel.org>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"David Airlie" <airlied@linux.ie>,
	"Olof Johansson" <olof@lixom.net>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	soc@kernel.org, "Thierry Reding" <thierry.reding@gmail.com>,
	"Sam Ravnborg" <sam@ravnborg.org>, "Søren Andersen" <san@skov.dk>,
	"Juergen Borleis" <jbe@pengutronix.de>,
	"Ulrich Ölmann" <u.oelmann@pengutronix.de>,
	"Michael Grzeschik" <m.grzeschik@pengutronix.de>,
	"Marco Felsch" <m.felsch@pengutronix.de>,
	"Lucas Stach" <l.stach@pengutronix.de>,
	devicetree@vger.kernel.org, "Fabio Estevam" <festevam@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 4/4] ARM: dts: add SKOV imx6q and imx6dl based boards
Date: Mon, 2 Aug 2021 11:21:00 +0200	[thread overview]
Message-ID: <20210802092100.ctkncu6g4ka4rvtt@pengutronix.de> (raw)
Message-ID: <20210802092100.Pt9cDNeA1fOasYZPwrrjxTcnOZKou760X5IxnIdY5G4@z> (raw)
In-Reply-To: <20210726012043.GC5901@dragon>

[...]
> > +	reg_vcc_mmc_io: regulator-vcc-mmc-io {
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&pinctrl_vcc_mmc_io>;
> > +		compatible = "regulator-gpio";
> > +		vin-supply = <&reg_5v0>;
> > +		regulator-name = "mmc_io_supply";
> > +		regulator-type = "voltage";
> > +		regulator-min-microvolt = <1800000>;
> > +		regulator-max-microvolt = <3300000>;
> > +		gpios = <&gpio7 13 GPIO_ACTIVE_HIGH>;
> 
> enable-active-high?

right, thx!

> > +		states = <1800000 0x1>, <3300000 0x0>;
> 
> Hmm, I do not see this 'states' in fixed-regulator.yaml.

It is in gpio-regulator.yaml

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-08-02  9:21 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-14  4:53 [PATCH v2 0/4] Mainline imx6 based SKOV boards Oleksij Rempel
2021-07-14  4:53 ` Oleksij Rempel
2021-07-14  4:53 ` Oleksij Rempel
2021-07-14  4:53 ` [PATCH v2 1/4] dt-bindings: display: simple: add some Logic Technologies and Multi-Inno panels Oleksij Rempel
2021-07-14  4:53   ` Oleksij Rempel
2021-07-14  4:53   ` Oleksij Rempel
2021-07-14 16:37   ` Rob Herring
2021-07-14 16:37     ` Rob Herring
2021-07-14 16:37     ` Rob Herring
2021-07-25 12:04   ` Sam Ravnborg
2021-07-25 12:04     ` Sam Ravnborg
2021-07-25 12:04     ` Sam Ravnborg
2021-07-14  4:53 ` [PATCH v2 2/4] dt-bindings: vendor-prefixes: Add an entry for SKOV A/S Oleksij Rempel
2021-07-14  4:53   ` Oleksij Rempel
2021-07-14  4:53   ` Oleksij Rempel
2021-07-14 16:37   ` Rob Herring
2021-07-14 16:37     ` Rob Herring
2021-07-14 16:37     ` Rob Herring
2021-07-14  4:53 ` [PATCH v2 3/4] dt-bindings: arm: fsl: add SKOV imx6q and imx6dl based boards Oleksij Rempel
2021-07-14  4:53   ` Oleksij Rempel
2021-07-14  4:53   ` Oleksij Rempel
2021-07-14 16:37   ` Rob Herring
2021-07-14 16:37     ` Rob Herring
2021-07-14 16:37     ` Rob Herring
2021-07-14  4:53 ` [PATCH v2 4/4] ARM: dts: " Oleksij Rempel
2021-07-14  4:53   ` Oleksij Rempel
2021-07-14  4:53   ` Oleksij Rempel
2021-07-18 20:22   ` Sam Ravnborg
2021-07-18 20:22     ` Sam Ravnborg
2021-07-18 20:22     ` Sam Ravnborg
2021-07-23  3:01     ` Shawn Guo
2021-07-23  3:01       ` Shawn Guo
2021-07-23  3:01       ` Shawn Guo
2021-07-26  1:20   ` Shawn Guo
2021-07-26  1:20     ` Shawn Guo
2021-07-26  1:20     ` Shawn Guo
2021-08-02  9:21     ` Oleksij Rempel [this message]
2021-08-02  9:21       ` Oleksij Rempel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210802092100.ctkncu6g4ka4rvtt@pengutronix.de \
    --to=o.rempel@pengutronix.de \
    --cc=airlied@linux.ie \
    --cc=arnd@arndb.de \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=festevam@gmail.com \
    --cc=jbe@pengutronix.de \
    --cc=kernel@pengutronix.de \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.felsch@pengutronix.de \
    --cc=m.grzeschik@pengutronix.de \
    --cc=olof@lixom.net \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sam@ravnborg.org \
    --cc=san@skov.dk \
    --cc=shawnguo@kernel.org \
    --cc=soc@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=u.oelmann@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.