From: Leo Yan <leo.yan@linaro.org> To: James Clark <james.clark@arm.com> Cc: acme@kernel.org, mathieu.poirier@linaro.org, coresight@lists.linaro.org, linux-perf-users@vger.kernel.org, suzuki.poulose@arm.com, mike.leach@linaro.org, Mark Rutland <mark.rutland@arm.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>, John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH 5/6] perf cs-etm: Improve Coresight zero timestamp warning Date: Mon, 2 Aug 2021 23:17:10 +0800 [thread overview] Message-ID: <20210802151710.GB148327@leoy-ThinkPad-X240s> (raw) In-Reply-To: <20210729155805.2830-6-james.clark@arm.com> On Thu, Jul 29, 2021 at 04:58:04PM +0100, James Clark wrote: > Only show the warning if the user hasn't already set timeless mode and > improve the text because there was ambiguity around the meaning of '...' > > Change the warning to a UI warning instead of printing straight to > stderr because this corrupts the UI when perf report TUI is used. The UI > warning function also handles printing to stderr when in perf script > mode. > > Suggested-by: Leo Yan <leo.yan@linaro.org> > Signed-off-by: James Clark <james.clark@arm.com> Reviewed-by: Leo Yan <leo.yan@linaro.org> > --- > tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > index 3e1a05bc82cc..5084bd2ca6eb 100644 > --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > @@ -324,8 +324,11 @@ cs_etm_decoder__do_hard_timestamp(struct cs_etm_queue *etmq, > * underflow. > */ > packet_queue->cs_timestamp = 0; > - WARN_ONCE(true, "Zero Coresight timestamp found at Idx:%" OCSD_TRC_IDX_STR > - ". Decoding may be improved with --itrace=Z...\n", indx); > + if (!cs_etm__etmq_is_timeless(etmq)) > + pr_warning_once("Zero Coresight timestamp found at Idx:%" OCSD_TRC_IDX_STR > + ". Decoding may be improved by prepending 'Z' to your current --itrace arguments.\n", > + indx); > + > } else if (packet_queue->instr_count > elem->timestamp) { > /* > * Sanity check that the elem->timestamp - packet_queue->instr_count would not > -- > 2.28.0 >
WARNING: multiple messages have this Message-ID (diff)
From: Leo Yan <leo.yan@linaro.org> To: James Clark <james.clark@arm.com> Cc: acme@kernel.org, mathieu.poirier@linaro.org, coresight@lists.linaro.org, linux-perf-users@vger.kernel.org, suzuki.poulose@arm.com, mike.leach@linaro.org, Mark Rutland <mark.rutland@arm.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>, John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH 5/6] perf cs-etm: Improve Coresight zero timestamp warning Date: Mon, 2 Aug 2021 23:17:10 +0800 [thread overview] Message-ID: <20210802151710.GB148327@leoy-ThinkPad-X240s> (raw) In-Reply-To: <20210729155805.2830-6-james.clark@arm.com> On Thu, Jul 29, 2021 at 04:58:04PM +0100, James Clark wrote: > Only show the warning if the user hasn't already set timeless mode and > improve the text because there was ambiguity around the meaning of '...' > > Change the warning to a UI warning instead of printing straight to > stderr because this corrupts the UI when perf report TUI is used. The UI > warning function also handles printing to stderr when in perf script > mode. > > Suggested-by: Leo Yan <leo.yan@linaro.org> > Signed-off-by: James Clark <james.clark@arm.com> Reviewed-by: Leo Yan <leo.yan@linaro.org> > --- > tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > index 3e1a05bc82cc..5084bd2ca6eb 100644 > --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > @@ -324,8 +324,11 @@ cs_etm_decoder__do_hard_timestamp(struct cs_etm_queue *etmq, > * underflow. > */ > packet_queue->cs_timestamp = 0; > - WARN_ONCE(true, "Zero Coresight timestamp found at Idx:%" OCSD_TRC_IDX_STR > - ". Decoding may be improved with --itrace=Z...\n", indx); > + if (!cs_etm__etmq_is_timeless(etmq)) > + pr_warning_once("Zero Coresight timestamp found at Idx:%" OCSD_TRC_IDX_STR > + ". Decoding may be improved by prepending 'Z' to your current --itrace arguments.\n", > + indx); > + > } else if (packet_queue->instr_count > elem->timestamp) { > /* > * Sanity check that the elem->timestamp - packet_queue->instr_count would not > -- > 2.28.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-02 15:17 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-29 15:57 [RFC PATCH 0/6] perf tools: Warning fixes James Clark 2021-07-29 15:57 ` James Clark 2021-07-29 15:58 ` [RFC PATCH 1/6] perf tools: Add WARN_ONCE equivalent for UI warnings James Clark 2021-07-29 15:58 ` James Clark 2021-08-02 14:44 ` Arnaldo Carvalho de Melo 2021-08-02 14:44 ` Arnaldo Carvalho de Melo 2021-07-29 15:58 ` [RFC PATCH 2/6] perf tools: Re-add annotate_warned functionality James Clark 2021-07-29 15:58 ` James Clark 2021-07-29 15:58 ` [RFC PATCH 3/6] perf tools: Add disassembly warnings for annotate --stdio James Clark 2021-07-29 15:58 ` James Clark 2021-07-29 15:58 ` [RFC PATCH 4/6] perf tools: Add flag for tracking warnings of missing DSOs James Clark 2021-07-29 15:58 ` James Clark 2021-07-29 15:58 ` [RFC PATCH 5/6] perf cs-etm: Improve Coresight zero timestamp warning James Clark 2021-07-29 15:58 ` James Clark 2021-08-02 15:17 ` Leo Yan [this message] 2021-08-02 15:17 ` Leo Yan 2021-08-03 13:25 ` Arnaldo Carvalho de Melo 2021-08-03 13:25 ` Arnaldo Carvalho de Melo 2021-07-29 15:58 ` [RFC PATCH 6/6] perf cs-etm: Add warnings for missing DSOs James Clark 2021-07-29 15:58 ` James Clark 2021-08-02 14:51 ` Arnaldo Carvalho de Melo 2021-08-02 14:51 ` Arnaldo Carvalho de Melo 2021-08-02 17:03 ` Mathieu Poirier 2021-08-02 17:03 ` Mathieu Poirier 2021-08-03 8:06 ` Mike Leach 2021-08-03 8:06 ` Mike Leach 2021-08-02 15:41 ` Leo Yan 2021-08-02 15:41 ` Leo Yan 2021-08-03 13:24 ` Arnaldo Carvalho de Melo 2021-08-03 13:24 ` Arnaldo Carvalho de Melo 2021-08-03 14:01 ` Leo Yan 2021-08-03 14:01 ` Leo Yan 2021-08-05 12:59 ` James Clark 2021-08-05 12:59 ` James Clark 2021-08-06 18:36 ` Arnaldo Carvalho de Melo 2021-08-06 18:36 ` Arnaldo Carvalho de Melo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210802151710.GB148327@leoy-ThinkPad-X240s \ --to=leo.yan@linaro.org \ --cc=acme@kernel.org \ --cc=alexander.shishkin@linux.intel.com \ --cc=coresight@lists.linaro.org \ --cc=james.clark@arm.com \ --cc=john.garry@huawei.com \ --cc=jolsa@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-perf-users@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mathieu.poirier@linaro.org \ --cc=mike.leach@linaro.org \ --cc=namhyung@kernel.org \ --cc=suzuki.poulose@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.