Re: [PATCH net-next] net: Keep vertical alignment

From: kernel test robot <lkp@intel.com>
To: Yajun Deng <yajun.deng@linux.dev>,
	davem@davemloft.net, kuba@kernel.org, yoshfuji@linux-ipv6.org,
	dsahern@kernel.org
Cc: kbuild-all@lists.01.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, Yajun Deng <yajun.deng@linux.dev>
Subject: Re: [PATCH net-next] net: Keep vertical alignment
Date: Mon, 2 Aug 2021 15:11:47 +0800	[thread overview]
Message-ID: <202108021545.QdGrWSU0-lkp@intel.com> (raw)
In-Reply-To: <20210802050937.604-1-yajun.deng@linux.dev>

[-- Attachment #1: Type: text/plain, Size: 3956 bytes --]

Hi Yajun,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Yajun-Deng/net-Keep-vertical-alignment/20210802-131102
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git aae950b189413ed3201354600d44223da0bcf63c
config: powerpc-sam440ep_defconfig (attached as .config)
compiler: powerpc-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/895e15bdf966d3c440d9e2e4cc0c9de89d899420
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Yajun-Deng/net-Keep-vertical-alignment/20210802-131102
        git checkout 895e15bdf966d3c440d9e2e4cc0c9de89d899420
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   net/core/neighbour.c: In function 'neigh_stat_seq_show':
>> net/core/neighbour.c:3322:2: error: too many arguments to function 'seq_puts'
    3322 |  seq_puts(seq, "%08x %08lx %08lx %08lx   %08lx %08lx %08lx   "
         |  ^~~~~~~~
   In file included from include/linux/seq_file_net.h:5,
                    from include/net/net_namespace.h:183,
                    from include/linux/netdevice.h:37,
                    from net/core/neighbour.c:22:
   include/linux/seq_file.h:120:6: note: declared here
     120 | void seq_puts(struct seq_file *m, const char *s);
         |      ^~~~~~~~
--
   net/ipv4/route.c: In function 'rt_cpu_seq_show':
>> net/ipv4/route.c:283:2: error: too many arguments to function 'seq_puts'
     283 |  seq_puts(seq, "%08x %08x %08x    %08x   %08x    %08x %08x       "
         |  ^~~~~~~~
   In file included from include/linux/seq_file_net.h:5,
                    from include/net/net_namespace.h:183,
                    from include/linux/inet.h:42,
                    from net/ipv4/route.c:75:
   include/linux/seq_file.h:120:6: note: declared here
     120 | void seq_puts(struct seq_file *m, const char *s);
         |      ^~~~~~~~
   net/ipv4/route.c: In function 'ip_rt_send_redirect':
   net/ipv4/route.c:863:6: warning: variable 'log_martians' set but not used [-Wunused-but-set-variable]
     863 |  int log_martians;
         |      ^~~~~~~~~~~~

vim +/seq_puts +3322 net/core/neighbour.c

  3311	
  3312	static int neigh_stat_seq_show(struct seq_file *seq, void *v)
  3313	{
  3314		struct neigh_table *tbl = PDE_DATA(file_inode(seq->file));
  3315		struct neigh_statistics *st = v;
  3316	
  3317		if (v == SEQ_START_TOKEN) {
  3318			seq_puts(seq, "entries  allocs   destroys hash_grows lookups  hits     res_failed rcv_probes_mcast rcv_probes_ucast periodic_gc_runs forced_gc_runs unresolved_discards table_fulls\n");
  3319			return 0;
  3320		}
  3321	
> 3322		seq_puts(seq, "%08x %08lx %08lx %08lx   %08lx %08lx %08lx   "
  3323			      "%08lx         %08lx         %08lx         "
  3324			      "%08lx       %08lx            %08lx\n",
  3325			   atomic_read(&tbl->entries),
  3326	
  3327			   st->allocs,
  3328			   st->destroys,
  3329			   st->hash_grows,
  3330	
  3331			   st->lookups,
  3332			   st->hits,
  3333	
  3334			   st->res_failed,
  3335	
  3336			   st->rcv_probes_mcast,
  3337			   st->rcv_probes_ucast,
  3338	
  3339			   st->periodic_gc_runs,
  3340			   st->forced_gc_runs,
  3341			   st->unres_discards,
  3342			   st->table_fulls
  3343			   );
  3344	
  3345		return 0;
  3346	}
  3347	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 18138 bytes --]