All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/openzwave: set back -fPIC
@ 2021-08-02 20:44 Fabrice Fontaine
  2021-08-03 21:15 ` Arnout Vandecappelle
  0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2021-08-02 20:44 UTC (permalink / raw)
  To: buildroot; +Cc: Fabrice Fontaine

Set back -fPIC in CFLAGS which was wrongly removed as a side effect of
commit c5ca521e232eae31276e7a12d17f0cf9d9c0108f

Fixes:
 - http://autobuild.buildroot.org/results/161f53574697016ab8bdb91aaaf4a2be5410ebb0

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/openzwave/openzwave.mk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/openzwave/openzwave.mk b/package/openzwave/openzwave.mk
index 9c28c0a13b..0f639635dd 100644
--- a/package/openzwave/openzwave.mk
+++ b/package/openzwave/openzwave.mk
@@ -23,7 +23,7 @@ OPENZWAVE_INSTALL_STAGING = YES
 # the correct directory otherwise openzwave will install configuration files in
 # $(PREFIX)/etc/openzwave.
 # Disable doxygen documentation.
-# Set {DEBUG,RELEASE}_CFLAGS to an empty value to remove -Werror.
+# Set {DEBUG,RELEASE}_CFLAGS to remove -Werror.
 OPENZWAVE_MAKE_OPTS = \
 	CROSS_COMPILE="$(TARGET_CROSS)" \
 	PREFIX=/usr \
@@ -31,8 +31,8 @@ OPENZWAVE_MAKE_OPTS = \
 	pkgconfigdir=/usr/lib/pkgconfig \
 	sysconfdir=/etc/openzwave \
 	DOXYGEN= \
-	DEBUG_CFLAGS= \
-	RELEASE_CFLAGS= \
+	DEBUG_CFLAGS="-fPIC" \
+	RELEASE_CFLAGS="-fPIC" \
 	USE_BI_TXML=0
 
 ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
-- 
2.30.2

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/openzwave: set back -fPIC
  2021-08-02 20:44 [Buildroot] [PATCH 1/1] package/openzwave: set back -fPIC Fabrice Fontaine
@ 2021-08-03 21:15 ` Arnout Vandecappelle
  0 siblings, 0 replies; 2+ messages in thread
From: Arnout Vandecappelle @ 2021-08-03 21:15 UTC (permalink / raw)
  To: Fabrice Fontaine, buildroot



On 02/08/2021 22:44, Fabrice Fontaine wrote:
> Set back -fPIC in CFLAGS which was wrongly removed as a side effect of
> commit c5ca521e232eae31276e7a12d17f0cf9d9c0108f

 That commit also removes -DSYSCONFDIR="\"$(PREFIX)/etc/openzwave/\"". Turns out
that's fine, so I added an explanation why to the commit message.

 Applied to master, thanks.

 Regards,
 Arnout


> 
> Fixes:
>  - http://autobuild.buildroot.org/results/161f53574697016ab8bdb91aaaf4a2be5410ebb0
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/openzwave/openzwave.mk | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/package/openzwave/openzwave.mk b/package/openzwave/openzwave.mk
> index 9c28c0a13b..0f639635dd 100644
> --- a/package/openzwave/openzwave.mk
> +++ b/package/openzwave/openzwave.mk
> @@ -23,7 +23,7 @@ OPENZWAVE_INSTALL_STAGING = YES
>  # the correct directory otherwise openzwave will install configuration files in
>  # $(PREFIX)/etc/openzwave.
>  # Disable doxygen documentation.
> -# Set {DEBUG,RELEASE}_CFLAGS to an empty value to remove -Werror.
> +# Set {DEBUG,RELEASE}_CFLAGS to remove -Werror.
>  OPENZWAVE_MAKE_OPTS = \
>  	CROSS_COMPILE="$(TARGET_CROSS)" \
>  	PREFIX=/usr \
> @@ -31,8 +31,8 @@ OPENZWAVE_MAKE_OPTS = \
>  	pkgconfigdir=/usr/lib/pkgconfig \
>  	sysconfdir=/etc/openzwave \
>  	DOXYGEN= \
> -	DEBUG_CFLAGS= \
> -	RELEASE_CFLAGS= \
> +	DEBUG_CFLAGS="-fPIC" \
> +	RELEASE_CFLAGS="-fPIC" \
>  	USE_BI_TXML=0
>  
>  ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
> 
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-03 23:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-02 20:44 [Buildroot] [PATCH 1/1] package/openzwave: set back -fPIC Fabrice Fontaine
2021-08-03 21:15 ` Arnout Vandecappelle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.